228265 2021-07-24 03:26:23 -0700 [Pipewire] Muting the display capture closes the Portal session 2021-07-26 02:51:16 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pnormand pnormand calvaris eric.carlson ews-watchlist glenn hta jer.noble philipj sergio tommyw webkit-bug-importer oldest_to_newest 1779317 0 pnormand 2021-07-24 03:26:23 -0700 The session should not be closed in that case, because setting the capture state to active again would have no effect. 1779318 1 434165 pnormand 2021-07-24 03:29:04 -0700 Created attachment 434165 Patch 1779417 2 ews-feeder 2021-07-26 02:50:51 -0700 Committed r280292 (239950@main): <https://commits.webkit.org/239950@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434165. 1779418 3 webkit-bug-importer 2021-07-26 02:51:16 -0700 <rdar://problem/81098331> 434165 2021-07-24 03:29:04 -0700 2021-07-26 02:50:52 -0700 Patch bug-228265-20210724032903.patch text/plain 6693 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwMjg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTU5YWQzYzA2YzU0YmNk OWRmM2M0OGFmMTgzYTFjODliYTY4ZTdjMS4uZGIwMTJhNGEwOWNiYmQyMDRjYzRmZDM1ODBhY2U4 Y2I3YzUwNzdmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIxLTA3LTI0ICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbUGlwZXdpcmVd IE11dGluZyB0aGUgZGlzcGxheSBjYXB0dXJlIGNsb3NlcyB0aGUgUG9ydGFsIHNlc3Npb24KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyODI2NQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBzZXNzaW9u IHNob3VsZCBub3QgYmUgY2xvc2VkIGluIHRoYXQgY2FzZSwgYmVjYXVzZSBzZXR0aW5nIHRoZSBj YXB0dXJlIHN0YXRlIHRvIGFjdGl2ZQorICAgICAgICBhZ2FpbiB3b3VsZCBoYXZlIG5vIGVmZmVj dC4gVGhpcyBwYXRjaCBhbHNvIHJlbW92ZXMgdXNlbGVzcyBDUkxGcyBmcm9tIFdURkxvZ0Fsd2F5 cygpIGNhbGxzCisgICAgICAgIGFuZCBpbmNyZWFzZXMgdGhlIHNlc3Npb24gQ2xvc2UgY2FsbCB0 aW1lb3V0IHRvIDEwMG1zLCAxMG1zIHdhcyB0b28gbG93LCBhdCBsZWFzdCBmb3IgbXkKKyAgICAg ICAgc2V0dXAuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tZWRpYXN0cmVhbS9nc3RyZWFtZXIvR1N0 cmVhbWVyRGlzcGxheUNhcHR1cmVEZXZpY2VNYW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkdTdHJlYW1lckRpc3BsYXlDYXB0dXJlRGV2aWNlTWFuYWdlcjo6Y3JlYXRlRGlzcGxheUNhcHR1 cmVTb3VyY2UpOgorICAgICAgICAoV2ViQ29yZTo6R1N0cmVhbWVyRGlzcGxheUNhcHR1cmVEZXZp Y2VNYW5hZ2VyOjpzdG9wU291cmNlKToKKyAgICAgICAgKiBwbGF0Zm9ybS9tZWRpYXN0cmVhbS9n c3RyZWFtZXIvR1N0cmVhbWVyVmlkZW9DYXB0dXJlU291cmNlLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkdTdHJlYW1lclZpZGVvQ2FwdHVyZVNvdXJjZTo6fkdTdHJlYW1lclZpZGVvQ2FwdHVyZVNv dXJjZSk6CisgICAgICAgIChXZWJDb3JlOjpHU3RyZWFtZXJWaWRlb0NhcHR1cmVTb3VyY2U6OnN0 b3BQcm9kdWNpbmdEYXRhKToKKwogMjAyMS0wNy0yNCAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0Bh cHBsZS5jb20+CiAKICAgICAgICAgW0FwcGxlIFBheV0gRG8gbm90IGFkZCBjb3Vwb24gY29kZSBg QXBwbGVQYXlFcnJvckNvZGVgIHZhbHVlcyBmb3Igc3lzdGVtcyB0aGF0IGRvIG5vdCBzdXBwb3J0 IGl0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9nc3Ry ZWFtZXIvR1N0cmVhbWVyRGlzcGxheUNhcHR1cmVEZXZpY2VNYW5hZ2VyLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2dzdHJlYW1lci9HU3RyZWFtZXJEaXNwbGF5Q2Fw dHVyZURldmljZU1hbmFnZXIuY3BwCmluZGV4IDFkY2VhNmFiMGE5ZDIzYWQ3M2E2MzEyNDY2NDVl YWQ0YjJiMTBhZTQuLmVlZmIxYzkxOTNiYjljOWEwMzZiZGVmYmM1MGJlOTZhNjA5NTUzNGYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2dzdHJlYW1lci9H U3RyZWFtZXJEaXNwbGF5Q2FwdHVyZURldmljZU1hbmFnZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2dzdHJlYW1lci9HU3RyZWFtZXJEaXNwbGF5Q2FwdHVy ZURldmljZU1hbmFnZXIuY3BwCkBAIC03Miw3ICs3Miw3IEBAIENhcHR1cmVTb3VyY2VPckVycm9y IEdTdHJlYW1lckRpc3BsYXlDYXB0dXJlRGV2aWNlTWFuYWdlcjo6Y3JlYXRlRGlzcGxheUNhcHR1 cmVTCiAgICAgICAgIHN0YXRpY19jYXN0PEdEQnVzUHJveHlGbGFncz4oR19EQlVTX1BST1hZX0ZM QUdTX0RPX05PVF9DT05ORUNUX1NJR05BTFMgfCBHX0RCVVNfUFJPWFlfRkxBR1NfRE9fTk9UX0xP QURfUFJPUEVSVElFUyksIG51bGxwdHIsCiAgICAgICAgICJvcmcuZnJlZWRlc2t0b3AucG9ydGFs LkRlc2t0b3AiLCAiL29yZy9mcmVlZGVza3RvcC9wb3J0YWwvZGVza3RvcCIsICJvcmcuZnJlZWRl c2t0b3AucG9ydGFsLlNjcmVlbkNhc3QiLCBudWxscHRyLCAmZXJyb3Iub3V0UHRyKCkpKTsKICAg ICBpZiAoZXJyb3IpIHsKLSAgICAgICAgV1RGTG9nQWx3YXlzKCJVbmFibGUgdG8gY29ubmVjdCB0 byB0aGUgRGVza29wIHBvcnRhbDogJXNcbiIsIGVycm9yLT5tZXNzYWdlKTsKKyAgICAgICAgV1RG TG9nQWx3YXlzKCJVbmFibGUgdG8gY29ubmVjdCB0byB0aGUgRGVza29wIHBvcnRhbDogJXMiLCBl cnJvci0+bWVzc2FnZSk7CiAgICAgICAgIHJldHVybiB7IH07CiAgICAgfQogCkBAIC04Niw3ICs4 Niw3IEBAIENhcHR1cmVTb3VyY2VPckVycm9yIEdTdHJlYW1lckRpc3BsYXlDYXB0dXJlRGV2aWNl TWFuYWdlcjo6Y3JlYXRlRGlzcGxheUNhcHR1cmVTCiAgICAgYXV0byByZXN1bHQgPSBhZG9wdEdS ZWYoZ19kYnVzX3Byb3h5X2NhbGxfc3luYyhtX3Byb3h5LmdldCgpLCAiQ3JlYXRlU2Vzc2lvbiIs IGdfdmFyaWFudF9uZXcoIihhe3N2fSkiLCAmb3B0aW9ucyksCiAgICAgICAgIEdfREJVU19DQUxM X0ZMQUdTX05PTkUsIHNfZGJ1c0NhbGxUaW1lb3V0Lm1pbGxpc2Vjb25kc0FzPGludD4oKSwgbnVs bHB0ciwgJmVycm9yLm91dFB0cigpKSk7CiAgICAgaWYgKGVycm9yKSB7Ci0gICAgICAgIFdURkxv Z0Fsd2F5cygiVW5hYmxlIHRvIGNyZWF0ZSBhIERlc2tvcCBwb3J0YWwgc2Vzc2lvbjogJXNcbiIs IGVycm9yLT5tZXNzYWdlKTsKKyAgICAgICAgV1RGTG9nQWx3YXlzKCJVbmFibGUgdG8gY3JlYXRl IGEgRGVza29wIHBvcnRhbCBzZXNzaW9uOiAlcyIsIGVycm9yLT5tZXNzYWdlKTsKICAgICAgICAg cmV0dXJuIHsgfTsKICAgICB9CiAKQEAgLTEyMSw3ICsxMjEsNyBAQCBDYXB0dXJlU291cmNlT3JF cnJvciBHU3RyZWFtZXJEaXNwbGF5Q2FwdHVyZURldmljZU1hbmFnZXI6OmNyZWF0ZURpc3BsYXlD YXB0dXJlUwogICAgIHJlc3VsdCA9IGFkb3B0R1JlZihnX2RidXNfcHJveHlfY2FsbF9zeW5jKG1f cHJveHkuZ2V0KCksICJTZWxlY3RTb3VyY2VzIiwKICAgICAgICAgZ192YXJpYW50X25ldygiKG9h e3N2fSkiLCBzZXNzaW9uUGF0aC5hc2NpaSgpLmRhdGEoKSwgJm9wdGlvbnMpLCBHX0RCVVNfQ0FM TF9GTEFHU19OT05FLCBzX2RidXNDYWxsVGltZW91dC5taWxsaXNlY29uZHNBczxpbnQ+KCksIG51 bGxwdHIsICZlcnJvci5vdXRQdHIoKSkpOwogICAgIGlmIChlcnJvcikgewotICAgICAgICBXVEZM b2dBbHdheXMoIlNlbGVjdFNvdXJjZXMgZXJyb3I6ICVzXG4iLCBlcnJvci0+bWVzc2FnZSk7Cisg ICAgICAgIFdURkxvZ0Fsd2F5cygiU2VsZWN0U291cmNlcyBlcnJvcjogJXMiLCBlcnJvci0+bWVz c2FnZSk7CiAgICAgICAgIHJldHVybiB7IH07CiAgICAgfQogICAgIGdfdmFyaWFudF9nZXQocmVz dWx0LmdldCgpLCAiKG8pIiwgJm9iamVjdFBhdGgub3V0UHRyKCkpOwpAQCAtMTMzLDcgKzEzMyw3 IEBAIENhcHR1cmVTb3VyY2VPckVycm9yIEdTdHJlYW1lckRpc3BsYXlDYXB0dXJlRGV2aWNlTWFu YWdlcjo6Y3JlYXRlRGlzcGxheUNhcHR1cmVTCiAgICAgcmVzdWx0ID0gYWRvcHRHUmVmKGdfZGJ1 c19wcm94eV9jYWxsX3N5bmMobV9wcm94eS5nZXQoKSwgIlN0YXJ0IiwKICAgICAgICAgZ192YXJp YW50X25ldygiKG9zYXtzdn0pIiwgc2Vzc2lvblBhdGguYXNjaWkoKS5kYXRhKCksICIiLCAmb3B0 aW9ucyksIEdfREJVU19DQUxMX0ZMQUdTX05PTkUsIHNfZGJ1c0NhbGxUaW1lb3V0Lm1pbGxpc2Vj b25kc0FzPGludD4oKSwgbnVsbHB0ciwgJmVycm9yLm91dFB0cigpKSk7CiAgICAgaWYgKGVycm9y KSB7Ci0gICAgICAgIFdURkxvZ0Fsd2F5cygiU3RhcnQgZXJyb3I6ICVzXG4iLCBlcnJvci0+bWVz c2FnZSk7CisgICAgICAgIFdURkxvZ0Fsd2F5cygiU3RhcnQgZXJyb3I6ICVzIiwgZXJyb3ItPm1l c3NhZ2UpOwogICAgICAgICByZXR1cm4geyB9OwogICAgIH0KIApAQCAtMTY3LDEzICsxNjcsMTQg QEAgdm9pZCBHU3RyZWFtZXJEaXNwbGF5Q2FwdHVyZURldmljZU1hbmFnZXI6OnN0b3BTb3VyY2Uo Y29uc3QgU3RyaW5nJiBwZXJzaXN0ZW50SUQKICAgICAgICAgc3RhdGljX2Nhc3Q8R0RCdXNQcm94 eUZsYWdzPihHX0RCVVNfUFJPWFlfRkxBR1NfRE9fTk9UX0NPTk5FQ1RfU0lHTkFMUyB8IEdfREJV U19QUk9YWV9GTEFHU19ET19OT1RfTE9BRF9QUk9QRVJUSUVTKSwgbnVsbHB0ciwKICAgICAgICAg Im9yZy5mcmVlZGVza3RvcC5wb3J0YWwuRGVza3RvcCIsIHNlc3Npb24tPnBhdGguYXNjaWkoKS5k YXRhKCksICJvcmcuZnJlZWRlc2t0b3AucG9ydGFsLlNlc3Npb24iLCBudWxscHRyLCAmZXJyb3Iu b3V0UHRyKCkpKTsKICAgICBpZiAoZXJyb3IpIHsKLSAgICAgICAgV1RGTG9nQWx3YXlzKCJVbmFi bGUgdG8gY29ubmVjdCB0byB0aGUgRGVza29wIHBvcnRhbDogJXNcbiIsIGVycm9yLT5tZXNzYWdl KTsKKyAgICAgICAgV1RGTG9nQWx3YXlzKCJVbmFibGUgdG8gY29ubmVjdCB0byB0aGUgRGVza29w IHBvcnRhbDogJXMiLCBlcnJvci0+bWVzc2FnZSk7CiAgICAgICAgIHJldHVybjsKICAgICB9Cisg ICAgYXV0byBkYnVzQ2FsbFRpbWVvdXQgPSAxMDBfbXM7CiAgICAgYXV0byByZXN1bHQgPSBhZG9w dEdSZWYoZ19kYnVzX3Byb3h5X2NhbGxfc3luYyhwcm94eS5nZXQoKSwgIkNsb3NlIiwgbnVsbHB0 ciwgR19EQlVTX0NBTExfRkxBR1NfTk9ORSwKLSAgICAgICAgc19kYnVzQ2FsbFRpbWVvdXQubWls bGlzZWNvbmRzQXM8aW50PigpLCBudWxscHRyLCAmZXJyb3Iub3V0UHRyKCkpKTsKKyAgICAgICAg ZGJ1c0NhbGxUaW1lb3V0Lm1pbGxpc2Vjb25kc0FzPGludD4oKSwgbnVsbHB0ciwgJmVycm9yLm91 dFB0cigpKSk7CiAgICAgaWYgKGVycm9yKQotICAgICAgICBXVEZMb2dBbHdheXMoIlBvcnRhbCBz ZXNzaW9uIGNvdWxkIG5vdCBiZSBjbG9zZWQ6ICVzXG4iLCBlcnJvci0+bWVzc2FnZSk7CisgICAg ICAgIFdURkxvZ0Fsd2F5cygiUG9ydGFsIHNlc3Npb24gY291bGQgbm90IGJlIGNsb3NlZDogJXMi LCBlcnJvci0+bWVzc2FnZSk7CiB9CiAKIHZvaWQgR1N0cmVhbWVyRGlzcGxheUNhcHR1cmVEZXZp Y2VNYW5hZ2VyOjp3YWl0UmVzcG9uc2VTaWduYWwoY29uc3QgY2hhciogb2JqZWN0UGF0aCkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2dzdHJlYW1lci9H U3RyZWFtZXJWaWRlb0NhcHR1cmVTb3VyY2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bWVkaWFzdHJlYW0vZ3N0cmVhbWVyL0dTdHJlYW1lclZpZGVvQ2FwdHVyZVNvdXJjZS5jcHAKaW5k ZXggMGVkN2Y1YWI0OTcxZWIzM2FhMGU0MjAyMTgzODIyMzhkY2FlNDBkZC4uNDUyY2VmMjI1ZTBk ZGVjMDQ5MzZlYmEyYmYxMDIzNmJlOWYzNjMxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbWVkaWFzdHJlYW0vZ3N0cmVhbWVyL0dTdHJlYW1lclZpZGVvQ2FwdHVyZVNvdXJj ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vZ3N0cmVhbWVy L0dTdHJlYW1lclZpZGVvQ2FwdHVyZVNvdXJjZS5jcHAKQEAgLTE0NCw2ICsxNDQsMTEgQEAgR1N0 cmVhbWVyVmlkZW9DYXB0dXJlU291cmNlOjp+R1N0cmVhbWVyVmlkZW9DYXB0dXJlU291cmNlKCkK ICAgICAgICAgcmV0dXJuOwogICAgIGdfc2lnbmFsX2hhbmRsZXJzX2Rpc2Nvbm5lY3RfYnlfZnVu YyhtX2NhcHR1cmVyLT5zaW5rKCksIHJlaW50ZXJwcmV0X2Nhc3Q8Z3BvaW50ZXI+KG5ld1NhbXBs ZUNhbGxiYWNrKSwgdGhpcyk7CiAgICAgbV9jYXB0dXJlci0+c3RvcCgpOworCisgICAgaWYgKGF1 dG8gZmQgPSBtX2NhcHR1cmVyLT5waXBld2lyZUZEKCkpIHsKKyAgICAgICAgYXV0byYgbWFuYWdl ciA9IEdTdHJlYW1lckRpc3BsYXlDYXB0dXJlRGV2aWNlTWFuYWdlcjo6c2luZ2xldG9uKCk7Cisg ICAgICAgIG1hbmFnZXIuc3RvcFNvdXJjZShwZXJzaXN0ZW50SUQoKSk7CisgICAgfQogfQogCiB2 b2lkIEdTdHJlYW1lclZpZGVvQ2FwdHVyZVNvdXJjZTo6c2V0dGluZ3NEaWRDaGFuZ2UoT3B0aW9u U2V0PFJlYWx0aW1lTWVkaWFTb3VyY2VTZXR0aW5nczo6RmxhZz4gc2V0dGluZ3MpCkBAIC0yMDQs MTEgKzIwOSw2IEBAIHZvaWQgR1N0cmVhbWVyVmlkZW9DYXB0dXJlU291cmNlOjpzdG9wUHJvZHVj aW5nRGF0YSgpCiB7CiAgICAgR1NUX0lORk8oIlJlc2V0IGhlaWdodCBhbmQgd2lkdGggYWZ0ZXIg c3RvcHBpbmcgc291cmNlIik7CiAgICAgc2V0U2l6ZSh7IDAsIDAgfSk7Ci0KLSAgICBpZiAoYXV0 byBmZCA9IG1fY2FwdHVyZXItPnBpcGV3aXJlRkQoKSkgewotICAgICAgICBhdXRvJiBtYW5hZ2Vy ID0gR1N0cmVhbWVyRGlzcGxheUNhcHR1cmVEZXZpY2VNYW5hZ2VyOjpzaW5nbGV0b24oKTsKLSAg ICAgICAgbWFuYWdlci5zdG9wU291cmNlKHBlcnNpc3RlbnRJRCgpKTsKLSAgICB9CiB9CiAKIGNv bnN0IFJlYWx0aW1lTWVkaWFTb3VyY2VDYXBhYmlsaXRpZXMmIEdTdHJlYW1lclZpZGVvQ2FwdHVy ZVNvdXJjZTo6Y2FwYWJpbGl0aWVzKCkK