<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>228234</bug_id>
          
          <creation_ts>2021-07-23 07:10:40 -0700</creation_ts>
          <short_desc>[GTK] Uninitialized data in UIClient::windowFrame written over IPC</short_desc>
          <delta_ts>2021-08-03 15:13:07 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Michael Catanzaro">mcatanzaro</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>cgarcia</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1779054</commentid>
    <comment_count>0</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-07-23 07:10:40 -0700</bug_when>
    <thetext>==87186== Thread 55 ReceiveQueue:
==87186== Syscall param sendmsg(msg.msg_iov[1]) points to uninitialised byte(s)
==87186==    at 0x59A0ACD: sendmsg (in /usr/lib64/libc-2.33.so)
==87186==    by 0x6AC8783: IPC::Connection::sendOutputMessage(IPC::UnixMessage&amp;) (ConnectionUnix.cpp:536)
==87186==    by 0x6ACA719: IPC::Connection::sendOutgoingMessage(WTF::UniqueRef&lt;IPC::Encoder&gt;&amp;&amp;) (ConnectionUnix.cpp:454)
==87186==    by 0x6AB7997: IPC::Connection::sendOutgoingMessages() [clone .part.0] (Connection.cpp:932)
==87186==    by 0xA9C8505: operator() (Function.h:82)
==87186==    by 0xA9C8505: WTF::RunLoop::performWork() (RunLoop.cpp:133)
==87186==    by 0xAA1D8F8: operator() (RunLoopGLib.cpp:80)
==87186==    by 0xAA1D8F8: WTF::RunLoop::RunLoop()::{lambda(void*)#1}::_FUN(void*) (RunLoopGLib.cpp:82)
==87186==    by 0xAA1E22E: operator() (RunLoopGLib.cpp:53)
==87186==    by 0xAA1E22E: WTF::RunLoop::{lambda(_GSource*, int (*)(void*), void*)#1}::_FUN(_GSource*, int (*)(void*), void*) (RunLoopGLib.cpp:56)
==87186==    by 0x5609922: g_main_dispatch (gmain.c:3344)
==87186==    by 0x560A875: g_main_context_dispatch (gmain.c:4062)
==87186==    by 0x560AA61: g_main_context_iterate (gmain.c:4138)
==87186==    by 0x560AEFE: g_main_loop_run (gmain.c:4336)
==87186==    by 0xAA1E34F: WTF::RunLoop::run() (RunLoopGLib.cpp:108)
==87186==  Address 0x21525daa is in a rw- anonymous segment
==87186==  Uninitialised value was created by a stack allocation
==87186==    at 0x6C310A0: UIClient::windowFrame(WebKit::WebPageProxy&amp;, WTF::Function&lt;void (WebCore::FloatRect)&gt;&amp;&amp;) (WebKitUIClient.cpp:240)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1781603</commentid>
    <comment_count>1</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2021-08-03 07:29:38 -0700</bug_when>
    <thetext>I guess the stack allocation at UIClient::windowFrame is the GdkRectangle, but it&apos;s initialized:

GdkRectangle geometry = { 0, 0, 0, 0 };

It could be the default geometry, which is not initialized but it&apos;s always set by webkit_window_properties_get_geometry().</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1781752</commentid>
    <comment_count>2</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-08-03 15:13:07 -0700</bug_when>
    <thetext>&gt; It could be the default geometry, which is not initialized but it&apos;s always
&gt; set by webkit_window_properties_get_geometry().

webkit_window_properties_get_geometry() copies windowProperties-&gt;priv-&gt;geometry, so that would mean this would have to somehow be uninitialized. But that seems impossible, because the entire priv struct should be zero-initialized.

I don&apos;t see the problem either....</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>