228232 2021-07-23 03:55:34 -0700 [GTK] MiniBrowser crashes when closed while capturing desktop 2021-08-16 06:34:02 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pnormand pnormand aperez berto bugs-noreply cgarcia ews-watchlist gustavo webkit-bug-importer oldest_to_newest 1779028 0 pnormand 2021-07-23 03:55:34 -0700 1. Visit https://webrtc.github.io/samples/src/content/getusermedia/getdisplaymedia/ 2. Click Start 3. Close the browser (gdb) bt #0 g_type_check_instance_cast (type_instance=0x1562280, iface_type=0x15570c0 [GtkEntry/GtkWidget/GInitiallyUnowned]) at ../gobject/gtype.c:4115 #1 0x000000000041897d in webViewMediaCaptureStateChanged () #5 0x00007f967fccead3 in <emit signal notify:camera-capture-state on instance 0x171ff20 [WebKitWebView]> (instance=instance@entry=0x171ff20, signal_id=<optimized out>, detail=<optimized out>) at ../gobject/gsignal.c:3553 #2 0x00007f967fcb4fcf in g_closure_invoke (closure=0x16ffdb0, return_value=return_value@entry=0x0, n_param_values=2, param_values=param_values@entry=0x7ffed5482390, invocation_hint=invocation_hint@entry=0x7ffed5482310) at ../gobject/gclosure.c:810 #3 0x00007f967fcc7e5b in signal_emit_unlocked_R (node=node@entry=0x11874c0, detail=detail@entry=1537, instance=instance@entry=0x171ff20, emission_return=emission_return@entry=0x0, instance_and_params=instance_and_params@entry=0x7ffed5482390) at ../gobject/gsignal.c:3741 #4 0x00007f967fcce971 in g_signal_emit_valist (instance=<optimized out>, signal_id=<optimized out>, detail=<optimized out>, var_args=var_args@entry=0x7ffed5482530) at ../gobject/gsignal.c:3497 #6 0x00007f967fcb9be4 in g_object_dispatch_properties_changed (object=0x171ff20 [WebKitWebView], n_pspecs=<optimized out>, pspecs=<optimized out>) at ../gobject/gobject.c:1206 #7 0x00007f967fcbbd9a in g_object_notify_by_spec_internal (pspec=<optimized out>, object=0x171ff20 [WebKitWebView]) at ../gobject/gobject.c:1299 #8 g_object_notify_by_pspec (object=0x171ff20 [WebKitWebView], pspec=<optimized out>) at ../gobject/gobject.c:1409 #9 0x00007f968609052e in webkitWebViewMediaCaptureStateDidChange(_WebKitWebView*, WTF::OptionSet<WebCore::MediaProducer::MediaState>) () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.1.so.0 #10 0x00007f9685fb1f83 in WebKit::WebPageProxy::updateReportedMediaCaptureState() () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.1.so.0 #11 0x00007f9685fb8611 in WebKit::WebPageProxy::updatePlayingMediaDidChange(WTF::OptionSet<WebCore::MediaProducer::MediaState>, WebKit::WebPageProxy::CanDelayNotification) () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.1.so.0 #12 0x00007f9685fb81cc in WebKit::WebPageProxy::resetState(WebKit::WebPageProxy::ResetStateReason) () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.1.so.0 #13 0x00007f9685fb430a in WebKit::WebPageProxy::close() () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.1.so.0 #14 0x00007f96860b9497 in webkitWebViewBaseDispose(_GObject*) () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.1.so.0 #15 0x00007f9686099a8f in webkitWebViewDispose(_GObject*) () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.1.so.0 #16 0x00007f967fcbb9f1 in g_object_run_dispose (object=0x171ff20 [WebKitWebView]) at ../gobject/gobject.c:1226 #17 0x00007f9684e01850 in gtk_overlay_forall (overlay=0x15cf9d0 [GtkOverlay], include_internals=<optimized out>, callback=0x7f9684f34050 <gtk_widget_destroy>, callback_data=0x0) at ../gtk/gtkoverlay.c:628 #18 0x00007f9684cdf14b in gtk_container_destroy (widget=0x15cf9d0 [GtkOverlay]) at ../gtk/gtkcontainer.c:1701 #22 0x00007f967fccead3 in <emit signal ??? on instance 0x15cf9d0 [GtkOverlay]> (instance=instance@entry=0x15cf9d0, signal_id=<optimized out>, detail=detail@entry=0) at ../gobject/gsignal.c:3553 #19 0x00007f967fcb4f0c in g_closure_invoke (closure=closure@entry=0x11da130, return_value=return_value@entry=0x0, n_param_values=1, param_values=param_values@entry=0x7ffed5482a30, invocation_hint=invocation_hint@entry=0x7ffed54829b0) at ../gobject/gclosure.c:810 #20 0x00007f967fcc7df5 in signal_emit_unlocked_R (node=node@entry=0x11f16d0, detail=detail@entry=0, instance=instance@entry=0x15cf9d0, emission_return=emission_return@entry=0x0, instance_and_params=instance_and_params@entry=0x7ffed5482a30) at ../gobject/gsignal.c:3859 #21 0x00007f967fcce971 in g_signal_emit_valist (instance=<optimized out>, signal_id=<optimized out>, detail=<optimized out>, var_args=var_args@entry=0x7ffed5482bb0) at ../gobject/gsignal.c:3497 #23 0x00007f9684f3d8af in gtk_widget_dispose (object=0x15cf9d0 [GtkOverlay]) at ../gtk/gtkwidget.c:12162 #24 0x00007f967fcbb9f1 in g_object_run_dispose (object=0x15cf9d0 [GtkOverlay]) at ../gobject/gobject.c:1226 #25 0x00007f9684c8a5a8 in gtk_box_forall (container=<optimized out>, include_internals=<optimized out>, callback=0x7f9684f34050 <gtk_widget_destroy>, callback_data=0x0) at ../gtk/gtkbox.c:2675 #26 0x00007f9684cdf14b in gtk_container_destroy (widget=0x1737180 [BrowserTab]) at ../gtk/gtkcontainer.c:1701 #30 0x00007f967fccead3 in <emit signal ??? on instance 0x1737180 [BrowserTab]> (instance=instance@entry=0x1737180, signal_id=<optimized out>, detail=detail@entry=0) at ../gobject/gsignal.c:3553 #27 0x00007f967fcb4f0c in g_closure_invoke (closure=closure@entry=0x11da130, return_value=return_value@entry=0x0, n_param_values=1, param_values=param_values@entry=0x7ffed5482eb0, invocation_hint=invocation_hint@entry=0x7ffed5482e30) at ../gobject/gclosure.c:810 #28 0x00007f967fcc7df5 in signal_emit_unlocked_R (node=node@entry=0x11f16d0, detail=detail@entry=0, instance=instance@entry=0x1737180, emission_return=emission_return@entry=0x0, instance_and_params=instance_and_params@entry=0x7ffed5482eb0) at ../gobject/gsignal.c:3859 #29 0x00007f967fcce971 in g_signal_emit_valist (instance=<optimized out>, signal_id=<optimized out>, detail=<optimized out>, var_args=var_args@entry=0x7ffed5483030) at ../gobject/gsignal.c:3497 #31 0x00007f9684f3d8af in gtk_widget_dispose (object=0x1737180 [BrowserTab]) at ../gtk/gtkwidget.c:12162 #32 0x00007f967fcbb9f1 in g_object_run_dispose (object=0x1737180 [BrowserTab]) at ../gobject/gobject.c:1226 #33 0x00007f9684df9456 in gtk_notebook_forall (container=<optimized out>, include_internals=0, callback=0x7f9684f34050 <gtk_widget_destroy>, callback_data=0x0) at ../gtk/gtknotebook.c:4607 #34 0x00007f9684cdf14b in gtk_container_destroy (widget=0x1754510 [GtkNotebook]) at ../gtk/gtkcontainer.c:1701 #38 0x00007f967fccead3 in <emit signal ??? on instance 0x1754510 [GtkNotebook]> (instance=instance@entry=0x1754510, signal_id=<optimized out>, detail=detail@entry=0) at ../gobject/gsignal.c:3553 #35 0x00007f967fcb4f0c in g_closure_invoke (closure=closure@entry=0x11da130, return_value=return_value@entry=0x0, n_param_values=1, param_values=param_values@entry=0x7ffed5483340, invocation_hint=invocation_hint@entry=0x7ffed54832c0) at ../gobject/gclosure.c:810 #36 0x00007f967fcc7df5 in signal_emit_unlocked_R --Type <RET> for more, q to quit, c to continue without paging-- (node=node@entry=0x11f16d0, detail=detail@entry=0, instance=instance@entry=0x1754510, emission_return=emission_return@entry=0x0, instance_and_params=instance_and_params@entry=0x7ffed5483340) at ../gobject/gsignal.c:3859 #37 0x00007f967fcce971 in g_signal_emit_valist (instance=<optimized out>, signal_id=<optimized out>, detail=<optimized out>, var_args=var_args@entry=0x7ffed54834c0) at ../gobject/gsignal.c:3497 #39 0x00007f9684f3d8af in gtk_widget_dispose (object=0x1754510 [GtkNotebook]) at ../gtk/gtkwidget.c:12162 #40 0x00007f967fcbb9f1 in g_object_run_dispose (object=0x1754510 [GtkNotebook]) at ../gobject/gobject.c:1226 #41 0x00007f9684c8a5a8 in gtk_box_forall (container=<optimized out>, include_internals=<optimized out>, callback=0x7f9684f34050 <gtk_widget_destroy>, callback_data=0x0) at ../gtk/gtkbox.c:2675 #42 0x00007f9684cdf14b in gtk_container_destroy (widget=0x15b7cc0 [GtkBox]) at ../gtk/gtkcontainer.c:1701 #46 0x00007f967fccead3 in <emit signal ??? on instance 0x15b7cc0 [GtkBox]> (instance=instance@entry=0x15b7cc0, signal_id=<optimized out>, detail=detail@entry=0) at ../gobject/gsignal.c:3553 #43 0x00007f967fcb4f0c in g_closure_invoke (closure=closure@entry=0x11da130, return_value=return_value@entry=0x0, n_param_values=1, param_values=param_values@entry=0x7ffed54837c0, invocation_hint=invocation_hint@entry=0x7ffed5483740) at ../gobject/gclosure.c:810 #44 0x00007f967fcc7df5 in signal_emit_unlocked_R (node=node@entry=0x11f16d0, detail=detail@entry=0, instance=instance@entry=0x15b7cc0, emission_return=emission_return@entry=0x0, instance_and_params=instance_and_params@entry=0x7ffed54837c0) at ../gobject/gsignal.c:3859 #45 0x00007f967fcce971 in g_signal_emit_valist (instance=<optimized out>, signal_id=<optimized out>, detail=<optimized out>, var_args=var_args@entry=0x7ffed5483940) at ../gobject/gsignal.c:3497 #47 0x00007f9684f3d8af in gtk_widget_dispose (object=0x15b7cc0 [GtkBox]) at ../gtk/gtkwidget.c:12162 #48 0x00007f967fcbb9f1 in g_object_run_dispose (object=0x15b7cc0 [GtkBox]) at ../gobject/gobject.c:1226 #49 0x00007f9684f4f9b9 in gtk_window_forall (container=0x15724a0 [BrowserWindow], include_internals=0, callback=0x7f9684f34050 <gtk_widget_destroy>, callback_data=0x0) at ../gtk/gtkwindow.c:8596 #50 0x00007f9684cdf14b in gtk_container_destroy (widget=0x15724a0 [BrowserWindow]) at ../gtk/gtkcontainer.c:1701 #54 0x00007f967fccead3 in <emit signal ??? on instance 0x15724a0 [BrowserWindow]> (instance=instance@entry=0x15724a0, signal_id=<optimized out>, detail=detail@entry=0) at ../gobject/gsignal.c:3553 #51 0x00007f967fcb4fcf in g_closure_invoke (closure=closure@entry=0x11da130, return_value=return_value@entry=0x0, n_param_values=1, param_values=param_values@entry=0x7ffed5483c50, invocation_hint=invocation_hint@entry=0x7ffed5483bd0) at ../gobject/gclosure.c:810 #52 0x00007f967fcc7df5 in signal_emit_unlocked_R (node=node@entry=0x11f16d0, detail=detail@entry=0, instance=instance@entry=0x15724a0, emission_return=emission_return@entry=0x0, instance_and_params=instance_and_params@entry=0x7ffed5483c50) at ../gobject/gsignal.c:3859 #53 0x00007f967fcce971 in g_signal_emit_valist (instance=<optimized out>, signal_id=<optimized out>, detail=<optimized out>, var_args=var_args@entry=0x7ffed5483dd0) at ../gobject/gsignal.c:3497 #55 0x00007f9684f3d8af in gtk_widget_dispose (object=0x15724a0 [BrowserWindow]) at ../gtk/gtkwidget.c:12162 #56 0x00007f9684f52e20 in gtk_window_dispose (object=0x15724a0 [BrowserWindow]) at ../gtk/gtkwindow.c:3166 #57 0x00007f9684c7b456 in gtk_application_window_dispose (object=0x15724a0 [BrowserWindow]) at ../gtk/gtkapplicationwindow.c:804 #58 0x00007f967fcbb9f1 in g_object_run_dispose (object=0x15724a0 [BrowserWindow]) at ../gobject/gobject.c:1226 #62 0x00007f967fccead3 in <emit signal ??? on instance 0x171ff20 [WebKitWebView]> (instance=<optimized out>, signal_id=<optimized out>, detail=<optimized out>) at ../gobject/gsignal.c:3553 #59 0x00007f967fcb4fcf in g_closure_invoke (closure=0x1735100, return_value=return_value@entry=0x0, n_param_values=1, param_values=param_values@entry=0x7ffed54840d0, invocation_hint=invocation_hint@entry=0x7ffed5484050) at ../gobject/gclosure.c:810 #60 0x00007f967fcc7e5b in signal_emit_unlocked_R (node=node@entry=0x16e7620, detail=detail@entry=0, instance=instance@entry=0x171ff20, emission_return=emission_return@entry=0x0, instance_and_params=instance_and_params@entry=0x7ffed54840d0) at ../gobject/gsignal.c:3741 #61 0x00007f967fcce971 in g_signal_emit_valist (instance=<optimized out>, signal_id=<optimized out>, detail=<optimized out>, var_args=var_args@entry=0x7ffed5484250) at ../gobject/gsignal.c:3497 #63 0x0000000000416589 in browserWindowTryClose () #64 0x000000000041636f in browserWindowDeleteEvent () #65 0x00007f9684c4bb18 in _gtk_marshal_BOOLEAN__BOXEDv (closure=0x11f7580, return_value=0x7ffed5484520, instance=<optimized out>, args=<optimized out>, marshal_data=<optimized out>, n_params=<optimized out>, param_types=0x11f6850) at gtk/gtkmarshalers.c:130 #66 0x00007f967fcb5209 in _g_closure_invoke_va (closure=closure@entry=0x11f7580, return_value=return_value@entry=0x7ffed5484520, instance=instance@entry=0x15724a0, args=args@entry=0x7ffed54845f0, n_params=1, param_types=0x11f6850) at ../gobject/gclosure.c:873 #67 0x00007f967fccdc34 in g_signal_emit_valist (instance=0x15724a0, signal_id=<optimized out>, detail=<optimized out>, var_args=var_args@entry=0x7ffed54845f0) at ../gobject/gsignal.c:3406 #68 0x00007f967fccead3 in g_signal_emit (instance=instance@entry=0x15724a0, signal_id=<optimized out>, detail=detail@entry=0) at ../gobject/gsignal.c:3553 #69 0x00007f9684f32ab4 in gtk_widget_event_internal (widget=0x15724a0 [BrowserWindow], event=0x16750d0) at ../gtk/gtkwidget.c:7808 #70 0x00007f9684f35892 in gtk_widget_event_internal (event=<optimized out>, widget=<optimized out>) at ../gtk/gtkwidget.c:7687 #71 gtk_widget_event (widget=<optimized out>, event=<optimized out>) at ../gtk/gtkwidget.c:7378 #72 0x0000000000000001 in () #73 0x00000000016750d0 in () #74 0x0000000001651020 in () --Type <RET> for more, q to quit, c to continue without paging-- #75 0x0000000000000000 in () 1779315 1 434164 pnormand 2021-07-24 03:25:05 -0700 Created attachment 434164 Patch 1779316 2 ews-watchlist 2021-07-24 03:25:59 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1779408 3 ews-feeder 2021-07-26 00:48:52 -0700 Committed r280291 (239949@main): <https://commits.webkit.org/239949@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434164. 1779409 4 webkit-bug-importer 2021-07-26 00:49:16 -0700 <rdar://problem/81093648> 1781612 5 cgarcia 2021-08-03 08:08:03 -0700 I'm not sure this is the right fix. We don't manually disconnect other clients because WebPageProxy does that for us in ::close(). Maybe we can just move the resetState() call in WebPageProxy::close() after the clients are reset. 1784424 6 cgarcia 2021-08-15 23:18:40 -0700 (In reply to Carlos Garcia Campos from comment #5) > I'm not sure this is the right fix. We don't manually disconnect other > clients because WebPageProxy does that for us in ::close(). Maybe we can > just move the resetState() call in WebPageProxy::close() after the clients > are reset. Could you check this Phil? 1784451 7 pnormand 2021-08-16 03:29:31 -0700 . 1784452 8 435582 pnormand 2021-08-16 03:31:43 -0700 Created attachment 435582 Patch 1784475 9 ews-feeder 2021-08-16 06:33:59 -0700 Committed r281076 (240536@main): <https://commits.webkit.org/240536@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435582. 434164 2021-07-24 03:25:05 -0700 2021-08-16 03:31:38 -0700 Patch bug-228232-20210724032504.patch text/plain 2700 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwMjQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGYyMzQxNGViMWI5M2I4NWQx NDllZTEzNjQyYTE0YmZkYzlmNjI1NDMuLmNmOTI3NDYyYzc4ZmIwOTdkZDI5Zjk1YTlmNjBjMDk2 NTJmMDQxY2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjEtMDctMjQgIFBoaWxpcHBl IE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIE1pbmlCcm93 c2VyIGNyYXNoZXMgd2hlbiBjbG9zZWQgd2hpbGUgY2FwdHVyaW5nIGRlc2t0b3AKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyODIzMgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERpc2Nvbm5lY3QgdGhlIFdl YlZpZXcgZnJvbSB0aGUgV2ViUGFnZVByb3h5IGp1c3QgYmVmb3JlIHRoZSBmaW5hbCBHT2JqZWN0 IGRpc3Bvc2UgY2FsbCwgaW4KKyAgICAgICAgb3JkZXIgdG8gYXZvaWQgVUlDbGllbnQgbm90aWZp Y2F0aW9ucyBvbiB0aGUgYmVpbmctZGlzcG9zZWQgV2ViVmlldy4KKworICAgICAgICAqIFVJUHJv Y2Vzcy9BUEkvZ2xpYi9XZWJLaXRVSUNsaWVudC5jcHA6CisgICAgICAgIChkZXRhY2hVSUNsaWVu dEZyb21WaWV3KToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0VUlDbGllbnQu aDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0V2ViVmlldy5jcHA6CisgICAg ICAgICh3ZWJraXRXZWJWaWV3RGlzcG9zZSk6CisKIDIwMjEtMDctMjMgIE15bGVzIEMuIE1heGZp ZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAgICBbR1BVIFByb2Nlc3NdIE1pZ3Jh dGUgdGhlIERpc3BsYXlMaXN0OjpSZXBsYXllcjo6RGVsZWdhdGUgZnJvbSBSZW1vdGVJbWFnZUJ1 ZmZlciB0byBSZW1vdGVSZW5kZXJpbmdCYWNrZW5kCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRVSUNsaWVudC5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRVSUNsaWVudC5jcHAKaW5kZXggODM2N2IyMzhmMjJjZjhh NDU0N2Y4ZWY3ZWM3NjdiZWJiMGE3YjIwOS4uNTYxYmJkMDE4Mjc4Njg1OWUzN2VkMDg5ZTNlYzZh YTExOGRlZjY1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIv V2ViS2l0VUlDbGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGli L1dlYktpdFVJQ2xpZW50LmNwcApAQCAtMzg5LDMgKzM4OSw3IEBAIHZvaWQgYXR0YWNoVUlDbGll bnRUb1ZpZXcoV2ViS2l0V2ViVmlldyogd2ViVmlldykKICAgICB3ZWJraXRXZWJWaWV3R2V0UGFn ZSh3ZWJWaWV3KS5zZXRVSUNsaWVudChtYWtlVW5pcXVlPFVJQ2xpZW50Pih3ZWJWaWV3KSk7CiB9 CiAKK3ZvaWQgZGV0YWNoVUlDbGllbnRGcm9tVmlldyhXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3KQor eworICAgIHdlYmtpdFdlYlZpZXdHZXRQYWdlKHdlYlZpZXcpLnNldFVJQ2xpZW50KG51bGxwdHIp OworfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0 VUlDbGllbnQuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFVJQ2xp ZW50LmgKaW5kZXggYThhNTAwN2RhOGVkMDU3ZTBkZjg5ZWIyOGU5YmI0ZGNiN2MzYWZkZi4uZDkw MDM1Nzg3ZWZhODY0ZDdhMzY3ZmViZGI2MTFlZGUxZDFmZDkwZSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0VUlDbGllbnQuaAorKysgYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRVSUNsaWVudC5oCkBAIC0yMiwzICsyMiw0 IEBACiAjaW5jbHVkZSAiV2ViS2l0V2ViVmlldy5oIgogCiB2b2lkIGF0dGFjaFVJQ2xpZW50VG9W aWV3KFdlYktpdFdlYlZpZXcqKTsKK3ZvaWQgZGV0YWNoVUlDbGllbnRGcm9tVmlldyhXZWJLaXRX ZWJWaWV3Kik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9X ZWJLaXRXZWJWaWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktp dFdlYlZpZXcuY3BwCmluZGV4IDU1NDM0ZDhhMDlmY2ZhYjc5NTRmMmE3ZWRjMjc5OTZkZTQwOTU2 ZGQuLmYwNDRkMTBmN2ZmNDM4OGI1MDA5MTk1ZGRjY2Y1YzVhYjQ5YTk0NzcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFdlYlZpZXcuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFdlYlZpZXcuY3BwCkBAIC0x MDE3LDYgKzEwMTcsNyBAQCBzdGF0aWMgdm9pZCB3ZWJraXRXZWJWaWV3RGlzcG9zZShHT2JqZWN0 KiBvYmplY3QpCiAjZW5kaWYKIAogICAgIFdlYkNvcmU6OnNldFNjcmVlbkRQSU9ic2VydmVySGFu ZGxlcihudWxscHRyLCB3ZWJWaWV3KTsKKyAgICBkZXRhY2hVSUNsaWVudEZyb21WaWV3KHdlYlZp ZXcpOwogCiAgICAgR19PQkpFQ1RfQ0xBU1Mod2Via2l0X3dlYl92aWV3X3BhcmVudF9jbGFzcykt PmRpc3Bvc2Uob2JqZWN0KTsKIH0K 435582 2021-08-16 03:31:43 -0700 2021-08-16 06:34:00 -0700 Patch bug-228232-20210816033142.patch text/plain 3849 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxMDcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGVkOTk0MGU1ZjJkMjcyZmEz M2IyOGExYzE1NGMxZDNmMzA0OWRmOTEuLmQ0ZjhlYTZmYzhhYTI3ZTgzNjEyYjU4Y2JhMDhhNDFh M2I5YjFmNGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMjEtMDgtMTYgIFBoaWxpcHBl IE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIE1pbmlCcm93 c2VyIGNyYXNoZXMgd2hlbiBjbG9zZWQgd2hpbGUgY2FwdHVyaW5nIGRlc2t0b3AKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyODIzMgorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vODEwOTM2NDg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUmVtb3ZlIGV4cGxpY2l0IGRldGFjaCBjYWxsIGZyb20gdGhlIFVJ Q2xpZW50LiBSZXNldHRpbmcgdGhlIHBhZ2Ugc3RhdGUgaW4gdGhlIHByb3h5ICphZnRlcioKKyAg ICAgICAgdGhlIGNsaWVudHMgaGF2ZSBiZWVuIGNsZWFyZWQgaXMgYSBiZXR0ZXIgZml4IGZvciB0 aGlzIGNyYXNoLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFVJQ2xpZW50 LmNwcDoKKyAgICAgICAgKGF0dGFjaFVJQ2xpZW50VG9WaWV3KToKKyAgICAgICAgKGRldGFjaFVJ Q2xpZW50RnJvbVZpZXcpOiBEZWxldGVkLgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ2xpYi9X ZWJLaXRVSUNsaWVudC5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRXZWJW aWV3LmNwcDoKKyAgICAgICAgKHdlYmtpdFdlYlZpZXdEaXNwb3NlKToKKyAgICAgICAgKiBVSVBy b2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5Ojpj bG9zZSk6CisKIDIwMjEtMDgtMTUgIE1pZ3VlbCBHb21leiAgPG1hZ29tZXpAaWdhbGlhLmNvbT4K IAogICAgICAgICBbR1RLXVtXUEVdIEFkZCBBUEkgdG8gcGFzcyBXZWJLaXRNZW1vcnlQcmVzc3Vy ZUhhbmRsZXIgcGFyYW1ldGVycyB0byB0aGUgbmV0d29yayBwcm9jZXNzZXMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFVJQ2xpZW50LmNwcCBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFVJQ2xpZW50LmNwcAppbmRleCA1 NjFiYmQwMTgyNzg2ODU5ZTM3ZWQwODllM2VjNmFhMTE4ZGVmNjU0Li42YzFjZjQ1NDQzNjMzZTRj NTQ4YzE0NjY1N2JkNTJhNTc0MzYyYWIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9BUEkvZ2xpYi9XZWJLaXRVSUNsaWVudC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvQVBJL2dsaWIvV2ViS2l0VUlDbGllbnQuY3BwCkBAIC0zODgsOCArMzg4LDMgQEAgdm9p ZCBhdHRhY2hVSUNsaWVudFRvVmlldyhXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3KQogewogICAgIHdl YmtpdFdlYlZpZXdHZXRQYWdlKHdlYlZpZXcpLnNldFVJQ2xpZW50KG1ha2VVbmlxdWU8VUlDbGll bnQ+KHdlYlZpZXcpKTsKIH0KLQotdm9pZCBkZXRhY2hVSUNsaWVudEZyb21WaWV3KFdlYktpdFdl YlZpZXcqIHdlYlZpZXcpCi17Ci0gICAgd2Via2l0V2ViVmlld0dldFBhZ2Uod2ViVmlldykuc2V0 VUlDbGllbnQobnVsbHB0cik7Ci19CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9BUEkvZ2xpYi9XZWJLaXRVSUNsaWVudC5oIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJ L2dsaWIvV2ViS2l0VUlDbGllbnQuaAppbmRleCBkOTAwMzU3ODdlZmE4NjRkN2EzNjdmZWJkYjYx MWVkZTFkMWZkOTBlLi44NjIyNTA3NDJiZmQwZTQ3YjMwNWUzMjg2ZTYxZjU0NGM0MDI0MzYxIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRVSUNsaWVu dC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFVJQ2xpZW50 LmgKQEAgLTIyLDQgKzIyLDQgQEAKICNpbmNsdWRlICJXZWJLaXRXZWJWaWV3LmgiCiAKIHZvaWQg YXR0YWNoVUlDbGllbnRUb1ZpZXcoV2ViS2l0V2ViVmlldyopOwotdm9pZCBkZXRhY2hVSUNsaWVu dEZyb21WaWV3KFdlYktpdFdlYlZpZXcqKTsKKwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0V2ViVmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9BUEkvZ2xpYi9XZWJLaXRXZWJWaWV3LmNwcAppbmRleCBmMDQ0ZDEwZjdmZjQzODhiNTAw OTE5NWRkY2NmNWM1YWI0OWE5NDc3Li41NTQzNGQ4YTA5ZmNmYWI3OTU0ZjJhN2VkYzI3OTk2ZGU0 MDk1NmRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJL aXRXZWJWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJL aXRXZWJWaWV3LmNwcApAQCAtMTAxNyw3ICsxMDE3LDYgQEAgc3RhdGljIHZvaWQgd2Via2l0V2Vi Vmlld0Rpc3Bvc2UoR09iamVjdCogb2JqZWN0KQogI2VuZGlmCiAKICAgICBXZWJDb3JlOjpzZXRT Y3JlZW5EUElPYnNlcnZlckhhbmRsZXIobnVsbHB0ciwgd2ViVmlldyk7Ci0gICAgZGV0YWNoVUlD bGllbnRGcm9tVmlldyh3ZWJWaWV3KTsKIAogICAgIEdfT0JKRUNUX0NMQVNTKHdlYmtpdF93ZWJf dmlld19wYXJlbnRfY2xhc3MpLT5kaXNwb3NlKG9iamVjdCk7CiB9CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwIGIvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvV2ViUGFnZVByb3h5LmNwcAppbmRleCAxZTdkOWJiMWEyZTNhMGU1ZjI5NDdkNTgwMTY5 NzM0YmIzNWExYTM0Li5mMTkwOTIyNTA5YzdkYWI0YmMxZDJkZTIzZDQzZmRjYjRlODIyMGVjIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKQEAgLTExNjksOCArMTE2 OSw2IEBAIHZvaWQgV2ViUGFnZVByb3h5OjpjbG9zZSgpCiAKICAgICBtX3Byb2Nlc3MtPmRpc2Nv bm5lY3RGcmFtZXNGcm9tUGFnZSh0aGlzKTsKIAotICAgIHJlc2V0U3RhdGUoUmVzZXRTdGF0ZVJl YXNvbjo6UGFnZUludmFsaWRhdGVkKTsKLQogICAgIG1fbG9hZGVyQ2xpZW50ID0gbnVsbHB0cjsK ICAgICBtX25hdmlnYXRpb25DbGllbnQgPSBtYWtlVW5pcXVlUmVmPEFQSTo6TmF2aWdhdGlvbkNs aWVudD4oKTsKICAgICBtX3BvbGljeUNsaWVudCA9IG51bGxwdHI7CkBAIC0xMTg3LDYgKzExODUs OCBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6Y2xvc2UoKQogICAgIG1fZnVsbHNjcmVlbkNsaWVudCA9 IG1ha2VVbmlxdWU8QVBJOjpGdWxsc2NyZWVuQ2xpZW50PigpOwogI2VuZGlmCiAKKyAgICByZXNl dFN0YXRlKFJlc2V0U3RhdGVSZWFzb246OlBhZ2VJbnZhbGlkYXRlZCk7CisKICAgICBtX3Byb2Nl c3MtPnByb2Nlc3NQb29sKCkuYmFja0ZvcndhcmRDYWNoZSgpLnJlbW92ZUVudHJpZXNGb3JQYWdl KCp0aGlzKTsKIAogICAgIFJ1bkxvb3A6OmN1cnJlbnQoKS5kaXNwYXRjaChbZGVzdGluYXRpb25J RCA9IG1lc3NhZ2VTZW5kZXJEZXN0aW5hdGlvbklEKCksIHByb3RlY3RlZFByb2Nlc3MgPSBtX3By b2Nlc3MuY29weVJlZigpLCBwcmV2ZW50UHJvY2Vzc1NodXRkb3duU2NvcGUgPSBtX3Byb2Nlc3Mt PnNodXRkb3duUHJldmVudGluZ1Njb3BlKCldIHsK