22823 2008-12-12 05:57:43 -0800 REGRESSION (TOT): Canvas is broken in high dpi mode 2008-12-12 06:11:48 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED http://nerget.com/tests/canvas-high-dpi.html InRadar P2 Normal --- 1 oliver oliver oldest_to_newest 102343 0 oliver 2008-12-12 05:57:43 -0800 <rdar://problem/6432739> I was working on another canvas issue and I realised the somewhere in the canvas refactorings of the past few months canvas lost the code that correctly scaled to handle high dpi display modes * STEPS TO REPRODUCE 1. Use Quartz Debug to change the display scale to 2x 2. Launch Safari (ToT) -- Safari must be launched *after* step 1 3. Go to http://nerget.com/tests/canvas-high-dpi.html 102344 1 25979 oliver 2008-12-12 06:02:27 -0800 Created attachment 25979 Fix initial context scale Patcheration 102345 2 25979 ap 2008-12-12 06:05:42 -0800 Comment on attachment 25979 Fix initial context scale + m_imageBuffer->context()->scale(FloatSize(size.width()/unscaledSize.width(), size.height()/unscaledSize.height())); Please add spaces around '/'. + transform.scale(size.width()/unscaledSize.width(), size.height()/unscaledSize.height()); Ditto. r=me 102346 3 oliver 2008-12-12 06:11:48 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/html/HTMLCanvasElement.cpp Committed r39240 25979 2008-12-12 06:02:27 -0800 2008-12-12 06:05:42 -0800 Fix initial context scale highdpi-canvas.patch text/plain 2055 oliver ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NWM5ZTAxNC4uYTk5YjU5ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOC0xMi0xMiAgT2xpdmVyIEh1bnQg IDxvbGl2ZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFJFR1JFU1NJT046IENhbnZhcyBpcyBicm9rZW4gaW4gaGlnaCBkcGkgbW9k ZQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjQzMjczOT4gPGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMjgyMz4KKworICAgICAgICBTaW1wbHkgbWFkZSBzdXJlIHRo YXQgd2UgY29ycmVjdGx5IHNjYWxlIHRoZSBncmFwaGljcyBjb250ZXh0IHRvCisgICAgICAgIGFj Y291bnQgZm9yIHRoZSBkaWZmZXJlbmNlIGJldHdlZW4gbG9naWNhbCBhbmQgYnVmZmVyIHJlc29s dXRpb24uCisKKyAgICAgICAgKiBodG1sL0hUTUxDYW52YXNFbGVtZW50LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkhUTUxDYW52YXNFbGVtZW50OjpjcmVhdGVJbWFnZUJ1ZmZlcik6CisgICAgICAg IChXZWJDb3JlOjpIVE1MQ2FudmFzRWxlbWVudDo6YmFzZVRyYW5zZm9ybSk6CisKIDIwMDgtMTIt MTIgIFRvciBBcm5lIFZlc3Riw7ggIDx0YXZlc3Rib0B0cm9sbHRlY2guY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL0hU TUxDYW52YXNFbGVtZW50LmNwcCBiL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHAK aW5kZXggOWY1OWYyMy4uODUwMDI0NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9odG1sL0hUTUxDYW52 YXNFbGVtZW50LmNwcAorKysgYi9XZWJDb3JlL2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuY3BwCkBA IC0yNTMsOCArMjUzLDkgQEAgdm9pZCBIVE1MQ2FudmFzRWxlbWVudDo6Y3JlYXRlSW1hZ2VCdWZm ZXIoKSBjb25zdAogICAgIEludFNpemUgc2l6ZSA9IGNvbnZlcnRMb2dpY2FsVG9EZXZpY2UodW5z Y2FsZWRTaXplKTsKICAgICBpZiAoIXNpemUud2lkdGgoKSB8fCAhc2l6ZS5oZWlnaHQoKSkKICAg ICAgICAgcmV0dXJuOwotICAgIG1faW1hZ2VCdWZmZXIuc2V0KEltYWdlQnVmZmVyOjpjcmVhdGUo c2l6ZSwgZmFsc2UpLnJlbGVhc2UoKSk7CiAKKyAgICBtX2ltYWdlQnVmZmVyLnNldChJbWFnZUJ1 ZmZlcjo6Y3JlYXRlKHNpemUsIGZhbHNlKS5yZWxlYXNlKCkpOworICAgIG1faW1hZ2VCdWZmZXIt PmNvbnRleHQoKS0+c2NhbGUoRmxvYXRTaXplKHNpemUud2lkdGgoKS91bnNjYWxlZFNpemUud2lk dGgoKSwgc2l6ZS5oZWlnaHQoKS91bnNjYWxlZFNpemUuaGVpZ2h0KCkpKTsKICAgICBtX2ltYWdl QnVmZmVyLT5jb250ZXh0KCktPnNldFNoYWRvd3NJZ25vcmVUcmFuc2Zvcm1zKHRydWUpOwogfQog CkBAIC0yNzMsNyArMjc0LDEzIEBAIEltYWdlQnVmZmVyKiBIVE1MQ2FudmFzRWxlbWVudDo6YnVm ZmVyKCkgY29uc3QKIEFmZmluZVRyYW5zZm9ybSBIVE1MQ2FudmFzRWxlbWVudDo6YmFzZVRyYW5z Zm9ybSgpIGNvbnN0CiB7CiAgICAgQVNTRVJUKG1fY3JlYXRlZEltYWdlQnVmZmVyKTsKLSAgICBy ZXR1cm4gbV9pbWFnZUJ1ZmZlci0+YmFzZVRyYW5zZm9ybSgpOworICAgIEZsb2F0U2l6ZSB1bnNj YWxlZFNpemUod2lkdGgoKSwgaGVpZ2h0KCkpOworICAgIEludFNpemUgc2l6ZSA9IGNvbnZlcnRM b2dpY2FsVG9EZXZpY2UodW5zY2FsZWRTaXplKTsKKyAgICBBZmZpbmVUcmFuc2Zvcm0gdHJhbnNm b3JtOworICAgIGlmIChzaXplLndpZHRoKCkgJiYgc2l6ZS5oZWlnaHQoKSkKKyAgICAgICAgdHJh bnNmb3JtLnNjYWxlKHNpemUud2lkdGgoKS91bnNjYWxlZFNpemUud2lkdGgoKSwgc2l6ZS5oZWln aHQoKS91bnNjYWxlZFNpemUuaGVpZ2h0KCkpOworICAgIHRyYW5zZm9ybS5tdWx0aXBseShtX2lt YWdlQnVmZmVyLT5iYXNlVHJhbnNmb3JtKCkpOworICAgIHJldHVybiB0cmFuc2Zvcm07CiB9CiAK IH0K