22820 2008-12-11 23:32:38 -0800 WebCore timers sometimes stop running 2008-12-12 10:11:10 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 sfalken webkit-unassigned sam oldest_to_newest 102328 0 sfalken 2008-12-11 23:32:38 -0800 A problem in the Windows shared timer code results in us failing to fire the shared timer. This is fatal to all future timers, so the net result is that no timers will run for the remainder of the app's lifetime. 102331 1 25975 sfalken 2008-12-12 00:25:47 -0800 Created attachment 25975 Delete the timer from the same thread that schedules the timer 102364 2 sfalken 2008-12-12 10:11:10 -0800 Fixed in r39247. 25975 2008-12-12 00:25:47 -0800 2008-12-12 00:59:04 -0800 Delete the timer from the same thread that schedules the timer diff.txt text/plain 4540 sfalken SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM5MjI2 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjcgQEAKKzIwMDgtMTIt MTEgIFN0ZXZlIEZhbGtlbmJ1cmcgIDxzZmFsa2VuQGFwcGxlLmNvbT4KKworICAgICAgICBEZWxl dGUgdGhlIHByZXZpb3VzIHRpbWVyLXF1ZXVlIHRpbWVyIGluIHRoZSBtYWluIHRocmVhZCwganVz dCBwcmlvciB0byBzY2hlZHVsaW5nIGEgbmV3IHRpbWVyLgorICAgICAgICBUaGUgY29kZSBwcmV2 aW91c2x5IGNhbGxlZCBEZWxldGVUaW1lclF1ZXVlVGltZXIgaW4gdGhlIHRpbWVyIGNhbGxiYWNr IHByb2MuCisgICAgICAgIAorICAgICAgICBUaGUgbmV3IHRlY2huaXF1ZSBzaW1wbGlmaWVzIHRo ZSBjb2RlLCBzaW5jZSB3ZSBub3cgY3JlYXRlIGFuZCBkZWxldGUgdGltZXJzIG9uIHRoZQorICAg ICAgICBzYW1lIHRocmVhZCwgYW5kIGRvbid0IGFjY2VzcyB0aGUgdGltZXIgcXVldWUgb3IgdGlt ZXIgaGFuZGxlcyBpbiB0aGUgY2FsbGJhY2suCisgICAgICAgIFRoaXMgYWxsb3dzIHVzIHRvIHJl bW92ZSBzb21lIG11dGV4IHVzZSwgYW5kIG1vcmUgaW1wb3J0YW50bHksIGl0IHNvbHZlcyBhIHJh Y2UKKyAgICAgICAgY29uZGl0aW9uIHRoYXQgd2FzIG9jY3VyaW5nIGJldHdlZW4gQ2hhbmdlVGlt ZXJRdWV1ZVRpbWVyIGFuZCBEZWxldGVUaW1lclF1ZXVlVGltZXIuCisgICAgICAgIAorICAgICAg ICBTaW5jZSB0aGUgdGltZXIgY2FsbGJhY2sgaXNuJ3QgcGFzc2VkIHRoZSB0aW1lciBoYW5kbGUs IHdlIHdlcmUgcmV0cmlldmluZyB0aGF0IGhhbmRsZQorICAgICAgICB2aWEgYSBnbG9iYWwuIElm IHRoZSB0aW1lciBjYWxsYmFjayBjb2RlIHdhcyBlbnRlcmVkLCBidXQgdGhlbiBhIG5ldyB0aW1l ciB3YXMgaW1tZWRpYXRlbHkKKyAgICAgICAgc2NoZWR1bGVkIChwcmlvciB0byB0aGUgY2FsbGJh Y2sgYWNxdWlyaW5nIHRoZSBtdXRleCBhbmQgY2FsbGluZyBEZWxldGVUaW1lclF1ZXVlVGltZXIp LAorICAgICAgICB0aGVyZSB3YXMgYSBzbWFsbCB3aW5kb3cgd2hlcmUgdGhlIHRpbWVyIGNvdWxk IGJlIHJlLXNjaGVkdWxlZCB2aWEgQ2hhbmdlVGltZXJRdWV1ZVRpbWVyCisgICAgICAgIGFuZCB0 aGVuIGltbWVkaWF0ZWx5IGRlbGV0ZWQgb25jZSB0aGUgYWxyZWFkeSBydW5uaW5nIGNhbGxiYWNr IGFjcXVpcmVkIHRoZSBtdXRleCBhbmQKKyAgICAgICAgdGhlbiBjYWxsZWQgRGVsZXRlVGltZXJR dWV1ZVRpbWVyLiBUaGlzIHJlc3VsdGVkIGluIHRoZSBuZXdseSBzY2hlZHVsZWQgdGltZXIgbmV2 ZXIgZmlyaW5nLgorICAgICAgICAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBwbGF0Zm9ybS93aW4vU2hhcmVkVGltZXJXaW4uY3BwOgorICAgICAgICAo V2ViQ29yZTo6cXVldWVUaW1lclByb2MpOiBEb24ndCBkZWxldGUgdGhlIHRpbWVyIGluIHRoZSBj YWxsYmFjay4KKyAgICAgICAgKFdlYkNvcmU6OnNldFNoYXJlZFRpbWVyRmlyZVRpbWUpOiBBbHdh eXMgZGVsZXRlIGFuZCBjcmVhdGUgdGhlIHRpbWVyIGluc3RlYWQgb2YgdXNpbmcgQ2hhbmdlVGlt ZXJRdWV1ZVRpbWVyLgorICAgICAgICAoV2ViQ29yZTo6c3RvcFNoYXJlZFRpbWVyKTogQ2FsbCBE ZWxldGVUaW1lclF1ZXVlVGltZXIgZGlyZWN0bHkuCisKIDIwMDgtMTItMTEgIE5pa29sYXMgWmlt bWVybWFubiAgPG5pa29sYXMuemltbWVybWFubkB0b3JjaG1vYmlsZS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgSG9sZ2VyIEZyZXl0aGVyLgpJbmRleDogcGxhdGZvcm0vd2luL1NoYXJlZFRp bWVyV2luLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBwbGF0Zm9ybS93aW4vU2hhcmVkVGltZXJXaW4uY3Bw CShyZXZpc2lvbiAzOTE0NykKKysrIHBsYXRmb3JtL3dpbi9TaGFyZWRUaW1lcldpbi5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTQxLDYgKzQxLDEwIEBACiAjaW5jbHVkZSA8d2luZG93cy5oPgogI2lu Y2x1ZGUgPG1tc3lzdGVtLmg+CiAKKyNpZiBQTEFURk9STShXSU4pCisjaW5jbHVkZSAiUGx1Z2lu Vmlldy5oIgorI2VuZGlmCisKIC8vIFRoZXNlIGFyZW4ndCBpbiB3aW51c2VyLmggd2l0aCB0aGUg TVNWUyAyMDAzIFBsYXRmb3JtIFNESywgCiAvLyBzbyB1c2UgZGVmYXVsdCB2YWx1ZXMgaW4gdGhh dCBjYXNlLgogI2lmbmRlZiBVU0VSX1RJTUVSX01JTklNVU0KQEAgLTU1LDEwICs1OSw2IEBACiAj ZGVmaW5lIFFTX1JBV0lOUFVUICAgICAgICAgMHgwNDAwCiAjZW5kaWYKIAotI2lmIFBMQVRGT1JN KFdJTikKLSNpbmNsdWRlICJQbHVnaW5WaWV3LmgiCi0jZW5kaWYKLQogbmFtZXNwYWNlIFdlYkNv cmUgewogCiBzdGF0aWMgVUlOVCB0aW1lcklEOwpAQCAtNjgsNyArNjgsNiBAQCBzdGF0aWMgSFdO RCB0aW1lcldpbmRvd0hhbmRsZSA9IDA7CiBzdGF0aWMgVUlOVCB0aW1lckZpcmVkTWVzc2FnZSA9 IDA7CiBzdGF0aWMgSEFORExFIHRpbWVyUXVldWU7CiBzdGF0aWMgSEFORExFIHRpbWVyOwotc3Rh dGljIE11dGV4IHRpbWVyTXV0ZXg7CiBzdGF0aWMgYm9vbCBoaWdoUmVzVGltZXJBY3RpdmU7CiBz dGF0aWMgYm9vbCBwcm9jZXNzaW5nQ3VzdG9tVGltZXJNZXNzYWdlID0gZmFsc2U7CiBzdGF0aWMg TE9ORyBwZW5kaW5nVGltZXJzOwpAQCAtMTM5LDE3ICsxMzgsOCBAQCB2b2lkIHNldFNoYXJlZFRp bWVyRmlyZWRGdW5jdGlvbih2b2lkICgqCiAgICAgc2hhcmVkVGltZXJGaXJlZEZ1bmN0aW9uID0g ZjsKIH0KIAotc3RhdGljIHZvaWQgY2xlYXJUaW1lcigpCi17Ci0gICAgTXV0ZXhMb2NrZXIgbG9j a2VyKHRpbWVyTXV0ZXgpOwotICAgIGlmICh0aW1lclF1ZXVlICYmIHRpbWVyKQotICAgICAgICBE ZWxldGVUaW1lclF1ZXVlVGltZXIodGltZXJRdWV1ZSwgdGltZXIsIDApOwotICAgIHRpbWVyID0g MDsKLX0KLQogc3RhdGljIHZvaWQgTlRBUEkgcXVldWVUaW1lclByb2MoUFZPSUQsIEJPT0xFQU4p CiB7Ci0gICAgY2xlYXJUaW1lcigpOwogICAgIGlmIChJbnRlcmxvY2tlZEluY3JlbWVudCgmcGVu ZGluZ1RpbWVycykgPT0gMSkKICAgICAgICAgUG9zdE1lc3NhZ2UodGltZXJXaW5kb3dIYW5kbGUs IHRpbWVyRmlyZWRNZXNzYWdlLCAwLCAwKTsKIH0KQEAgLTE5NiwxMSArMTg2LDkgQEAgdm9pZCBz ZXRTaGFyZWRUaW1lckZpcmVUaW1lKGRvdWJsZSBmaXJlVAogICAgICAgICAgICAgLy8gT3RoZXJ3 aXNlLCBkZWxheSB0aGUgUG9zdE1lc3NhZ2UgdmlhIGEgQ3JlYXRlVGltZXJRdWV1ZVRpbWVyCiAg ICAgICAgICAgICBpZiAoIXRpbWVyUXVldWUpCiAgICAgICAgICAgICAgICAgdGltZXJRdWV1ZSA9 IENyZWF0ZVRpbWVyUXVldWUoKTsKLSAgICAgICAgICAgIE11dGV4TG9ja2VyIGxvY2tlcih0aW1l ck11dGV4KTsKICAgICAgICAgICAgIGlmICh0aW1lcikKLSAgICAgICAgICAgICAgICB0aW1lclNl dCA9IENoYW5nZVRpbWVyUXVldWVUaW1lcih0aW1lclF1ZXVlLCB0aW1lciwgaW50ZXJ2YWxJbk1T LCAwKTsKLSAgICAgICAgICAgIGVsc2UKLSAgICAgICAgICAgICAgICB0aW1lclNldCA9IENyZWF0 ZVRpbWVyUXVldWVUaW1lcigmdGltZXIsIHRpbWVyUXVldWUsIHF1ZXVlVGltZXJQcm9jLCAwLCBp bnRlcnZhbEluTVMsIDAsIFdUX0VYRUNVVEVJTlRJTUVSVEhSRUFEIHwgV1RfRVhFQ1VURU9OTFlP TkNFKTsKKyAgICAgICAgICAgICAgICBEZWxldGVUaW1lclF1ZXVlVGltZXIodGltZXJRdWV1ZSwg dGltZXIsIDApOworICAgICAgICAgICAgdGltZXJTZXQgPSBDcmVhdGVUaW1lclF1ZXVlVGltZXIo JnRpbWVyLCB0aW1lclF1ZXVlLCBxdWV1ZVRpbWVyUHJvYywgMCwgaW50ZXJ2YWxJbk1TLCAwLCBX VF9FWEVDVVRFSU5USU1FUlRIUkVBRCB8IFdUX0VYRUNVVEVPTkxZT05DRSk7CiAgICAgICAgIH0K ICAgICB9CiAKQEAgLTIwOSwxMyArMTk3LDE5IEBAIHZvaWQgc2V0U2hhcmVkVGltZXJGaXJlVGlt ZShkb3VibGUgZmlyZVQKICAgICAgICAgICAgIEtpbGxUaW1lcih0aW1lcldpbmRvd0hhbmRsZSwg dGltZXJJRCk7CiAgICAgICAgICAgICB0aW1lcklEID0gMDsKICAgICAgICAgfQotICAgIH0gZWxz ZQorICAgIH0gZWxzZSB7CiAgICAgICAgIHRpbWVySUQgPSBTZXRUaW1lcih0aW1lcldpbmRvd0hh bmRsZSwgc2hhcmVkVGltZXJJRCwgaW50ZXJ2YWxJbk1TLCAwKTsKKyAgICAgICAgdGltZXIgPSAw OworICAgIH0KIH0KIAogdm9pZCBzdG9wU2hhcmVkVGltZXIoKQogewotICAgIGNsZWFyVGltZXIo KTsKKyAgICBpZiAodGltZXJRdWV1ZSAmJiB0aW1lcikgeworICAgICAgICBEZWxldGVUaW1lclF1 ZXVlVGltZXIodGltZXJRdWV1ZSwgdGltZXIsIDApOworICAgICAgICB0aW1lciA9IDA7CisgICAg fQorCiAgICAgaWYgKHRpbWVySUQpIHsKICAgICAgICAgS2lsbFRpbWVyKHRpbWVyV2luZG93SGFu ZGxlLCB0aW1lcklEKTsKICAgICAgICAgdGltZXJJRCA9IDA7Cg==