228184 2021-07-22 09:17:54 -0700 Compilation error with gcc version 9.3.0 (Buildroot 2020.08-14-ge5a2a90) 2021-07-22 10:19:22 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 vjaquez vjaquez cdumez darin eric.carlson ews-watchlist glenn hta jer.noble philipj sergio tommyw webkit-bug-importer youennf oldest_to_newest 1778714 0 vjaquez 2021-07-22 09:17:54 -0700 While cross compiling with gcc version 9.3.0 (Buildroot 2020.08-14-ge5a2a90) I hit with this compilation error: WebCore/DerivedSources/JSRTCRtpSender.cpp: In function ‘JSC::JSValue WebCore::toJSNewlyCreated(JSC::JSGlobalObject*, WebCore::JSDOMGlobalObject*, WTF::Ref<WebCore::RTCRtpSender>&&)’: WebCore/DerivedSources/JSRTCRtpSender.cpp:500:54: error: static assertion failed: RTCRtpSender is not polymorphic 500 | static_assert(std::is_polymorphic<RTCRtpSender>::value, "RTCRtpSender is not polymorphic"); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~ 1778718 1 434014 vjaquez 2021-07-22 09:24:37 -0700 Created attachment 434014 Patch 1778721 2 434014 cdumez 2021-07-22 09:28:47 -0700 Comment on attachment 434014 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434014&action=review > Source/WebCore/Modules/mediastream/RTCRtpReceiver.h:59 > + virtual ~RTCRtpReceiver(); Oh, that's because your port doesn't subclass LoggerHelper. 1778728 3 vjaquez 2021-07-22 09:47:53 -0700 (In reply to Chris Dumez from comment #2) > Comment on attachment 434014 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=434014&action=review > > > Source/WebCore/Modules/mediastream/RTCRtpReceiver.h:59 > > + virtual ~RTCRtpReceiver(); > > Oh, that's because your port doesn't subclass LoggerHelper. Thanks! Let me look at it :) 1778731 4 vjaquez 2021-07-22 09:59:06 -0700 But still, LoggerHelper inheritance is conditional... 1778737 5 ews-feeder 2021-07-22 10:18:27 -0700 Committed r280179 (239873@main): <https://commits.webkit.org/239873@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434014. 1778738 6 webkit-bug-importer 2021-07-22 10:19:22 -0700 <rdar://problem/80968862> 434014 2021-07-22 09:24:37 -0700 2021-07-22 10:18:29 -0700 Patch bug-228184-20210722182435.patch text/plain 2633 vjaquez U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwMTcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmQ2NTgyZmNkOTBhMTEz MTg4ZmQ0Y2U4NThmZmIzNTczMWMzM2Y3Ny4uMGJhZTlmZmI2ZjBjN2JjZDc0MzczMzNkNTM0Mjkz N2Q2YjM2N2JiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIxLTA3LTIyICBWw61j dG9yIE1hbnVlbCBKw6FxdWV6IExlYWwgIDx2amFxdWV6QGlnYWxpYS5jb20+CisKKyAgICAgICAg Q29tcGlsYXRpb24gZXJyb3Igd2l0aCBnY2MgdmVyc2lvbiA5LjMuMCAoQnVpbGRyb290IDIwMjAu MDgtMTQtZ2U1YTJhOTApCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMjgxODQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUdXJuIGRlc3RydWN0b3JzIGludG8gdmlydHVhbCBvbmVzIGZvciBSVENSdHBSZWNl aXZlciBhbmQgUlRDUnRwU2VuZGVyLgorCisgICAgICAgIEl0IHNlZW1zIHRoYXQgZ2NjIGRvZXNu J3QgY3JlYXRlIGEgdmlydHVhbCB0YWJsZSBmb3IgdGhlc2UgY2xhc3Nlcywgd2hpbGUgY2xhbmcg ZG9lcy4gVGhhdAorICAgICAgICB3b3VsZCB0aGUgY2F1c2UsIHdoZW4gY29tcGlsaW5nIGNsYW5n LCBJbXBsZW1lbnRhdGlvbkxhY2tzVlRhYmxlIGlzIG5vdCBuZWVkZWQgaW4gdGhlIElETAorICAg ICAgICBmaWxlLiBUaGUgYXBwcm9hY2ggZm9yIHRoaXMgZml4IHRvIGZvcmNlIHRoZSB2aXJ0dWFs IHRhYmxlIGNyZWF0aW9uIGJ5IHR1cm5pbmcgZGVzdHJ1Y3RvcnMKKyAgICAgICAgaW50byB2aXJ0 dWFsLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAgICAgICAgKiBNb2R1bGVz L21lZGlhc3RyZWFtL1JUQ1J0cFJlY2VpdmVyLmg6CisgICAgICAgICogTW9kdWxlcy9tZWRpYXN0 cmVhbS9SVENSdHBTZW5kZXIuaDoKKwogMjAyMS0wNy0yMiAgTWFydGluIFJvYmluc29uICA8bXJv Ymluc29uQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW2Nzcy1zY3JvbGwtc25hcF0gUGFzcyB0aGUg ZnVsbCB0YXJnZXQgcG9pbnQgd2hlbiBzZWxlY3RpbmcgYSBzbmFwIG9mZnNldApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENSdHBSZWNlaXZlci5oIGIv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENSdHBSZWNlaXZlci5oCmluZGV4 IGQ4Mzg3ZWY0MzhiYWRiYWY4ODhiMDhlY2YzZWQyNDdiNDhiMWRmMDUuLjZhMGUwZTdkNGY3ODg5 YzY1ZWZhOTQ1OGQ2OTU4MDI1YWJmZWU0MWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvbWVkaWFzdHJlYW0vUlRDUnRwUmVjZWl2ZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL21lZGlhc3RyZWFtL1JUQ1J0cFJlY2VpdmVyLmgKQEAgLTU2LDcgKzU2LDcgQEAgcHVi bGljOgogICAgIHsKICAgICAgICAgcmV0dXJuIGFkb3B0UmVmKCpuZXcgUlRDUnRwUmVjZWl2ZXIo Y29ubmVjdGlvbiwgV1RGTW92ZSh0cmFjayksIFdURk1vdmUoYmFja2VuZCkpKTsKICAgICB9Ci0g ICAgflJUQ1J0cFJlY2VpdmVyKCk7CisgICAgdmlydHVhbCB+UlRDUnRwUmVjZWl2ZXIoKTsKIAog ICAgIHN0YXRpYyBzdGQ6Om9wdGlvbmFsPFJUQ1J0cENhcGFiaWxpdGllcz4gZ2V0Q2FwYWJpbGl0 aWVzKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQmLCBjb25zdCBTdHJpbmcmIGtpbmQpOwogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1J0cFNlbmRlci5o IGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENSdHBTZW5kZXIuaAppbmRl eCBiZjI3N2NhZjVhMWM5MWM5MzA3YWNmOTgzNmExNjc2YTgwNjFkODVkLi4xZjNhZDU2ZjRlZjJm MDkwZGVlMzg0MTU3NGMyNGI4NzdjMWI2Y2FhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL21lZGlhc3RyZWFtL1JUQ1J0cFNlbmRlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvbWVkaWFzdHJlYW0vUlRDUnRwU2VuZGVyLmgKQEAgLTU4LDcgKzU4LDcgQEAgY2xhc3Mg UlRDUnRwU2VuZGVyIGZpbmFsIDogcHVibGljIFJlZkNvdW50ZWQ8UlRDUnRwU2VuZGVyPgogcHVi bGljOgogICAgIHN0YXRpYyBSZWY8UlRDUnRwU2VuZGVyPiBjcmVhdGUoUlRDUGVlckNvbm5lY3Rp b24mLCBSZWY8TWVkaWFTdHJlYW1UcmFjaz4mJiwgc3RkOjp1bmlxdWVfcHRyPFJUQ1J0cFNlbmRl ckJhY2tlbmQ+JiYpOwogICAgIHN0YXRpYyBSZWY8UlRDUnRwU2VuZGVyPiBjcmVhdGUoUlRDUGVl ckNvbm5lY3Rpb24mLCBTdHJpbmcmJiB0cmFja0tpbmQsIHN0ZDo6dW5pcXVlX3B0cjxSVENSdHBT ZW5kZXJCYWNrZW5kPiYmKTsKLSAgICB+UlRDUnRwU2VuZGVyKCk7CisgICAgdmlydHVhbCB+UlRD UnRwU2VuZGVyKCk7CiAKICAgICBzdGF0aWMgc3RkOjpvcHRpb25hbDxSVENSdHBDYXBhYmlsaXRp ZXM+IGdldENhcGFiaWxpdGllcyhTY3JpcHRFeGVjdXRpb25Db250ZXh0JiwgY29uc3QgU3RyaW5n JiBraW5kKTsKIAo=