228171 2021-07-21 16:54:35 -0700 REGRESSION: [iOS] ASSERTION FAILED: !m_useCount in WebKit::SandboxExtension::~SandboxExtension() 2021-07-26 17:02:39 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build iPhone / iPad Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ayumi_kojima jer.noble bfulgham darin eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1778605 0 ayumi_kojima 2021-07-21 16:54:35 -0700 media/media-usage-state-private-browsing.html Is crashing on iOS 14 E Simulator wk2 Debug History: https://results.webkit.org/?suite=layout-tests&test=media%2Fmedia-usage-state-private-browsing.html It seems the crash started on around 6/8/21. I was not able to reproduce the crash on a simulator (iOS 15) on my local machine using run-webkit-tests --iterations 50 --exit-after-n-failures 2 --exit-after-n-crashes-or-timeouts 2 --debug --iphone-simulator -f media/media-usage-state-private-browsing.html The test timed out instead and it hanged with --no-timeout flag. Crash log: ASSERTION FAILED: !m_useCount /Volumes/Data/worker/ios-simulator-14-debug/build/Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm(452) : WebKit::SandboxExtension::~SandboxExtension() 1 0x123f4ba19 WTFCrash 2 0x1128e5e3b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x11354de98 WebKit::SandboxExtension::~SandboxExtension() 4 0x11354df25 WebKit::SandboxExtension::~SandboxExtension() 5 0x112930eab std::__1::default_delete<WebKit::SandboxExtension>::operator()(WebKit::SandboxExtension*) const 6 0x112930e6c WTF::RefCounted<WebKit::SandboxExtension, std::__1::default_delete<WebKit::SandboxExtension> >::deref() const 7 0x112930e21 WTF::DefaultRefDerefTraits<WebKit::SandboxExtension>::derefIfNotNull(WebKit::SandboxExtension*) 8 0x112930de9 WTF::RefPtr<WebKit::SandboxExtension, WTF::RawPtrTraits<WebKit::SandboxExtension>, WTF::DefaultRefDerefTraits<WebKit::SandboxExtension> >::~RefPtr() 9 0x112930b15 WTF::RefPtr<WebKit::SandboxExtension, WTF::RawPtrTraits<WebKit::SandboxExtension>, WTF::DefaultRefDerefTraits<WebKit::SandboxExtension> >::~RefPtr() 10 0x1134c096c WebKit::RemoteMediaPlayerProxy::~RemoteMediaPlayerProxy() 11 0x1134c0d55 WebKit::RemoteMediaPlayerProxy::~RemoteMediaPlayerProxy() 12 0x1134da40b std::__1::default_delete<WebKit::RemoteMediaPlayerProxy>::operator()(WebKit::RemoteMediaPlayerProxy*) const 13 0x1134da38f std::__1::unique_ptr<WebKit::RemoteMediaPlayerProxy, std::__1::default_delete<WebKit::RemoteMediaPlayerProxy> >::reset(WebKit::RemoteMediaPlayerProxy*) 14 0x1134da329 std::__1::unique_ptr<WebKit::RemoteMediaPlayerProxy, std::__1::default_delete<WebKit::RemoteMediaPlayerProxy> >::~unique_ptr() 15 0x1134bef75 std::__1::unique_ptr<WebKit::RemoteMediaPlayerProxy, std::__1::default_delete<WebKit::RemoteMediaPlayerProxy> >::~unique_ptr() 16 0x1134d044e WTF::KeyValuePair<WTF::ObjectIdentifier<WebCore::MediaPlayerIdentifierType>, std::__1::unique_ptr<WebKit::RemoteMediaPlayerProxy, std::__1::default_delete<WebKit::RemoteMediaPlayerProxy> > >::~KeyValuePair() 17 0x1134d03b5 WTF::KeyValuePair<WTF::ObjectIdentifier<WebCore::MediaPlayerIdentifierType>, std::__1::unique_ptr<WebKit::RemoteMediaPlayerProxy, std::__1::default_delete<WebKit::RemoteMediaPlayerProxy> > >::~KeyValuePair() 18 0x1134d02d1 WTF::HashTable<WTF::ObjectIdentifier<WebCore::MediaPlayerIdentifierType>, WTF::KeyValuePair<WTF::ObjectIdentifier<WebCore::MediaPlayerIdentifierType>, std::__1::unique_ptr<WebKit::RemoteMediaPlayerProxy, std::__1::default_delete<WebKit::RemoteMediaPlayerProxy> > >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::ObjectIdentifier<WebCore::MediaPlayerIdentifierType>, std::__1::unique_ptr<WebKit::RemoteMediaPlayerProxy, std::__1::default_delete<WebKit::RemoteMediaPlayerProxy> > > >, WTF::DefaultHash<WTF::ObjectIdentifier<WebCore::MediaPlayerIdentifierType> >, WTF::HashMap<WTF::ObjectIdentifier<WebCore::MediaPlayerIdentifierType>, std::__1::unique_ptr<WebKit::RemoteMediaPlayerProxy, std::__1::default_delete<WebKit::RemoteMediaPlayerProxy> >, WTF::DefaultHash<WTF::ObjectIdentifier<WebCore::MediaPlayerIdentifierType> >, WTF::HashTraits<WTF::ObjectIdentifier<WebCore::MediaPlayerIdentifierType> >, WTF::HashTraits<std::__1::unique_ptr<WebKit::RemoteMediaPlayerProxy, std::__1::default_delete<WebKit::RemoteMediaPlayerProxy> > >, WTF::HashTableTraits>::KeyValuePairTraits, WTF::HashTraits<WTF::ObjectIdentifier<WebCore::MediaPlayerIdentifierType> > >::deallocateTable(WTF::KeyValuePair<WTF::ObjectIdentifier<WebCore::MediaPlayerIdentifierType>, std::__1::unique_ptr<WebKit::RemoteMediaPlayerProxy, std::__1::default_delete<WebKit::RemoteMediaPlayerProxy> > >*) 19 0x1134d01a6 WTF::HashTable<WTF::ObjectIdentifier<WebCore::MediaPlayerIdentifierType>, WTF::KeyValuePair<WTF::ObjectIdentifier<WebCore::MediaPlayerIdentifierType>, std::__1::unique_ptr<WebKit::RemoteMediaPlayerProxy, std::__1::default_delete<WebKit::RemoteMediaPlayerProxy> > >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::ObjectIdentifier<WebCore::MediaPlayerIdentifierType>, std::__1::unique_ptr<WebKit::RemoteMediaPlayerProxy, std::__1::default_delete<WebKit::RemoteMediaPlayerProxy> > > >, WTF::DefaultHash<WTF::ObjectIdentifier<WebCore::MediaPlayerIdentifierType> >, WTF::HashMap<WTF::ObjectIdentifier<WebCore::MediaPlayerIdentifierType>, std::__1::unique_ptr<WebKit::RemoteMediaPlayerProxy, std::__1::default_delete<WebKit::RemoteMediaPlayerProxy> >, WTF::DefaultHash<WTF::ObjectIdentifier<WebCore::MediaPlayerIdentifierType> >, WTF::HashTraits<WTF::ObjectIdentifier<WebCore::MediaPlayerIdentifierType> >, WTF::HashTraits<std::__1::unique_ptr<WebKit::RemoteMediaPlayerProxy, std::__1::default_delete<WebKit::RemoteMediaPlayerProxy> > >, WTF::HashTableTraits>::KeyValuePairTraits, WTF::HashTraits<WTF::ObjectIdentifier<WebCore::MediaPlayerIdentifierType> > >::~HashTable() 20 0x1134d0165 WTF::HashTable<WTF::ObjectIdentifier<WebCore::MediaPlayerIdentifierType>, WTF::KeyValuePair<WTF::ObjectIdentifier<WebCore::MediaPlayerIdentifierType>, std::__1::unique_ptr<WebKit::RemoteMediaPlayerProxy, std::__1::default_delete<WebKit::RemoteMediaPlayerProxy> > >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::ObjectIdentifier<WebCore::MediaPlayerIdentifierType>, std::__1::unique_ptr<WebKit::RemoteMediaPlayerProxy, std::__1::default_delete<WebKit::RemoteMediaPlayerProxy> > > >, WTF::DefaultHash<WTF::ObjectIdentifier<WebCore::MediaPlayerIdentifierType> >, WTF::HashMap<WTF::ObjectIdentifier<WebCore::MediaPlayerIdentifierType>, std::__1::unique_ptr<WebKit::RemoteMediaPlayerProxy, std::__1::default_delete<WebKit::RemoteMediaPlayerProxy> >, WTF::DefaultHash<WTF::ObjectIdentifier<WebCore::MediaPlayerIdentifierType> >, WTF::HashTraits<WTF::ObjectIdentifier<WebCore::MediaPlayerIdentifierType> >, WTF::HashTraits<std::__1::unique_ptr<WebKit::RemoteMediaPlayerProxy, std::__1::default_delete<WebKit::RemoteMediaPlayerProxy> > >, WTF::HashTableTraits>::KeyValuePairTraits, WTF::HashTraits<WTF::ObjectIdentifier<WebCore::MediaPlayerIdentifierType> > >::~HashTable() 21 0x1134d0145 WTF::HashMap<WTF::ObjectIdentifier<WebCore::MediaPlayerIdentifierType>, std::__1::unique_ptr<WebKit::RemoteMediaPlayerProxy, std::__1::default_delete<WebKit::RemoteMediaPlayerProxy> >, WTF::DefaultHash<WTF::ObjectIdentifier<WebCore::MediaPlayerIdentifierType> >, WTF::HashTraits<WTF::ObjectIdentifier<WebCore::MediaPlayerIdentifierType> >, WTF::HashTraits<std::__1::unique_ptr<WebKit::RemoteMediaPlayerProxy, std::__1::default_delete<WebKit::RemoteMediaPlayerProxy> > >, WTF::HashTableTraits>::~HashMap() 22 0x1134beb85 WTF::HashMap<WTF::ObjectIdentifier<WebCore::MediaPlayerIdentifierType>, std::__1::unique_ptr<WebKit::RemoteMediaPlayerProxy, std::__1::default_delete<WebKit::RemoteMediaPlayerProxy> >, WTF::DefaultHash<WTF::ObjectIdentifier<WebCore::MediaPlayerIdentifierType> >, WTF::HashTraits<WTF::ObjectIdentifier<WebCore::MediaPlayerIdentifierType> >, WTF::HashTraits<std::__1::unique_ptr<WebKit::RemoteMediaPlayerProxy, std::__1::default_delete<WebKit::RemoteMediaPlayerProxy> > >, WTF::HashTableTraits>::~HashMap() 23 0x1134beb59 WebKit::RemoteMediaPlayerManagerProxy::~RemoteMediaPlayerManagerProxy() 24 0x1134beba5 WebKit::RemoteMediaPlayerManagerProxy::~RemoteMediaPlayerManagerProxy() 25 0x1134bebcc WebKit::RemoteMediaPlayerManagerProxy::~RemoteMediaPlayerManagerProxy() 26 0x1133eb1bf std::__1::default_delete<WebKit::RemoteMediaPlayerManagerProxy>::operator()(WebKit::RemoteMediaPlayerManagerProxy*) const 27 0x1133eb13f std::__1::unique_ptr<WebKit::RemoteMediaPlayerManagerProxy, std::__1::default_delete<WebKit::RemoteMediaPlayerManagerProxy> >::reset(WebKit::RemoteMediaPlayerManagerProxy*) 28 0x1133eb0d9 std::__1::unique_ptr<WebKit::RemoteMediaPlayerManagerProxy, std::__1::default_delete<WebKit::RemoteMediaPlayerManagerProxy> >::~unique_ptr() 29 0x1133eb0b5 std::__1::unique_ptr<WebKit::RemoteMediaPlayerManagerProxy, std::__1::default_delete<WebKit::RemoteMediaPlayerManagerProxy> >::~unique_ptr() 30 0x1133eb095 WTF::UniqueRef<WebKit::RemoteMediaPlayerManagerProxy>::~UniqueRef() 31 0x1133d5485 WTF::UniqueRef<WebKit::RemoteMediaPlayerManagerProxy>::~UniqueRef() 1778607 1 webkit-bug-importer 2021-07-21 16:54:57 -0700 <rdar://problem/80926509> 1778614 2 ayumi_kojima 2021-07-21 17:24:45 -0700 Updated test expectations https://trac.webkit.org/changeset/280169/webkit 1779565 3 434237 jer.noble 2021-07-26 14:11:51 -0700 Created attachment 434237 Patch 1779566 4 434237 darin 2021-07-26 14:17:30 -0700 Comment on attachment 434237 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434237&action=review > Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp:59 > + ProxyMap proxies; > + proxies.swap(m_proxies); This is old fashioned. New way to do it would be std::exchange instead. 1779574 5 jer.noble 2021-07-26 14:29:32 -0700 (In reply to Darin Adler from comment #4) > Comment on attachment 434237 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=434237&action=review > > > Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp:59 > > + ProxyMap proxies; > > + proxies.swap(m_proxies); > > This is old fashioned. New way to do it would be std::exchange instead. Fantastic, then it turns into an `auto` declaration, and I don't need the change to the header. Thanks! 1779578 6 434243 jer.noble 2021-07-26 14:37:15 -0700 Created attachment 434243 Patch 1779635 7 ews-feeder 2021-07-26 17:02:37 -0700 Committed r280326 (239973@main): <https://commits.webkit.org/239973@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434243. 434237 2021-07-26 14:11:51 -0700 2021-07-26 14:37:14 -0700 Patch bug-228171-20210726141150.patch text/plain 3244 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5OTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDllYzVkMDRiYTk1OTg0MDAw YzEwZGQxOTFhOWRjY2NiZmUyYzhlZjQuLjU2ZjcwZjM3MjAzNjhkNGY4NDZlOWQyOTIyZmVhNDI5 OTlmNmQ4Y2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjEtMDctMjYgIEplciBOb2Js ZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTjogW2lPU10gQVNT RVJUSU9OIEZBSUxFRDogIW1fdXNlQ291bnQgaW4gV2ViS2l0OjpTYW5kYm94RXh0ZW5zaW9uOjp+ U2FuZGJveEV4dGVuc2lvbigpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMjgxNzEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzgwOTI2NTA5PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNhbmRib3hFeHRl bnNpb24gZXhwZWN0cyB0byBiZSByZXZva2VkIGJlZm9yZSBpdCBpcyBkZXN0cm95ZWQsIHNvbWV0 aGluZyB0aGF0IGlzIGRvbmUgYnkKKyAgICAgICAgUmVtb3RlTWVkaWFQbGF5ZXJQcm94eTo6aW52 YWxpZGF0ZSgpLiBIb3dldmVyLCBpbnZhbGlkYXRlKCkgd29uJ3QgYmUgY2FsbGVkIGlmIHRoZSAK KyAgICAgICAgUmVtb3RlTWVkaWFQbGF5ZXJNYW5hZ2VyUHJveHkgaXMgZGVzdHJveWVkIGJlZm9y ZSBhbGwgaXRzIHByb3hpZXMgYXJlIGludmFsaWRhdGVkLgorCisgICAgICAgIEVuc3VyZSBldmVy eSBSZW1vdGVNZWRpYVBsYXllclByb3h5IGNvbnRhaW5lZCBieSB0aGUgUmVtb3RlTWVkaWFQbGF5 ZXJNYW5hZ2VyUHJveHkgaXMKKyAgICAgICAgaW52YWxpZGF0ZWQgaW4gUmVtb3RlTWVkaWFQbGF5 ZXJNYW5hZ2VyUHJveHkncyBkZXN0cnVjdG9yLgorCisgICAgICAgICogR1BVUHJvY2Vzcy9tZWRp YS9SZW1vdGVNZWRpYVBsYXllck1hbmFnZXJQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OlJl bW90ZU1lZGlhUGxheWVyTWFuYWdlclByb3h5Ojp+UmVtb3RlTWVkaWFQbGF5ZXJNYW5hZ2VyUHJv eHkpOgorICAgICAgICAqIEdQVVByb2Nlc3MvbWVkaWEvUmVtb3RlTWVkaWFQbGF5ZXJNYW5hZ2Vy UHJveHkuaDoKKwogMjAyMS0wNy0yNiAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4K IAogICAgICAgICBbQ29jb2FdIFdlYktpdCBpcyBtYWtpbmcgR3JvdXBBY3Rpdml0aWVzIEFQSSBj YWxscyBmb3IgYWxsIFdlYktpdCBjbGllbnRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0dQ VVByb2Nlc3MvbWVkaWEvUmVtb3RlTWVkaWFQbGF5ZXJNYW5hZ2VyUHJveHkuY3BwIGIvU291cmNl L1dlYktpdC9HUFVQcm9jZXNzL21lZGlhL1JlbW90ZU1lZGlhUGxheWVyTWFuYWdlclByb3h5LmNw cAppbmRleCA2MDA4NDI0NzYwOTliN2IyOGVhMGMxNjRjMGRlOGRmMWQ2ZDk4MDhmLi4zMGQ1NThm MDIyMWI5MDlmYmQzYzI3YjE2OWVmZDc4YjQwNjg3MTNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L0dQVVByb2Nlc3MvbWVkaWEvUmVtb3RlTWVkaWFQbGF5ZXJNYW5hZ2VyUHJveHkuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9tZWRpYS9SZW1vdGVNZWRpYVBsYXllck1hbmFn ZXJQcm94eS5jcHAKQEAgLTU1LDYgKzU1LDExIEBAIFJlbW90ZU1lZGlhUGxheWVyTWFuYWdlclBy b3h5OjpSZW1vdGVNZWRpYVBsYXllck1hbmFnZXJQcm94eShHUFVDb25uZWN0aW9uVG9XZWJQCiAK IFJlbW90ZU1lZGlhUGxheWVyTWFuYWdlclByb3h5Ojp+UmVtb3RlTWVkaWFQbGF5ZXJNYW5hZ2Vy UHJveHkoKQogeworICAgIFByb3h5TWFwIHByb3hpZXM7CisgICAgcHJveGllcy5zd2FwKG1fcHJv eGllcyk7CisKKyAgICBmb3IgKGF1dG8mIHByb3h5IDogcHJveGllcy52YWx1ZXMoKSkKKyAgICAg ICAgcHJveHktPmludmFsaWRhdGUoKTsKIH0KIAogdm9pZCBSZW1vdGVNZWRpYVBsYXllck1hbmFn ZXJQcm94eTo6Y3JlYXRlTWVkaWFQbGF5ZXIoTWVkaWFQbGF5ZXJJZGVudGlmaWVyIGlkZW50aWZp ZXIsIE1lZGlhUGxheWVyRW51bXM6Ok1lZGlhRW5naW5lSWRlbnRpZmllciBlbmdpbmVJZGVudGlm aWVyLCBSZW1vdGVNZWRpYVBsYXllclByb3h5Q29uZmlndXJhdGlvbiYmIHByb3h5Q29uZmlndXJh dGlvbikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9tZWRpYS9SZW1vdGVN ZWRpYVBsYXllck1hbmFnZXJQcm94eS5oIGIvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL21lZGlh L1JlbW90ZU1lZGlhUGxheWVyTWFuYWdlclByb3h5LmgKaW5kZXggMzU4YmI5MTA5YzNjZjM3ZmNi M2ZkNWQzYTdhNDJjYjAxNmU2Mjk0ZS4uY2QzMGEyZDllYmZhYWZmY2Q5OTMwMzk3ZDAwN2NmZWYy NDBmNTAyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL21lZGlhL1JlbW90 ZU1lZGlhUGxheWVyTWFuYWdlclByb3h5LmgKKysrIGIvU291cmNlL1dlYktpdC9HUFVQcm9jZXNz L21lZGlhL1JlbW90ZU1lZGlhUGxheWVyTWFuYWdlclByb3h5LmgKQEAgLTgzLDcgKzgzLDggQEAg cHJpdmF0ZToKICAgICB2b2lkIGNsZWFyTWVkaWFDYWNoZUZvck9yaWdpbnMoV2ViQ29yZTo6TWVk aWFQbGF5ZXJFbnVtczo6TWVkaWFFbmdpbmVJZGVudGlmaWVyLCBjb25zdCBTdHJpbmcmJiwgSGFz aFNldDxXZWJDb3JlOjpTZWN1cml0eU9yaWdpbkRhdGE+JiYpOwogICAgIHZvaWQgc3VwcG9ydHNL ZXlTeXN0ZW0oV2ViQ29yZTo6TWVkaWFQbGF5ZXJFbnVtczo6TWVkaWFFbmdpbmVJZGVudGlmaWVy LCBjb25zdCBTdHJpbmcmJiwgY29uc3QgU3RyaW5nJiYsIENvbXBsZXRpb25IYW5kbGVyPHZvaWQo Ym9vbCk+JiYpOwogCi0gICAgSGFzaE1hcDxXZWJDb3JlOjpNZWRpYVBsYXllcklkZW50aWZpZXIs IHN0ZDo6dW5pcXVlX3B0cjxSZW1vdGVNZWRpYVBsYXllclByb3h5Pj4gbV9wcm94aWVzOworICAg IHVzaW5nIFByb3h5TWFwID0gSGFzaE1hcDxXZWJDb3JlOjpNZWRpYVBsYXllcklkZW50aWZpZXIs IHN0ZDo6dW5pcXVlX3B0cjxSZW1vdGVNZWRpYVBsYXllclByb3h5Pj47CisgICAgUHJveHlNYXAg bV9wcm94aWVzOwogICAgIFdlYWtQdHI8R1BVQ29ubmVjdGlvblRvV2ViUHJvY2Vzcz4gbV9ncHVD b25uZWN0aW9uVG9XZWJQcm9jZXNzOwogCiAjaWYgIVJFTEVBU0VfTE9HX0RJU0FCTEVECg== 434243 2021-07-26 14:37:15 -0700 2021-07-26 17:02:38 -0700 Patch bug-228171-20210726143715.patch text/plain 2227 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5OTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDllYzVkMDRiYTk1OTg0MDAw YzEwZGQxOTFhOWRjY2NiZmUyYzhlZjQuLjU2ZjcwZjM3MjAzNjhkNGY4NDZlOWQyOTIyZmVhNDI5 OTlmNmQ4Y2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjEtMDctMjYgIEplciBOb2Js ZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTjogW2lPU10gQVNT RVJUSU9OIEZBSUxFRDogIW1fdXNlQ291bnQgaW4gV2ViS2l0OjpTYW5kYm94RXh0ZW5zaW9uOjp+ U2FuZGJveEV4dGVuc2lvbigpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMjgxNzEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzgwOTI2NTA5PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNhbmRib3hFeHRl bnNpb24gZXhwZWN0cyB0byBiZSByZXZva2VkIGJlZm9yZSBpdCBpcyBkZXN0cm95ZWQsIHNvbWV0 aGluZyB0aGF0IGlzIGRvbmUgYnkKKyAgICAgICAgUmVtb3RlTWVkaWFQbGF5ZXJQcm94eTo6aW52 YWxpZGF0ZSgpLiBIb3dldmVyLCBpbnZhbGlkYXRlKCkgd29uJ3QgYmUgY2FsbGVkIGlmIHRoZSAK KyAgICAgICAgUmVtb3RlTWVkaWFQbGF5ZXJNYW5hZ2VyUHJveHkgaXMgZGVzdHJveWVkIGJlZm9y ZSBhbGwgaXRzIHByb3hpZXMgYXJlIGludmFsaWRhdGVkLgorCisgICAgICAgIEVuc3VyZSBldmVy eSBSZW1vdGVNZWRpYVBsYXllclByb3h5IGNvbnRhaW5lZCBieSB0aGUgUmVtb3RlTWVkaWFQbGF5 ZXJNYW5hZ2VyUHJveHkgaXMKKyAgICAgICAgaW52YWxpZGF0ZWQgaW4gUmVtb3RlTWVkaWFQbGF5 ZXJNYW5hZ2VyUHJveHkncyBkZXN0cnVjdG9yLgorCisgICAgICAgICogR1BVUHJvY2Vzcy9tZWRp YS9SZW1vdGVNZWRpYVBsYXllck1hbmFnZXJQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OlJl bW90ZU1lZGlhUGxheWVyTWFuYWdlclByb3h5Ojp+UmVtb3RlTWVkaWFQbGF5ZXJNYW5hZ2VyUHJv eHkpOgorICAgICAgICAqIEdQVVByb2Nlc3MvbWVkaWEvUmVtb3RlTWVkaWFQbGF5ZXJNYW5hZ2Vy UHJveHkuaDoKKwogMjAyMS0wNy0yNiAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4K IAogICAgICAgICBbQ29jb2FdIFdlYktpdCBpcyBtYWtpbmcgR3JvdXBBY3Rpdml0aWVzIEFQSSBj YWxscyBmb3IgYWxsIFdlYktpdCBjbGllbnRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0dQ VVByb2Nlc3MvbWVkaWEvUmVtb3RlTWVkaWFQbGF5ZXJNYW5hZ2VyUHJveHkuY3BwIGIvU291cmNl L1dlYktpdC9HUFVQcm9jZXNzL21lZGlhL1JlbW90ZU1lZGlhUGxheWVyTWFuYWdlclByb3h5LmNw cAppbmRleCA2MDA4NDI0NzYwOTliN2IyOGVhMGMxNjRjMGRlOGRmMWQ2ZDk4MDhmLi4wYTAwZTQ4 YmIyMTk2YzJhMjZiZDIyOWYzMjljOWVkYjhlOGIyMjY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L0dQVVByb2Nlc3MvbWVkaWEvUmVtb3RlTWVkaWFQbGF5ZXJNYW5hZ2VyUHJveHkuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9tZWRpYS9SZW1vdGVNZWRpYVBsYXllck1hbmFn ZXJQcm94eS5jcHAKQEAgLTU1LDYgKzU1LDEwIEBAIFJlbW90ZU1lZGlhUGxheWVyTWFuYWdlclBy b3h5OjpSZW1vdGVNZWRpYVBsYXllck1hbmFnZXJQcm94eShHUFVDb25uZWN0aW9uVG9XZWJQCiAK IFJlbW90ZU1lZGlhUGxheWVyTWFuYWdlclByb3h5Ojp+UmVtb3RlTWVkaWFQbGF5ZXJNYW5hZ2Vy UHJveHkoKQogeworICAgIGF1dG8gcHJveGllcyA9IHN0ZDo6ZXhjaGFuZ2UobV9wcm94aWVzLCB7 IH0pOworCisgICAgZm9yIChhdXRvJiBwcm94eSA6IHByb3hpZXMudmFsdWVzKCkpCisgICAgICAg IHByb3h5LT5pbnZhbGlkYXRlKCk7CiB9CiAKIHZvaWQgUmVtb3RlTWVkaWFQbGF5ZXJNYW5hZ2Vy UHJveHk6OmNyZWF0ZU1lZGlhUGxheWVyKE1lZGlhUGxheWVySWRlbnRpZmllciBpZGVudGlmaWVy LCBNZWRpYVBsYXllckVudW1zOjpNZWRpYUVuZ2luZUlkZW50aWZpZXIgZW5naW5lSWRlbnRpZmll ciwgUmVtb3RlTWVkaWFQbGF5ZXJQcm94eUNvbmZpZ3VyYXRpb24mJiBwcm94eUNvbmZpZ3VyYXRp b24pCg==