228160 2021-07-21 12:43:59 -0700 REGRESSION(r279987): [GTK][WPE] It caused 2 new test failures 2021-08-06 19:25:59 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=208204 https://bugs.webkit.org/show_bug.cgi?id=214455 P2 Normal --- 1 clopez alicem alicem bugs-noreply changseok esprehn+autocc ews-watchlist glenn kondapallykalyan mcatanzaro pdr oldest_to_newest 1778505 0 clopez 2021-07-21 12:43:59 -0700 Commit r279987 caused 7 new unexpected failures on GTK and WPE ports: Regressions: Unexpected image-only failures (7) fast/selectors/input-with-selection-pseudo-element.html [ ImageOnlyFailure ] imported/blink/fast/table/whitespace-between-elements-with-table-cell-display-3.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-color-adjust/rendering/dark-color-scheme/color-scheme-change-checkbox.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-color-adjust/rendering/dark-color-scheme/color-scheme-iframe-background-mismatch-alpha.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-color-adjust/rendering/dark-color-scheme/color-scheme-iframe-background-mismatch-opaque.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-color-adjust/rendering/dark-color-scheme/color-scheme-visited-link-initial.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/propagate-text-decoration.html [ ImageOnlyFailure ] Looking at the diffs seems that there is some difference on the rounding of the corners of some boxes in some cases and also differences on the color of the text or background in other cases Check here the results: - https://people.igalia.com/clopez/wkbug/208204/layout-test-results/results.html 1778522 1 alicem 2021-07-21 13:15:41 -0700 `imported/w3c/web-platform-tests/css/css-color-adjust/rendering/dark-color-scheme/*` ones - I see we have a Pass override for glib and otherwise it's expected to fail. Which is... interesting, but I suppose we should match Safari here. The rounding ones - I need to check again if there's a way to only do the rounding with non-`none` appearance. Makes sense, that seems like an actual regression. 1778524 2 clopez 2021-07-21 13:18:50 -0700 An update: The 5 WPT tests for css-color-adjust (imported WPT tests) tests fail also on the Mac port, and they started to fail on GTK/WPE after enabling this CSS property, so it seems there is a pre-exist bug somewhere on the common code for this (not related with r279987 ) The other 2 failures seem new failures that are not reported on the Mac port: - fast/selectors/input-with-selection-pseudo-element.html [ ImageOnlyFailure ] - imported/blink/fast/table/whitespace-between-elements-with-table-cell-display-3.html [ ImageOnlyFailure ] Which are the ones related with some difference on the rounding of the corners of the boxes, 1778525 3 clopez 2021-07-21 13:19:35 -0700 (In reply to Carlos Alberto Lopez Perez from comment #2) > An update: > > The 5 WPT tests for css-color-adjust (imported WPT tests) tests fail also on > the Mac port, and they started to fail on GTK/WPE after enabling this CSS > property, so it seems there is a pre-exist bug somewhere on the common code > for this (not related with r279987 ) > See bug 214455 1778526 4 clopez 2021-07-21 13:21:15 -0700 imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/propagate-text-decoration.html is also reported on the Mac port (no bug assigned), so I assume this was also a pre-existent failure not related with r279987 1778535 5 clopez 2021-07-21 13:35:38 -0700 Updated test expectations on r280159 1778546 6 alicem 2021-07-21 13:49:08 -0700 Mm, I think fixing the rounding would still make sense. Thanks for updating the tests! 1778683 7 alicem 2021-07-22 03:38:38 -0700 Found the reason for the rounding. https://bugs.webkit.org/show_bug.cgi?id=173572 calls adjustTextFieldStyle() even if the element is styled: ``` + case TextFieldPart: + adjustTextFieldStyle(styleResolver, style, element); + FALLTHROUGH; ``` I wonder if that's still relevant or if it was only relevant before for RenderThemeGtk? Because then we could remove that for an easy fix. 1782591 8 435095 alicem 2021-08-06 15:17:57 -0700 Created attachment 435095 Patch 1782594 9 435095 alicem 2021-08-06 15:45:20 -0700 Comment on attachment 435095 Patch Let's see if setting cq+ myself works. 1782600 10 ews-feeder 2021-08-06 16:15:01 -0700 Committed r280742 (240328@main): <https://commits.webkit.org/240328@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435095. 435095 2021-08-06 15:17:57 -0700 2021-08-06 19:25:59 -0700 Patch bug-228160-20210807031836.patch text/plain 1769 alicem U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGY1ZGFhNzRiMzQ3OWEx NGJmODEzZDdkN2I5ODg5Y2Y5YTk4MDZhYi4uNjhmZDA0NTIwMDlhN2M0ZDAyYTEzODk1ZjJiZjQ1 ZGY4YWRkYzU5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTA4LTA2ICBBbGV4 YW5kZXIgTWlraGF5bGVua28gIDxhbGV4bUBnbm9tZS5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lP TihyMjc5OTg3KTogW0dUS11bV1BFXSBJdCBjYXVzZWQgMiBuZXcgdGVzdCBmYWlsdXJlcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI4MTYwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm9ybWFsbHkgYWRq dXN0VGV4dCooKSBhcmUgb25seSBjYWxsZWQgZm9yIHVuc3R5bGVkIGVsZW1lbnRzIHRvIGFkanVz dCB0aGVpciBwbGF0Zm9ybQorICAgICAgICBhcHBlYXJhbmNlLCBIb3dldmVyLCBmb3IgZW50cmll cyB3ZSBhbHdheXMgY2FsbCBpdCBzaW5jZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTczNTcyIGFuZCBpdCBjYXVzZXMgcHJvYmxlbXMuCisKKyAgICAg ICAgVGhhdCBjaGFuZ2Ugd2FzIGRvbmUgZm9yIFJlbmRlclRoZW1lR3RrIGFuZCBpcyBub3QgcmVs ZXZhbnQgYW55bW9yZSwgc28gd2UgY2FuIHJldmVydAorICAgICAgICBpdC4KKworICAgICAgICAq IHJlbmRlcmluZy9SZW5kZXJUaGVtZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVt ZTo6YWRqdXN0U3R5bGUpOgorCiAyMDIxLTA3LTMxICBNYWNpZWogU3RhY2hvd2lhayAgPG1qc0Bh cHBsZS5jb20+CiAKICAgICAgICAgTGlzdEF0dHJpYnV0ZVRhcmdldE9ic2VydmVyIGlzIG5lZWRs ZXNzbHkgY3JlYXRlZCBldmVuIHdoZW4gdGhlcmUgaXMgbm8gbGlzdCBhdHRyaWJ1dGUKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZS5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWUuY3BwCmluZGV4IGFlNDI2ODZkYzQ2M2I3YjEx MjVmOTBkNDdhODQwNGIwYTU1MWJlNzIuLmFhOWJiNzdhYTZlZTYyYmQ4YTg1OWUyOTA3Njk0MGJh MDI4Y2ZlOGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVt ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lLmNwcApAQCAt OTMsOSArOTMsNiBAQCB2b2lkIFJlbmRlclRoZW1lOjphZGp1c3RTdHlsZShSZW5kZXJTdHlsZSYg c3R5bGUsIGNvbnN0IEVsZW1lbnQqIGVsZW1lbnQsIGNvbnN0CiAgICAgICAgICAgICBzdHlsZS5z ZXRBcHBlYXJhbmNlKE1lbnVsaXN0QnV0dG9uUGFydCk7CiAgICAgICAgICAgICBwYXJ0ID0gTWVu dWxpc3RCdXR0b25QYXJ0OwogICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgIGNhc2UgVGV4dEZp ZWxkUGFydDoKLSAgICAgICAgICAgIGFkanVzdFRleHRGaWVsZFN0eWxlKHN0eWxlLCBlbGVtZW50 KTsKLSAgICAgICAgICAgIEZBTExUSFJPVUdIOwogICAgICAgICBkZWZhdWx0OgogICAgICAgICAg ICAgc3R5bGUuc2V0QXBwZWFyYW5jZShOb0NvbnRyb2xQYXJ0KTsKICAgICAgICAgICAgIGJyZWFr Owo=