228155 2021-07-21 12:26:41 -0700 macOS key-driven smooth scrolling does not work for spacebar 2021-07-30 18:07:06 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 228009 1 dana.estra webkit-unassigned akeerthi bdakin simon.fraser thorton webkit-bug-importer oldest_to_newest 1778491 0 dana.estra 2021-07-21 12:26:41 -0700 spacebar and spacebar+shift do not case any movement 1778498 1 webkit-bug-importer 2021-07-21 12:37:40 -0700 <rdar://problem/80911775> 1779515 2 434224 dana.estra 2021-07-26 12:24:39 -0700 Created attachment 434224 Patch 1779520 3 434226 dana.estra 2021-07-26 12:40:29 -0700 Created attachment 434226 Patch 1779529 4 434226 thorton 2021-07-26 13:05:18 -0700 Comment on attachment 434226 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434226&action=review > Source/WebCore/platform/KeyboardScrollingAnimator.cpp:237 > - if (event.type() != eventNames().keydownEvent) > + if (!(event.type() == eventNames().keydownEvent || event.type() == eventNames().keypressEvent)) Hmm, I'm not sure this is right. Are you not getting `keydown` for the spacebar? If not, you probably want to figure out who is eating it. 1780151 5 434226 thorton 2021-07-28 12:17:44 -0700 Comment on attachment 434226 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434226&action=review >> Source/WebCore/platform/KeyboardScrollingAnimator.cpp:237 >> + if (!(event.type() == eventNames().keydownEvent || event.type() == eventNames().keypressEvent)) > > Hmm, I'm not sure this is right. Are you not getting `keydown` for the spacebar? If not, you probably want to figure out who is eating it. I guess it's OK (a bit weird, but existing weirdness); EventHandler::defaultSpaceEventHandler itself asserts it's only called with keypress, and the other callers of this call it explicitly only for keydown, so we won't get duplicates. 1780173 6 thorton 2021-07-28 13:09:39 -0700 Can't cq+ this till the other patch lands :) 1780180 7 434453 dana.estra 2021-07-28 13:21:48 -0700 Created attachment 434453 Patch 1780974 8 ews-feeder 2021-07-30 16:04:14 -0700 Committed r280501 (240133@main): <https://commits.webkit.org/240133@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434453. 434224 2021-07-26 12:24:39 -0700 2021-07-26 12:40:26 -0700 Patch bug-228155-20210726152438.patch text/plain 1541 dana.estra U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5OTU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmE2ZjE2OTAwOGE2ZTdh NzM3ODA1Y2ZmNjY1MDc5Y2I4ZTVjYjZiNS4uZDQ1M2NjZGM4ZjY0ZTcxOTMzZDhlZGFlZGZlOTc1 YzJjM2U4ZjlkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA3LTI2ICBEYW5h IEVzdHJhICA8ZGVzdHJhQGFwcGxlLmNvbT4KKworICAgICAgICBTcGFjZWJhciBmdW5jdGlvbmFs aXR5IGZvciBtYWNPUyBzbW9vdGggc2Nyb2xsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjgxNTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIEZpeGVkIGJ1ZyB0aGF0IHdhcyBjYXVzaW5n IHNwYWNlYmFyIGtleWJvYXJkIGV2ZW50cyB0byByZXR1cm4gZmFsc2UgZnJvbSBiZWdpbktleWJv YXJkU2Nyb2xsR2VzdHVyZS4KKworICAgICAgICBObyB0ZXN0cyB5ZXQuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9LZXlib2FyZFNjcm9sbGluZ0FuaW1hdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OktleWJvYXJkU2Nyb2xsaW5nQW5pbWF0b3I6OmJlZ2luS2V5Ym9hcmRTY3JvbGxHZXN0dXJlKToK KwogMjAyMS0wNy0yMyAgRGFuYSBFc3RyYSAgPGRlc3RyYUBhcHBsZS5jb20+CiAKICAgICAgICAg QWRkIGtleS1kcml2ZW4gc21vb3RoIHNjcm9sbGluZyB0byBtYWNPUwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vS2V5Ym9hcmRTY3JvbGxpbmdBbmltYXRvci5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9LZXlib2FyZFNjcm9sbGluZ0FuaW1hdG9yLmNwcAppbmRleCBl YWRjZjIwNTY2M2Q3NjBmYWY4NTcxYzAwNGQ1OTdjZDQxOTIwMmFkLi5jMzBhZTk0NDliNjJjN2Ri NmEyOTliMTUxZWQ4NjhkYWVmYzM0OWNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9LZXlib2FyZFNjcm9sbGluZ0FuaW1hdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9LZXlib2FyZFNjcm9sbGluZ0FuaW1hdG9yLmNwcApAQCAtMjM0LDcgKzIzNCw3IEBA IGJvb2wgS2V5Ym9hcmRTY3JvbGxpbmdBbmltYXRvcjo6YmVnaW5LZXlib2FyZFNjcm9sbEdlc3R1 cmUoS2V5Ym9hcmRFdmVudCYgZXZlbnQpCiAKICAgICBtX2N1cnJlbnRLZXlib2FyZFNjcm9sbCA9 IHNjcm9sbDsKIAotICAgIGlmIChldmVudC50eXBlKCkgIT0gZXZlbnROYW1lcygpLmtleWRvd25F dmVudCkKKyAgICBpZiAoIShldmVudC50eXBlKCkgPT0gZXZlbnROYW1lcygpLmtleWRvd25FdmVu dCB8fCBldmVudC50eXBlKCkgPT0gZXZlbnROYW1lcygpLmtleXByZXNzRXZlbnQpKQogICAgICAg ICByZXR1cm4gZmFsc2U7CiAKICAgICBpZiAobV9zY3JvbGxUcmlnZ2VyaW5nS2V5SXNQcmVzc2Vk KQo= 434226 2021-07-26 12:40:29 -0700 2021-07-28 13:21:44 -0700 Patch bug-228155-20210726154028.patch text/plain 1550 dana.estra U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5OTU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmE2ZjE2OTAwOGE2ZTdh NzM3ODA1Y2ZmNjY1MDc5Y2I4ZTVjYjZiNS4uZjRjZTQ1MTQzODk5NWFmMGJmYjAwYjQzMGU3YTJk MWU0MDJlZDVlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA3LTI2ICBEYW5h IEVzdHJhICA8ZGVzdHJhQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgc3BhY2ViYXIgZnVuY3Rp b25hbGl0eSBmb3IgbWFjT1Mgc21vb3RoIHNjcm9sbGluZworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI4MTU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBGaXhlZCBidWcgdGhhdCB3YXMgY2F1 c2luZyBzcGFjZWJhciBldmVudHMgdG8gcmV0dXJuIGZhbHNlIGZyb20gYmVnaW5LZXlib2FyZFNj cm9sbEdlc3R1cmUuCisKKyAgICAgICAgTWFudWFsbHkgdGVzdGVkIG9uIHdlYnBhZ2UuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9LZXlib2FyZFNjcm9sbGluZ0FuaW1hdG9yLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OktleWJvYXJkU2Nyb2xsaW5nQW5pbWF0b3I6OmJlZ2luS2V5Ym9hcmRTY3JvbGxH ZXN0dXJlKToKKwogMjAyMS0wNy0yMyAgRGFuYSBFc3RyYSAgPGRlc3RyYUBhcHBsZS5jb20+CiAK ICAgICAgICAgQWRkIGtleS1kcml2ZW4gc21vb3RoIHNjcm9sbGluZyB0byBtYWNPUwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vS2V5Ym9hcmRTY3JvbGxpbmdBbmltYXRvci5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9LZXlib2FyZFNjcm9sbGluZ0FuaW1hdG9yLmNw cAppbmRleCBlYWRjZjIwNTY2M2Q3NjBmYWY4NTcxYzAwNGQ1OTdjZDQxOTIwMmFkLi5jMzBhZTk0 NDliNjJjN2RiNmEyOTliMTUxZWQ4NjhkYWVmYzM0OWNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9LZXlib2FyZFNjcm9sbGluZ0FuaW1hdG9yLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9LZXlib2FyZFNjcm9sbGluZ0FuaW1hdG9yLmNwcApAQCAtMjM0LDcg KzIzNCw3IEBAIGJvb2wgS2V5Ym9hcmRTY3JvbGxpbmdBbmltYXRvcjo6YmVnaW5LZXlib2FyZFNj cm9sbEdlc3R1cmUoS2V5Ym9hcmRFdmVudCYgZXZlbnQpCiAKICAgICBtX2N1cnJlbnRLZXlib2Fy ZFNjcm9sbCA9IHNjcm9sbDsKIAotICAgIGlmIChldmVudC50eXBlKCkgIT0gZXZlbnROYW1lcygp LmtleWRvd25FdmVudCkKKyAgICBpZiAoIShldmVudC50eXBlKCkgPT0gZXZlbnROYW1lcygpLmtl eWRvd25FdmVudCB8fCBldmVudC50eXBlKCkgPT0gZXZlbnROYW1lcygpLmtleXByZXNzRXZlbnQp KQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBpZiAobV9zY3JvbGxUcmlnZ2VyaW5nS2V5 SXNQcmVzc2VkKQo= 434453 2021-07-28 13:21:48 -0700 2021-07-30 18:07:06 -0700 Patch bug-228155-20210728162147.patch text/plain 1546 dana.estra U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5OTU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmE2ZjE2OTAwOGE2ZTdh NzM3ODA1Y2ZmNjY1MDc5Y2I4ZTVjYjZiNS4uMGViNmIxOWM3MGQyMWQ0NmI1ZDgyOGQwMjUwNWI0 YjYyNWViZTNmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA3LTI2ICBEYW5h IEVzdHJhICA8ZGVzdHJhQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgc3BhY2ViYXIgZnVuY3Rp b25hbGl0eSBmb3IgbWFjT1Mgc21vb3RoIHNjcm9sbGluZworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI4MTU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg VGltIEhvcnRvbi4KKyAgICAgICAgCisgICAgICAgIEZpeGVkIGJ1ZyB0aGF0IHdhcyBjYXVzaW5n IHNwYWNlYmFyIGV2ZW50cyB0byByZXR1cm4gZmFsc2UgZnJvbSBiZWdpbktleWJvYXJkU2Nyb2xs R2VzdHVyZS4KKworICAgICAgICBNYW51YWxseSB0ZXN0ZWQgb24gd2VicGFnZS4KKworICAgICAg ICAqIHBsYXRmb3JtL0tleWJvYXJkU2Nyb2xsaW5nQW5pbWF0b3IuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6S2V5Ym9hcmRTY3JvbGxpbmdBbmltYXRvcjo6YmVnaW5LZXlib2FyZFNjcm9sbEdlc3R1 cmUpOgorCiAyMDIxLTA3LTIzICBEYW5hIEVzdHJhICA8ZGVzdHJhQGFwcGxlLmNvbT4KIAogICAg ICAgICBBZGQga2V5LWRyaXZlbiBzbW9vdGggc2Nyb2xsaW5nIHRvIG1hY09TCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9LZXlib2FyZFNjcm9sbGluZ0FuaW1hdG9yLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0tleWJvYXJkU2Nyb2xsaW5nQW5pbWF0b3IuY3BwCmlu ZGV4IGVhZGNmMjA1NjYzZDc2MGZhZjg1NzFjMDA0ZDU5N2NkNDE5MjAyYWQuLmMzMGFlOTQ0OWI2 MmM3ZGI2YTI5OWIxNTFlZDg2OGRhZWZjMzQ5Y2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL0tleWJvYXJkU2Nyb2xsaW5nQW5pbWF0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL0tleWJvYXJkU2Nyb2xsaW5nQW5pbWF0b3IuY3BwCkBAIC0yMzQsNyArMjM0 LDcgQEAgYm9vbCBLZXlib2FyZFNjcm9sbGluZ0FuaW1hdG9yOjpiZWdpbktleWJvYXJkU2Nyb2xs R2VzdHVyZShLZXlib2FyZEV2ZW50JiBldmVudCkKIAogICAgIG1fY3VycmVudEtleWJvYXJkU2Ny b2xsID0gc2Nyb2xsOwogCi0gICAgaWYgKGV2ZW50LnR5cGUoKSAhPSBldmVudE5hbWVzKCkua2V5 ZG93bkV2ZW50KQorICAgIGlmICghKGV2ZW50LnR5cGUoKSA9PSBldmVudE5hbWVzKCkua2V5ZG93 bkV2ZW50IHx8IGV2ZW50LnR5cGUoKSA9PSBldmVudE5hbWVzKCkua2V5cHJlc3NFdmVudCkpCiAg ICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIGlmIChtX3Njcm9sbFRyaWdnZXJpbmdLZXlJc1By ZXNzZWQpCg==