228139 2021-07-21 00:27:01 -0700 [WebAudio] Add webm/vorbis container support 2022-02-08 14:41:09 -0800 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=227110 https://bugs.webkit.org/show_bug.cgi?id=236328 InRadar P2 Normal --- 227111 1 jean-yves.avenard jean-yves.avenard cdumez jer.noble webkit-bug-importer oldest_to_newest 1778368 0 jean-yves.avenard 2021-07-21 00:27:01 -0700 WebAudio currently only works with content AudioToolBox/CoreMedia supports; and it doesn't support webm. Opus support will be done in bug 227110. Creating a separate bug as the code is there to support it but it fails for multiple reasons, the primary one being a sandbox issue preventing loading the Vorbis decoder in the content process. 1778369 1 webkit-bug-importer 2021-07-21 00:27:52 -0700 <rdar://problem/80883073> 1779673 2 jean-yves.avenard 2021-07-26 20:56:46 -0700 This patch will not compile until bug 227110 lands. 1779674 3 434266 jean-yves.avenard 2021-07-26 20:57:29 -0700 Created attachment 434266 Patch 1781488 4 ews-feeder 2021-08-02 17:49:44 -0700 Committed r280573 (240195@main): <https://commits.webkit.org/240195@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434266. 434266 2021-07-26 20:57:29 -0700 2021-08-02 17:49:44 -0700 Patch bug-228139-20210727135727.patch text/plain 5501 jean-yves.avenard U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwMzMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDk3ZmEzY2I4ZGZhZTcxMWU5 MjkxOTgwMzUwNTU2NmQ4ZDNmZDllYTEuLjQwM2Y2YTNkNmZiZDNiZTA1NmIzMjE3MzM3YWY5YmQ2 OTk2Yjk5NDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjEtMDctMjYgIEplYW4tWXZl cyBBdmVuYXJkICA8anlhQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViQXVkaW9dIEFkZCB3ZWJt L3ZvcmJpcyBjb250YWluZXIgc3VwcG9ydAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjI4MTM5CisgICAgICAgIHJkYXI6Ly84MDg4MzA3MworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFjY2VzcyB0byB0aGUg Y29tLmFwcGxlLmF1ZGlvLkF1ZGlvQ29tcG9uZW50UmVnaXN0cmFyIGlzIGRlbmllZCBieSB0aGUg c2FuZGJveCB3aGljaAorICAgICAgICBwcmV2ZW50cyByZWdpc3RlcmluZyB0aGUgVm9yYmlzIEF1 ZGlvIENvbXBvbmVudC4gU28gd2UgaW5zdGFudGlhdGUgdGhlIGRlY29kZXIgcmlnaHQgYmVmb3Jl CisgICAgICAgIHNldHRpbmcgdXAgdGhlIHNhbmRib3guCisgICAgICAgIFRoaXMgaXMgYSB3b3Jr YXJvdW5kIGZvciByZGFyOi8vODExMzc5NTMuCisgICAgICAgIFRlc3Q6IHdlYmF1ZGlvL2RlY29k ZS1hdWRpby1kYXRhLXdlYm0tdm9yYmlzLmh0bWwKKworICAgICAgICAqIFdlYlByb2Nlc3MvY29j b2EvV2ViUHJvY2Vzc0NvY29hLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzOjppbml0 aWFsaXplU2FuZGJveCk6CisKIDIwMjEtMDctMjEgIEplYW4tWXZlcyBBdmVuYXJkICA8anlhQGFw cGxlLmNvbT4KIAogICAgICAgICBbV2ViQXVkaW9dIEFkZCB3ZWJtL29wdXMgY29udGFpbmVyIHN1 cHBvcnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9j ZXNzQ29jb2EubW0gYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0Nv Y29hLm1tCmluZGV4IDg0NTY1MjM2NDhmN2VmMDc2MTU5OTk3MTI2MTJhZGRmZDk3NzRhMDEuLmU0 ZDg4NDIyNDZlMGVjODE4NjA5MGI0NDY4YjE1YzBiZGY3NmM5MGUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW0KKysrIGIvU291cmNl L1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbQpAQCAtODEsNiArODEs NyBAQAogI2ltcG9ydCA8V2ViQ29yZS9TeXN0ZW1Tb3VuZE1hbmFnZXIuaD4KICNpbXBvcnQgPFdl YkNvcmUvVVRJVXRpbGl0aWVzLmg+CiAjaW1wb3J0IDxXZWJDb3JlL1ZlcnNpb25DaGVja3MuaD4K KyNpbXBvcnQgPFdlYkNvcmUvV2ViTUF1ZGlvVXRpbGl0aWVzQ29jb2EuaD4KICNpbXBvcnQgPGFs Z29yaXRobT4KICNpbXBvcnQgPGRpc3BhdGNoL2Rpc3BhdGNoLmg+CiAjaW1wb3J0IDxtYWNoL21h Y2guaD4KQEAgLTc0NCw2ICs3NDUsOSBAQCB2b2lkIFdlYlByb2Nlc3M6OmluaXRpYWxpemVTYW5k Ym94KGNvbnN0IEF1eGlsaWFyeVByb2Nlc3NJbml0aWFsaXphdGlvblBhcmFtZXRlcgogICAgIC8v IE5lZWQgdG8gb3ZlcnJpZGUgdGhlIGRlZmF1bHQsIGJlY2F1c2Ugc2VydmljZSBoYXMgYSBkaWZm ZXJlbnQgYnVuZGxlIElELgogICAgIGF1dG8gd2ViS2l0QnVuZGxlID0gW05TQnVuZGxlIGJ1bmRs ZVdpdGhJZGVudGlmaWVyOkAiY29tLmFwcGxlLldlYktpdCJdOwogCisgICAgLy8gV2UgbmVlZCB0 byBpbml0aWFsaXplIHRoZSBWb3JiaXMgZGVjb2RlciBiZWZvcmUgdGhlIHNhbmRib3ggZ2V0cyBz ZXR1cDsgdGhpcyBpcyBhIG9uZSBvZmYgYWN0aW9uLgorICAgIFdlYkNvcmU6OnJlZ2lzdGVyVm9y YmlzRGVjb2RlcklmTmVlZGVkKCk7CisKICAgICBzYW5kYm94UGFyYW1ldGVycy5zZXRPdmVycmlk ZVNhbmRib3hQcm9maWxlUGF0aChtYWtlU3RyaW5nKFN0cmluZyhbd2ViS2l0QnVuZGxlIHJlc291 cmNlUGF0aF0pLCAiL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiIikpOwogCiAgICAgYm9vbCBlbmFi bGVNZXNzYWdlRmlsdGVyID0gZmFsc2U7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNjIwOGU4Nzk4NWRhMWU1ZTIzNmY5Nzdh MzdlODYxNzk1N2Y2ODQ0MS4uYTFhM2M2MjA0MzliOTA3MTFjNzI0OGRlOWJiOTI2MzVmMzdlZWQx MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0No YW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIxLTA3LTI2ICBKZWFuLVl2ZXMgQXZlbmFyZCAg PGp5YUBhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYkF1ZGlvXSBBZGQgd2VibS92b3JiaXMgY29u dGFpbmVyIHN1cHBvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIyODEzOQorICAgICAgICByZGFyOi8vODA4ODMwNzMKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9UZXN0RXhwZWN0 YXRpb25zOgorICAgICAgICAqIHdlYmF1ZGlvL2RlY29kZS1hdWRpby1kYXRhLXdlYm0tdm9yYmlz LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogd2ViYXVkaW8vZGVjb2RlLWF1ZGlvLWRh dGEtd2VibS12b3JiaXMuaHRtbDogQWRkZWQuCisKIDIwMjEtMDctMjEgIEplYW4tWXZlcyBBdmVu YXJkICA8anlhQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViQXVkaW9dIEFkZCB3ZWJtL29wdXMg Y29udGFpbmVyIHN1cHBvcnQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9U ZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlv bnMKaW5kZXggZjIyMjE4ZmQ2YmJhOTRmMzI0YmNhZWIzOWVlYjQ4OWQ2OTY4ZjE2My4uNDFhNGVh NjhmMGRiM2E0ZTY2MDQ4ZWVmMjA5Mjg5Njg1ZDAyZGU2ZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTE3NjgsNiArMTc2OCw3IEBAIHdlYmtpdC5vcmcv Yi8yMTQxNTUgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL2Nyb3NzLW9yaWdp bi1lbWJlZGRlci1wCiBbIENhdGFsaW5hIE1vamF2ZSBCaWdTdXIgXSBtZWRpYS9tZWRpYS1zb3Vy Y2UvbWVkaWEtd2VibS1vcHVzLXBhcnRpYWwuaHRtbCBbIFNraXAgXQogWyBDYXRhbGluYSBNb2ph dmUgQmlnU3VyIF0gbWVkaWEvbWVkaWEtc291cmNlL21lZGlhLXdlYm0tb3B1cy1wYXJ0aWFsLWFi b3J0Lmh0bWwgWyBTa2lwIF0KIFsgQ2F0YWxpbmEgTW9qYXZlIEJpZ1N1ciBdIHdlYmF1ZGlvL2Rl Y29kZS1hdWRpby1kYXRhLXdlYm0tb3B1cy5odG1sIFsgU2tpcCBdCitbIENhdGFsaW5hIE1vamF2 ZSBCaWdTdXIgXSB3ZWJhdWRpby9kZWNvZGUtYXVkaW8tZGF0YS13ZWJtLXZvcmJpcy5odG1sIFsg U2tpcCBdCiAKIHdlYmtpdC5vcmcvYi8yMTQ0MjIgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10 ZXN0cy93ZWJhdWRpby90aGUtYXVkaW8tYXBpL3RoZS1hdWRpb2NvbnRleHQtaW50ZXJmYWNlL3N1 c3BlbmQtYWZ0ZXItY29uc3RydWN0Lmh0bWwgWyBQYXNzIEZhaWx1cmUgXQogCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy93ZWJhdWRpby9kZWNvZGUtYXVkaW8tZGF0YS13ZWJtLXZvcmJpcy1leHBl Y3RlZC50eHQgYi9MYXlvdXRUZXN0cy93ZWJhdWRpby9kZWNvZGUtYXVkaW8tZGF0YS13ZWJtLXZv cmJpcy1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uOTg1NmZlMmVhNGU3N2VkZjEyYzcxNmViZmY5 OWYyMDM4OWI4NWM1YwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3dlYmF1ZGlvL2Rl Y29kZS1hdWRpby1kYXRhLXdlYm0tdm9yYmlzLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDEwIEBA CitUZXN0IHRoYXQgZGVjb2RpbmcgYW4gdm9yYmlzIHdlYm0gZmlsZSBzdWNjZWVkcworCitPbiBz dWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dl ZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBTdWNjZXNzZnVsbHkgZGVjb2RlZCBjb250 ZW50CitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvd2ViYXVkaW8vZGVjb2RlLWF1ZGlvLWRhdGEtd2VibS12 b3JiaXMuaHRtbCBiL0xheW91dFRlc3RzL3dlYmF1ZGlvL2RlY29kZS1hdWRpby1kYXRhLXdlYm0t dm9yYmlzLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNjVmYjBmYWM2OGY1MjBiYzAzNTZjYjlmZGY1ZjcyMmE1 OTcwMDAwMQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3dlYmF1ZGlvL2RlY29kZS1h dWRpby1kYXRhLXdlYm0tdm9yYmlzLmh0bWwKQEAgLTAsMCArMSwzMSBAQAorPCFET0NUWVBFIGh0 bWw+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uL3Jlc291cmNlcy9qcy10ZXN0Lmpz Ij48L3NjcmlwdD4KKzxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0IiBzcmM9InJlc291cmNl cy9hdWRpby10ZXN0aW5nLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHNjcmlwdD4K K2Rlc2NyaXB0aW9uKCJUZXN0IHRoYXQgZGVjb2RpbmcgYW4gdm9yYmlzIHdlYm0gZmlsZSBzdWNj ZWVkcyIpOworCit3aW5kb3cuanNUZXN0SXNBc3luYyA9IHRydWU7CisKK3ZhciBjb250ZXh0ID0g bmV3IHdpbmRvdy5BdWRpb0NvbnRleHQoKTsKK3ZhciByZXF1ZXN0ID0gbmV3IFhNTEh0dHBSZXF1 ZXN0KCk7CityZXF1ZXN0Lm9wZW4oIkdFVCIsICdyZXNvdXJjZXMvbWVkaWEvdm9yYmlzLndlYm0n LCB0cnVlKTsKK3JlcXVlc3QucmVzcG9uc2VUeXBlID0gImFycmF5YnVmZmVyIjsKKworcmVxdWVz dC5vbmxvYWQgPSBmdW5jdGlvbigpIHsKKyAgICBjb250ZXh0LmRlY29kZUF1ZGlvRGF0YShyZXF1 ZXN0LnJlc3BvbnNlLCAoYnVmZmVyKSA9PiB7CisgICAgICAgIHRlc3RQYXNzZWQoIlN1Y2Nlc3Nm dWxseSBkZWNvZGVkIGNvbnRlbnQiKTsKKyAgICAgICAgZmluaXNoSlNUZXN0KCk7CisgICAgICB9 LCAoKSA9PiB7CisgICAgICAgIHRlc3RGYWlsZWQoIkZhaWxlZCB0byBkZWNvZGUgZmlsZSIpOwor ICAgICAgICBmaW5pc2hKU1Rlc3QoKTsKKyAgICAgIH0pOworfQorcmVxdWVzdC5zZW5kKCk7CisK Kzwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=