228106 2021-07-20 05:47:36 -0700 [GStreamer] Switch raw GstStructure pointers to GUniquePtr 2021-07-20 08:30:17 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pnormand pnormand calvaris cgarcia eric.carlson ews-watchlist glenn gustavo jer.noble menard philipj sergio vjaquez webkit-bug-importer oldest_to_newest 1778159 0 pnormand 2021-07-20 05:47:36 -0700 SSIA 1778164 1 433872 pnormand 2021-07-20 06:33:15 -0700 Created attachment 433872 Patch 1778171 2 433872 calvaris 2021-07-20 07:34:32 -0700 Comment on attachment 433872 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433872&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2399 > + m_mediaLocationCurrentIndex = static_cast<int>(gst_value_list_get_size(locations)) -1; Now that we're changing this line, let's fix that - 1 . 1778178 3 pnormand 2021-07-20 08:29:49 -0700 Committed r280080 (239806@main): <https://commits.webkit.org/239806@main> 1778179 4 webkit-bug-importer 2021-07-20 08:30:17 -0700 <rdar://problem/80840075> 433872 2021-07-20 06:33:15 -0700 2021-07-20 07:34:32 -0700 Patch bug-228106-20210720063313.patch text/plain 5718 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwMDc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2M0NmEzMDQ2ZjFiN2Yz ZDQxYzM3ODdiMWYxNzA5ZDM0MmY3YjZjMi4uMzcyNGI0MDE5OGVjMzc4ZjNmN2ZkNDZmYzkwMTc3 Nzk4N2NhYjUxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA3LTIwICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSBTd2l0Y2ggcmF3IEdzdFN0cnVjdHVyZSBwb2ludGVycyB0byBHVW5pcXVlUHRyCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjgxMDYKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwOgorICAgICAgICAo V2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjp+TWVkaWFQbGF5ZXJQcml2YXRl R1N0cmVhbWVyKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l cjo6c2V0QXVkaW9TdHJlYW1Qcm9wZXJ0aWVzKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxh eWVyUHJpdmF0ZUdTdHJlYW1lcjo6bWVkaWFMb2NhdGlvbkNoYW5nZWQpOgorICAgICAgICAoV2Vi Q29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjpsb2FkTmV4dExvY2F0aW9uKToKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0 cmVhbWVyLmg6CisKIDIwMjEtMDctMjAgIFppcmFuIFN1biAgPHpzdW5AaWdhbGlhLmNvbT4KIAog ICAgICAgICBJbWFnZXMgYXMgZ3JpZCBpdGVtcyBzaG91bGQgdXNlIHRoZSBvdmVycmlkaW5nTG9n aWNhbFdpZHRoIHdoZW4gZGVmaW5lZCB0byBjb21wdXRlIHRoZSBsb2dpY2FsIEhlaWdodApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAppbmRleCBhZjM1 NDNkZjNkYjFhOWNmNmVkMzgzMDJiMDBkNjk4ODM5ZDY5MzA3Li45NGNiNjgyZTczNDlmMDlmODY2 NjEyY2MxMDVkYzA5ZjgyODI0OGQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyLmNwcApAQCAtMjAwLDExICsyMDAsNiBAQCBNZWRpYVBsYXllclByaXZh dGVHU3RyZWFtZXI6On5NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIoKQogICAgIGlmIChtX2Zp bGxUaW1lci5pc0FjdGl2ZSgpKQogICAgICAgICBtX2ZpbGxUaW1lci5zdG9wKCk7CiAKLSAgICBp ZiAobV9tZWRpYUxvY2F0aW9ucykgewotICAgICAgICBnc3Rfc3RydWN0dXJlX2ZyZWUobV9tZWRp YUxvY2F0aW9ucyk7Ci0gICAgICAgIG1fbWVkaWFMb2NhdGlvbnMgPSBudWxscHRyOwotICAgIH0K LQogICAgIGlmIChXRUJLSVRfSVNfV0VCX1NSQyhtX3NvdXJjZS5nZXQoKSkgJiYgR1NUX09CSkVD VF9QQVJFTlQobV9zb3VyY2UuZ2V0KCkpKQogICAgICAgICBnX3NpZ25hbF9oYW5kbGVyc19kaXNj b25uZWN0X2J5X2Z1bmMoR1NUX0VMRU1FTlRfUEFSRU5UKG1fc291cmNlLmdldCgpKSwgcmVpbnRl cnByZXRfY2FzdDxncG9pbnRlcj4odXJpRGVjb2RlQmluRWxlbWVudEFkZGVkQ2FsbGJhY2spLCB0 aGlzKTsKIApAQCAtOTA5LDkgKzkwNCw4IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVh bWVyOjpzZXRBdWRpb1N0cmVhbVByb3BlcnRpZXMoR09iamVjdCogb2JqZWN0KQogICAgICAgICBy ZXR1cm47CiAKICAgICBjb25zdCBjaGFyKiByb2xlID0gbV9wbGF5ZXItPmlzVmlkZW9QbGF5ZXIo KSA/ICJ2aWRlbyIgOiAibXVzaWMiOwotICAgIEdzdFN0cnVjdHVyZSogc3RydWN0dXJlID0gZ3N0 X3N0cnVjdHVyZV9uZXcoInN0cmVhbS1wcm9wZXJ0aWVzIiwgIm1lZGlhLnJvbGUiLCBHX1RZUEVf U1RSSU5HLCByb2xlLCBudWxscHRyKTsKLSAgICBnX29iamVjdF9zZXQob2JqZWN0LCAic3RyZWFt LXByb3BlcnRpZXMiLCBzdHJ1Y3R1cmUsIG51bGxwdHIpOwotICAgIGdzdF9zdHJ1Y3R1cmVfZnJl ZShzdHJ1Y3R1cmUpOworICAgIEdVbmlxdWVQdHI8R3N0U3RydWN0dXJlPiBwcm9wZXJ0aWVzKGdz dF9zdHJ1Y3R1cmVfbmV3KCJzdHJlYW0tcHJvcGVydGllcyIsICJtZWRpYS5yb2xlIiwgR19UWVBF X1NUUklORywgcm9sZSwgbnVsbHB0cikpOworICAgIGdfb2JqZWN0X3NldChvYmplY3QsICJzdHJl YW0tcHJvcGVydGllcyIsIHByb3BlcnRpZXMuZ2V0KCksIG51bGxwdHIpOwogICAgIEdVbmlxdWVQ dHI8Z2NoYXI+IGVsZW1lbnROYW1lKGdzdF9lbGVtZW50X2dldF9uYW1lKEdTVF9FTEVNRU5UKG9i amVjdCkpKTsKICAgICBHU1RfREVCVUdfT0JKRUNUKHBpcGVsaW5lKCksICJTZXQgbWVkaWEucm9s ZSBhcyAlcyBhdCAlcyIsIHJvbGUsIGVsZW1lbnROYW1lLmdldCgpKTsKIH0KQEAgLTIzOTEsMjIg KzIzODUsMjAgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6OnVwZGF0ZVN0YXRl cygpCiAKIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjptZWRpYUxvY2F0aW9uQ2hh bmdlZChHc3RNZXNzYWdlKiBtZXNzYWdlKQogewotICAgIGlmIChtX21lZGlhTG9jYXRpb25zKQot ICAgICAgICBnc3Rfc3RydWN0dXJlX2ZyZWUobV9tZWRpYUxvY2F0aW9ucyk7Ci0KICAgICBjb25z dCBHc3RTdHJ1Y3R1cmUqIHN0cnVjdHVyZSA9IGdzdF9tZXNzYWdlX2dldF9zdHJ1Y3R1cmUobWVz c2FnZSk7Ci0gICAgaWYgKHN0cnVjdHVyZSkgewotICAgICAgICAvLyBUaGlzIHN0cnVjdHVyZSBj YW4gY29udGFpbjoKLSAgICAgICAgLy8gLSBib3RoIGEgbmV3LWxvY2F0aW9uIHN0cmluZyBhbmQg ZW1iZWRkZWQgbG9jYXRpb25zIHN0cnVjdHVyZQotICAgICAgICAvLyAtIG9yIG9ubHkgYSBuZXct bG9jYXRpb24gc3RyaW5nLgotICAgICAgICBtX21lZGlhTG9jYXRpb25zID0gZ3N0X3N0cnVjdHVy ZV9jb3B5KHN0cnVjdHVyZSk7Ci0gICAgICAgIGNvbnN0IEdWYWx1ZSogbG9jYXRpb25zID0gZ3N0 X3N0cnVjdHVyZV9nZXRfdmFsdWUobV9tZWRpYUxvY2F0aW9ucywgImxvY2F0aW9ucyIpOworICAg IGlmICghc3RydWN0dXJlKQorICAgICAgICByZXR1cm47CiAKLSAgICAgICAgaWYgKGxvY2F0aW9u cykKLSAgICAgICAgICAgIG1fbWVkaWFMb2NhdGlvbkN1cnJlbnRJbmRleCA9IHN0YXRpY19jYXN0 PGludD4oZ3N0X3ZhbHVlX2xpc3RfZ2V0X3NpemUobG9jYXRpb25zKSkgLTE7CisgICAgLy8gVGhp cyBzdHJ1Y3R1cmUgY2FuIGNvbnRhaW46CisgICAgLy8gLSBib3RoIGEgbmV3LWxvY2F0aW9uIHN0 cmluZyBhbmQgZW1iZWRkZWQgbG9jYXRpb25zIHN0cnVjdHVyZQorICAgIC8vIC0gb3Igb25seSBh IG5ldy1sb2NhdGlvbiBzdHJpbmcuCisgICAgbV9tZWRpYUxvY2F0aW9ucy5yZXNldChnc3Rfc3Ry dWN0dXJlX2NvcHkoc3RydWN0dXJlKSk7CisgICAgY29uc3QgR1ZhbHVlKiBsb2NhdGlvbnMgPSBn c3Rfc3RydWN0dXJlX2dldF92YWx1ZShtX21lZGlhTG9jYXRpb25zLmdldCgpLCAibG9jYXRpb25z Iik7CiAKLSAgICAgICAgbG9hZE5leHRMb2NhdGlvbigpOwotICAgIH0KKyAgICBpZiAobG9jYXRp b25zKQorICAgICAgICBtX21lZGlhTG9jYXRpb25DdXJyZW50SW5kZXggPSBzdGF0aWNfY2FzdDxp bnQ+KGdzdF92YWx1ZV9saXN0X2dldF9zaXplKGxvY2F0aW9ucykpIC0xOworCisgICAgbG9hZE5l eHRMb2NhdGlvbigpOwogfQogCiBib29sIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6bG9h ZE5leHRMb2NhdGlvbigpCkBAIC0yNDE0LDE5ICsyNDA2LDE5IEBAIGJvb2wgTWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyOjpsb2FkTmV4dExvY2F0aW9uKCkKICAgICBpZiAoIW1fbWVkaWFMb2Nh dGlvbnMpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAotICAgIGNvbnN0IEdWYWx1ZSogbG9jYXRp b25zID0gZ3N0X3N0cnVjdHVyZV9nZXRfdmFsdWUobV9tZWRpYUxvY2F0aW9ucywgImxvY2F0aW9u cyIpOworICAgIGNvbnN0IEdWYWx1ZSogbG9jYXRpb25zID0gZ3N0X3N0cnVjdHVyZV9nZXRfdmFs dWUobV9tZWRpYUxvY2F0aW9ucy5nZXQoKSwgImxvY2F0aW9ucyIpOwogICAgIGNvbnN0IGNoYXIq IG5ld0xvY2F0aW9uID0gbnVsbHB0cjsKIAogICAgIGlmICghbG9jYXRpb25zKSB7CiAgICAgICAg IC8vIEZhbGxiYWNrIG9uIG5ldy1sb2NhdGlvbiBzdHJpbmcuCi0gICAgICAgIG5ld0xvY2F0aW9u ID0gZ3N0X3N0cnVjdHVyZV9nZXRfc3RyaW5nKG1fbWVkaWFMb2NhdGlvbnMsICJuZXctbG9jYXRp b24iKTsKKyAgICAgICAgbmV3TG9jYXRpb24gPSBnc3Rfc3RydWN0dXJlX2dldF9zdHJpbmcobV9t ZWRpYUxvY2F0aW9ucy5nZXQoKSwgIm5ldy1sb2NhdGlvbiIpOwogICAgICAgICBpZiAoIW5ld0xv Y2F0aW9uKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KIAogICAgIGlmICghbmV3 TG9jYXRpb24pIHsKICAgICAgICAgaWYgKG1fbWVkaWFMb2NhdGlvbkN1cnJlbnRJbmRleCA8IDAp IHsKLSAgICAgICAgICAgIG1fbWVkaWFMb2NhdGlvbnMgPSBudWxscHRyOworICAgICAgICAgICAg bV9tZWRpYUxvY2F0aW9ucy5yZXNldCgpOwogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAg ICAgICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dz dHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuaApp bmRleCBhYjEyYmFlZWNiMzA4MDZhODkwZGQxZDJkZTBlOWVjMjk2NzJhYzRlLi5hOTJmZTVmNzc2 MWJiZjVjODFhNTYxODUyYTJkN2Q2YjQ0NDczYjQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVy LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lci5oCkBAIC00ODUsNyArNDg1LDcgQEAgcHJpdmF0ZToKIAog ICAgIEF0b21pYzxib29sPiBtX2lzUGxheWVyU2h1dHRpbmdEb3duOwogICAgIEdSZWZQdHI8R3N0 RWxlbWVudD4gbV90ZXh0U2luazsKLSAgICBHc3RTdHJ1Y3R1cmUqIG1fbWVkaWFMb2NhdGlvbnMg eyBudWxscHRyIH07CisgICAgR1VuaXF1ZVB0cjxHc3RTdHJ1Y3R1cmU+IG1fbWVkaWFMb2NhdGlv bnM7CiAgICAgaW50IG1fbWVkaWFMb2NhdGlvbkN1cnJlbnRJbmRleCB7IDAgfTsKICAgICBib29s IG1faXNQbGF5YmFja1JhdGVQYXVzZWQgeyBmYWxzZSB9OwogICAgIE1lZGlhVGltZSBtX3RpbWVP Zk92ZXJsYXBwaW5nU2VlazsK