228099 2021-07-19 23:41:26 -0700 Use references instead of pointers in WidthIterator::advanceInternal() 2021-07-20 13:41:16 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mmaxfield mmaxfield fujii webkit-bug-importer oldest_to_newest 1778102 0 mmaxfield 2021-07-19 23:41:26 -0700 Use references instead of pointers in WidthIterator::advanceInternal() 1778103 1 433852 mmaxfield 2021-07-19 23:42:22 -0700 Created attachment 433852 Patch 1778254 2 433852 fujii 2021-07-20 13:23:30 -0700 Comment on attachment 433852 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433852&action=review > Source/WebCore/platform/graphics/WidthIterator.cpp:237 > + ASSERT(&font); This ASSERT doesn't looks useful. I think you should remove this ASSERT. 1778265 3 mmaxfield 2021-07-20 13:39:59 -0700 Thanks for the review!!! 1778267 4 mmaxfield 2021-07-20 13:40:25 -0700 Committed r280102 (239819@main): <https://commits.webkit.org/239819@main> 1778268 5 webkit-bug-importer 2021-07-20 13:41:16 -0700 <rdar://problem/80855739> 433852 2021-07-19 23:42:22 -0700 2021-07-20 13:23:30 -0700 Patch bug-228099-20210719234222.patch text/plain 3579 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwMDY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzIwN2NhNmNmZDcxMTc0 ZWJhNzFkNTg1MTk5MzRmMDcxOGFiMDZmMC4uZGE0YmE4NTZjMmFkYzQ3NzdmNmRlYmMyNTlhNzFm MzA0NWRiYmE4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA3LTE5ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIHJlZmVy ZW5jZXMgaW5zdGVhZCBvZiBwb2ludGVycyBpbiBXaWR0aEl0ZXJhdG9yOjphZHZhbmNlSW50ZXJu YWwoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI4 MDk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ug YXNzZXJ0IHRoYXQgZm9udCBpcyBub24tbnVsbCwgc28gd2Ugc2hvdWxkIGJlIGFibGUgdG8gdXNl IGEgcmVmZXJlbmNlIGZvciBpdCBpbnN0ZWFkIG9mIGEgcG9pbnRlci4KKworICAgICAgICBObyBu ZXcgdGVzdHMgYmVjYXVzZSB0aGVyZSBpcyBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9XaWR0aEl0ZXJhdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OldpZHRoSXRlcmF0b3I6OmFkdmFuY2VJbnRlcm5hbCk6CisKIDIwMjEtMDctMTkgIFNpaHVpIExp dSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CiAKICAgICAgICAgSW1wbGVtZW50IElEQlRyYW5zYWN0 aW9uLmNvbW1pdCgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9XaWR0aEl0ZXJhdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1dp ZHRoSXRlcmF0b3IuY3BwCmluZGV4IDIyMGIwZWIxMjlmMmMwZjM4OGFjMzhmYzFkODA0NGRiMTY3 NzNhODQuLjg3ZTc4NTM0NzcwMzhjOWU1ODIzOTk2OTA4OGIzY2IyMWQ3ZDViYjggMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1dpZHRoSXRlcmF0b3IuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1dpZHRoSXRlcmF0b3IuY3BwCkBA IC0yMzMsMTYgKzIzMywxNiBAQCBpbmxpbmUgdm9pZCBXaWR0aEl0ZXJhdG9yOjphZHZhbmNlSW50 ZXJuYWwoVGV4dEl0ZXJhdG9yJiB0ZXh0SXRlcmF0b3IsIEdseXBoQnVmZgogICAgICAgICAgICAg Y3VycmVudENoYXJhY3RlckluZGV4ID0gdGV4dEl0ZXJhdG9yLmN1cnJlbnRJbmRleCgpOwogICAg ICAgICAgICAgY29udGludWU7CiAgICAgICAgIH0KLSAgICAgICAgY29uc3QgRm9udCogZm9udCA9 IGdseXBoRGF0YS5mb250ID8gZ2x5cGhEYXRhLmZvbnQgOiAmbV9mb250LnByaW1hcnlGb250KCk7 Ci0gICAgICAgIEFTU0VSVChmb250KTsKKyAgICAgICAgY29uc3QgRm9udCYgZm9udCA9IGdseXBo RGF0YS5mb250ID8gKmdseXBoRGF0YS5mb250IDogcHJpbWFyeUZvbnQ7CisgICAgICAgIEFTU0VS VCgmZm9udCk7CiAKICAgICAgICAgcHJldmlvdXNXaWR0aCA9IHdpZHRoOwotICAgICAgICB3aWR0 aCA9IGZvbnQtPndpZHRoRm9yR2x5cGgoZ2x5cGgpOworICAgICAgICB3aWR0aCA9IGZvbnQud2lk dGhGb3JHbHlwaChnbHlwaCk7CiAKLSAgICAgICAgaWYgKGZvbnQgIT0gbGFzdEZvbnREYXRhKSB7 CisgICAgICAgIGlmICgmZm9udCAhPSBsYXN0Rm9udERhdGEpIHsKICAgICAgICAgICAgIGNvbW1p dEN1cnJlbnRGb250UmFuZ2UoZ2x5cGhCdWZmZXIsIGxhc3RHbHlwaENvdW50LCBjdXJyZW50Q2hh cmFjdGVySW5kZXgsICpsYXN0Rm9udERhdGEsIHByaW1hcnlGb250LCBjaGFyYWN0ZXIsIHdpZHRo T2ZDdXJyZW50Rm9udFJhbmdlLCBjaGFyYWN0ZXJzVHJlYXRlZEFzU3BhY2UpOwogICAgICAgICAg ICAgbGFzdEdseXBoQ291bnQgPSBnbHlwaEJ1ZmZlci5zaXplKCk7Ci0gICAgICAgICAgICBsYXN0 Rm9udERhdGEgPSBmb250OworICAgICAgICAgICAgbGFzdEZvbnREYXRhID0gJmZvbnQ7CiAgICAg ICAgICAgICB3aWR0aE9mQ3VycmVudEZvbnRSYW5nZSA9IHdpZHRoOwogICAgICAgICB9IGVsc2UK ICAgICAgICAgICAgIHdpZHRoT2ZDdXJyZW50Rm9udFJhbmdlICs9IHdpZHRoOwpAQCAtMjU3LDcg KzI1Nyw3IEBAIGlubGluZSB2b2lkIFdpZHRoSXRlcmF0b3I6OmFkdmFuY2VJbnRlcm5hbChUZXh0 SXRlcmF0b3ImIHRleHRJdGVyYXRvciwgR2x5cGhCdWZmCiAgICAgICAgIH0KIAogICAgICAgICBp ZiAobV9hY2NvdW50Rm9yR2x5cGhCb3VuZHMpIHsKLSAgICAgICAgICAgIGJvdW5kcyA9IGZvbnQt PmJvdW5kc0ZvckdseXBoKGdseXBoKTsKKyAgICAgICAgICAgIGJvdW5kcyA9IGZvbnQuYm91bmRz Rm9yR2x5cGgoZ2x5cGgpOwogICAgICAgICAgICAgaWYgKCFjdXJyZW50Q2hhcmFjdGVySW5kZXgp CiAgICAgICAgICAgICAgICAgbV9maXJzdEdseXBoT3ZlcmZsb3cgPSBzdGQ6Om1heDxmbG9hdD4o MCwgLWJvdW5kcy54KCkpOwogICAgICAgICB9CkBAIC0yNjUsMTQgKzI2NSwxNCBAQCBpbmxpbmUg dm9pZCBXaWR0aEl0ZXJhdG9yOjphZHZhbmNlSW50ZXJuYWwoVGV4dEl0ZXJhdG9yJiB0ZXh0SXRl cmF0b3IsIEdseXBoQnVmZgogICAgICAgICBpZiAobV9mb3JUZXh0RW1waGFzaXMgJiYgIUZvbnRD YXNjYWRlOjpjYW5SZWNlaXZlVGV4dEVtcGhhc2lzKGNoYXJhY3RlcikpCiAgICAgICAgICAgICBn bHlwaCA9IDA7CiAKLSAgICAgICAgZ2x5cGhCdWZmZXIuYWRkKGdseXBoLCAqZm9udCwgd2lkdGgs IGN1cnJlbnRDaGFyYWN0ZXJJbmRleCk7CisgICAgICAgIGdseXBoQnVmZmVyLmFkZChnbHlwaCwg Zm9udCwgd2lkdGgsIGN1cnJlbnRDaGFyYWN0ZXJJbmRleCk7CiAjaWYgVVNFKENURk9OVFNIQVBF R0xZUEhTKQogICAgICAgICAvLyBUaGVzZSAwIGdseXBocyBhcmUgbmVlZGVkIGJ5IHNoYXBlcnMg aWYgdGhlIHNvdXJjZSB0ZXh0IGhhcyBzdXJyb2dhdGUgcGFpcnMuCiAgICAgICAgIC8vIEhvd2V2 ZXIsIENURm9udFRyYW5zZm9ybUdseXBocygpIGNhbid0IGRlbGV0ZSB0aGVzZSAwIGdseXBocyBm cm9tIHRoZSBzaGFwZWQgdGV4dCwKICAgICAgICAgLy8gc28gd2Ugc2hvdWxkbid0IGFkZCB0aGVt IGluIHRoZSBmaXJzdCBwbGFjZSBpZiB3ZSdyZSB1c2luZyB0aGF0IHNoYXBpbmcgcm91dGluZS4K ICAgICAgICAgLy8gQW55IG90aGVyIHNoYXBpbmcgcm91dGluZSBzaG91bGQgZGVsZXRlIHRoZXNl IGdseXBocyBmcm9tIHRoZSBzaGFwZWQgdGV4dC4KICAgICAgICAgaWYgKCFVX0lTX0JNUChjaGFy YWN0ZXIpKQotICAgICAgICAgICAgZ2x5cGhCdWZmZXIuYWRkKDAsICpmb250LCAwLCBjdXJyZW50 Q2hhcmFjdGVySW5kZXggKyAxKTsKKyAgICAgICAgICAgIGdseXBoQnVmZmVyLmFkZCgwLCBmb250 LCAwLCBjdXJyZW50Q2hhcmFjdGVySW5kZXggKyAxKTsKICNlbmRpZgogCiAgICAgICAgIC8vIEFk dmFuY2UgcGFzdCB0aGUgY2hhcmFjdGVyIHdlIGp1c3QgZGVhbHQgd2l0aC4K