228086 2021-07-19 13:34:58 -0700 [iOS] Tapping images on twitter.com should not toggle tab bar visibility 2021-07-19 17:00:25 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin ggaren megan_gardner thorton webkit-bug-importer oldest_to_newest 1777976 0 wenson_hsieh 2021-07-19 13:34:58 -0700 rdar://79667219 1778008 1 433824 wenson_hsieh 2021-07-19 14:52:49 -0700 Created attachment 433824 Patch 1778012 2 433824 ggaren 2021-07-19 15:07:34 -0700 Comment on attachment 433824 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433824&action=review > Source/WebKit/ChangeLog:9 > + Treat taps over elements that are explicitly marked draggable and also respond to click events as "meaningful" Is the "and also respond to click events" detail in this patch, or in pre-existing code? 1778013 3 433824 wenson_hsieh 2021-07-19 15:09:16 -0700 Comment on attachment 433824 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433824&action=review >> Source/WebKit/ChangeLog:9 >> + Treat taps over elements that are explicitly marked draggable and also respond to click events as "meaningful" > > Is the "and also respond to click events" detail in this patch, or in pre-existing code? Ah, so this is in pre-existing code (more specifically, the `clickNode` that's passed in is a `nodeRespondingToClickEvents`). 1778014 4 433824 ggaren 2021-07-19 15:09:56 -0700 Comment on attachment 433824 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433824&action=review r=me >> Source/WebKit/ChangeLog:9 >> + Treat taps over elements that are explicitly marked draggable and also respond to click events as "meaningful" > > Is the "and also respond to click events" detail in this patch, or in pre-existing code? I see: The caller ensures nodeRespondingToClickEvents(). 1778045 5 433824 wenson_hsieh 2021-07-19 16:43:15 -0700 Comment on attachment 433824 Patch Thanks for the review! 1778048 6 ews-feeder 2021-07-19 17:00:23 -0700 Committed r280057 (239792@main): <https://commits.webkit.org/239792@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433824. 433824 2021-07-19 14:52:49 -0700 2021-07-19 17:00:24 -0700 Patch bug-228086-20210719145248.patch text/plain 5232 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwMDIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDlkNTg1MWEzMzgwNGY0MDA1 MmNmMGFiYTM2YWM0N2ViMzAwMzhjOGMuLjdhYTRiNzdmODUxMjQ2NGFmYTA0MWJjNWRkNDVkMWRi ZTg1NWU4NDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjEtMDctMTkgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gVGFwcGluZyBp bWFnZXMgb24gdHdpdHRlci5jb20gc2hvdWxkIG5vdCB0b2dnbGUgdGFiIGJhciB2aXNpYmlsaXR5 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjgwODYK KyAgICAgICAgcmRhcjovLzc5NjY3MjE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVHJlYXQgdGFwcyBvdmVyIGVsZW1lbnRzIHRoYXQgYXJlIGV4cGxp Y2l0bHkgbWFya2VkIGRyYWdnYWJsZSBhbmQgYWxzbyByZXNwb25kIHRvIGNsaWNrIGV2ZW50cyBh cyAibWVhbmluZ2Z1bCIKKyAgICAgICAgd2l0aCByZXNwZWN0IHRvIHRoZSBwcml2YXRlIFVJRGVs ZWdhdGUgbWV0aG9kIGAtX3dlYlZpZXc6ZGlkVGFwQXRQb2ludDp3aXRoUmVzdWx0OmAuIEluIGRv aW5nIHRoaXMsIHdlIHVzZSB0aGUKKyAgICAgICAgY29tYmluYXRpb24gb2YgcmVzcG9uZGluZyB0 byBkcmFncyBhbmQgY2xpY2tzIGFzIGEgcHJveHkgZm9yIGNvbnRlbnQgdGhhdCBwcm9iYWJseSBy ZXN1bHRzIGluIHNvbWUgbWVhbmluZ2Z1bAorICAgICAgICBpbnRlcmFjdGlvbiB3aGVuIHRhcHBl ZC4KKworICAgICAgICBUZXN0OiBmYXN0L2V2ZW50cy9pb3MvbWVhbmluZ2Z1bC1jbGljay13aGVu LXRhcHBpbmctZHJhZ2dhYmxlLWNvbnRlbnQuaHRtbAorCisgICAgICAgICogV2ViUHJvY2Vzcy9X ZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tOgorICAgICAgICAoV2ViS2l0Ojppc1Byb2JhYmx5TWVh bmluZ2Z1bENsaWNrKToKKwogMjAyMS0wNy0xOSAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVo QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZlcnQgYSBkZWJ1ZyBhc3NlcnRpb24gdGhhdCB3YXMg YWRkZWQgaW4gcjI4MDAxOQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dl YlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0gYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFn ZS9pb3MvV2ViUGFnZUlPUy5tbQppbmRleCAyZjRkODFjMWYxZmI4ZmYwNTA4YTQyODJhMjZlMDhm MDFlNzE0Mzc5Li44ZTFmOGQ0YWFmMzEwZWYwY2E3YjAyMTUxM2RlNDNkNWVhZjdkNjY2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5t bQorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5t bQpAQCAtODQ2LDYgKzg0Niw5IEBAIHN0YXRpYyBib29sIGlzUHJvYmFibHlNZWFuaW5nZnVsQ2xp Y2soTm9kZSYgY2xpY2tOb2RlKQogICAgIGlmIChpczxIVE1MQm9keUVsZW1lbnQ+KGNsaWNrTm9k ZSkgfHwgaXM8RG9jdW1lbnQ+KGNsaWNrTm9kZSkgfHwgY2xpY2tOb2RlLmRvY3VtZW50KCkuZG9j dW1lbnRFbGVtZW50KCkgPT0gJmNsaWNrTm9kZSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCisg ICAgaWYgKGlzPEVsZW1lbnQ+KGNsaWNrTm9kZSkgJiYgZXF1YWxMZXR0ZXJzSWdub3JpbmdBU0NJ SUNhc2UoZG93bmNhc3Q8RWxlbWVudD4oY2xpY2tOb2RlKS5hdHRyaWJ1dGVXaXRob3V0U3luY2hy b25pemF0aW9uKEhUTUxOYW1lczo6ZHJhZ2dhYmxlQXR0ciksICJ0cnVlIikpCisgICAgICAgIHJl dHVybiB0cnVlOworCiAgICAgaWYgKGF1dG8gdmlldyA9IG1ha2VSZWZQdHIoZnJhbWUtPm1haW5G cmFtZSgpLnZpZXcoKSkpIHsKICAgICAgICAgYXV0byBlbGVtZW50Qm91bmRzID0gV2ViUGFnZTo6 cm9vdFZpZXdJbnRlcmFjdGlvbkJvdW5kcyhjbGlja05vZGUpOwogICAgICAgICBhdXRvIHVub2Jz Y3VyZWRSZWN0ID0gdmlldy0+dW5vYnNjdXJlZENvbnRlbnRSZWN0KCk7CmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9pb3MvbWVhbmluZ2Z1bC1jbGljay13aGVuLXRhcHBpbmct ZHJhZ2dhYmxlLWNvbnRlbnQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMv aW9zL21lYW5pbmdmdWwtY2xpY2std2hlbi10YXBwaW5nLWRyYWdnYWJsZS1jb250ZW50LWV4cGVj dGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwLi42YWU0MjRjNmYyNWRiZDE5Njc2MmMwNTBiYWRhZWYyN2RiZmI4 N2I2Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvaW9zL21lYW5p bmdmdWwtY2xpY2std2hlbi10YXBwaW5nLWRyYWdnYWJsZS1jb250ZW50LWV4cGVjdGVkLnR4dApA QCAtMCwwICsxLDEyIEBACitUaGlzIHRlc3QgZXhlcmNpc2VzIHRoZSAnbWVhbmluZ2Z1bCBjbGlj aycgaGV1cmlzdGljIHdoZW4gdGFwcGluZyBkcmFnZ2FibGUgY29udGVudC4KKworT24gc3VjY2Vz cywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkg IlRFU1QgQ09NUExFVEUiLgorCitQQVNTIGRpZEhhbmRsZVRhcCBiZWNhbWUgdHJ1ZQorUEFTUyBk aWRIYW5kbGVUYXBBc01lYW5pbmdmdWxDbGljayBpcyB0cnVlCitQQVNTIGRpZEhhbmRsZVRhcCBi ZWNhbWUgdHJ1ZQorUEFTUyBkaWRIYW5kbGVUYXBBc01lYW5pbmdmdWxDbGljayBpcyBmYWxzZQor UEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2lvcy9tZWFuaW5nZnVsLWNsaWNrLXdoZW4t dGFwcGluZy1kcmFnZ2FibGUtY29udGVudC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMv aW9zL21lYW5pbmdmdWwtY2xpY2std2hlbi10YXBwaW5nLWRyYWdnYWJsZS1jb250ZW50Lmh0bWwK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uM2YyNTMxZmI5MzQ2MWExOGEyNjA4ZGQ5Nzg0ZmJhNTYyNDk0MThkMwotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2lvcy9tZWFuaW5nZnVsLWNs aWNrLXdoZW4tdGFwcGluZy1kcmFnZ2FibGUtY29udGVudC5odG1sCkBAIC0wLDAgKzEsNjYgQEAK KzwhRE9DVFlQRSBodG1sPiA8IS0tIHdlYmtpdC10ZXN0LXJ1bm5lciBbIHVzZUZsZXhpYmxlVmll d3BvcnQ9dHJ1ZSBdIC0tPgorPGh0bWw+Cis8aGVhZD4KKzxtZXRhIG5hbWU9InZpZXdwb3J0IiBj b250ZW50PSJ3aWR0aD1kZXZpY2Utd2lkdGgsIGluaXRpYWwtc2NhbGU9MSwgdXNlci1zY2FsYWJs ZT1ubyI+Cis8c3R5bGU+Citib2R5LCBodG1sIHsKKyAgICBmb250LXNpemU6IDE4cHg7CisgICAg Zm9udC1mYW1pbHk6IHN5c3RlbS11aTsKKyAgICB3aWR0aDogMTAwJTsKKyAgICBoZWlnaHQ6IDEw MCU7CisgICAgbWFyZ2luOiAwOworfQorCisjdGFyZ2V0IHsKKyAgICB3aWR0aDogMTAwJTsKKyAg ICBoZWlnaHQ6IDEwMCU7CisgICAgYmFja2dyb3VuZC1jb2xvcjogc2lsdmVyOworfQorPC9zdHls ZT4KKzxzY3JpcHQgc3JjPSIuLi8uLi8uLi9yZXNvdXJjZXMvanMtdGVzdC5qcyI+PC9zY3JpcHQ+ Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vcmVzb3VyY2VzL3VpLWhlbHBlci5qcyI+PC9zY3JpcHQ+ Cis8c2NyaXB0PgoranNUZXN0SXNBc3luYyA9IHRydWU7CisKK2FkZEV2ZW50TGlzdGVuZXIoImxv YWQiLCBhc3luYyAoKSA9PiB7CisgICAgZGVzY3JpcHRpb24oIlRoaXMgdGVzdCBleGVyY2lzZXMg dGhlICdtZWFuaW5nZnVsIGNsaWNrJyBoZXVyaXN0aWMgd2hlbiB0YXBwaW5nIGRyYWdnYWJsZSBj b250ZW50LiIpOworCisgICAgaWYgKCF3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgICAgcmV0dXJu OworCisgICAgY29uc3QgdGFyZ2V0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRhcmdldCIp OworICAgIHRhcmdldC5hZGRFdmVudExpc3RlbmVyKCJtb3VzZWRvd24iLCAoKSA9PiB7IH0pOwor CisgICAgYXN5bmMgZnVuY3Rpb24gc2ltdWxhdGVUYXAoZXhwZWN0TWVhbmluZ2Z1bENsaWNrKSB7 CisgICAgICAgIGRpZEhhbmRsZVRhcCA9IGZhbHNlOworICAgICAgICBkaWRIYW5kbGVUYXBBc01l YW5pbmdmdWxDbGljayA9IGZhbHNlOworICAgICAgICB0ZXN0UnVubmVyLmluc3RhbGxEaWRIYW5k bGVUYXBDYWxsYmFjayh3YXNNZWFuaW5nZnVsID0+IHsKKyAgICAgICAgICAgIGRpZEhhbmRsZVRh cCA9IHRydWU7CisgICAgICAgICAgICBkaWRIYW5kbGVUYXBBc01lYW5pbmdmdWxDbGljayA9IHdh c01lYW5pbmdmdWw7CisgICAgICAgIH0pOworCisgICAgICAgIGF3YWl0IFVJSGVscGVyLmFjdGl2 YXRlRWxlbWVudCh0YXJnZXQpOworICAgICAgICBhd2FpdCBzaG91bGRCZWNvbWVFcXVhbCgiZGlk SGFuZGxlVGFwIiwgInRydWUiKTsKKyAgICAgICAgaWYgKGV4cGVjdE1lYW5pbmdmdWxDbGljaykK KyAgICAgICAgICAgIHNob3VsZEJlVHJ1ZSgiZGlkSGFuZGxlVGFwQXNNZWFuaW5nZnVsQ2xpY2si KTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgc2hvdWxkQmVGYWxzZSgiZGlkSGFuZGxlVGFw QXNNZWFuaW5nZnVsQ2xpY2siKTsKKyAgICAgICAgdGVzdFJ1bm5lci5jbGVhclRlc3RSdW5uZXJD YWxsYmFja3MoKTsKKyAgICAgICAgYXdhaXQgVUlIZWxwZXIud2FpdEZvckRvdWJsZVRhcERlbGF5 KCk7CisgICAgfQorCisgICAgYXdhaXQgc2ltdWxhdGVUYXAodHJ1ZSk7CisKKyAgICB0YXJnZXQu cmVtb3ZlQXR0cmlidXRlKCJkcmFnZ2FibGUiKTsKKyAgICBhd2FpdCBzaW11bGF0ZVRhcChmYWxz ZSk7CisKKyAgICBmaW5pc2hKU1Rlc3QoKTsKK30pOworPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9k eT4KKyAgICA8ZGl2IGlkPSJkZXNjcmlwdGlvbiI+PC9kaXY+CisgICAgPGRpdiBpZD0iY29uc29s ZSI+PC9kaXY+CisgICAgPGRpdiBpZD0idGFyZ2V0IiBkcmFnZ2FibGU9InRydWUiPjwvZGl2Pgor PC9ib2R5PgorPC9odG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK