228077 2021-07-19 04:05:04 -0700 [GTK][WPE] fix compilation when ATK is not used 2021-07-20 03:25:20 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 vjaquez vjaquez aperez bfulgham bugs-noreply cgarcia katherine_cheney megan_gardner thorton oldest_to_newest 1777846 0 vjaquez 2021-07-19 04:05:04 -0700 When compiling in embedded environment I get this error: In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-7.cpp:8: Source/WebKit/UIProcess/WebPageProxy.cpp: In member function ‘void WebKit::WebPageProxy::swapToProvisionalPage(std::unique_ptr<WebKit::ProvisionalPageProxy>)’: Source/WebKit/UIProcess/WebPageProxy.cpp:975:9: error: ‘bindAccessibilityTree’ was not declared in this scope 975 | bindAccessibilityTree(accessibilityPlugID); | ^~~~~~~~~~~~~~~~~~~~~ It seems r279983 introduced this regression. 1777847 1 433783 vjaquez 2021-07-19 04:12:00 -0700 Created attachment 433783 Patch 1777852 2 cgarcia 2021-07-19 04:59:51 -0700 Right, this is because I changed this in a local branch and I forgot about it. Could you change the ATK ifdef in WebPageProxy.messages.in to PLATFORM GTK or WPE and in WebPageProxyWPE.cpp move the ATK ifdef inside the bindAccessibilityTree() function? 1777867 3 433789 vjaquez 2021-07-19 07:56:07 -0700 Created attachment 433789 Patch 1778109 4 433789 cgarcia 2021-07-20 01:04:45 -0700 Comment on attachment 433789 Patch Thanks! 1778112 5 ews-feeder 2021-07-20 01:23:36 -0700 vjaquez@igalia.com does not have committer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/Tools/Scripts/webkitpy/common/config/contributors.json. Rejecting attachment 433789 from commit queue. 1778113 6 433789 cgarcia 2021-07-20 01:25:55 -0700 Comment on attachment 433789 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433789&action=review > Source/WebKit/UIProcess/WebPageProxy.h:2225 > +#if USE(ATK) > void showEmojiPicker(const WebCore::IntRect&, CompletionHandler<void(String)>&&); > #endif Wait. I didn't notice this. It's an existing issue, but we can fix it now that we are changing it. This should the PLATFORM(GTK) since the emoji picker is GTK specific, it has nothing to do with ATK 1778118 7 433858 vjaquez 2021-07-20 01:53:19 -0700 Created attachment 433858 Patch 1778123 8 ews-feeder 2021-07-20 02:28:57 -0700 vjaquez@igalia.com does not have committer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/Tools/Scripts/webkitpy/common/config/contributors.json. Rejecting attachment 433858 from commit queue. 1778126 9 433858 vjaquez 2021-07-20 02:44:31 -0700 Comment on attachment 433858 Patch It seems I forgot a step while re-enabling my committer status :S In the meanwhile, Carlos, can you pull the commit-queue knob? 1778132 10 ews-feeder 2021-07-20 03:25:18 -0700 Committed r280074 (239800@main): <https://commits.webkit.org/239800@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433858. 433783 2021-07-19 04:12:00 -0700 2021-07-19 07:56:03 -0700 Patch bug-228077-20210719131159.patch text/plain 4058 vjaquez U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwMDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDczMDQ1ZmViMWMxYjZlMDE2 ZTAwZjhlMWI5M2VlZDliYTk1YTAyYjguLjhmYTlmZTAyNzFlZDNiMGVkNjNmY2RlZmU5NDEyZTkz ZTFlM2JmZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjEtMDctMTkgIFbDrWN0b3Ig TWFudWVsIErDoXF1ZXogTGVhbCAgPHZqYXF1ZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RL XVtXUEVdIGZpeCBjb21waWxhdGlvbiB3aGVuIEFUSyBpcyBub3QgdXNlZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI4MDc3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIG1pc3NpbmcgVVNFKEFUSykg Z3VhcmRzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvUHJvdmlzaW9uYWxQYWdlUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpQcm92aXNp b25hbFBhZ2VQcm94eTo6ZGlkUmVjZWl2ZU1lc3NhZ2UpOgorICAgICAgICAqIFVJUHJvY2Vzcy9Q cm92aXNpb25hbFBhZ2VQcm94eS5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHku Y3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OnN3YXBUb1Byb3Zpc2lvbmFsUGFn ZSk6CisKIDIwMjEtMDctMTggIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+ CiAKICAgICAgICAgW2lPU10gW0FYXSBLZXlib2FyZCB0ZXh0IGNhbmRpZGF0ZXMgZG9uJ3QgdXBk YXRlIHdoZW4gY2hhbmdpbmcgc2VsZWN0aW9uIHVzaW5nIFN3aXRjaCBDb250cm9sCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Qcm92aXNpb25hbFBhZ2VQcm94eS5jcHAgYi9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Qcm92aXNpb25hbFBhZ2VQcm94eS5jcHAKaW5kZXggYzY1 NGNiOGMxMjIxYWY4MTFmNmIwYTczYjNlMWRmOTQzNWIyYjc2ZC4uNmM1YzE1YmU1ZTcwOGM3OThl NzQxNmEzZjdiODQxYjQyYzNiMjNjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvUHJvdmlzaW9uYWxQYWdlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L1Byb3Zpc2lvbmFsUGFnZVByb3h5LmNwcApAQCAtNDExLDcgKzQxMSw3IEBAIHZvaWQgUHJvdmlz aW9uYWxQYWdlUHJveHk6OnJlZ2lzdGVyV2ViUHJvY2Vzc0FjY2Vzc2liaWxpdHlUb2tlbihjb25z dCBJUEM6OkRhdGFSCiB9CiAjZW5kaWYKIAotI2lmIFBMQVRGT1JNKEdUSykgfHwgUExBVEZPUk0o V1BFKQorI2lmIFVTRShBVEspICYmIChQTEFURk9STShHVEspIHx8IFBMQVRGT1JNKFdQRSkpCiB2 b2lkIFByb3Zpc2lvbmFsUGFnZVByb3h5OjpiaW5kQWNjZXNzaWJpbGl0eVRyZWUoY29uc3QgU3Ry aW5nJiBwbHVnSUQpCiB7CiAgICAgbV9hY2Nlc3NpYmlsaXR5UGx1Z0lEID0gcGx1Z0lEOwpAQCAt NDc3LDcgKzQ3Nyw3IEBAIHZvaWQgUHJvdmlzaW9uYWxQYWdlUHJveHk6OmRpZFJlY2VpdmVNZXNz YWdlKElQQzo6Q29ubmVjdGlvbiYgY29ubmVjdGlvbiwgSVBDOjpECiAgICAgfQogI2VuZGlmCiAK LSNpZiBQTEFURk9STShHVEspIHx8IFBMQVRGT1JNKFdQRSkKKyNpZiBVU0UoQVRLKSAmJiAoUExB VEZPUk0oR1RLKSB8fCBQTEFURk9STShXUEUpKQogICAgIGlmIChkZWNvZGVyLm1lc3NhZ2VOYW1l KCkgPT0gTWVzc2FnZXM6OldlYlBhZ2VQcm94eTo6QmluZEFjY2Vzc2liaWxpdHlUcmVlOjpuYW1l KCkpIHsKICAgICAgICAgSVBDOjpoYW5kbGVNZXNzYWdlPE1lc3NhZ2VzOjpXZWJQYWdlUHJveHk6 OkJpbmRBY2Nlc3NpYmlsaXR5VHJlZT4oZGVjb2RlciwgdGhpcywgJlByb3Zpc2lvbmFsUGFnZVBy b3h5OjpiaW5kQWNjZXNzaWJpbGl0eVRyZWUpOwogICAgICAgICByZXR1cm47CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Qcm92aXNpb25hbFBhZ2VQcm94eS5oIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvUHJvdmlzaW9uYWxQYWdlUHJveHkuaAppbmRleCBhN2ZiNjZhNmRh YTczN2M5MDYwOTA3YzA4OTZmMGNiYzk0ZWIzODBlLi4zMmVmMjU0MzlhOTNkNGQzM2VlYTgxZjgw MmMzNWQyNGNiOTU2YTdiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Qcm92 aXNpb25hbFBhZ2VQcm94eS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1Byb3Zpc2lv bmFsUGFnZVByb3h5LmgKQEAgLTkwLDcgKzkwLDcgQEAgcHVibGljOgogI2lmIFBMQVRGT1JNKENP Q09BKQogICAgIFZlY3Rvcjx1aW50OF90PiB0YWtlQWNjZXNzaWJpbGl0eVRva2VuKCkgeyByZXR1 cm4gV1RGTW92ZShtX2FjY2Vzc2liaWxpdHlUb2tlbik7IH0KICNlbmRpZgotI2lmIFBMQVRGT1JN KEdUSykgfHwgUExBVEZPUk0oV1BFKQorI2lmIFVTRShBVEspICYmIChQTEFURk9STShHVEspIHx8 IFBMQVRGT1JNKFdQRSkpCiAgICAgY29uc3QgU3RyaW5nJiBhY2Nlc3NpYmlsaXR5UGx1Z0lEKCkg eyByZXR1cm4gbV9hY2Nlc3NpYmlsaXR5UGx1Z0lEOyB9CiAjZW5kaWYKICNpZiBIQVZFKFZJU0lC SUxJVFlfUFJPUEFHQVRJT05fVklFVykKQEAgLTE0OCw3ICsxNDgsNyBAQCBwcml2YXRlOgogI2lm IFBMQVRGT1JNKENPQ09BKQogICAgIHZvaWQgcmVnaXN0ZXJXZWJQcm9jZXNzQWNjZXNzaWJpbGl0 eVRva2VuKGNvbnN0IElQQzo6RGF0YVJlZmVyZW5jZSYpOwogI2VuZGlmCi0jaWYgUExBVEZPUk0o R1RLKSB8fCBQTEFURk9STShXUEUpCisjaWYgVVNFKEFUSykgJiYgKFBMQVRGT1JNKEdUSykgfHwg UExBVEZPUk0oV1BFKSkKICAgICB2b2lkIGJpbmRBY2Nlc3NpYmlsaXR5VHJlZShjb25zdCBTdHJp bmcmKTsKICNlbmRpZgogI2lmIEVOQUJMRShDT05URU5UX0ZJTFRFUklORykKQEAgLTE3Niw3ICsx NzYsNyBAQCBwcml2YXRlOgogI2lmIFBMQVRGT1JNKENPQ09BKQogICAgIFZlY3Rvcjx1aW50OF90 PiBtX2FjY2Vzc2liaWxpdHlUb2tlbjsKICNlbmRpZgotI2lmIFBMQVRGT1JNKEdUSykgfHwgUExB VEZPUk0oV1BFKQorI2lmIFVTRShBVEspICYmIChQTEFURk9STShHVEspIHx8IFBMQVRGT1JNKFdQ RSkpCiAgICAgU3RyaW5nIG1fYWNjZXNzaWJpbGl0eVBsdWdJRDsKICNlbmRpZgogI2lmIFBMQVRG T1JNKElPU19GQU1JTFkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQ YWdlUHJveHkuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcApp bmRleCBmNjJjZTY4NDBmYTQzNDc4ZWU5Yjg0MTAzNTM3MmQ5ODRlOGYzZWQ3Li5jZWM5NjAzNTM4 MGU0NzNmZmNkNjY1YTRkZGZjYWUzMGRmOTIyODllIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L1dlYlBhZ2VQcm94eS5jcHAKQEAgLTk2OSw3ICs5NjksNyBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6 c3dhcFRvUHJvdmlzaW9uYWxQYWdlKHN0ZDo6dW5pcXVlX3B0cjxQcm92aXNpb25hbFBhZ2VQcm94 eT4gcAogICAgIGlmICghYWNjZXNzaWJpbGl0eVRva2VuLmlzRW1wdHkoKSkKICAgICAgICAgcmVn aXN0ZXJXZWJQcm9jZXNzQWNjZXNzaWJpbGl0eVRva2VuKHsgYWNjZXNzaWJpbGl0eVRva2VuLmRh dGEoKSwgYWNjZXNzaWJpbGl0eVRva2VuLnNpemUoKSB9KTsKICNlbmRpZgotI2lmIFBMQVRGT1JN KEdUSykgfHwgUExBVEZPUk0oV1BFKQorI2lmIFVTRShBVEspICYmIChQTEFURk9STShHVEspIHx8 IFBMQVRGT1JNKFdQRSkpCiAgICAgYXV0byBhY2Nlc3NpYmlsaXR5UGx1Z0lEID0gcHJvdmlzaW9u YWxQYWdlLT5hY2Nlc3NpYmlsaXR5UGx1Z0lEKCk7CiAgICAgaWYgKCFhY2Nlc3NpYmlsaXR5UGx1 Z0lELmlzRW1wdHkoKSkKICAgICAgICAgYmluZEFjY2Vzc2liaWxpdHlUcmVlKGFjY2Vzc2liaWxp dHlQbHVnSUQpOwo= 433789 2021-07-19 07:56:07 -0700 2021-07-20 01:53:14 -0700 Patch bug-228077-20210719165606.patch text/plain 3257 vjaquez U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwMDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDczMDQ1ZmViMWMxYjZlMDE2 ZTAwZjhlMWI5M2VlZDliYTk1YTAyYjguLjc1ZmFiNzliZWNkNjRkY2ZhMjM5MDcyZmIwNjYwY2Q2 YWEyOTBmMzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjEtMDctMTkgIFbDrWN0b3Ig TWFudWVsIErDoXF1ZXogTGVhbCAgPHZqYXF1ZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RL XVtXUEVdIEZpeCBjb21waWxhdGlvbiB3aGVuIEFUSyBpcyBub3QgdXNlZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI4MDc3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR3VhcmQgQVRLIG9ubHkgaW5zaWRl IGltcGxlbWVudGF0aW9ucywgc28gdGhlIGNvZGUgbG9va3MgbW9yZSByZWFkYWJsZS4KKworICAg ICAgICBObyBuZXcgdGVzdHMgbmVlZGVkLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQ cm94eS5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkubWVzc2FnZXMuaW46Cisg ICAgICAgICogVUlQcm9jZXNzL3dwZS9XZWJQYWdlUHJveHlXUEUuY3BwOgorICAgICAgICAoV2Vi S2l0OjpXZWJQYWdlUHJveHk6OmJpbmRBY2Nlc3NpYmlsaXR5VHJlZSk6CisKIDIwMjEtMDctMTgg IFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10g W0FYXSBLZXlib2FyZCB0ZXh0IGNhbmRpZGF0ZXMgZG9uJ3QgdXBkYXRlIHdoZW4gY2hhbmdpbmcg c2VsZWN0aW9uIHVzaW5nIFN3aXRjaCBDb250cm9sCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBh Z2VQcm94eS5oCmluZGV4IGE2ODNiMjcxZmVkMTE5NDA1Njc0ODM4ZDI3YjA4NTE5MGQyNjI1ODQu LmIwYjA0Y2IyYTc1YTQzYzk2YzQ4NTFkY2VlODUyYTkyZTYwNTY0NjUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCisrKyBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCkBAIC0yMjE2LDggKzIyMTYsMTEgQEAgcHJpdmF0ZToK ICAgICB2b2lkIGdldEVkaXRvckNvbW1hbmRzRm9yS2V5RXZlbnQoY29uc3QgQXRvbVN0cmluZyYs IFZlY3RvcjxTdHJpbmc+Jik7CiAjZW5kaWYKIAotI2lmIFVTRShBVEspCisjaWYgUExBVEZPUk0o R1RLKSB8fCBQTEFURk9STShXUEUpCiAgICAgdm9pZCBiaW5kQWNjZXNzaWJpbGl0eVRyZWUoY29u c3QgU3RyaW5nJik7CisjZW5kaWYKKworI2lmIFVTRShBVEspCiAgICAgdm9pZCBzaG93RW1vamlQ aWNrZXIoY29uc3QgV2ViQ29yZTo6SW50UmVjdCYsIENvbXBsZXRpb25IYW5kbGVyPHZvaWQoU3Ry aW5nKT4mJik7CiAjZW5kaWYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv V2ViUGFnZVByb3h5Lm1lc3NhZ2VzLmluIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFn ZVByb3h5Lm1lc3NhZ2VzLmluCmluZGV4IDAyZDhmZDlmYjIyMDZjODMzMWI1Y2QwZDg2ZDYxNmMw Yzg5OTdlOTEuLjljN2YwZDRiYTcxNWJkZTU4M2Y1Y2E2ODk4MjFjNTA5MWIwNzZjODggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5tZXNzYWdlcy5pbgor KysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkubWVzc2FnZXMuaW4KQEAg LTE4NCwxMiArMTg0LDEwIEBAIG1lc3NhZ2VzIC0+IFdlYlBhZ2VQcm94eSB7CiAgICAgUGx1Z2lu U2NhbGVGYWN0b3JEaWRDaGFuZ2UoZG91YmxlIHpvb21GYWN0b3IpCiAgICAgUGx1Z2luWm9vbUZh Y3RvckRpZENoYW5nZShkb3VibGUgem9vbUZhY3RvcikKIAotI2lmIFVTRShBVEspCisjaWYgUExB VEZPUk0oR1RLKSB8fCBQTEFURk9STShXUEUpCiAgICAgIyBTdXBwb3J0IGZvciBjb25uZWN0aW5n IHRoZSBBY2Nlc3NpYmlsaXR5IHdvcmxkcyBvZiB0aGUgVUkgYW5kIHRoZSBXZWIgcHJvY2Vzc2Vz CiAgICAgQmluZEFjY2Vzc2liaWxpdHlUcmVlKFN0cmluZyBwbHVnSUQpCi0jZW5kaWYKIAotI2lm IFBMQVRGT1JNKEdUSykgfHwgUExBVEZPUk0oV1BFKQogICAgIFNldElucHV0TWV0aG9kU3RhdGUo c3RkOjpvcHRpb25hbDxXZWJLaXQ6OklucHV0TWV0aG9kU3RhdGU+IHN0YXRlKTsKICNlbmRpZgog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy93cGUvV2ViUGFnZVByb3h5V1BF LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL3dwZS9XZWJQYWdlUHJveHlXUEUuY3BwCmlu ZGV4IGRjZWE5YzFkY2VkMWQxNDBmYTAxYTg1ZGU4OWJmZmRkN2Y1YjU3OTAuLjhmMjg0NGQ4NTJm ZmI0ZjM1NjBlYmEyZGZjYzc5NGMzY2Y1OGJiY2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL3dwZS9XZWJQYWdlUHJveHlXUEUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL3dwZS9XZWJQYWdlUHJveHlXUEUuY3BwCkBAIC00NSwxNCArNDUsMTQgQEAgc3RydWN0 IHdwZV92aWV3X2JhY2tlbmQqIFdlYlBhZ2VQcm94eTo6dmlld0JhY2tlbmQoKQogICAgIHJldHVy biBzdGF0aWNfY2FzdDxQYWdlQ2xpZW50SW1wbCY+KHBhZ2VDbGllbnQoKSkudmlld0JhY2tlbmQo KTsKIH0KIAotI2lmIFVTRShBVEspCiB2b2lkIFdlYlBhZ2VQcm94eTo6YmluZEFjY2Vzc2liaWxp dHlUcmVlKGNvbnN0IFN0cmluZyYgcGx1Z0lEKQogeworI2lmIFVTRShBVEspCiAgICAgYXV0byog YWNjZXNzaWJsZSA9IHN0YXRpY19jYXN0PFBhZ2VDbGllbnRJbXBsJj4ocGFnZUNsaWVudCgpKS5h Y2Nlc3NpYmxlKCk7CiAgICAgYXRrX3NvY2tldF9lbWJlZChBVEtfU09DS0VUKGFjY2Vzc2libGUp LCBjb25zdF9jYXN0PGNoYXIqPihwbHVnSUQudXRmOCgpLmRhdGEoKSkpOwogICAgIGF0a19vYmpl Y3Rfbm90aWZ5X3N0YXRlX2NoYW5nZShhY2Nlc3NpYmxlLCBBVEtfU1RBVEVfVFJBTlNJRU5ULCBG QUxTRSk7Ci19CiAjZW5kaWYKK30KIAogdm9pZCBXZWJQYWdlUHJveHk6OmRpZFVwZGF0ZUVkaXRv clN0YXRlKGNvbnN0IEVkaXRvclN0YXRlJiwgY29uc3QgRWRpdG9yU3RhdGUmIG5ld0VkaXRvclN0 YXRlKQogewo= 433858 2021-07-20 01:53:19 -0700 2021-07-20 03:25:19 -0700 Patch bug-228077-20210720105318.patch text/plain 3339 vjaquez U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwMDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDczMDQ1ZmViMWMxYjZlMDE2 ZTAwZjhlMWI5M2VlZDliYTk1YTAyYjguLjY1NmVkOGNlZThhM2M3YmQyZDAyZjFiZjM3MDVhZTQy OGI0NThhYmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjEtMDctMjAgIFbDrWN0b3Ig TWFudWVsIErDoXF1ZXogTGVhbCAgPHZqYXF1ZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RL XVtXUEVdIEZpeCBjb21waWxhdGlvbiB3aGVuIEFUSyBpcyBub3QgdXNlZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI4MDc3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgQ2FybG9zIEdhcmNpYSBDYW1wb3MuCisKKyAgICAgICAgR3VhcmQgQVRLIG9ubHkg aW5zaWRlIGltcGxlbWVudGF0aW9ucywgc28gdGhlIGNvZGUgaXMgbW9yZSByZWFkYWJsZS4KKwor ICAgICAgICBBbHNvIGNoYW5nZWQgZ3VhcmQgZnJvbSBBVEsgdG8gR1RLIHBsYXRmb3JtIHNob3dF bW9qaVBpY2tlcigpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAgICAgICAg KiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5Lmg6CisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQ cm94eS5tZXNzYWdlcy5pbjoKKyAgICAgICAgKiBVSVByb2Nlc3Mvd3BlL1dlYlBhZ2VQcm94eVdQ RS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6YmluZEFjY2Vzc2liaWxpdHlU cmVlKToKKwogMjAyMS0wNy0xOCAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNv bT4KIAogICAgICAgICBbaU9TXSBbQVhdIEtleWJvYXJkIHRleHQgY2FuZGlkYXRlcyBkb24ndCB1 cGRhdGUgd2hlbiBjaGFuZ2luZyBzZWxlY3Rpb24gdXNpbmcgU3dpdGNoIENvbnRyb2wKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgKaW5kZXggYTY4M2IyNzFmZWQxMTk0MDU2NzQ4 MzhkMjdiMDg1MTkwZDI2MjU4NC4uMzQ0MmM4YThlOGJiMTcyN2NhOGVjN2IyZDc3YzJkY2MxYWE3 OWJhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgK KysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgKQEAgLTIyMTYsOCAr MjIxNiwxMSBAQCBwcml2YXRlOgogICAgIHZvaWQgZ2V0RWRpdG9yQ29tbWFuZHNGb3JLZXlFdmVu dChjb25zdCBBdG9tU3RyaW5nJiwgVmVjdG9yPFN0cmluZz4mKTsKICNlbmRpZgogCi0jaWYgVVNF KEFUSykKKyNpZiBQTEFURk9STShHVEspIHx8IFBMQVRGT1JNKFdQRSkKICAgICB2b2lkIGJpbmRB Y2Nlc3NpYmlsaXR5VHJlZShjb25zdCBTdHJpbmcmKTsKKyNlbmRpZgorCisjaWYgUExBVEZPUk0o R1RLKQogICAgIHZvaWQgc2hvd0Vtb2ppUGlja2VyKGNvbnN0IFdlYkNvcmU6OkludFJlY3QmLCBD b21wbGV0aW9uSGFuZGxlcjx2b2lkKFN0cmluZyk+JiYpOwogI2VuZGlmCiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5tZXNzYWdlcy5pbiBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5tZXNzYWdlcy5pbgppbmRleCAwMmQ4ZmQ5 ZmIyMjA2YzgzMzFiNWNkMGQ4NmQ2MTZjMGM4OTk3ZTkxLi45YzdmMGQ0YmE3MTViZGU1ODNmNWNh Njg5ODIxYzUwOTFiMDc2Yzg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9X ZWJQYWdlUHJveHkubWVzc2FnZXMuaW4KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vi UGFnZVByb3h5Lm1lc3NhZ2VzLmluCkBAIC0xODQsMTIgKzE4NCwxMCBAQCBtZXNzYWdlcyAtPiBX ZWJQYWdlUHJveHkgewogICAgIFBsdWdpblNjYWxlRmFjdG9yRGlkQ2hhbmdlKGRvdWJsZSB6b29t RmFjdG9yKQogICAgIFBsdWdpblpvb21GYWN0b3JEaWRDaGFuZ2UoZG91YmxlIHpvb21GYWN0b3Ip CiAKLSNpZiBVU0UoQVRLKQorI2lmIFBMQVRGT1JNKEdUSykgfHwgUExBVEZPUk0oV1BFKQogICAg ICMgU3VwcG9ydCBmb3IgY29ubmVjdGluZyB0aGUgQWNjZXNzaWJpbGl0eSB3b3JsZHMgb2YgdGhl IFVJIGFuZCB0aGUgV2ViIHByb2Nlc3NlcwogICAgIEJpbmRBY2Nlc3NpYmlsaXR5VHJlZShTdHJp bmcgcGx1Z0lEKQotI2VuZGlmCiAKLSNpZiBQTEFURk9STShHVEspIHx8IFBMQVRGT1JNKFdQRSkK ICAgICBTZXRJbnB1dE1ldGhvZFN0YXRlKHN0ZDo6b3B0aW9uYWw8V2ViS2l0OjpJbnB1dE1ldGhv ZFN0YXRlPiBzdGF0ZSk7CiAjZW5kaWYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVBy b2Nlc3Mvd3BlL1dlYlBhZ2VQcm94eVdQRS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy93 cGUvV2ViUGFnZVByb3h5V1BFLmNwcAppbmRleCBkY2VhOWMxZGNlZDFkMTQwZmEwMWE4NWRlODli ZmZkZDdmNWI1NzkwLi44ZjI4NDRkODUyZmZiNGYzNTYwZWJhMmRmY2M3OTRjM2NmNThiYmNlIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy93cGUvV2ViUGFnZVByb3h5V1BFLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy93cGUvV2ViUGFnZVByb3h5V1BFLmNwcApA QCAtNDUsMTQgKzQ1LDE0IEBAIHN0cnVjdCB3cGVfdmlld19iYWNrZW5kKiBXZWJQYWdlUHJveHk6 OnZpZXdCYWNrZW5kKCkKICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8UGFnZUNsaWVudEltcGwmPihw YWdlQ2xpZW50KCkpLnZpZXdCYWNrZW5kKCk7CiB9CiAKLSNpZiBVU0UoQVRLKQogdm9pZCBXZWJQ YWdlUHJveHk6OmJpbmRBY2Nlc3NpYmlsaXR5VHJlZShjb25zdCBTdHJpbmcmIHBsdWdJRCkKIHsK KyNpZiBVU0UoQVRLKQogICAgIGF1dG8qIGFjY2Vzc2libGUgPSBzdGF0aWNfY2FzdDxQYWdlQ2xp ZW50SW1wbCY+KHBhZ2VDbGllbnQoKSkuYWNjZXNzaWJsZSgpOwogICAgIGF0a19zb2NrZXRfZW1i ZWQoQVRLX1NPQ0tFVChhY2Nlc3NpYmxlKSwgY29uc3RfY2FzdDxjaGFyKj4ocGx1Z0lELnV0Zjgo KS5kYXRhKCkpKTsKICAgICBhdGtfb2JqZWN0X25vdGlmeV9zdGF0ZV9jaGFuZ2UoYWNjZXNzaWJs ZSwgQVRLX1NUQVRFX1RSQU5TSUVOVCwgRkFMU0UpOwotfQogI2VuZGlmCit9CiAKIHZvaWQgV2Vi UGFnZVByb3h5OjpkaWRVcGRhdGVFZGl0b3JTdGF0ZShjb25zdCBFZGl0b3JTdGF0ZSYsIGNvbnN0 IEVkaXRvclN0YXRlJiBuZXdFZGl0b3JTdGF0ZSkKIHsK