228068 2021-07-18 19:59:14 -0700 Compiler Incorrect Optimization 2021-07-19 17:49:45 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 vulbugs mark.lam ews-watchlist fpizlo keith_miller mark.lam msaboff saam tzagallo vulbugs webkit-bug-importer ysuzuki oldest_to_newest 1777799 0 vulbugs 2021-07-18 19:59:14 -0700 OS: ubuntu18.04 Architecture: <x64> ./jsc bug.js expected output -Infinity -Infinity actual output -Infinity Infinity bug.js ################################## function f() { v0 = (-0.0).toLocaleString(); return parseInt(v0); } let a0 = f(); print(1 / a0); for (let i = 0; i < 0x1000; i++) { f(); } let a3 = f(); print(1 / a3); 1777887 1 webkit-bug-importer 2021-07-19 09:44:59 -0700 <rdar://problem/80788603> 1778023 2 433828 mark.lam 2021-07-19 15:31:39 -0700 Created attachment 433828 proposed patch. 1778025 3 433828 ysuzuki 2021-07-19 15:35:10 -0700 Comment on attachment 433828 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=433828&action=review > Source/JavaScriptCore/dfg/DFGOperations.cpp:206 > + if (static_cast<double>(asInt) == input) { > + if (asInt || !std::signbit(input)) I think it is worth putting `LIKELY`. if (LIKELY(static_cast<double>(asInt) == input && (asInt || !std::signbit(input)))) return JSValue::encode(jsNumber(asInt)); 1778027 4 mark.lam 2021-07-19 15:36:22 -0700 (In reply to Yusuke Suzuki from comment #3) > Comment on attachment 433828 [details] > proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=433828&action=review > > > Source/JavaScriptCore/dfg/DFGOperations.cpp:206 > > + if (static_cast<double>(asInt) == input) { > > + if (asInt || !std::signbit(input)) > > I think it is worth putting `LIKELY`. > > if (LIKELY(static_cast<double>(asInt) == input && (asInt || > !std::signbit(input)))) > return JSValue::encode(jsNumber(asInt)); OK, will do. 1778031 5 433830 mark.lam 2021-07-19 15:44:25 -0700 Created attachment 433830 patch for landing. 1778069 6 mark.lam 2021-07-19 17:49:45 -0700 Thanks for the review. Landed in r280060: <http://trac.webkit.org/r280060>. 433828 2021-07-19 15:31:39 -0700 2021-07-19 15:44:25 -0700 proposed patch. bug-228068.patch text/plain 2748 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyODAwNTApCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDIxLTA3LTE5ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBERkcncyBwYXJzZUludFJlc3VsdCgpIHNob3VsZCBjaGVjayBmb3IgbmVn YXRpdmUgemVyby4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIyODA2OAorICAgICAgICByZGFyOi8vODA3ODg2MDMKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy9kZmctcGFyc2VJbnRSZXN1bHQt c2hvdWxkLWNoZWNrLWZvci1uZWdhdGl2ZS16ZXJvLmpzOiBBZGRlZC4KKwogMjAyMS0wNy0xOSAg WXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFtKU0NdIEluQnlT dGF0dXMgLyBJbkJ5VmFyaWFudCBzaG91bGQgdmlzaXQgQ2FjaGVhYmxlSWRlbnRpZmllcgpJbmRl eDogSlNUZXN0cy9zdHJlc3MvZGZnLXBhcnNlSW50UmVzdWx0LXNob3VsZC1jaGVjay1mb3ItbmVn YXRpdmUtemVyby5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9kZmctcGFyc2VJbnRS ZXN1bHQtc2hvdWxkLWNoZWNrLWZvci1uZWdhdGl2ZS16ZXJvLmpzCShub25leGlzdGVudCkKKysr IEpTVGVzdHMvc3RyZXNzL2RmZy1wYXJzZUludFJlc3VsdC1zaG91bGQtY2hlY2stZm9yLW5lZ2F0 aXZlLXplcm8uanMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxMyBAQAorZnVuY3Rpb24gYXNz ZXJ0RXEoeCwgeSkgeworICAgIGlmICh4ICE9IHkpCisgICAgICAgIHRocm93ICJGQUlMRUQ6IGV4 cGVjdCAiICsgeSArICIsIGFjdHVhbCAiICsgeDsKK30KK25vSW5saW5lKGFzc2VydEVxKTsKKwor ZnVuY3Rpb24gdGVzdCgpIHsKKyAgICBhc3NlcnRFcSgxLjAgLyBwYXJzZUludCgiLTAuMCIpLCAi LUluZmluaXR5Iik7Cit9Citub0lubGluZSh0ZXN0KTsKKworZm9yIChsZXQgaSA9IDA7IGkgPCAx MDAwMDsgKytpKQorICAgIHRlc3QoKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFu Z2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2 aXNpb24gMjgwMDI4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA3LTE5ICBNYXJrIExhbSAgPG1hcmsubGFt QGFwcGxlLmNvbT4KKworICAgICAgICBERkcncyBwYXJzZUludFJlc3VsdCgpIHNob3VsZCBjaGVj ayBmb3IgbmVnYXRpdmUgemVyby4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIyODA2OAorICAgICAgICByZGFyOi8vODA3ODg2MDMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBoYXZlIHRvIGNoZWNrIGZv ciBuZWdhdGl2ZSB6ZXJvIGV4cGxpY2l0bHkgYmVjYXVzZSBDKysgZXZhbHVhdGVzIDAuMCA9PSAt MC4wCisgICAgICAgIGFzIHRydWUuCisKKyAgICAgICAgKiBkZmcvREZHT3BlcmF0aW9ucy5jcHA6 CisgICAgICAgIChKU0M6OkRGRzo6cGFyc2VJbnRSZXN1bHQpOgorCiAyMDIxLTA3LTE2ICBZaWpp YSBIdWFuZyAgPHlpamlhX2h1YW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgRXh0ZW5kVHlw ZSB0byBBaXI6OkFyZyBJbmRleCB0byBmdWxseSB1dGlsaXplIGFkZHJlc3MgY29tcHV0YXRpb24g aW4gbWVtb3J5IGluc3RydWN0aW9uIGZvciBBUk02NApJbmRleDogU291cmNlL0phdmFTY3JpcHRD b3JlL2RmZy9ERkdPcGVyYXRpb25zLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvZGZnL0RGR09wZXJhdGlvbnMuY3BwCShyZXZpc2lvbiAyODAwMjgpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR09wZXJhdGlvbnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0y MDIsOCArMjAyLDEwIEBAIHN0YXRpYyBBTFdBWVNfSU5MSU5FIHZvaWQgcHV0V2l0aFRoaXMoSlMK IHN0YXRpYyBBTFdBWVNfSU5MSU5FIEVuY29kZWRKU1ZhbHVlIHBhcnNlSW50UmVzdWx0KGRvdWJs ZSBpbnB1dCkKIHsKICAgICBpbnQgYXNJbnQgPSBzdGF0aWNfY2FzdDxpbnQ+KGlucHV0KTsKLSAg ICBpZiAoc3RhdGljX2Nhc3Q8ZG91YmxlPihhc0ludCkgPT0gaW5wdXQpCi0gICAgICAgIHJldHVy biBKU1ZhbHVlOjplbmNvZGUoanNOdW1iZXIoYXNJbnQpKTsKKyAgICBpZiAoc3RhdGljX2Nhc3Q8 ZG91YmxlPihhc0ludCkgPT0gaW5wdXQpIHsKKyAgICAgICAgaWYgKGFzSW50IHx8ICFzdGQ6OnNp Z25iaXQoaW5wdXQpKQorICAgICAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc051bWJl cihhc0ludCkpOworICAgIH0KICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzTnVtYmVyKGlu cHV0KSk7CiB9CiAK 433830 2021-07-19 15:44:25 -0700 2021-07-19 15:44:25 -0700 patch for landing. bug-228068.patch text/plain 2639 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyODAwNTEpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDIxLTA3LTE5ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBERkcncyBwYXJzZUludFJlc3VsdCgpIHNob3VsZCBjaGVjayBmb3IgbmVn YXRpdmUgemVyby4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIyODA2OAorICAgICAgICByZGFyOi8vODA3ODg2MDMKKworICAgICAgICBSZXZpZXdlZCBi eSBZdXN1a2UgU3V6dWtpLgorCisgICAgICAgICogc3RyZXNzL2RmZy1wYXJzZUludFJlc3VsdC1z aG91bGQtY2hlY2stZm9yLW5lZ2F0aXZlLXplcm8uanM6IEFkZGVkLgorCiAyMDIxLTA3LTE5ICBZ dXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10gSW5CeVN0 YXR1cyAvIEluQnlWYXJpYW50IHNob3VsZCB2aXNpdCBDYWNoZWFibGVJZGVudGlmaWVyCkluZGV4 OiBKU1Rlc3RzL3N0cmVzcy9kZmctcGFyc2VJbnRSZXN1bHQtc2hvdWxkLWNoZWNrLWZvci1uZWdh dGl2ZS16ZXJvLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL2RmZy1wYXJzZUludFJl c3VsdC1zaG91bGQtY2hlY2stZm9yLW5lZ2F0aXZlLXplcm8uanMJKG5vbmV4aXN0ZW50KQorKysg SlNUZXN0cy9zdHJlc3MvZGZnLXBhcnNlSW50UmVzdWx0LXNob3VsZC1jaGVjay1mb3ItbmVnYXRp dmUtemVyby5qcwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDEzIEBACitmdW5jdGlvbiBhc3Nl cnRFcSh4LCB5KSB7CisgICAgaWYgKHggIT0geSkKKyAgICAgICAgdGhyb3cgIkZBSUxFRDogZXhw ZWN0ICIgKyB5ICsgIiwgYWN0dWFsICIgKyB4OworfQorbm9JbmxpbmUoYXNzZXJ0RXEpOworCitm dW5jdGlvbiB0ZXN0KCkgeworICAgIGFzc2VydEVxKDEuMCAvIHBhcnNlSW50KCItMC4wIiksICIt SW5maW5pdHkiKTsKK30KK25vSW5saW5lKHRlc3QpOworCitmb3IgKGxldCBpID0gMDsgaSA8IDEw MDAwOyArK2kpCisgICAgdGVzdCgpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5n ZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZp c2lvbiAyODAwNTEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMDctMTkgIE1hcmsgTGFtICA8bWFyay5sYW1A YXBwbGUuY29tPgorCisgICAgICAgIERGRydzIHBhcnNlSW50UmVzdWx0KCkgc2hvdWxkIGNoZWNr IGZvciBuZWdhdGl2ZSB6ZXJvLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjI4MDY4CisgICAgICAgIHJkYXI6Ly84MDc4ODYwMworCisgICAgICAgIFJl dmlld2VkIGJ5IFl1c3VrZSBTdXp1a2kuCisKKyAgICAgICAgV2UgaGF2ZSB0byBjaGVjayBmb3Ig bmVnYXRpdmUgemVybyBleHBsaWNpdGx5IGJlY2F1c2UgQysrIGV2YWx1YXRlcyAwLjAgPT0gLTAu MAorICAgICAgICBhcyB0cnVlLgorCisgICAgICAgICogZGZnL0RGR09wZXJhdGlvbnMuY3BwOgor ICAgICAgICAoSlNDOjpERkc6OnBhcnNlSW50UmVzdWx0KToKKwogMjAyMS0wNy0xOSAgWXVzdWtl IFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFtKU0NdIEluQnlTdGF0dXMg LyBJbkJ5VmFyaWFudCBzaG91bGQgdmlzaXQgQ2FjaGVhYmxlSWRlbnRpZmllcgpJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPcGVyYXRpb25zLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09wZXJhdGlvbnMuY3BwCShyZXZpc2lvbiAyODAw NTEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09wZXJhdGlvbnMuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0yMDIsNyArMjAyLDcgQEAgc3RhdGljIEFMV0FZU19JTkxJTkUgdm9pZCBw dXRXaXRoVGhpcyhKUwogc3RhdGljIEFMV0FZU19JTkxJTkUgRW5jb2RlZEpTVmFsdWUgcGFyc2VJ bnRSZXN1bHQoZG91YmxlIGlucHV0KQogewogICAgIGludCBhc0ludCA9IHN0YXRpY19jYXN0PGlu dD4oaW5wdXQpOwotICAgIGlmIChzdGF0aWNfY2FzdDxkb3VibGU+KGFzSW50KSA9PSBpbnB1dCkK KyAgICBpZiAoTElLRUxZKHN0YXRpY19jYXN0PGRvdWJsZT4oYXNJbnQpID09IGlucHV0ICYmIChh c0ludCB8fCAhc3RkOjpzaWduYml0KGlucHV0KSkpKQogICAgICAgICByZXR1cm4gSlNWYWx1ZTo6 ZW5jb2RlKGpzTnVtYmVyKGFzSW50KSk7CiAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc051 bWJlcihpbnB1dCkpOwogfQo=