228063 2021-07-18 13:04:53 -0700 Ignore weak external symbols in clang coverage builds using check-for-weak-vtables-and-externals 2021-07-18 18:21:51 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 226562 226684 1 ddkilzer ddkilzer darin jbedard webkit-bug-importer youennf oldest_to_newest 1777774 0 ddkilzer 2021-07-18 13:04:53 -0700 Ignore weak external symbols in clang coverage builds using check-for-weak-vtables-and-externals. It turns out that -exported_symbol and -unexported_symbol can't be used together when linking: ld: can't use -unexported_symbol and -exported_symbol clang: error: linker command failed with exit code 1 (use -v to see invocation) So go back to the solution from Bug 226562 (effectively reverting the change for Bug 226684). <rdar://problem/80477138> 1777775 1 433757 ddkilzer 2021-07-18 13:13:59 -0700 Created attachment 433757 Patch v1 1777776 2 ddkilzer 2021-07-18 13:15:10 -0700 Note that the libwebrtc project was the first project failing with a coverage build before this change. 1777790 3 ews-feeder 2021-07-18 15:59:35 -0700 Committed r280021 (239763@main): <https://commits.webkit.org/239763@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433757. 433757 2021-07-18 13:13:59 -0700 2021-07-18 18:21:51 -0700 Patch v1 bug-228063-20210718131354.patch text/plain 2621 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5ODU0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGQ0OWQzMDZmNWM2MTYwMWJiOTFmNjk2ZjlhYmFlMzEx ZGZhOTA4MC4uNjZiNGEwYmExMDJhN2Y5NDE5MGI5MWEzNzU0N2ZkMjQ1ZDVmY2NlMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDIxLTA3LTE4ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgSWdub3JlIHdlYWsgZXh0ZXJuYWwgc3ltYm9scyBpbiBjbGFuZyBjb3ZlcmFnZSBidWls ZHMgdXNpbmcgY2hlY2stZm9yLXdlYWstdnRhYmxlcy1hbmQtZXh0ZXJuYWxzCisgICAgICAgIDxo dHRwczovL3dlYmtpdC5vcmcvYi8yMjgwNjM+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84MDQ3 NzEzOD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFNjcmlwdHMvY2hlY2stZm9yLXdlYWstdnRhYmxlcy1hbmQtZXh0ZXJuYWxzOgorICAgICAgICAt IElnbm9yZSB3ZWFrIHN5bWJvbHMgZnJvbSBsbHZtIHdoZW4gYnVpbGRpbmcgd2l0aAorICAgICAg ICAgIGNvdmVyYWdlIGVuYWJsZWQuICBUaGlzIGZpeGVzIHRoZSBidWlsZC4KKyAgICAgICAgKiBj b3ZlcmFnZS9jb3ZlcmFnZS54Y2NvbmZpZzoKKyAgICAgICAgKFVORVhQT1JURURfU1lNQk9MX0xE RkxBR1NfRk9SX0NPVkVSQUdFKTogUmVtb3ZlLgorICAgICAgICAtIENhbid0IHVzZSAtdW5leHBv cnRlZF9zeW1ib2wgYW5kIC1leHBvcnRlZF9zeW1ib2wKKyAgICAgICAgICB0b2dldGhlciwgc28g cmVtb3ZlIHRoaXMuCisKIDIwMjEtMDctMTIgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBh cHBsZS5jb20+CiAKICAgICAgICAgQmlmdXJjYXRlZEdyYXBoaWNzQ29udGV4dCBjYW4ndCBkcmF3 IHRleHQKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvY2hlY2stZm9yLXdlYWstdnRhYmxlcy1h bmQtZXh0ZXJuYWxzIGIvVG9vbHMvU2NyaXB0cy9jaGVjay1mb3Itd2Vhay12dGFibGVzLWFuZC1l eHRlcm5hbHMKaW5kZXggOGJjZGVlMjg3ODJlOWZmMmQ2Njk3ODU2YWNhNjAxNjA0ZjY2ODU5OC4u NDhkNjVmMTAzZGJkODMwMWQxOWVkNWI1YTI0YmUxZTRmMTA2NmEwYyAxMDA3NTUKLS0tIGEvVG9v bHMvU2NyaXB0cy9jaGVjay1mb3Itd2Vhay12dGFibGVzLWFuZC1leHRlcm5hbHMKKysrIGIvVG9v bHMvU2NyaXB0cy9jaGVjay1mb3Itd2Vhay12dGFibGVzLWFuZC1leHRlcm5hbHMKQEAgLTY4LDYg KzY4LDkgQEAgaWYgKCFkZWZpbmVkICRleGVjdXRhYmxlUGF0aEFnZSB8fCAhZGVmaW5lZCAkYnVp bGRUaW1lc3RhbXBBZ2UgfHwgJGV4ZWN1dGFibGVQYXQKICAgICAgICAgICAgICMgQVNhbiBjb21w aWxlci1ydCBjYWxscyBpbnRvIF9fYXNhbl9tYXBwaW5nX29mZnNldCBhbmQgX19hc2FuX21hcHBp bmdfc2NhbGUKICAgICAgICAgICAgIG5leHQgaWYgL1xiX19fYXNhbi87CiAKKyAgICAgICAgICAg ICMgSWdub3JlIHdlYWsgc3ltYm9scyBwcmVzZW50IHdoZW4gY29tcGlsaW5nIHdpdGggY292ZXJh Z2UgZW5hYmxlZC4KKyAgICAgICAgICAgIG5leHQgaWYgL1xiKF9fX2xsdm1fcHJvZmlsZV9maWxl bmFtZXxfX19sbHZtX3Byb2ZpbGVfcmF3X3ZlcnNpb258X2xwcm9mRGlyTW9kZSkvICYmIGNvdmVy YWdlSXNFbmFibGVkKCk7CisKICAgICAgICAgICAgIGlmICgvd2VhayBleHRlcm5hbCB2dGFibGUg Zm9yICguKikkLykgewogICAgICAgICAgICAgICAgIHB1c2ggQHdlYWtWVGFibGVDbGFzc2VzLCAk MTsKICAgICAgICAgICAgIH0gZWxzaWYgKC93ZWFrIGV4dGVybmFsICguKikkLykgewpkaWZmIC0t Z2l0IGEvVG9vbHMvY292ZXJhZ2UvY292ZXJhZ2UueGNjb25maWcgYi9Ub29scy9jb3ZlcmFnZS9j b3ZlcmFnZS54Y2NvbmZpZwppbmRleCBkYTU0YzE4YjZjNWJmZjEyNjBlMmFmNzk1MzZkNTY3NjA0 N2IwZTU0Li4wZWYyMmMxN2Y3MmY2MTg2NGY5YzJmMzg5ZWRiNDE4MGFiODFjN2E3IDEwMDY0NAot LS0gYS9Ub29scy9jb3ZlcmFnZS9jb3ZlcmFnZS54Y2NvbmZpZworKysgYi9Ub29scy9jb3ZlcmFn ZS9jb3ZlcmFnZS54Y2NvbmZpZwpAQCAtMSw1ICsxLDIgQEAKLS8vIFVuZXhwb3J0IHdlYWsgZXh0 ZXJuYWwgc3ltYm9scyBmcm9tIGxsdm0gY292ZXJhZ2UuCi1VTkVYUE9SVEVEX1NZTUJPTF9MREZM QUdTX0ZPUl9DT1ZFUkFHRSA9IC1XbCwtdW5leHBvcnRlZF9zeW1ib2wgLVdsLF9fX2xsdm1fcHJv ZmlsZV9maWxlbmFtZSAtV2wsLXVuZXhwb3J0ZWRfc3ltYm9sIC1XbCxfX19sbHZtX3Byb2ZpbGVf cmF3X3ZlcnNpb24gLVdsLC11bmV4cG9ydGVkX3N5bWJvbCAtV2wsX2xwcm9mRGlyTW9kZTsKLQog T1RIRVJfQ0ZMQUdTID0gJChpbmhlcml0ZWQpIC1mcHJvZmlsZS1pbnN0ci1nZW5lcmF0ZSAtZmNv dmVyYWdlLW1hcHBpbmc7Ci1PVEhFUl9MREZMQUdTID0gJChpbmhlcml0ZWQpIC1mcHJvZmlsZS1p bnN0ci1nZW5lcmF0ZSAkKFVORVhQT1JURURfU1lNQk9MX0xERkxBR1NfRk9SX0NPVkVSQUdFKTsK K09USEVSX0xERkxBR1MgPSAkKGluaGVyaXRlZCkgLWZwcm9maWxlLWluc3RyLWdlbmVyYXRlOwo=