22804 2008-12-10 22:58:09 -0800 Crash (null-deref) when using :before pseudoselector with content CSS rule in SVG 2008-12-11 14:34:16 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED HasReduction, InRadar P2 Normal --- 1 oliver oliver oldest_to_newest 102208 0 oliver 2008-12-10 22:58:09 -0800 CSS generated content results in a RenderObject with no element, causing SVG text layout and painting to crash and burn <rdar://problem/6302405> 102209 1 25941 oliver 2008-12-10 22:58:59 -0800 Created attachment 25941 Patch o' doom Fixeration 102220 2 25941 adele 2008-12-11 01:44:03 -0800 Comment on attachment 25941 Patch o' doom R=me. I assume the CL entries for Info.plist and the Xcode proj don't belong... 102221 3 oliver 2008-12-11 01:51:58 -0800 (In reply to comment #2) > (From update of attachment 25941 [review]) > R=me. I assume the CL entries for Info.plist and the Xcode proj don't > belong... > Yup *sigh* Also, have better text in the test now -- says something akin to "This test ensures that we don't display css content or crash when css generated content is used" 102282 4 oliver 2008-12-11 14:34:16 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog A LayoutTests/svg/css/crash-css-generated-content-expected.txt A LayoutTests/svg/css/crash-css-generated-content.xhtml M WebCore/ChangeLog M WebCore/rendering/SVGRootInlineBox.cpp Committed r39218 25941 2008-12-10 22:58:59 -0800 2008-12-11 01:44:03 -0800 Patch o' doom svg-css-generated-content-crash.patch text/plain 4788 oliver ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA4N2M3YWM1Li45NDIzMDhhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgtMTIt MTAgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjMwMjQwNT4gQ3Jh c2ggKG51bGwtZGVyZWYpIHdoZW4gdXNpbmcgOmJlZm9yZSBwc2V1ZG9zZWxlY3RvciB3aXRoIGNv bnRlbnQgQ1NTIHJ1bGUgaW4gU1ZHCisKKyAgICAgICAgVGVzdCB0byBtYWtlIHN1cmUgd2UgZG9u J3QgY3Jhc2gsIGFuZCBkb24ndCBkaXNwbGF5IGdlbmVyYXRlZCBjb250ZW50LgorCisgICAgICAg ICogc3ZnL2Nzcy9jcmFzaC1jc3MtZ2VuZXJhdGVkLWNvbnRlbnQtZXhwZWN0ZWQudHh0OiBBZGRl ZC4KKyAgICAgICAgKiBzdmcvY3NzL2NyYXNoLWNzcy1nZW5lcmF0ZWQtY29udGVudC54aHRtbDog QWRkZWQuCisKIDIwMDgtMTItMTAgIE5pa29sYXMgWmltbWVybWFubiAgPG5pa29sYXMuemltbWVy bWFubkB0b3JjaG1vYmlsZS5jb20+CiAKICAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkgR2Vvcmdl IFN0YWlrb3MuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zdmcvY3NzL2NyYXNoLWNzcy1nZW5l cmF0ZWQtY29udGVudC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9zdmcvY3NzL2NyYXNoLWNz cy1nZW5lcmF0ZWQtY29udGVudC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMC4uNjljZmM1YQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3N2Zy9j c3MvY3Jhc2gtY3NzLWdlbmVyYXRlZC1jb250ZW50LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDIg QEAKK1BBU1MKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3ZnL2Nzcy9jcmFzaC1jc3MtZ2Vu ZXJhdGVkLWNvbnRlbnQueGh0bWwgYi9MYXlvdXRUZXN0cy9zdmcvY3NzL2NyYXNoLWNzcy1nZW5l cmF0ZWQtY29udGVudC54aHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5m YzQ2MGI1Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvc3ZnL2Nzcy9jcmFzaC1jc3Mt Z2VuZXJhdGVkLWNvbnRlbnQueGh0bWwKQEAgLTAsMCArMSwyNCBAQAorPCFET0NUWVBFIGh0bWwK KyAgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjAgU3RyaWN0Ly9FTiIKKyAgImh0dHA6Ly93 d3cudzMub3JnL1RSL3hodG1sMS9EVEQveGh0bWwxLXN0cmljdC5kdGQiPgorPGh0bWwgbGFuZz0i ZW4tVVMiIHhtbDpsYW5nPSJlbi1VUyIgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0 bWwiPgorICAgIDxzdHlsZT4KKyAgICAgICAgc3ZnIHRleHQ6YmVmb3JlIHsKKyAgICAgICAgICAg IGNvbnRlbnQ6ICdGQUlMJzsKKyAgICAgICAgfQorICAgIDwvc3R5bGU+CisgICAgPGhlYWQ+Cisg ICAgICAgIDx0aXRsZT5UZXN0IGNhc2UgZm9yIHJkYXI6Ly82MzAyNDA1PC90aXRsZT4KKyAgICA8 L2hlYWQ+CisgICAgPGJvZHk+CisgICAgICAgIDxzdmcgeG1sbnM9Imh0dHA6Ly93d3cudzMub3Jn LzIwMDAvc3ZnIiB4bWxuczp4bGluaz0iaHR0cDovL3d3dy53My5vcmcvMTk5OS94bGluayI+Cisg ICAgICAgICAgICA8dGV4dCB4PSI1MCIgeT0iNTAiPlBBU1M8L3RleHQ+CisgICAgICAgIDwvc3Zn PgorICAgICAgICA8c2NyaXB0PgorICAgICAgICA8IVtDREFUQVsKKyAgICAgICAgICAgIGlmICh3 aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgICAgICAgICAgbGF5b3V0VGVzdENv bnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAgICAgICBdXT4KKyAgICAgICAgPC9zY3JpcHQ+Cisg ICAgPC9ib2R5PgorPC9odG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKZGlmZiAtLWdp dCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDI4NGZmYy4u M2EyOWQzYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAwOC0xMi0xMCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJA YXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS82MzAyNDA1PiBDcmFzaCAobnVsbC1kZXJlZikgd2hlbiB1c2lu ZyA6YmVmb3JlIHBzZXVkb3NlbGVjdG9yIHdpdGggY29udGVudCBDU1MgcnVsZSBpbiBTVkcKKwor ICAgICAgICBUaGlzIGlzc3VlIHdhcyBjYXVzZWQgYnkgY3NzIGdlbmVyYXRlZCBjb250ZW50IHJl c3VsdGluZyBpbiBub24tc3ZnIGZsb3dib3hlcworICAgICAgICBiZWluZyBpbmplY3RlZCBpbnRv IFNWRyBjb250ZW50LiAgQXMgU1ZHIHNwZWMgZG9lcyBub3QgZGVzY3JpYmUgYmVoYXZpb3VyIGlu CisgICAgICAgIHRoaXMgY2FzZSwgYW5kIG5laXRoZXIgT3BlcmEgbm9yIEZpcmVmb3ggZGlzcGxh eXMgc3VjaCBnZW5lcmF0ZWQgY29udGVudCwgc28KKyAgICAgICAgbm93IHdlIG1ha2Ugc3ZnIHRl eHQgbGF5b3V0IGFuZCByZW5kZXJpbmcganVzdCBpZ25vcmUgYW55IHN1Y2ggY29udGVudC4KKwor ICAgICAgICBUZXN0OiBzdmcvY3NzL2NyYXNoLWNzcy1nZW5lcmF0ZWQtY29udGVudC54aHRtbAor CisgICAgICAgICogSW5mby5wbGlzdDoKKyAgICAgICAgKiBXZWJDb3JlLnhjb2RlcHJvai9wcm9q ZWN0LnBieHByb2o6CisgICAgICAgICogcmVuZGVyaW5nL1NWR1Jvb3RJbmxpbmVCb3guY3BwOgor ICAgICAgICAoV2ViQ29yZTo6U1ZHUm9vdElubGluZUJveDo6YnVpbGRMYXlvdXRJbmZvcm1hdGlv bik6CisgICAgICAgIChXZWJDb3JlOjpTVkdSb290SW5saW5lQm94OjpsYXlvdXRJbmxpbmVCb3hl cyk6CisgICAgICAgIChXZWJDb3JlOjpTVkdSb290SW5saW5lQm94OjpidWlsZFRleHRDaHVua3Mp OgorCiAyMDA4LTEyLTEwICBOaWtvbGFzIFppbW1lcm1hbm4gIDxuaWtvbGFzLnppbW1lcm1hbm5A dG9yY2htb2JpbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsIGFuZCBH ZW9yZ2UgU3RhaWtvcy4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1NWR1Jvb3RJbmxp bmVCb3guY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvU1ZHUm9vdElubGluZUJveC5jcHAKaW5kZXgg ZTVmOWZkZi4uZGVjODg0ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvU1ZHUm9vdElu bGluZUJveC5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvU1ZHUm9vdElubGluZUJveC5jcHAK QEAgLTkxNSw2ICs5MTUsOSBAQCB2b2lkIFNWR1Jvb3RJbmxpbmVCb3g6OmJ1aWxkTGF5b3V0SW5m b3JtYXRpb24oSW5saW5lRmxvd0JveCogc3RhcnQsIFNWR0NoYXJhY3RlcgogICAgICAgICAgICAg QVNTRVJUKGN1cnItPmlzSW5saW5lRmxvd0JveCgpKTsKICAgICAgICAgICAgIElubGluZUZsb3dC b3gqIGZsb3dCb3ggPSBzdGF0aWNfY2FzdDxJbmxpbmVGbG93Qm94Kj4oY3Vycik7CiAKKyAgICAg ICAgICAgIGlmICghZmxvd0JveC0+b2JqZWN0KCktPmVsZW1lbnQoKSkKKyAgICAgICAgICAgICAg ICBjb250aW51ZTsgLy8gU2tpcCBnZW5lcmF0ZWQgY29udGVudC4KKwogICAgICAgICAgICAgYm9v bCBpc0FuY2hvciA9IGZsb3dCb3gtPm9iamVjdCgpLT5lbGVtZW50KCktPmhhc1RhZ05hbWUoU1ZH TmFtZXM6OmFUYWcpOwogICAgICAgICAgICAgYm9vbCBpc1RleHRQYXRoID0gZmxvd0JveC0+b2Jq ZWN0KCktPmVsZW1lbnQoKS0+aGFzVGFnTmFtZShTVkdOYW1lczo6dGV4dFBhdGhUYWcpOwogCkBA IC0xMDYyLDYgKzEwNjUsMTAgQEAgdm9pZCBTVkdSb290SW5saW5lQm94OjpsYXlvdXRJbmxpbmVC b3hlcyhJbmxpbmVGbG93Qm94KiBzdGFydCwgVmVjdG9yPFNWR0NoYXI+OjoKICAgICAgICAgICAg IGludCBtYXhZID0gSU5UX01JTjsKIAogICAgICAgICAgICAgSW5saW5lRmxvd0JveCogZmxvd0Jv eCA9IHN0YXRpY19jYXN0PElubGluZUZsb3dCb3gqPihjdXJyKTsKKyAgICAgICAgICAgIAorICAg ICAgICAgICAgaWYgKCFmbG93Qm94LT5vYmplY3QoKS0+ZWxlbWVudCgpKQorICAgICAgICAgICAg ICAgIGNvbnRpbnVlOyAvLyBTa2lwIGdlbmVyYXRlZCBjb250ZW50LgorICAgIAogICAgICAgICAg ICAgbGF5b3V0SW5saW5lQm94ZXMoZmxvd0JveCwgaXQsIG1pblgsIG1heFgsIG1pblksIG1heFkp OwogCiAgICAgICAgICAgICBjdXJyLT5zZXRYUG9zKG1pblggLSBvYmplY3QoKS0+eFBvcygpKTsK QEAgLTE1MTcsNiArMTUyNCw5IEBAIHZvaWQgU1ZHUm9vdElubGluZUJveDo6YnVpbGRUZXh0Q2h1 bmtzKFZlY3RvcjxTVkdDaGFyPiYgc3ZnQ2hhcnMsIElubGluZUZsb3dCb3gqCiAgICAgICAgICAg ICBBU1NFUlQoY3Vyci0+aXNJbmxpbmVGbG93Qm94KCkpOwogICAgICAgICAgICAgSW5saW5lRmxv d0JveCogZmxvd0JveCA9IHN0YXRpY19jYXN0PElubGluZUZsb3dCb3gqPihjdXJyKTsKIAorICAg ICAgICAgICAgaWYgKCFmbG93Qm94LT5vYmplY3QoKS0+ZWxlbWVudCgpKQorICAgICAgICAgICAg ICAgIGNvbnRpbnVlOyAvLyBTa2lwIGdlbmVyYXRlZCBjb250ZW50LgorCiAgICAgICAgICAgICBi b29sIGlzVGV4dFBhdGggPSBmbG93Qm94LT5vYmplY3QoKS0+ZWxlbWVudCgpLT5oYXNUYWdOYW1l KFNWR05hbWVzOjp0ZXh0UGF0aFRhZyk7CiAKICNpZiBERUJVR19DSFVOS19CVUlMRElORyA+IDEK