228038 2021-07-16 15:20:28 -0700 REGRESSION: [iOS] ASSERTION FAILED: !m_messageReceiverMapCount under WebKit::RemoteAudioHardwareListener::~RemoteAudioHardwareListener() 2022-02-12 20:32:28 -0800 1 1 1 Unclassified WebKit Media Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=226248 https://bugs.webkit.org/show_bug.cgi?id=228659 InRadar P2 Normal --- 1 ryanhaddad jer.noble ayumi_kojima cdumez eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bot-watchers-bugzilla webkit-bug-importer youennf oldest_to_newest 1777624 0 ryanhaddad 2021-07-16 15:20:28 -0700 ASSERTION FAILED: !m_messageReceiverMapCount /Volumes/Data/worker/ios-simulator-14-debug/build/Source/WebKit/Platform/IPC/MessageReceiver.h(41) : virtual IPC::MessageReceiver::~MessageReceiver() 1 0x1255e53d9 WTFCrash 2 0x10bf5c46b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x10bfa1478 IPC::MessageReceiver::~MessageReceiver() 4 0x10dc60e1e WebKit::RemoteAudioHardwareListener::~RemoteAudioHardwareListener() 5 0x10dc60f65 WebKit::RemoteAudioHardwareListener::~RemoteAudioHardwareListener() 6 0x10dc60fcc WebKit::RemoteAudioHardwareListener::~RemoteAudioHardwareListener() 7 0x12e47249f std::__1::default_delete<WebCore::AudioHardwareListener>::operator()(WebCore::AudioHardwareListener*) const 8 0x12e472462 WTF::RefCounted<WebCore::AudioHardwareListener, std::__1::default_delete<WebCore::AudioHardwareListener> >::deref() const 9 0x12e4723e7 WTF::DefaultRefDerefTraits<WebCore::AudioHardwareListener>::derefIfNotNull(WebCore::AudioHardwareListener*) 10 0x12fad96c4 WTF::RefPtr<WebCore::AudioHardwareListener, WTF::RawPtrTraits<WebCore::AudioHardwareListener>, WTF::DefaultRefDerefTraits<WebCore::AudioHardwareListener> >::operator=(std::nullptr_t) 11 0x12fad967e WebCore::MediaSessionManagerCocoa::removeSession(WebCore::PlatformMediaSession&) 12 0x13222c86f WebCore::PlatformMediaSession::stopSession() 13 0x131583c9c WebCore::HTMLMediaElement::stop() 14 0x1311cc7ad auto WebCore::ScriptExecutionContext::stopActiveDOMObjects()::$_3::operator()<WebCore::ActiveDOMObject>(WebCore::ActiveDOMObject&) const 15 0x1311cc743 WTF::Detail::CallableWrapper<WebCore::ScriptExecutionContext::stopActiveDOMObjects()::$_3, WebCore::ScriptExecutionContext::ShouldContinue, WebCore::ActiveDOMObject&>::call(WebCore::ActiveDOMObject&) 16 0x1311b4ffa WTF::Function<WebCore::ScriptExecutionContext::ShouldContinue (WebCore::ActiveDOMObject&)>::operator()(WebCore::ActiveDOMObject&) const 17 0x1311b4e50 WebCore::ScriptExecutionContext::forEachActiveDOMObject(WTF::Function<WebCore::ScriptExecutionContext::ShouldContinue (WebCore::ActiveDOMObject&)> const&) const 18 0x1311b5367 WebCore::ScriptExecutionContext::stopActiveDOMObjects() 19 0x130f7423f WebCore::Document::stopActiveDOMObjects() 20 0x130f73fdc WebCore::Document::commonTeardown() 21 0x130f814b4 WebCore::Document::willBeRemovedFromFrame() 22 0x131f28803 WebCore::Frame::setView(WTF::RefPtr<WebCore::FrameView, WTF::RawPtrTraits<WebCore::FrameView>, WTF::DefaultRefDerefTraits<WebCore::FrameView> >&&) 23 0x131cecace WebCore::FrameLoader::closeAndRemoveChild(WebCore::Frame&) 24 0x131cec9d3 WebCore::FrameLoader::detachFromParent() 25 0x131cdfaca WebCore::FrameLoader::detachChildren() 26 0x131cec93c WebCore::FrameLoader::detachFromParent() 27 0x131ced16d WebCore::FrameLoader::frameDetached() 28 0x13151f959 WebCore::HTMLFrameOwnerElement::disconnectContentFrame() 29 0x130f1e401 WebCore::disconnectSubframes(WebCore::ContainerNode&, WebCore::SubframeDisconnectPolicy) 30 0x130f19585 WebCore::disconnectSubframesIfNeeded(WebCore::ContainerNode&, WebCore::SubframeDisconnectPolicy) 31 0x130f15efd WebCore::ContainerNode::removeAllChildrenWithScriptAssertion(WebCore::ContainerNode::ChildChange::Source, WebCore::ContainerNode::DeferChildrenChanged) The assert is attributed to the following tests on an iOS simulator debug test run: fast/events/tabindex-focus-blur-all.html media/modern-media-controls/media-documents/media-document-video-with-initial-audio-layout.html media/modern-media-controls/mute-button/mute-button.html media/non-existent-video-playback-interrupted.html https://build.webkit.org/results/Apple-iOS-14-Simulator-Debug-WK2-Tests/r279988%20(2025)/results.html 1777625 1 webkit-bug-importer 2021-07-16 15:20:46 -0700 <rdar://problem/80705471> 1777626 2 ryanhaddad 2021-07-16 15:22:32 -0700 Looks like this is a flaky crash that happens with various tests: https://build.webkit.org/results/Apple-iOS-14-Simulator-Debug-WK2-Tests/r279992%20(2026)/results.html fast/mediastream/audio-bad-sampleRate.html media/media-can-play-av1.html media/modern-media-controls/media-documents/media-document-video-with-initial-audio-layout.html media/modern-media-controls/mute-button/mute-button.html 1778269 3 ayumi_kojima 2021-07-20 13:43:08 -0700 The same crash is seen with fast/mediastream/apply-constraints-video.html History: https://results.webkit.org/?suite=layout-tests&test=fast%2Fmediastream%2Fapply-constraints-video.html https://build.webkit.org/results/Apple-iPadOS-14-Simulator-Debug-WK2-Tests/r279869%20(1386)/fast/mediastream/apply-constraints-video-crash-log.txt 1778277 4 ryanhaddad 2021-07-20 13:57:28 -0700 This could be related to https://trac.webkit.org/changeset/279584/webkit 1778329 5 ap 2021-07-20 18:05:00 -0700 *** Bug 228111 has been marked as a duplicate of this bug. *** 1778333 6 ap 2021-07-20 18:08:28 -0700 *** Bug 228117 has been marked as a duplicate of this bug. *** 1778612 7 ryanhaddad 2021-07-21 17:06:47 -0700 From one of the dupes, this apparently reproduced the crash: run-webkit-tests --iterations 50 --exit-after-n-failures 2 --exit-after-n-crashes-or-timeouts 2 fast/mediastream/apply-constraints-video.html --debug -f --iphone-simulator 1778626 8 ap 2021-07-21 18:15:26 -0700 *** Bug 228167 has been marked as a duplicate of this bug. *** 1778792 9 ayumi_kojima 2021-07-22 12:17:52 -0700 In the meantime, updated test expectations for 7 tests here https://trac.webkit.org/changeset/280192/webkit 1778838 10 jer.noble 2021-07-22 14:34:07 -0700 RemoteAudioHardwareListener holds a WeakRef to the holder of its MessageReceiverMap, GPUProcessConnection. If GPUProcessConnection is destroyed before RemoteAudioHardwareListener is, then the listener will never get a chance to remove itself from the GPUProcessConnection map, and will hit this assertion. 1778850 11 ayumi_kojima 2021-07-22 15:01:26 -0700 Tried to reproduce the crash again on fast/mediastream/apply-constraints-video.html, but I was not able to reproduce the crash on arm64 remote machine with iOS 14 simulator using: run-webkit-tests --iterations 50 --exit-after-n-failures 2 --exit-after-n-crashes-or-timeouts 2 fast/mediastream/apply-constraints-video.html --debug -f --iphone-simulator run-webkit-tests --no-build --clobber-old-results --exit-after-n-failures 500 --exit-after-n-crashes-or-timeouts 500 --debug -f --force --iphone-simulator --child-processes 1 --test-list <testlist> 1779213 12 ayumi_kojima 2021-07-23 15:55:19 -0700 media/media-blocked-by-willsendrequest.html Also shows the same crash (ASSERTION FAILED: !m_messageReceiverMapCount) History: https://results.webkit.org/?suite=layout-tests&test=media%2Fmedia-blocked-by-willsendrequest.html Updated test expectations: https://trac.webkit.org/changeset/280266/webkit 1779572 13 434240 jer.noble 2021-07-26 14:24:52 -0700 Created attachment 434240 Patch 1779577 14 434242 jer.noble 2021-07-26 14:33:39 -0700 Created attachment 434242 Patch 1779591 15 434240 cdumez 2021-07-26 15:01:54 -0700 Comment on attachment 434240 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434240&action=review > Source/WebKit/WebProcess/GPU/media/RemoteAudioHardwareListener.cpp:69 > + m_gpuProcessConnection->messageReceiverMap().removeMessageReceiver(*this); Don't we want to null out m_gpuProcessConnection too to make sure that the RemoteAudioHardwareListener destructor doesn't attempt to do the same thing if the GPUProcessConnection is still alive? I think it would likely hit assertions if we called messageReceiverMap().removeMessageReceiver(*this) unnecessarily. 1779598 16 434240 jer.noble 2021-07-26 15:19:27 -0700 Comment on attachment 434240 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434240&action=review >> Source/WebKit/WebProcess/GPU/media/RemoteAudioHardwareListener.cpp:69 >> + m_gpuProcessConnection->messageReceiverMap().removeMessageReceiver(*this); > > Don't we want to null out m_gpuProcessConnection too to make sure that the RemoteAudioHardwareListener destructor doesn't attempt to do the same thing if the GPUProcessConnection is still alive? I think it would likely hit assertions if we called messageReceiverMap().removeMessageReceiver(*this) unnecessarily. Sure, this would also protect against this close method from being called twice (accidentally). 1779599 17 434248 jer.noble 2021-07-26 15:20:47 -0700 Created attachment 434248 Patch 1779638 18 ews-feeder 2021-07-26 17:06:59 -0700 Committed r280328 (239975@main): <https://commits.webkit.org/239975@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434248. 1780273 19 ayumi_kojima 2021-07-28 17:11:17 -0700 *** Bug 228570 has been marked as a duplicate of this bug. *** 1807368 20 ayumi_kojima 2021-10-21 14:43:58 -0700 Removed test expectations https://trac.webkit.org/changeset/284647/webkit 1840863 21 bfulgham 2022-02-12 20:32:28 -0800 *** Bug 228667 has been marked as a duplicate of this bug. *** 434240 2021-07-26 14:24:52 -0700 2021-07-26 15:20:45 -0700 Patch bug-228038-20210726142451.patch text/plain 1974 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5OTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDU2ZjcwZjM3MjAzNjhkNGY4 NDZlOWQyOTIyZmVhNDI5OTlmNmQ4Y2IuLmE0YWRlMzhiYzkxOGY5ZTkyNWU2NmM3MDcwYjU5NDI0 MWIxOTcxMjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMDctMjYgIEplciBOb2Js ZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTjogW2lPU10gQVNT RVJUSU9OIEZBSUxFRDogIW1fbWVzc2FnZVJlY2VpdmVyTWFwQ291bnQgdW5kZXIgV2ViS2l0OjpS ZW1vdGVBdWRpb0hhcmR3YXJlTGlzdGVuZXI6On5SZW1vdGVBdWRpb0hhcmR3YXJlTGlzdGVuZXIo KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI4MDM4 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84MDcwNTQ3MT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgUmVtb3RlQXVkaW9IYXJkd2FyZUxp c3RlbmVyIGZyb20gdGhlIEdQVVByb2Nlc3NDb25uZWN0aW9uIG1lc3NhZ2VNYXAgd2hlbiB0aGUg Y29ubmVjdGlvbiBjbG9zZXMuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL0dQVS9tZWRpYS9SZW1v dGVBdWRpb0hhcmR3YXJlTGlzdGVuZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpSZW1vdGVBdWRp b0hhcmR3YXJlTGlzdGVuZXI6OmdwdVByb2Nlc3NDb25uZWN0aW9uRGlkQ2xvc2UpOgorCiAyMDIx LTA3LTI2ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JF U1NJT046IFtpT1NdIEFTU0VSVElPTiBGQUlMRUQ6ICFtX3VzZUNvdW50IGluIFdlYktpdDo6U2Fu ZGJveEV4dGVuc2lvbjo6flNhbmRib3hFeHRlbnNpb24oKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9XZWJQcm9jZXNzL0dQVS9tZWRpYS9SZW1vdGVBdWRpb0hhcmR3YXJlTGlzdGVuZXIuY3Bw IGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0dQVS9tZWRpYS9SZW1vdGVBdWRpb0hhcmR3YXJl TGlzdGVuZXIuY3BwCmluZGV4IDZiYzkwYmI4NmQ4YmI1YmI2YjgyNTRjMTk4ODZhNTljMTk1OGJk YzYuLjg5M2M0Mjg5NjA2OTliZTdmMzUxYzg1NWEzOGY4NjlmMjQ0ZDZiNTAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvbWVkaWEvUmVtb3RlQXVkaW9IYXJkd2FyZUxp c3RlbmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BVL21lZGlhL1JlbW90 ZUF1ZGlvSGFyZHdhcmVMaXN0ZW5lci5jcHAKQEAgLTYwLDkgKzYwLDEzIEBAIFJlbW90ZUF1ZGlv SGFyZHdhcmVMaXN0ZW5lcjo6flJlbW90ZUF1ZGlvSGFyZHdhcmVMaXN0ZW5lcigpCiAgICAgfQog fQogCi12b2lkIFJlbW90ZUF1ZGlvSGFyZHdhcmVMaXN0ZW5lcjo6Z3B1UHJvY2Vzc0Nvbm5lY3Rp b25EaWRDbG9zZShHUFVQcm9jZXNzQ29ubmVjdGlvbiYpCit2b2lkIFJlbW90ZUF1ZGlvSGFyZHdh cmVMaXN0ZW5lcjo6Z3B1UHJvY2Vzc0Nvbm5lY3Rpb25EaWRDbG9zZShHUFVQcm9jZXNzQ29ubmVj dGlvbiYgY29ubmVjdGlvbikKIHsKICAgICBhdWRpb0hhcmR3YXJlRGlkQmVjb21lSW5hY3RpdmUo KTsKKworICAgIEFTU0VSVF9VTlVTRUQoY29ubmVjdGlvbiwgJmNvbm5lY3Rpb24gPT0gbV9ncHVQ cm9jZXNzQ29ubmVjdGlvbik7CisgICAgaWYgKG1fZ3B1UHJvY2Vzc0Nvbm5lY3Rpb24pCisgICAg ICAgIG1fZ3B1UHJvY2Vzc0Nvbm5lY3Rpb24tPm1lc3NhZ2VSZWNlaXZlck1hcCgpLnJlbW92ZU1l c3NhZ2VSZWNlaXZlcigqdGhpcyk7CiB9CiAKIHZvaWQgUmVtb3RlQXVkaW9IYXJkd2FyZUxpc3Rl bmVyOjphdWRpb0hhcmR3YXJlRGlkQmVjb21lQWN0aXZlKCkK 434242 2021-07-26 14:33:39 -0700 2021-07-26 14:35:07 -0700 Patch bug-228038-20210726143338.patch text/plain 2227 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5OTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDllYzVkMDRiYTk1OTg0MDAw YzEwZGQxOTFhOWRjY2NiZmUyYzhlZjQuLjU2ZjcwZjM3MjAzNjhkNGY4NDZlOWQyOTIyZmVhNDI5 OTlmNmQ4Y2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjEtMDctMjYgIEplciBOb2Js ZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTjogW2lPU10gQVNT RVJUSU9OIEZBSUxFRDogIW1fdXNlQ291bnQgaW4gV2ViS2l0OjpTYW5kYm94RXh0ZW5zaW9uOjp+ U2FuZGJveEV4dGVuc2lvbigpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMjgxNzEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzgwOTI2NTA5PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNhbmRib3hFeHRl bnNpb24gZXhwZWN0cyB0byBiZSByZXZva2VkIGJlZm9yZSBpdCBpcyBkZXN0cm95ZWQsIHNvbWV0 aGluZyB0aGF0IGlzIGRvbmUgYnkKKyAgICAgICAgUmVtb3RlTWVkaWFQbGF5ZXJQcm94eTo6aW52 YWxpZGF0ZSgpLiBIb3dldmVyLCBpbnZhbGlkYXRlKCkgd29uJ3QgYmUgY2FsbGVkIGlmIHRoZSAK KyAgICAgICAgUmVtb3RlTWVkaWFQbGF5ZXJNYW5hZ2VyUHJveHkgaXMgZGVzdHJveWVkIGJlZm9y ZSBhbGwgaXRzIHByb3hpZXMgYXJlIGludmFsaWRhdGVkLgorCisgICAgICAgIEVuc3VyZSBldmVy eSBSZW1vdGVNZWRpYVBsYXllclByb3h5IGNvbnRhaW5lZCBieSB0aGUgUmVtb3RlTWVkaWFQbGF5 ZXJNYW5hZ2VyUHJveHkgaXMKKyAgICAgICAgaW52YWxpZGF0ZWQgaW4gUmVtb3RlTWVkaWFQbGF5 ZXJNYW5hZ2VyUHJveHkncyBkZXN0cnVjdG9yLgorCisgICAgICAgICogR1BVUHJvY2Vzcy9tZWRp YS9SZW1vdGVNZWRpYVBsYXllck1hbmFnZXJQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OlJl bW90ZU1lZGlhUGxheWVyTWFuYWdlclByb3h5Ojp+UmVtb3RlTWVkaWFQbGF5ZXJNYW5hZ2VyUHJv eHkpOgorICAgICAgICAqIEdQVVByb2Nlc3MvbWVkaWEvUmVtb3RlTWVkaWFQbGF5ZXJNYW5hZ2Vy UHJveHkuaDoKKwogMjAyMS0wNy0yNiAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4K IAogICAgICAgICBbQ29jb2FdIFdlYktpdCBpcyBtYWtpbmcgR3JvdXBBY3Rpdml0aWVzIEFQSSBj YWxscyBmb3IgYWxsIFdlYktpdCBjbGllbnRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0dQ VVByb2Nlc3MvbWVkaWEvUmVtb3RlTWVkaWFQbGF5ZXJNYW5hZ2VyUHJveHkuY3BwIGIvU291cmNl L1dlYktpdC9HUFVQcm9jZXNzL21lZGlhL1JlbW90ZU1lZGlhUGxheWVyTWFuYWdlclByb3h5LmNw cAppbmRleCA2MDA4NDI0NzYwOTliN2IyOGVhMGMxNjRjMGRlOGRmMWQ2ZDk4MDhmLi4wYTAwZTQ4 YmIyMTk2YzJhMjZiZDIyOWYzMjljOWVkYjhlOGIyMjY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L0dQVVByb2Nlc3MvbWVkaWEvUmVtb3RlTWVkaWFQbGF5ZXJNYW5hZ2VyUHJveHkuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9tZWRpYS9SZW1vdGVNZWRpYVBsYXllck1hbmFn ZXJQcm94eS5jcHAKQEAgLTU1LDYgKzU1LDEwIEBAIFJlbW90ZU1lZGlhUGxheWVyTWFuYWdlclBy b3h5OjpSZW1vdGVNZWRpYVBsYXllck1hbmFnZXJQcm94eShHUFVDb25uZWN0aW9uVG9XZWJQCiAK IFJlbW90ZU1lZGlhUGxheWVyTWFuYWdlclByb3h5Ojp+UmVtb3RlTWVkaWFQbGF5ZXJNYW5hZ2Vy UHJveHkoKQogeworICAgIGF1dG8gcHJveGllcyA9IHN0ZDo6ZXhjaGFuZ2UobV9wcm94aWVzLCB7 IH0pOworCisgICAgZm9yIChhdXRvJiBwcm94eSA6IHByb3hpZXMudmFsdWVzKCkpCisgICAgICAg IHByb3h5LT5pbnZhbGlkYXRlKCk7CiB9CiAKIHZvaWQgUmVtb3RlTWVkaWFQbGF5ZXJNYW5hZ2Vy UHJveHk6OmNyZWF0ZU1lZGlhUGxheWVyKE1lZGlhUGxheWVySWRlbnRpZmllciBpZGVudGlmaWVy LCBNZWRpYVBsYXllckVudW1zOjpNZWRpYUVuZ2luZUlkZW50aWZpZXIgZW5naW5lSWRlbnRpZmll ciwgUmVtb3RlTWVkaWFQbGF5ZXJQcm94eUNvbmZpZ3VyYXRpb24mJiBwcm94eUNvbmZpZ3VyYXRp b24pCg== 434248 2021-07-26 15:20:47 -0700 2021-07-26 18:13:40 -0700 Patch bug-228038-20210726152046.patch text/plain 2026 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5OTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDU2ZjcwZjM3MjAzNjhkNGY4 NDZlOWQyOTIyZmVhNDI5OTlmNmQ4Y2IuLmE0YWRlMzhiYzkxOGY5ZTkyNWU2NmM3MDcwYjU5NDI0 MWIxOTcxMjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMDctMjYgIEplciBOb2Js ZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTjogW2lPU10gQVNT RVJUSU9OIEZBSUxFRDogIW1fbWVzc2FnZVJlY2VpdmVyTWFwQ291bnQgdW5kZXIgV2ViS2l0OjpS ZW1vdGVBdWRpb0hhcmR3YXJlTGlzdGVuZXI6On5SZW1vdGVBdWRpb0hhcmR3YXJlTGlzdGVuZXIo KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI4MDM4 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84MDcwNTQ3MT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgUmVtb3RlQXVkaW9IYXJkd2FyZUxp c3RlbmVyIGZyb20gdGhlIEdQVVByb2Nlc3NDb25uZWN0aW9uIG1lc3NhZ2VNYXAgd2hlbiB0aGUg Y29ubmVjdGlvbiBjbG9zZXMuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL0dQVS9tZWRpYS9SZW1v dGVBdWRpb0hhcmR3YXJlTGlzdGVuZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpSZW1vdGVBdWRp b0hhcmR3YXJlTGlzdGVuZXI6OmdwdVByb2Nlc3NDb25uZWN0aW9uRGlkQ2xvc2UpOgorCiAyMDIx LTA3LTI2ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JF U1NJT046IFtpT1NdIEFTU0VSVElPTiBGQUlMRUQ6ICFtX3VzZUNvdW50IGluIFdlYktpdDo6U2Fu ZGJveEV4dGVuc2lvbjo6flNhbmRib3hFeHRlbnNpb24oKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9XZWJQcm9jZXNzL0dQVS9tZWRpYS9SZW1vdGVBdWRpb0hhcmR3YXJlTGlzdGVuZXIuY3Bw IGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0dQVS9tZWRpYS9SZW1vdGVBdWRpb0hhcmR3YXJl TGlzdGVuZXIuY3BwCmluZGV4IDZiYzkwYmI4NmQ4YmI1YmI2YjgyNTRjMTk4ODZhNTljMTk1OGJk YzYuLmIwNjg5OTE2ZjA1NTJlZTA5YzljNGNlZjMwNDI0NTk4ZTJhNjAwODggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvbWVkaWEvUmVtb3RlQXVkaW9IYXJkd2FyZUxp c3RlbmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BVL21lZGlhL1JlbW90 ZUF1ZGlvSGFyZHdhcmVMaXN0ZW5lci5jcHAKQEAgLTYwLDkgKzYwLDE1IEBAIFJlbW90ZUF1ZGlv SGFyZHdhcmVMaXN0ZW5lcjo6flJlbW90ZUF1ZGlvSGFyZHdhcmVMaXN0ZW5lcigpCiAgICAgfQog fQogCi12b2lkIFJlbW90ZUF1ZGlvSGFyZHdhcmVMaXN0ZW5lcjo6Z3B1UHJvY2Vzc0Nvbm5lY3Rp b25EaWRDbG9zZShHUFVQcm9jZXNzQ29ubmVjdGlvbiYpCit2b2lkIFJlbW90ZUF1ZGlvSGFyZHdh cmVMaXN0ZW5lcjo6Z3B1UHJvY2Vzc0Nvbm5lY3Rpb25EaWRDbG9zZShHUFVQcm9jZXNzQ29ubmVj dGlvbiYgY29ubmVjdGlvbikKIHsKICAgICBhdWRpb0hhcmR3YXJlRGlkQmVjb21lSW5hY3RpdmUo KTsKKworICAgIEFTU0VSVF9VTlVTRUQoY29ubmVjdGlvbiwgJmNvbm5lY3Rpb24gPT0gbV9ncHVQ cm9jZXNzQ29ubmVjdGlvbik7CisgICAgaWYgKG1fZ3B1UHJvY2Vzc0Nvbm5lY3Rpb24pIHsKKyAg ICAgICAgbV9ncHVQcm9jZXNzQ29ubmVjdGlvbi0+bWVzc2FnZVJlY2VpdmVyTWFwKCkucmVtb3Zl TWVzc2FnZVJlY2VpdmVyKCp0aGlzKTsKKyAgICAgICAgbV9ncHVQcm9jZXNzQ29ubmVjdGlvbiA9 IG51bGxwdHI7CisgICAgfQogfQogCiB2b2lkIFJlbW90ZUF1ZGlvSGFyZHdhcmVMaXN0ZW5lcjo6 YXVkaW9IYXJkd2FyZURpZEJlY29tZUFjdGl2ZSgpCg==