228028 2021-07-16 10:34:38 -0700 macOS Safari network sessions not being marked as being from a browser 2021-07-16 14:28:42 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 katherine_cheney katherine_cheney bfulgham jberlin webkit-bug-importer wilander oldest_to_newest 1777532 0 katherine_cheney 2021-07-16 10:34:38 -0700 macOS Safari network sessions not being marked as being from a browser 1777535 1 433684 katherine_cheney 2021-07-16 10:42:51 -0700 Created attachment 433684 Patch 1777573 2 433684 bfulgham 2021-07-16 13:12:27 -0700 Comment on attachment 433684 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433684&action=review r=me > Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:-86 > -#define NETWORK_SESSION_COCOA_ADDITIONS_1 Always nice to see this stuff go away. 1777601 3 ews-feeder 2021-07-16 14:26:21 -0700 Committed r280001 (239743@main): <https://commits.webkit.org/239743@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433684. 1777602 4 webkit-bug-importer 2021-07-16 14:27:18 -0700 <rdar://problem/80703045> 1777603 5 katherine_cheney 2021-07-16 14:28:42 -0700 The correct radar is rdar://80648664 433684 2021-07-16 10:42:51 -0700 2021-07-16 14:26:22 -0700 Patch bug-228028-20210716104250.patch text/plain 3288 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5ODc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGFjODc3MDQ3MDllYTVjMDM4 MzNkMDgxY2JlNGU2OGMyODhhZjg2N2MuLjJjZTE4ZWQ0YjFlM2ViNzBjOWU2MDI4NWMxYzA4ZDYz MDY0YTY5ODcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjEtMDctMTYgIEthdGUgQ2hl bmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgbWFjT1MgU2FmYXJp IG5ldHdvcmsgc2Vzc2lvbnMgbm90IGJlaW5nIG1hcmtlZCBhcyBiZWluZyBmcm9tIGEgYnJvd3Nl cgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI4MDI4 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84MDY0ODY2ND4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNb3ZlIFdlYktpdEFkZGl0aW9ucyB0byBvcGVu IHNvdXJjZSB0byBjb21tdW5pY2F0ZSBmdWxsIHdlYiBicm93c2VyCisgICAgICAgIHN0YXR1cyB0 byB0aGUgbmV0d29ya2luZyBzdGFjay4gSW4gdGhlIG1hY09TIGNhc2UsIHdlIGRvbid0IGhhdmUK KyAgICAgICAgYSBmdWxsIGJyb3dzZXIgZW50aXRsZW1lbnQsIHNvIHdlIHNob3VsZCBjaGVjayBm b3IgU2FmYXJpLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Nlc3Np b25Db2NvYS5tbToKKyAgICAgICAgKFdlYktpdDo6U2Vzc2lvbldyYXBwZXI6OmluaXRpYWxpemUp OgorICAgICAgICBUaGUgbmFtZSBjb20uYXBwbGUuV2ViS2l0LkluQXBwQnJvd3NlciBpcyBub3Qg dGhlIG1vc3QgYWNjdXJhdGUgbmFtZSwKKyAgICAgICAgYnV0IGNoYW5naW5nIGl0IHdvdWxkIHJl cXVpcmUgc3luY2luZyB3aXRoIG90aGVyIHBhcnRzIG9mIHRoZSBuZXR3b3JrCisgICAgICAgIHN0 YWNrLiBXZSBzaG91bGQgZG8gdGhpcyBpbiBhIHNlcGFyYXRlIGJ1Zy4KKwogMjAyMS0wNy0xMyAg S2F0ZSBDaGVuZXkgIDxrYXRoZXJpbmVfY2hlbmV5QGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJl dmlld2VkIGlPUy90dk9TL3dhdGNoT1MgYnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrU2Vzc2lvbkNvY29hLm1tIGIvU291cmNl L1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrU2Vzc2lvbkNvY29hLm1tCmluZGV4 IGZkY2U3NjgxZmU2ZjI4ODcyYjQyMmU2MzU0OTE5MmQ1MTk0NzY3MjkuLjdmMDczYzZmY2VlYzU3 Y2M4MWM4YjhiZTY1MmI4ZWEwZjg1ZmM1OGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0 d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Nlc3Npb25Db2NvYS5tbQorKysgYi9Tb3VyY2UvV2Vi S2l0L05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtTZXNzaW9uQ29jb2EubW0KQEAgLTY0LDcg KzY0LDYgQEAKICNpbXBvcnQgPHd0Zi90ZXh0L1dURlN0cmluZy5oPgogCiAjaWYgVVNFKEFQUExF X0lOVEVSTkFMX1NESykKLSNpbXBvcnQgPFdlYktpdEFkZGl0aW9ucy9OZXR3b3JrU2Vzc2lvbkNv Y29hQWRkaXRpb25zLmg+CiAKICNpZiBFTkFCTEUoQVBQX1BSSVZBQ1lfUkVQT1JUKSAmJiBIQVZF KFNZTVBUT01TX0ZSQU1FV09SSykKICNpbXBvcnQgPFN5bXB0b21zL1N5bXB0b21BbmFseXRpY3Mu aD4KQEAgLTgzLDcgKzgyLDYgQEAgU09GVF9MSU5LX0NPTlNUQU5UX01BWV9GQUlMKFN5bXB0b21Q cmVzZW50YXRpb25MaXRlLCBrU3ltcHRvbUFuYWx5dGljc1NlcnZpY2VFbmQKICNlbmRpZgogCiAj ZWxzZQotI2RlZmluZSBORVRXT1JLX1NFU1NJT05fQ09DT0FfQURESVRJT05TXzEKIHZvaWQgV2Vi S2l0OjpOZXR3b3JrU2Vzc2lvbkNvY29hOjpyZW1vdmVOZXR3b3JrV2Vic2l0ZURhdGEoc3RkOjpv cHRpb25hbDxXYWxsVGltZT4sIHN0ZDo6b3B0aW9uYWw8SGFzaFNldDxXZWJDb3JlOjpSZWdpc3Ry YWJsZURvbWFpbj4+JiYsIENvbXBsZXRpb25IYW5kbGVyPHZvaWQoKT4mJiBjb21wbGV0aW9uSGFu ZGxlcikgeyBjb21wbGV0aW9uSGFuZGxlcigpOyB9CiAjZW5kaWYKIApAQCAtMTE4NSw5ICsxMTgz LDE0IEBAIHN0YXRpYyBSZXRhaW5QdHI8TlNEaWN0aW9uYXJ5PiBwcm94eURpY3Rpb25hcnkoY29u c3QgVVJMJiBodHRwUHJveHksIGNvbnN0IFVSTCYKIHZvaWQgU2Vzc2lvbldyYXBwZXI6OmluaXRp YWxpemUoTlNVUkxTZXNzaW9uQ29uZmlndXJhdGlvbiAqY29uZmlndXJhdGlvbiwgTmV0d29ya1Nl c3Npb25Db2NvYSYgbmV0d29ya1Nlc3Npb24sIFdlYkNvcmU6OlN0b3JlZENyZWRlbnRpYWxzUG9s aWN5IHN0b3JlZENyZWRlbnRpYWxzUG9saWN5LCBOYXZpZ2F0aW5nVG9BcHBCb3VuZERvbWFpbiBp c05hdmlnYXRpbmdUb0FwcEJvdW5kRG9tYWluKQogewogICAgIFVOVVNFRF9QQVJBTShpc05hdmln YXRpbmdUb0FwcEJvdW5kRG9tYWluKTsKLSNpZiBQTEFURk9STShJT1NfRkFNSUxZKQotICAgIE5F VFdPUktfU0VTU0lPTl9DT0NPQV9BRERJVElPTlNfMQorCisgICAgYXV0byBpc0Z1bGxCcm93c2Vy ID0gaXNQYXJlbnRQcm9jZXNzQUZ1bGxXZWJCcm93c2VyKG5ldHdvcmtTZXNzaW9uLm5ldHdvcmtQ cm9jZXNzKCkpOworI2lmIFBMQVRGT1JNKE1BQykKKyAgICBpc0Z1bGxCcm93c2VyID0gV2ViQ29y ZTo6TWFjQXBwbGljYXRpb246OmlzU2FmYXJpKCk7CiAjZW5kaWYKKyAgICBpZiAoIWNvbmZpZ3Vy YXRpb24uX3NvdXJjZUFwcGxpY2F0aW9uU2Vjb25kYXJ5SWRlbnRpZmllciAmJiBpc0Z1bGxCcm93 c2VyKQorICAgICAgICBjb25maWd1cmF0aW9uLl9zb3VyY2VBcHBsaWNhdGlvblNlY29uZGFyeUlk ZW50aWZpZXIgPSBAImNvbS5hcHBsZS5XZWJLaXQuSW5BcHBCcm93c2VyIjsKKwogICAgIGRlbGVn YXRlID0gYWRvcHROUyhbW1dLTmV0d29ya1Nlc3Npb25EZWxlZ2F0ZSBhbGxvY10gaW5pdFdpdGhO ZXR3b3JrU2Vzc2lvbjpuZXR3b3JrU2Vzc2lvbiB3cmFwcGVyOip0aGlzIHdpdGhDcmVkZW50aWFs czpzdG9yZWRDcmVkZW50aWFsc1BvbGljeSA9PSBXZWJDb3JlOjpTdG9yZWRDcmVkZW50aWFsc1Bv bGljeTo6VXNlXSk7CiAgICAgc2Vzc2lvbiA9IFtOU1VSTFNlc3Npb24gc2Vzc2lvbldpdGhDb25m aWd1cmF0aW9uOmNvbmZpZ3VyYXRpb24gZGVsZWdhdGU6ZGVsZWdhdGUuZ2V0KCkgZGVsZWdhdGVR dWV1ZTpbTlNPcGVyYXRpb25RdWV1ZSBtYWluUXVldWVdXTsKIH0K