228003 2021-07-15 13:16:47 -0700 JITWorklist::waitUntilAllPlansForVMAreReady() should also be notified when plans are cancelled. 2021-07-15 13:43:34 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1777310 0 mark.lam 2021-07-15 13:16:47 -0700 Previously, it only gets notified when plans are done compiling. As a result, if JITWorklist::waitUntilAllPlansForVMAreReady() found non-ready plans and started waiting, and those plans were canceled, then JITWorklist::waitUntilAllPlansForVMAreReady() can hang indefinitely. rdar://78314543 1777313 1 433619 mark.lam 2021-07-15 13:24:15 -0700 Created attachment 433619 proposed patch. 1777317 2 433619 ysuzuki 2021-07-15 13:32:05 -0700 Comment on attachment 433619 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=433619&action=review r=me > Source/JavaScriptCore/jit/JITWorklist.cpp:336 > + bool didCancelPlans = deadPlanKeys.size(); Using !isEmpty() would be better. 1777319 3 mark.lam 2021-07-15 13:33:30 -0700 Thanks for the review. (In reply to Yusuke Suzuki from comment #2) > > Source/JavaScriptCore/jit/JITWorklist.cpp:336 > > + bool didCancelPlans = deadPlanKeys.size(); > > Using !isEmpty() would be better. Agreed. Will fix. 1777324 4 mark.lam 2021-07-15 13:43:34 -0700 Landed in r279961: <http://trac.webkit.org/r279961>. 433619 2021-07-15 13:24:15 -0700 2021-07-15 13:32:05 -0700 proposed patch. bug-228003.patch text/plain 4743 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNzk5NTUpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDIxLTA3LTE1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBKSVRXb3JrbGlzdDo6d2FpdFVudGlsQWxsUGxhbnNGb3JWTUFyZVJlYWR5 KCkgc2hvdWxkIGFsc28gYmUgbm90aWZpZWQgd2hlbiBwbGFucyBhcmUgY2FuY2VsbGVkLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI4MDAzCisgICAg ICAgIHJkYXI6Ly83ODMxNDU0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogc3RyZXNzL3dhaXRVbnRpbEFsbFBsYW5zRm9yVk1BcmVSZWFkeS1zaG91 bGQtYmUtbm90aWZpZWQtb2YtY2FuY2VsbGVkLXBsYW5zLXRvby5qczogQWRkZWQuCisKIDIwMjEt MDctMTQgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIEltcGxl bWVudCBBcnJheS5wcm90b3R5cGUuZmluZExhc3QgYW5kIEFycmF5LnByb3RvdHlwZS5maW5kTGFz dEluZGV4CkluZGV4OiBKU1Rlc3RzL3N0cmVzcy93YWl0VW50aWxBbGxQbGFuc0ZvclZNQXJlUmVh ZHktc2hvdWxkLWJlLW5vdGlmaWVkLW9mLWNhbmNlbGxlZC1wbGFucy10b28uanMKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gSlNUZXN0cy9zdHJlc3Mvd2FpdFVudGlsQWxsUGxhbnNGb3JWTUFyZVJlYWR5LXNob3Vs ZC1iZS1ub3RpZmllZC1vZi1jYW5jZWxsZWQtcGxhbnMtdG9vLmpzCShub25leGlzdGVudCkKKysr IEpTVGVzdHMvc3RyZXNzL3dhaXRVbnRpbEFsbFBsYW5zRm9yVk1BcmVSZWFkeS1zaG91bGQtYmUt bm90aWZpZWQtb2YtY2FuY2VsbGVkLXBsYW5zLXRvby5qcwkod29ya2luZyBjb3B5KQpAQCAtMCww ICsxLDUgQEAKKy8vQCByZXF1aXJlT3B0aW9ucygiLS1kZXN0cm95LXZtIiwgIi0tY29sbGVjdENv bnRpbnVvdXNseT10cnVlIiwgIi0tZm9yY2VNaW5pVk1Nb2RlPXRydWUiKQorCisvLyBUaGlzIHRl c3QgcGFzc2VzIGlmIGl0IGRvZXMgbm90IGhhbmcgb3IgY3Jhc2guCitsZXQgYSA9IG5ldyBVaW50 OEFycmF5KDEwMDAwKTsKK2ZvciAobGV0IHggb2YgYSkge30KSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwkocmV2aXNpb24gMjc5OTI0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBACisyMDIxLTA3LTE1ICBNYXJrIExh bSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBKSVRXb3JrbGlzdDo6d2FpdFVudGls QWxsUGxhbnNGb3JWTUFyZVJlYWR5KCkgc2hvdWxkIGFsc28gYmUgbm90aWZpZWQgd2hlbiBwbGFu cyBhcmUgY2FuY2VsbGVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjI4MDAzCisgICAgICAgIHJkYXI6Ly83ODMxNDU0MworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFByZXZpb3VzbHksIGl0IG9ubHkgZ2V0 cyBub3RpZmllZCB3aGVuIHBsYW5zIGFyZSBkb25lIGNvbXBpbGluZy4gIEFzIGEgcmVzdWx0LCBp ZgorICAgICAgICBKSVRXb3JrbGlzdDo6d2FpdFVudGlsQWxsUGxhbnNGb3JWTUFyZVJlYWR5KCkg Zm91bmQgbm9uLXJlYWR5IHBsYW5zIGFuZCBzdGFydGVkCisgICAgICAgIHdhaXRpbmcsIGFuZCB0 aG9zZSBwbGFucyB3ZXJlIGNhbmNlbGVkLCB0aGVuIEpJVFdvcmtsaXN0Ojp3YWl0VW50aWxBbGxQ bGFuc0ZvclZNQXJlUmVhZHkoKQorICAgICAgICBjYW4gaGFuZyBpbmRlZmluaXRlbHkuCisKKyAg ICAgICAgVGhpcyBwYXRjaCByZW5hbWVzIEpJVFdvcmtsaXN0Ojo6Om1fcGxhbkNvbXBpbGVkIHRv IG1fcGxhbkNvbXBpbGVkT3JDYW5jZWxsZWQsCisgICAgICAgIGFuZCBub3RpZmllcyBpdCBhbHNv IHdoZW4gcGxhbnMgYXJlIGNhbmNlbGxlZC4KKworICAgICAgICAqIGppdC9KSVRXb3JrbGlzdC5j cHA6CisgICAgICAgIChKU0M6OkpJVFdvcmtsaXN0Ojp3YWl0VW50aWxBbGxQbGFuc0ZvclZNQXJl UmVhZHkpOgorICAgICAgICAoSlNDOjpKSVRXb3JrbGlzdDo6cmVtb3ZlTWF0Y2hpbmdQbGFuc0Zv clZNKToKKyAgICAgICAgKiBqaXQvSklUV29ya2xpc3QuaDoKKyAgICAgICAgKiBqaXQvSklUV29y a2xpc3RUaHJlYWQuY3BwOgorICAgICAgICAoSlNDOjpKSVRXb3JrbGlzdFRocmVhZDo6d29yayk6 CisKIDIwMjEtMDctMTQgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAg IFNwZWN1bGF0aXZlIGZpeCBmb3IgZmFpbGVkIHNjb3BlLnJlbGVhc2VBc3NlcnROb0V4Y2VwdGlv bigpIGFmdGVyIGNhbGxzIHRvIEpTTWFwOjpjcmVhdGUoKS4KSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9qaXQvSklUV29ya2xpc3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9qaXQvSklUV29ya2xpc3QuY3BwCShyZXZpc2lvbiAyNzk5MjMpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvaml0L0pJVFdvcmtsaXN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjA0 LDcgKzIwNCw3IEBAIHZvaWQgSklUV29ya2xpc3Q6OndhaXRVbnRpbEFsbFBsYW5zRm9yVk0KICAg ICAgICAgaWYgKGFsbEFyZUNvbXBpbGVkKQogICAgICAgICAgICAgYnJlYWs7CiAKLSAgICAgICAg bV9wbGFuQ29tcGlsZWQud2FpdCgqbV9sb2NrKTsKKyAgICAgICAgbV9wbGFuQ29tcGlsZWRPckNh bmNlbGxlZC53YWl0KCptX2xvY2spOwogICAgIH0KIH0KIApAQCAtMzMzLDYgKzMzMyw3IEBAIHZv aWQgSklUV29ya2xpc3Q6OnJlbW92ZU1hdGNoaW5nUGxhbnNGb3IKICAgICAgICAgUkVMRUFTRV9B U1NFUlQocGxhbi0+c3RhZ2UoKSAhPSBKSVRQbGFuU3RhZ2U6OkNhbmNlbGVkKTsKICAgICAgICAg ZGVhZFBsYW5LZXlzLmFkZChwbGFuLT5rZXkoKSk7CiAgICAgfQorICAgIGJvb2wgZGlkQ2FuY2Vs UGxhbnMgPSBkZWFkUGxhbktleXMuc2l6ZSgpOwogICAgIGZvciAoSklUQ29tcGlsYXRpb25LZXkg a2V5IDogZGVhZFBsYW5LZXlzKQogICAgICAgICBtX3BsYW5zLnRha2Uoa2V5KS0+Y2FuY2VsKCk7 CiAgICAgZm9yIChhdXRvJiBxdWV1ZSA6IG1fcXVldWVzKSB7CkBAIC0zNTAsNiArMzUxLDggQEAg dm9pZCBKSVRXb3JrbGlzdDo6cmVtb3ZlTWF0Y2hpbmdQbGFuc0ZvcgogICAgICAgICBtX3JlYWR5 UGxhbnNbaS0tXSA9IG1fcmVhZHlQbGFucy5sYXN0KCk7CiAgICAgICAgIG1fcmVhZHlQbGFucy5y ZW1vdmVMYXN0KCk7CiAgICAgfQorICAgIGlmIChkaWRDYW5jZWxQbGFucykKKyAgICAgICAgbV9w bGFuQ29tcGlsZWRPckNhbmNlbGxlZC5ub3RpZnlBbGwoKTsKIH0KIAogfSAvLyBuYW1lc3BhY2Ug SlNDCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFdvcmtsaXN0LmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRXb3JrbGlzdC5oCShyZXZpc2lv biAyNzk5MjMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFdvcmtsaXN0LmgJKHdv cmtpbmcgY29weSkKQEAgLTEyMiw3ICsxMjIsNyBAQCBwcml2YXRlOgogICAgIEJveDxMb2NrPiBt X2xvY2s7CiAKICAgICBSZWY8QXV0b21hdGljVGhyZWFkQ29uZGl0aW9uPiBtX3BsYW5FbnF1ZXVl ZDsKLSAgICBDb25kaXRpb24gbV9wbGFuQ29tcGlsZWQ7CisgICAgQ29uZGl0aW9uIG1fcGxhbkNv bXBpbGVkT3JDYW5jZWxsZWQ7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBKU0MKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUV29ya2xpc3RUaHJlYWQuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUV29ya2xpc3RUaHJlYWQuY3BwCShyZXZpc2lv biAyNzk5MjMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFdvcmtsaXN0VGhyZWFk LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTQyLDcgKzE0Miw3IEBAIGF1dG8gSklUV29ya2xpc3RU aHJlYWQ6OndvcmsoKSAtPiBXb3JrUmUKIAogICAgICAgICBSRUxFQVNFX0FTU0VSVCghbV9wbGFu LT52bSgpLT5oZWFwLndvcmxkSXNTdG9wcGVkKCkpOwogICAgICAgICBtX3dvcmtsaXN0Lm1fcmVh ZHlQbGFucy5hcHBlbmQoV1RGTW92ZShtX3BsYW4pKTsKLSAgICAgICAgbV93b3JrbGlzdC5tX3Bs YW5Db21waWxlZC5ub3RpZnlBbGwoKTsKKyAgICAgICAgbV93b3JrbGlzdC5tX3BsYW5Db21waWxl ZE9yQ2FuY2VsbGVkLm5vdGlmeUFsbCgpOwogICAgIH0KIAogICAgIHJldHVybiBXb3JrUmVzdWx0 OjpDb250aW51ZTsK