227946 2021-07-14 05:05:50 -0700 [build.webkit.org] lldb-webkit-test is failing on Catalina queues 2021-07-20 03:08:54 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain jbedard jbedard ryanhaddad vjaquez webkit-bug-importer oldest_to_newest 1776913 0 aakash_jain 2021-07-14 05:05:50 -0700 lldb-webkit-test is failing on various queues. e.g.: https://build.webkit.org/#/builders/33/builds/2099/steps/12/logs/stdio Checking imports ... Failed to import dump_class_layout_unittest: Traceback (most recent call last): File "/Applications/Xcode.app/Contents/SharedFrameworks/LLDB.framework/Resources/Python/lldb/__init__.py", line 35, in <module> import _lldb ModuleNotFoundError: No module named '_lldb' During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/Volumes/Data/worker/catalina-debug-tests-wk1/build/Tools/Scripts/webkitpy/test/main.py", line 290, in _check_imports __import__(name) File "/Volumes/Data/worker/catalina-debug-tests-wk1/build/Tools/lldb/dump_class_layout_unittest.py", line 28, in <module> import lldb File "/Applications/Xcode.app/Contents/SharedFrameworks/LLDB.framework/Resources/Python/lldb/__init__.py", line 38, in <module> from . import _lldb ImportError: dynamic module does not define module export function (PyInit__lldb) On Apple-Catalina-Debug-WK1-Tests queue this issue started happening about two months back (https://build.webkit.org/#/builders/33/builds/2098 passed and https://build.webkit.org/#/builders/33/builds/2099 failed). Other examples: https://build.webkit.org/#/builders/33/builds/3104, https://build.webkit.org/#/builders/34/builds/1708, https://build.webkit.org/#/builders/25/builds/4158, https://build.webkit.org/#/builders/13/builds/3957 1776935 1 jbedard 2021-07-14 08:12:39 -0700 There isn't a great solution to this, we should probably just stop trying to run this test suite on Catalina. The problem is that in Big Sur mid-year release, Xcode changed lldb from Python 2 to Python 3. In an effort to support the newer way (because that's what Monterey and presumably future OSes will be using). In order to fix this, we basically have to have two lldb-webkit-test scripts, which doesn't seem worth the trouble. Most development is done on Big Sur and Monterey at this point, I think the engineer effort to "fix" this problem on Catalina is not worth it. Especially since I'm pretty sure lldb debugging still works on Catalina, we would just no longer be defending that fact in automation. 1777383 2 ap 2021-07-15 17:16:51 -0700 > There isn't a great solution to this, we should probably just stop trying to run this test suite on Catalina. Let's do that then. 1777900 3 433798 ryanhaddad 2021-07-19 10:51:03 -0700 Created attachment 433798 Patch 1777904 4 433798 aakash_jain 2021-07-19 10:57:05 -0700 Comment on attachment 433798 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433798&action=review > Tools/CISupport/build-webkit-org/factories.py:111 > + if platform.startswith('mac') and not (platform == 'mac-catalina'): This might be slightly easier to read: and (platform != 'mac-catalina') 1777917 5 ryanhaddad 2021-07-19 11:23:41 -0700 (In reply to Aakash Jain from comment #4) > Comment on attachment 433798 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=433798&action=review > > > Tools/CISupport/build-webkit-org/factories.py:111 > > + if platform.startswith('mac') and not (platform == 'mac-catalina'): > > This might be slightly easier to read: > and (platform != 'mac-catalina') Fair enough, will address before landing. Thanks! 1777918 6 433802 ryanhaddad 2021-07-19 11:24:35 -0700 Created attachment 433802 Patch for landing 1777928 7 ews-feeder 2021-07-19 11:54:04 -0700 Committed r280040 (239775@main): <https://commits.webkit.org/239775@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433802. 1777932 8 webkit-bug-importer 2021-07-19 11:55:39 -0700 <rdar://problem/80795641> 1777950 9 ryanhaddad 2021-07-19 12:50:51 -0700 *** Bug 226603 has been marked as a duplicate of this bug. *** 433798 2021-07-19 10:51:03 -0700 2021-07-19 11:24:32 -0700 Patch bug-227946-20210719105102.patch text/plain 1745 ryanhaddad U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwMDI1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzYyMWVkY2Y2MGY2NDc1OTZjOGQ4NmEwOTg2ZjgzN2Zh N2YyYTBlOS4uMTIzNGVmZmU4Mjg1M2Y1ZmUyZmZkY2JmNTFkMzMyNGVlY2RkMTIwNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDIxLTA3LTE5ICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgorCisg ICAgICAgIFtidWlsZC53ZWJraXQub3JnXSBsbGRiLXdlYmtpdC10ZXN0IGlzIGZhaWxpbmcgb24g Q2F0YWxpbmEgcXVldWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMjc5NDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGUgY2hhbmdlcyB0byBsbGRiLXdlYmtpdC10ZXN0IHRvIHN1cHBvcnQgdGhlIFB5 dGhvbiAzIHZlcnNpb24gb2YgbGxkYiBwcmVzZW50IGluIHRoZQorICAgICAgICBCaWcgU3VyLWFs aWduZWQgWGNvZGUgaGF2ZSBtYWRlIGl0IGluY29tcGF0aWJsZSB3aXRoIENhdGFsaW4ncyBQeXRo b24gMiB2ZXJzaW9uLgorCisgICAgICAgIFJhdGhlciB0aGFuIGNyZWF0aW5nIGFuZCBkZWZlbmRp bmcgdGhlIHJlc3VsdHMgZm9yIHR3byBkaWZmZXJlbnQgdmVyc2lvbnMgb2YgdGhlIGxsZGItd2Vi a2l0LXRlc3QKKyAgICAgICAgc2NyaXB0LCBkaXNhYmxlIHRoaXMgdGVzdCBzdGVwIGZvciBDYXRh bGluYS4KKworICAgICAgICAqIENJU3VwcG9ydC9idWlsZC13ZWJraXQtb3JnL2ZhY3Rvcmllcy5w eToKKyAgICAgICAgKFRlc3RGYWN0b3J5Ll9faW5pdF9fKToKKwogMjAyMS0wNy0xOSAgUnlhbiBI YWRkYWQgIDxyeWFuaGFkZGFkQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIGluZnJh c3RydWN0dXJlIGZpeCwgcmVtb3ZlIGJvdCB0aGF0IGlzIG91dCBmb3IgaGFyZHdhcmUgcmVwYWly LgpkaWZmIC0tZ2l0IGEvVG9vbHMvQ0lTdXBwb3J0L2J1aWxkLXdlYmtpdC1vcmcvZmFjdG9yaWVz LnB5IGIvVG9vbHMvQ0lTdXBwb3J0L2J1aWxkLXdlYmtpdC1vcmcvZmFjdG9yaWVzLnB5CmluZGV4 IDgxZDgyMTM3Zjk4MGZkZDYzMGFkMWYwNzc2NTQ2ZGU4N2IzZTQ3MGQuLmM3ZTdmNWYzZDRjNTM1 ZTQ3OWQ3NjU4MDA5NTVlMDgyMWM0NDdiMmUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NJU3VwcG9ydC9i dWlsZC13ZWJraXQtb3JnL2ZhY3Rvcmllcy5weQorKysgYi9Ub29scy9DSVN1cHBvcnQvYnVpbGQt d2Via2l0LW9yZy9mYWN0b3JpZXMucHkKQEAgLTEwOCw3ICsxMDgsNyBAQCBjbGFzcyBUZXN0RmFj dG9yeShGYWN0b3J5KToKICAgICAgICAgaWYgcGxhdGZvcm0uc3RhcnRzd2l0aCgnd2luJykgb3Ig cGxhdGZvcm0uc3RhcnRzd2l0aCgnbWFjJykgb3IgcGxhdGZvcm0uc3RhcnRzd2l0aCgnaW9zLXNp bXVsYXRvcicpOgogICAgICAgICAgICAgc2VsZi5hZGRTdGVwKFJ1bkFQSVRlc3RzKCkpCiAKLSAg ICAgICAgaWYgcGxhdGZvcm0uc3RhcnRzd2l0aCgnbWFjJyk6CisgICAgICAgIGlmIHBsYXRmb3Jt LnN0YXJ0c3dpdGgoJ21hYycpIGFuZCBub3QgKHBsYXRmb3JtID09ICdtYWMtY2F0YWxpbmEnKToK ICAgICAgICAgICAgIHNlbGYuYWRkU3RlcChSdW5MTERCV2ViS2l0VGVzdHMoKSkKIAogICAgICAg ICBzZWxmLmFkZFN0ZXAoUnVuV2ViS2l0UHlUZXN0cygpKQo= 433802 2021-07-19 11:24:35 -0700 2021-07-20 03:08:54 -0700 Patch for landing bug-227946-20210719112434.patch text/plain 1738 ryanhaddad U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwMDI1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzYyMWVkY2Y2MGY2NDc1OTZjOGQ4NmEwOTg2ZjgzN2Zh N2YyYTBlOS4uYTY2YTI0ZmU0NzlmMWU5NDI3Zjc5ZDI3N2JkMTRlZTg5MGU3ZmIzYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDIxLTA3LTE5ICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgorCisg ICAgICAgIFtidWlsZC53ZWJraXQub3JnXSBsbGRiLXdlYmtpdC10ZXN0IGlzIGZhaWxpbmcgb24g Q2F0YWxpbmEgcXVldWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMjc5NDYKKworICAgICAgICBSZXZpZXdlZCBieSBBYWthc2ggSmFpbi4KKworICAg ICAgICBUaGUgY2hhbmdlcyB0byBsbGRiLXdlYmtpdC10ZXN0IHRvIHN1cHBvcnQgdGhlIFB5dGhv biAzIHZlcnNpb24gb2YgbGxkYiBwcmVzZW50IGluIHRoZQorICAgICAgICBCaWcgU3VyLWFsaWdu ZWQgWGNvZGUgaGF2ZSBtYWRlIGl0IGluY29tcGF0aWJsZSB3aXRoIENhdGFsaW4ncyBQeXRob24g MiB2ZXJzaW9uLgorCisgICAgICAgIFJhdGhlciB0aGFuIGNyZWF0aW5nIGFuZCBkZWZlbmRpbmcg dGhlIHJlc3VsdHMgZm9yIHR3byBkaWZmZXJlbnQgdmVyc2lvbnMgb2YgdGhlIGxsZGItd2Via2l0 LXRlc3QKKyAgICAgICAgc2NyaXB0LCBkaXNhYmxlIHRoaXMgdGVzdCBzdGVwIGZvciBDYXRhbGlu YS4KKworICAgICAgICAqIENJU3VwcG9ydC9idWlsZC13ZWJraXQtb3JnL2ZhY3Rvcmllcy5weToK KyAgICAgICAgKFRlc3RGYWN0b3J5Ll9faW5pdF9fKToKKwogMjAyMS0wNy0xOSAgUnlhbiBIYWRk YWQgIDxyeWFuaGFkZGFkQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIGluZnJhc3Ry dWN0dXJlIGZpeCwgcmVtb3ZlIGJvdCB0aGF0IGlzIG91dCBmb3IgaGFyZHdhcmUgcmVwYWlyLgpk aWZmIC0tZ2l0IGEvVG9vbHMvQ0lTdXBwb3J0L2J1aWxkLXdlYmtpdC1vcmcvZmFjdG9yaWVzLnB5 IGIvVG9vbHMvQ0lTdXBwb3J0L2J1aWxkLXdlYmtpdC1vcmcvZmFjdG9yaWVzLnB5CmluZGV4IDgx ZDgyMTM3Zjk4MGZkZDYzMGFkMWYwNzc2NTQ2ZGU4N2IzZTQ3MGQuLjAyYjI3NDRhMGE4ODNlZTA1 ZjE0NTQ4YTc1NDc1MTEwNjQ5ZjgyOWUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NJU3VwcG9ydC9idWls ZC13ZWJraXQtb3JnL2ZhY3Rvcmllcy5weQorKysgYi9Ub29scy9DSVN1cHBvcnQvYnVpbGQtd2Vi a2l0LW9yZy9mYWN0b3JpZXMucHkKQEAgLTEwOCw3ICsxMDgsNyBAQCBjbGFzcyBUZXN0RmFjdG9y eShGYWN0b3J5KToKICAgICAgICAgaWYgcGxhdGZvcm0uc3RhcnRzd2l0aCgnd2luJykgb3IgcGxh dGZvcm0uc3RhcnRzd2l0aCgnbWFjJykgb3IgcGxhdGZvcm0uc3RhcnRzd2l0aCgnaW9zLXNpbXVs YXRvcicpOgogICAgICAgICAgICAgc2VsZi5hZGRTdGVwKFJ1bkFQSVRlc3RzKCkpCiAKLSAgICAg ICAgaWYgcGxhdGZvcm0uc3RhcnRzd2l0aCgnbWFjJyk6CisgICAgICAgIGlmIHBsYXRmb3JtLnN0 YXJ0c3dpdGgoJ21hYycpIGFuZCAocGxhdGZvcm0gIT0gJ21hYy1jYXRhbGluYScpOgogICAgICAg ICAgICAgc2VsZi5hZGRTdGVwKFJ1bkxMREJXZWJLaXRUZXN0cygpKQogCiAgICAgICAgIHNlbGYu YWRkU3RlcChSdW5XZWJLaXRQeVRlc3RzKCkpCg==