<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>227935</bug_id>
          
          <creation_ts>2021-07-13 18:14:40 -0700</creation_ts>
          <short_desc>Add step name and description to InstallBuiltProduct build step</short_desc>
          <delta_ts>2021-07-19 16:03:23 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=227526</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Aakash Jain">aakash_jain</reporter>
          <assigned_to name="Aakash Jain">aakash_jain</assigned_to>
          <cc>clopez</cc>
    
    <cc>jbedard</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>pnormand</cc>
    
    <cc>ryanhaddad</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1776828</commentid>
    <comment_count>0</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2021-07-13 18:14:40 -0700</bug_when>
    <thetext>https://trac.webkit.org/r279563 added InstallBuiltProduct build step. However, it didn&apos;t have step name and description. So the step shows up as &apos;shell&apos; and &apos;python3 Tools/Scripts/install-built-product...&apos; in the buildbot UI, e.g.: see step 11 in https://build.webkit.org/#/builders/41/builds/4247

We should add a proper name and description to this build step.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1776830</commentid>
    <comment_count>1</comment_count>
      <attachid>433468</attachid>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2021-07-13 18:22:25 -0700</bug_when>
    <thetext>Created attachment 433468
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1776894</commentid>
    <comment_count>2</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2021-07-14 00:37:22 -0700</bug_when>
    <thetext>Thanks Aakash!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1776911</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-07-14 04:55:27 -0700</bug_when>
    <thetext>Committed r279908 (239657@main): &lt;https://commits.webkit.org/239657@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433468.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1776912</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-07-14 04:56:16 -0700</bug_when>
    <thetext>&lt;rdar://problem/80571466&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1776914</commentid>
    <comment_count>5</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2021-07-14 05:22:07 -0700</bug_when>
    <thetext>Restarted buildbot on EWS to pick up this change. Seems to be working fine, e.g.: step 16 in https://ews-build.webkit.org/#/builders/36/builds/40064

(still need to restart build.webkit.org, it will be picked up in next buildbot restart)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1778036</commentid>
    <comment_count>6</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2021-07-19 16:03:23 -0700</bug_when>
    <thetext>build.webkit.org was restarted few hours back and picked up this change. Seems to be working fine, e.g.: step 11 in https://build.webkit.org/#/builders/41/builds/4368</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>433468</attachid>
            <date>2021-07-13 18:22:25 -0700</date>
            <delta_ts>2021-07-14 04:55:28 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-227935-20210713212224.patch</filename>
            <type>text/plain</type>
            <size>2328</size>
            <attacher name="Aakash Jain">aakash_jain</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDI3OTkwMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE1IEBACisyMDIxLTA3LTEzICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv
bT4KKworICAgICAgICBBZGQgc3RlcCBuYW1lIGFuZCBkZXNjcmlwdGlvbiB0byBJbnN0YWxsQnVp
bHRQcm9kdWN0IGJ1aWxkIHN0ZXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTIyNzkzNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgICogQ0lTdXBwb3J0L2J1aWxkLXdlYmtpdC1vcmcvc3RlcHMucHk6CisgICAg
ICAgIChJbnN0YWxsQnVpbHRQcm9kdWN0KToKKyAgICAgICAgKiBDSVN1cHBvcnQvZXdzLWJ1aWxk
L3N0ZXBzLnB5OgorICAgICAgICAoSW5zdGFsbEJ1aWx0UHJvZHVjdCk6CisKIDIwMjEtMDctMTMg
IEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAgICAgIFt3ZWJraXRz
Y21weV0gSGFuZGxlIGZhaWxlZCBgZ2l0IGxvZ2AgcHJvY2VzcwpJbmRleDogVG9vbHMvQ0lTdXBw
b3J0L2J1aWxkLXdlYmtpdC1vcmcvc3RlcHMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ0lTdXBw
b3J0L2J1aWxkLXdlYmtpdC1vcmcvc3RlcHMucHkJKHJldmlzaW9uIDI3OTkwMSkKKysrIFRvb2xz
L0NJU3VwcG9ydC9idWlsZC13ZWJraXQtb3JnL3N0ZXBzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0z
MjQsOSArMzI0LDEzIEBAIGNsYXNzIENvbXBpbGVKU0NPbmx5KENvbXBpbGVXZWJLaXQpOgogCiAK
IGNsYXNzIEluc3RhbGxCdWlsdFByb2R1Y3Qoc2hlbGwuU2hlbGxDb21tYW5kKToKKyAgICBuYW1l
ID0gJ2luc3RhbGwtYnVpbHQtcHJvZHVjdCcKKyAgICBkZXNjcmlwdGlvbiA9IFsnSW5zdGFsbGlu
ZyBCdWlsdCBQcm9kdWN0J10KKyAgICBkZXNjcmlwdGlvbkRvbmUgPSBbJ0luc3RhbGxlZCBCdWls
dCBQcm9kdWN0J10KICAgICBjb21tYW5kID0gWyJweXRob24zIiwgIlRvb2xzL1NjcmlwdHMvaW5z
dGFsbC1idWlsdC1wcm9kdWN0IiwKICAgICAgICAgICAgICAgIFdpdGhQcm9wZXJ0aWVzKCItLXBs
YXRmb3JtPSUoZnVsbFBsYXRmb3JtKXMiKSwgV2l0aFByb3BlcnRpZXMoIi0tJShjb25maWd1cmF0
aW9uKXMiKV0KIAorCiBjbGFzcyBBcmNoaXZlQnVpbHRQcm9kdWN0KHNoZWxsLlNoZWxsQ29tbWFu
ZCk6CiAgICAgY29tbWFuZCA9IFsicHl0aG9uMyIsICJUb29scy9DSVN1cHBvcnQvYnVpbHQtcHJv
ZHVjdC1hcmNoaXZlIiwKICAgICAgICAgICAgICAgIFdpdGhQcm9wZXJ0aWVzKCItLXBsYXRmb3Jt
PSUoZnVsbFBsYXRmb3JtKXMiKSwgV2l0aFByb3BlcnRpZXMoIi0tJShjb25maWd1cmF0aW9uKXMi
KSwgImFyY2hpdmUiXQpJbmRleDogVG9vbHMvQ0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQo9
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09Ci0tLSBUb29scy9DSVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CShyZXZpc2lv
biAyNzk5MDEpCisrKyBUb29scy9DSVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CSh3b3JraW5n
IGNvcHkpCkBAIC0yMDM0LDkgKzIwMzQsMTMgQEAgY2xhc3MgQW5hbHl6ZUpTQ1Rlc3RzUmVzdWx0
cyhidWlsZHN0ZXAuQgogCiAKIGNsYXNzIEluc3RhbGxCdWlsdFByb2R1Y3Qoc2hlbGwuU2hlbGxD
b21tYW5kKToKKyAgICBuYW1lID0gJ2luc3RhbGwtYnVpbHQtcHJvZHVjdCcKKyAgICBkZXNjcmlw
dGlvbiA9IFsnSW5zdGFsbGluZyBCdWlsdCBQcm9kdWN0J10KKyAgICBkZXNjcmlwdGlvbkRvbmUg
PSBbJ0luc3RhbGxlZCBCdWlsdCBQcm9kdWN0J10KICAgICBjb21tYW5kID0gWyJweXRob24zIiwg
IlRvb2xzL1NjcmlwdHMvaW5zdGFsbC1idWlsdC1wcm9kdWN0IiwKICAgICAgICAgICAgICAgIFdp
dGhQcm9wZXJ0aWVzKCItLXBsYXRmb3JtPSUoZnVsbFBsYXRmb3JtKXMiKSwgV2l0aFByb3BlcnRp
ZXMoIi0tJShjb25maWd1cmF0aW9uKXMiKV0KIAorCiBjbGFzcyBDbGVhbkJ1aWxkKHNoZWxsLkNv
bXBpbGUpOgogICAgIG5hbWUgPSAnZGVsZXRlLVdlYktpdEJ1aWxkLWRpcmVjdG9yeScKICAgICBk
ZXNjcmlwdGlvbiA9IFsnZGVsZXRpbmcgV2ViS2l0QnVpbGQgZGlyZWN0b3J5J10K
</data>

          </attachment>
      

    </bug>

</bugzilla>