22793 2008-12-10 11:31:09 -0800 Clean up FloatPoint3D 2008-12-10 12:03:55 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser oldest_to_newest 102127 0 simon.fraser 2008-12-10 11:31:09 -0800 Want to do some cleanup of FloatPoint3D. 102128 1 25922 simon.fraser 2008-12-10 11:40:13 -0800 Created attachment 25922 Patch, changelog 102129 2 25922 sam 2008-12-10 11:56:12 -0800 Comment on attachment 25922 Patch, changelog > +FloatPoint3D::FloatPoint3D(const FloatPoint& p) > + : m_x(p.x()) > + , m_y(p.y()) > + , m_z(0.f) This should be m_z(0.0f) or just 0. > > +#include "FloatPoint.h" Can this simply be forward declared? Otherwise, r=me. 102130 3 simon.fraser 2008-12-10 12:03:55 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/graphics/FloatPoint3D.cpp M WebCore/platform/graphics/FloatPoint3D.h Committed r39181 25922 2008-12-10 11:40:13 -0800 2008-12-10 11:56:12 -0800 Patch, changelog 22793_patch.txt text/plain 2863 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OWNkZTRmOC4uNGQxMzE5NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAwOC0xMi0xMCAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjI3OTMKKworICAgICAgICBDbGVhbnVwIEZsb2F0UG9pbnQzRDogaW5saW5lIHRoZSBnZXR0 ZXJzIGFuZCBzZXR0ZXJzLAorICAgICAgICBmaXggYSBwb3RlbnRpYWwgZGl2aWRlLWJ5LXplcm8g aW4gbm9ybWFsaXplKCksIGFuZCBhZGQKKyAgICAgICAgYSBGbG9hdFBvaW50IGNvbnN0cnVjdG9y LgorICAgICAgICAKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9GbG9hdFBvaW50M0QuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6RmxvYXRQb2ludDNEOjpGbG9hdFBvaW50M0QpOgorICAgICAg ICAoV2ViQ29yZTo6RmxvYXRQb2ludDNEOjpub3JtYWxpemUpOgorICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL0Zsb2F0UG9pbnQzRC5oOgorICAgICAgICAoV2ViQ29yZTo6RmxvYXRQb2ludDNE Ojp4KToKKyAgICAgICAgKFdlYkNvcmU6OkZsb2F0UG9pbnQzRDo6c2V0WCk6CisgICAgICAgIChX ZWJDb3JlOjpGbG9hdFBvaW50M0Q6OnkpOgorICAgICAgICAoV2ViQ29yZTo6RmxvYXRQb2ludDNE OjpzZXRZKToKKyAgICAgICAgKFdlYkNvcmU6OkZsb2F0UG9pbnQzRDo6eik6CisgICAgICAgIChX ZWJDb3JlOjpGbG9hdFBvaW50M0Q6OnNldFopOgorCiAyMDA4LTEyLTEwICBEaW1pdHJpIEdsYXpr b3YgIDxkZ2xhemtvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgVGltb3Ro eSBIYXRjaGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9GbG9hdFBv aW50M0QuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9GbG9hdFBvaW50M0QuY3BwCmlu ZGV4IGVjNTJkNDAuLmU3ZjkyZTUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvRmxvYXRQb2ludDNELmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Zsb2F0 UG9pbnQzRC5jcHAKQEAgLTQxLDQzICs0MSwyMiBAQCBGbG9hdFBvaW50M0Q6OkZsb2F0UG9pbnQz RChmbG9hdCB4LCBmbG9hdCB5LCBmbG9hdCB6KQogewogfQogCi1mbG9hdCBGbG9hdFBvaW50M0Q6 OngoKSBjb25zdAotewotICAgIHJldHVybiBtX3g7Ci19Ci0KLXZvaWQgRmxvYXRQb2ludDNEOjpz ZXRYKGZsb2F0IHgpCi17Ci0gICAgbV94ID0geDsKLX0KLQotZmxvYXQgRmxvYXRQb2ludDNEOjp5 KCkgY29uc3QKLXsKLSAgICByZXR1cm4gbV95OwotfQotCi12b2lkIEZsb2F0UG9pbnQzRDo6c2V0 WShmbG9hdCB5KQotewotICAgIG1feSA9IHk7Ci19Ci0KLWZsb2F0IEZsb2F0UG9pbnQzRDo6eigp IGNvbnN0Ci17Ci0gICAgcmV0dXJuIG1fejsKLX0KLQotdm9pZCBGbG9hdFBvaW50M0Q6OnNldFoo ZmxvYXQgeikKK0Zsb2F0UG9pbnQzRDo6RmxvYXRQb2ludDNEKGNvbnN0IEZsb2F0UG9pbnQmIHAp CisgICAgOiBtX3gocC54KCkpCisgICAgLCBtX3kocC55KCkpCisgICAgLCBtX3ooMC5mKQogewot ICAgIG1feiA9IHo7CiB9CiAKIHZvaWQgRmxvYXRQb2ludDNEOjpub3JtYWxpemUoKQogewogICAg IGZsb2F0IGxlbmd0aCA9IHNxcnRmKG1feCAqIG1feCArIG1feSAqIG1feSArIG1feiAqIG1feik7 CiAKLSAgICBtX3ggLz0gbGVuZ3RoOwotICAgIG1feSAvPSBsZW5ndGg7Ci0gICAgbV96IC89IGxl bmd0aDsKKyAgICBpZiAobGVuZ3RoICE9IDApIHsKKyAgICAgICAgbV94IC89IGxlbmd0aDsKKyAg ICAgICAgbV95IC89IGxlbmd0aDsKKyAgICAgICAgbV96IC89IGxlbmd0aDsKKyAgICB9CiB9CiAK IH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvRmxvYXRQb2ludDNELmggYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Zsb2F0UG9p bnQzRC5oCmluZGV4IDU1ZjcwZTcuLmNkOTViYmIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvRmxvYXRQb2ludDNELmgKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9GbG9hdFBvaW50M0QuaApAQCAtMjQsMjEgKzI0LDI0IEBACiAKICNpZiBFTkFCTEUoU1ZHKQog CisjaW5jbHVkZSAiRmxvYXRQb2ludC5oIgorCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIGNsYXNz IEZsb2F0UG9pbnQzRCB7CiBwdWJsaWM6CiAgICAgRmxvYXRQb2ludDNEKCk7CiAgICAgRmxvYXRQ b2ludDNEKGZsb2F0IHgsIGZsb2F0IHksIGZsb2F0IHopOworICAgIEZsb2F0UG9pbnQzRChjb25z dCBGbG9hdFBvaW50Jik7CiAKLSAgICBmbG9hdCB4KCkgY29uc3Q7Ci0gICAgdm9pZCBzZXRYKGZs b2F0IHgpOworICAgIGZsb2F0IHgoKSBjb25zdCB7IHJldHVybiBtX3g7IH0KKyAgICB2b2lkIHNl dFgoZmxvYXQgeCkgeyBtX3ggPSB4OyB9CiAKLSAgICBmbG9hdCB5KCkgY29uc3Q7Ci0gICAgdm9p ZCBzZXRZKGZsb2F0IHkpOworICAgIGZsb2F0IHkoKSBjb25zdCB7IHJldHVybiBtX3k7IH0KKyAg ICB2b2lkIHNldFkoZmxvYXQgeSkgeyBtX3kgPSB5OyB9CiAKLSAgICBmbG9hdCB6KCkgY29uc3Q7 Ci0gICAgdm9pZCBzZXRaKGZsb2F0IHopOworICAgIGZsb2F0IHooKSBjb25zdCB7IHJldHVybiBt X3o7IH0KKyAgICB2b2lkIHNldFooZmxvYXQgeikgeyBtX3ogPSB6OyB9CiAKICAgICB2b2lkIG5v cm1hbGl6ZSgpOwogCg==