227889 2021-07-12 16:25:48 -0700 [build.webkit.org] Upload layout-tests results immediately after running layout-tests 2021-07-19 16:16:53 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain clopez jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1776486 0 aakash_jain 2021-07-12 16:25:48 -0700 Currently on build.webkit.org builds, we run layout-tests, then we run various other test suites (e.g.: api, webkitpy, webkitperl, etc.), then we upload the layout-test results and make them accessible to the user. After finishing the layout-tests, there can be a delay of upto an hour before results are uploaded and made available to the user, e.g.: see step 11 and 21 in https://build.webkit.org/#/builders/59/builds/1972. We should upload the layout test results immediately after completing layout-tests. 1776487 1 433369 aakash_jain 2021-07-12 16:27:42 -0700 Created attachment 433369 Patch 1776488 2 433370 aakash_jain 2021-07-12 16:30:36 -0700 Created attachment 433370 Patch 1776492 3 433370 clopez 2021-07-12 16:45:06 -0700 Comment on attachment 433370 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433370&action=review > Tools/CISupport/build-webkit-org/factories.py:103 > self.addStep(self.LayoutTestClass()) > + self.addStep(ArchiveTestResults()) > + self.addStep(UploadTestResults()) > + self.addStep(ExtractTestResults()) > + self.addStep(SetPermissions()) Maybe RunDashboardTests() should run before ExtractTestResults() ? so the "view dashboard test results" links that appears when you click on the arrow on the step of "extract-test-results" works? Not sure if its really needed that it runs before. 1776496 4 aakash_jain 2021-07-12 16:56:00 -0700 (In reply to Carlos Alberto Lopez Perez from comment #3) > Maybe RunDashboardTests() should run before ExtractTestResults() ? so the "view dashboard test results" links that appears when you click on the arrow on the step of "extract-test-results" works? Good point, will do that. 1776600 5 433402 aakash_jain 2021-07-13 05:44:33 -0700 Created attachment 433402 Patch 1776601 6 aakash_jain 2021-07-13 05:45:44 -0700 Sample run: https://build.webkit-dev.org/#/builders/82/builds/8 1776654 7 ews-feeder 2021-07-13 09:46:25 -0700 Committed r279875 (239628@main): <https://commits.webkit.org/239628@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433402. 1776655 8 webkit-bug-importer 2021-07-13 09:47:16 -0700 <rdar://problem/80523498> 1778039 9 aakash_jain 2021-07-19 16:16:53 -0700 build.webkit.org was restarted to pick up this change. Seems to be working fine, e.g.: https://build.webkit.org/#/builders/48/builds/4133 433369 2021-07-12 16:27:42 -0700 2021-07-12 16:30:33 -0700 Patch bug-227889-20210712192741.patch text/plain 1929 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3OTg1NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDIxLTA3LTEyICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbYnVpbGQud2Via2l0Lm9yZ10gVXBsb2FkIGxheW91dC10ZXN0cyByZXN1 bHRzIGltbWVkaWF0ZWx5IGFmdGVyIHJ1bm5pbmcgbGF5b3V0LXRlc3RzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjc4ODkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIENJU3VwcG9ydC9idWlsZC13ZWJr aXQtb3JnL2ZhY3Rvcmllcy5weToKKwogMjAyMS0wNy0xMiAgVGltIEhvcnRvbiAgPHRpbW90aHlf aG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBCaWZ1cmNhdGVkR3JhcGhpY3NDb250ZXh0IGNh bid0IGRyYXcgdGV4dApJbmRleDogVG9vbHMvQ0lTdXBwb3J0L2J1aWxkLXdlYmtpdC1vcmcvZmFj dG9yaWVzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NJU3VwcG9ydC9idWlsZC13ZWJraXQtb3Jn L2ZhY3Rvcmllcy5weQkocmV2aXNpb24gMjc5ODU1KQorKysgVG9vbHMvQ0lTdXBwb3J0L2J1aWxk LXdlYmtpdC1vcmcvZmFjdG9yaWVzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC05Nyw2ICs5NywxMCBA QCBjbGFzcyBUZXN0RmFjdG9yeShGYWN0b3J5KToKICAgICAgICAgICAgIHNlbGYuYWRkU3RlcChz ZWxmLkpTQ1Rlc3RDbGFzcygpKQogICAgICAgICBpZiBzZWxmLkxheW91dFRlc3RDbGFzczoKICAg ICAgICAgICAgIHNlbGYuYWRkU3RlcChzZWxmLkxheW91dFRlc3RDbGFzcygpKQorICAgICAgICAg ICAgc2VsZi5hZGRTdGVwKEFyY2hpdmVUZXN0UmVzdWx0cygpKQorICAgICAgICAgICAgc2VsZi5h ZGRTdGVwKFVwbG9hZFRlc3RSZXN1bHRzKCkpCisgICAgICAgICAgICBzZWxmLmFkZFN0ZXAoRXh0 cmFjdFRlc3RSZXN1bHRzKCkpCisgICAgICAgICAgICBzZWxmLmFkZFN0ZXAoU2V0UGVybWlzc2lv bnMoKSkKIAogICAgICAgICBpZiBwbGF0Zm9ybS5zdGFydHN3aXRoKCd3aW4nKSBvciBwbGF0Zm9y bS5zdGFydHN3aXRoKCdtYWMnKSBvciBwbGF0Zm9ybS5zdGFydHN3aXRoKCdpb3Mtc2ltdWxhdG9y Jyk6CiAgICAgICAgICAgICBzZWxmLmFkZFN0ZXAoUnVuQVBJVGVzdHMoKSkKQEAgLTExNCwxMSAr MTE4LDYgQEAgY2xhc3MgVGVzdEZhY3RvcnkoRmFjdG9yeSk6CiAgICAgICAgIGlmIHBsYXRmb3Jt LnN0YXJ0c3dpdGgoJ21hYycpIG9yIHBsYXRmb3JtLnN0YXJ0c3dpdGgoJ2lvcy1zaW11bGF0b3In KToKICAgICAgICAgICAgIHNlbGYuYWRkU3RlcChUcmlnZ2VyQ3Jhc2hMb2dTdWJtaXNzaW9uKCkp CiAKLSAgICAgICAgaWYgc2VsZi5MYXlvdXRUZXN0Q2xhc3M6Ci0gICAgICAgICAgICBzZWxmLmFk ZFN0ZXAoQXJjaGl2ZVRlc3RSZXN1bHRzKCkpCi0gICAgICAgICAgICBzZWxmLmFkZFN0ZXAoVXBs b2FkVGVzdFJlc3VsdHMoKSkKLSAgICAgICAgICAgIHNlbGYuYWRkU3RlcChFeHRyYWN0VGVzdFJl c3VsdHMoKSkKLSAgICAgICAgICAgIHNlbGYuYWRkU3RlcChTZXRQZXJtaXNzaW9ucygpKQogICAg ICAgICBpZiBwbGF0Zm9ybSA9PSAiZ3RrIjoKICAgICAgICAgICAgIHNlbGYuYWRkU3RlcChSdW5H dGtBUElUZXN0cygpKQogICAgICAgICAgICAgaWYgYWRkaXRpb25hbEFyZ3VtZW50cyBhbmQgIi0t ZGlzcGxheS1zZXJ2ZXI9d2F5bGFuZCIgaW4gYWRkaXRpb25hbEFyZ3VtZW50czoK 433370 2021-07-12 16:30:36 -0700 2021-07-13 05:44:31 -0700 Patch bug-227889-20210712193035.patch text/plain 2206 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3OTg1NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDIxLTA3LTEyICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbYnVpbGQud2Via2l0Lm9yZ10gVXBsb2FkIGxheW91dC10ZXN0cyByZXN1 bHRzIGltbWVkaWF0ZWx5IGFmdGVyIHJ1bm5pbmcgbGF5b3V0LXRlc3RzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjc4ODkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIENJU3VwcG9ydC9idWlsZC13ZWJr aXQtb3JnL2ZhY3Rvcmllcy5weToKKwogMjAyMS0wNy0xMiAgVGltIEhvcnRvbiAgPHRpbW90aHlf aG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBCaWZ1cmNhdGVkR3JhcGhpY3NDb250ZXh0IGNh bid0IGRyYXcgdGV4dApJbmRleDogVG9vbHMvQ0lTdXBwb3J0L2J1aWxkLXdlYmtpdC1vcmcvZmFj dG9yaWVzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NJU3VwcG9ydC9idWlsZC13ZWJraXQtb3Jn L2ZhY3Rvcmllcy5weQkocmV2aXNpb24gMjc5ODU1KQorKysgVG9vbHMvQ0lTdXBwb3J0L2J1aWxk LXdlYmtpdC1vcmcvZmFjdG9yaWVzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xLDQgKzEsNCBAQAot IyBDb3B5cmlnaHQgKEMpIDIwMTctMjAyMCBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQu CisjIENvcHlyaWdodCAoQykgMjAxNy0yMDIxIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZl ZC4KICMKICMgUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jt cywgd2l0aCBvciB3aXRob3V0CiAjIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRl ZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtOTcsNiArOTcsMTAgQEAgY2xhc3Mg VGVzdEZhY3RvcnkoRmFjdG9yeSk6CiAgICAgICAgICAgICBzZWxmLmFkZFN0ZXAoc2VsZi5KU0NU ZXN0Q2xhc3MoKSkKICAgICAgICAgaWYgc2VsZi5MYXlvdXRUZXN0Q2xhc3M6CiAgICAgICAgICAg ICBzZWxmLmFkZFN0ZXAoc2VsZi5MYXlvdXRUZXN0Q2xhc3MoKSkKKyAgICAgICAgICAgIHNlbGYu YWRkU3RlcChBcmNoaXZlVGVzdFJlc3VsdHMoKSkKKyAgICAgICAgICAgIHNlbGYuYWRkU3RlcChV cGxvYWRUZXN0UmVzdWx0cygpKQorICAgICAgICAgICAgc2VsZi5hZGRTdGVwKEV4dHJhY3RUZXN0 UmVzdWx0cygpKQorICAgICAgICAgICAgc2VsZi5hZGRTdGVwKFNldFBlcm1pc3Npb25zKCkpCiAK ICAgICAgICAgaWYgcGxhdGZvcm0uc3RhcnRzd2l0aCgnd2luJykgb3IgcGxhdGZvcm0uc3RhcnRz d2l0aCgnbWFjJykgb3IgcGxhdGZvcm0uc3RhcnRzd2l0aCgnaW9zLXNpbXVsYXRvcicpOgogICAg ICAgICAgICAgc2VsZi5hZGRTdGVwKFJ1bkFQSVRlc3RzKCkpCkBAIC0xMTQsMTEgKzExOCw2IEBA IGNsYXNzIFRlc3RGYWN0b3J5KEZhY3RvcnkpOgogICAgICAgICBpZiBwbGF0Zm9ybS5zdGFydHN3 aXRoKCdtYWMnKSBvciBwbGF0Zm9ybS5zdGFydHN3aXRoKCdpb3Mtc2ltdWxhdG9yJyk6CiAgICAg ICAgICAgICBzZWxmLmFkZFN0ZXAoVHJpZ2dlckNyYXNoTG9nU3VibWlzc2lvbigpKQogCi0gICAg ICAgIGlmIHNlbGYuTGF5b3V0VGVzdENsYXNzOgotICAgICAgICAgICAgc2VsZi5hZGRTdGVwKEFy Y2hpdmVUZXN0UmVzdWx0cygpKQotICAgICAgICAgICAgc2VsZi5hZGRTdGVwKFVwbG9hZFRlc3RS ZXN1bHRzKCkpCi0gICAgICAgICAgICBzZWxmLmFkZFN0ZXAoRXh0cmFjdFRlc3RSZXN1bHRzKCkp Ci0gICAgICAgICAgICBzZWxmLmFkZFN0ZXAoU2V0UGVybWlzc2lvbnMoKSkKICAgICAgICAgaWYg cGxhdGZvcm0gPT0gImd0ayI6CiAgICAgICAgICAgICBzZWxmLmFkZFN0ZXAoUnVuR3RrQVBJVGVz dHMoKSkKICAgICAgICAgICAgIGlmIGFkZGl0aW9uYWxBcmd1bWVudHMgYW5kICItLWRpc3BsYXkt c2VydmVyPXdheWxhbmQiIGluIGFkZGl0aW9uYWxBcmd1bWVudHM6Cg== 433402 2021-07-13 05:44:33 -0700 2021-07-13 09:46:25 -0700 Patch bug-227889-20210713084432.patch text/plain 2558 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3OTg3MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDIxLTA3LTEzICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbYnVpbGQud2Via2l0Lm9yZ10gVXBsb2FkIGxheW91dC10ZXN0cyByZXN1 bHRzIGltbWVkaWF0ZWx5IGFmdGVyIHJ1bm5pbmcgbGF5b3V0LXRlc3RzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjc4ODkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIENJU3VwcG9ydC9idWlsZC13ZWJr aXQtb3JnL2ZhY3Rvcmllcy5weToKKwogMjAyMS0wNy0xMiAgRmlsaXAgUGl6bG8gIDxmcGl6bG9A YXBwbGUuY29tPiBhbmQgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAg ICAgIE5ldyBtYWxsb2MgYWxnb3JpdGhtCkluZGV4OiBUb29scy9DSVN1cHBvcnQvYnVpbGQtd2Vi a2l0LW9yZy9mYWN0b3JpZXMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ0lTdXBwb3J0L2J1aWxk LXdlYmtpdC1vcmcvZmFjdG9yaWVzLnB5CShyZXZpc2lvbiAyNzk4NzApCisrKyBUb29scy9DSVN1 cHBvcnQvYnVpbGQtd2Via2l0LW9yZy9mYWN0b3JpZXMucHkJKHdvcmtpbmcgY29weSkKQEAgLTEs NCArMSw0IEBACi0jIENvcHlyaWdodCAoQykgMjAxNy0yMDIwIEFwcGxlIEluYy4gQWxsIHJpZ2h0 cyByZXNlcnZlZC4KKyMgQ29weXJpZ2h0IChDKSAyMDE3LTIwMjEgQXBwbGUgSW5jLiBBbGwgcmln aHRzIHJlc2VydmVkLgogIwogIyBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQg YmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICMgbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0 dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC05Nyw2ICs5Nywx MyBAQCBjbGFzcyBUZXN0RmFjdG9yeShGYWN0b3J5KToKICAgICAgICAgICAgIHNlbGYuYWRkU3Rl cChzZWxmLkpTQ1Rlc3RDbGFzcygpKQogICAgICAgICBpZiBzZWxmLkxheW91dFRlc3RDbGFzczoK ICAgICAgICAgICAgIHNlbGYuYWRkU3RlcChzZWxmLkxheW91dFRlc3RDbGFzcygpKQorICAgICAg ICBpZiBub3QgcGxhdGZvcm0uc3RhcnRzd2l0aCgnd2luJyk6CisgICAgICAgICAgICBzZWxmLmFk ZFN0ZXAoUnVuRGFzaGJvYXJkVGVzdHMoKSkKKyAgICAgICAgaWYgc2VsZi5MYXlvdXRUZXN0Q2xh c3M6CisgICAgICAgICAgICBzZWxmLmFkZFN0ZXAoQXJjaGl2ZVRlc3RSZXN1bHRzKCkpCisgICAg ICAgICAgICBzZWxmLmFkZFN0ZXAoVXBsb2FkVGVzdFJlc3VsdHMoKSkKKyAgICAgICAgICAgIHNl bGYuYWRkU3RlcChFeHRyYWN0VGVzdFJlc3VsdHMoKSkKKyAgICAgICAgICAgIHNlbGYuYWRkU3Rl cChTZXRQZXJtaXNzaW9ucygpKQogCiAgICAgICAgIGlmIHBsYXRmb3JtLnN0YXJ0c3dpdGgoJ3dp bicpIG9yIHBsYXRmb3JtLnN0YXJ0c3dpdGgoJ21hYycpIG9yIHBsYXRmb3JtLnN0YXJ0c3dpdGgo J2lvcy1zaW11bGF0b3InKToKICAgICAgICAgICAgIHNlbGYuYWRkU3RlcChSdW5BUElUZXN0cygp KQpAQCAtMTA4LDE3ICsxMTUsMTAgQEAgY2xhc3MgVGVzdEZhY3RvcnkoRmFjdG9yeSk6CiAgICAg ICAgIHNlbGYuYWRkU3RlcChSdW5QZXJsVGVzdHMoKSkKICAgICAgICAgc2VsZi5hZGRTdGVwKFJ1 bkJpbmRpbmdzVGVzdHMoKSkKICAgICAgICAgc2VsZi5hZGRTdGVwKFJ1bkJ1aWx0aW5zVGVzdHMo KSkKLSAgICAgICAgaWYgbm90IHBsYXRmb3JtLnN0YXJ0c3dpdGgoJ3dpbicpOgotICAgICAgICAg ICAgc2VsZi5hZGRTdGVwKFJ1bkRhc2hib2FyZFRlc3RzKCkpCiAKICAgICAgICAgaWYgcGxhdGZv cm0uc3RhcnRzd2l0aCgnbWFjJykgb3IgcGxhdGZvcm0uc3RhcnRzd2l0aCgnaW9zLXNpbXVsYXRv cicpOgogICAgICAgICAgICAgc2VsZi5hZGRTdGVwKFRyaWdnZXJDcmFzaExvZ1N1Ym1pc3Npb24o KSkKIAotICAgICAgICBpZiBzZWxmLkxheW91dFRlc3RDbGFzczoKLSAgICAgICAgICAgIHNlbGYu YWRkU3RlcChBcmNoaXZlVGVzdFJlc3VsdHMoKSkKLSAgICAgICAgICAgIHNlbGYuYWRkU3RlcChV cGxvYWRUZXN0UmVzdWx0cygpKQotICAgICAgICAgICAgc2VsZi5hZGRTdGVwKEV4dHJhY3RUZXN0 UmVzdWx0cygpKQotICAgICAgICAgICAgc2VsZi5hZGRTdGVwKFNldFBlcm1pc3Npb25zKCkpCiAg ICAgICAgIGlmIHBsYXRmb3JtID09ICJndGsiOgogICAgICAgICAgICAgc2VsZi5hZGRTdGVwKFJ1 bkd0a0FQSVRlc3RzKCkpCiAgICAgICAgICAgICBpZiBhZGRpdGlvbmFsQXJndW1lbnRzIGFuZCAi LS1kaXNwbGF5LXNlcnZlcj13YXlsYW5kIiBpbiBhZGRpdGlvbmFsQXJndW1lbnRzOgo=