227861 2021-07-11 15:24:54 -0700 Remove an unused deprecated private UI delegate method 2021-07-11 16:42:19 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh hi kkinnunen megan_gardner thorton webkit-bug-importer oldest_to_newest 1776228 0 wenson_hsieh 2021-07-11 15:24:54 -0700 No longer needed after rdar://79700201. 1776229 1 433292 wenson_hsieh 2021-07-11 15:34:09 -0700 Created attachment 433292 Patch 1776231 2 433292 wenson_hsieh 2021-07-11 16:36:50 -0700 Comment on attachment 433292 Patch Thanks for the review! 1776234 3 ews-feeder 2021-07-11 16:41:10 -0700 Committed r279817 (239578@main): <https://commits.webkit.org/239578@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433292. 1776235 4 webkit-bug-importer 2021-07-11 16:42:19 -0700 <rdar://problem/80442181> 433292 2021-07-11 15:34:09 -0700 2021-07-11 16:41:10 -0700 Patch bug-227861-20210711153409.patch text/plain 5140 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5NzcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGVlNTU3YjVlNzVmNWVkNzg3 ZTI3MzFiNzAzMmE5NTI2ZmVlNTJmYTUuLjk5OWVjZWU5Y2QzNWY5ZmE4Y2E0YmE3Mzg0NTgyM2Ew OWNlZmY2MjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjEtMDctMTEgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIGFuIHVudXNl ZCBkZXByZWNhdGVkIHByaXZhdGUgVUkgZGVsZWdhdGUgbWV0aG9kCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjc4NjEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBgLV93ZWJWaWV3OmRpZE5vdEhhbmRsZVRh cEFzTWVhbmluZ2Z1bENsaWNrQXRQb2ludDpgIGlzIHJlcGxhY2VkIHdpdGggYC1fd2ViVmlldzpk aWRUYXBBdFBvaW50OndpdGhSZXN1bHQ6YDsKKyAgICAgICAgdGhlIG9sZCBTUEkgaXMgbm8gbG9u Z2VyIHJlcXVpcmVkIGZvciBlaXRoZXIgYmluYXJ5IG9yIHNvdXJjZSBjb21wYXRpYmlsaXR5IGFm dGVyIHJkYXI6Ly83OTcwMDIwMS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tV SURlbGVnYXRlUHJpdmF0ZS5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9Db2NvYS9VSURlbGVnYXRl Lmg6CisgICAgICAgICogVUlQcm9jZXNzL0NvY29hL1VJRGVsZWdhdGUubW06CisgICAgICAgIChX ZWJLaXQ6OlVJRGVsZWdhdGU6OnNldERlbGVnYXRlKToKKyAgICAgICAgKFdlYktpdDo6VUlEZWxl Z2F0ZTo6VUlDbGllbnQ6OmRpZFRhcEF0UG9pbnQpOgorCiAyMDIxLTA3LTExICBXZW5zb24gSHNp ZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIFt3YXRjaE9TXSBNYWtlIGEg ZmV3IGFkZGl0aW9uYWwgYWRqdXN0bWVudHMgdG8gc3VwcG9ydCBzeXN0ZW0gbWluaW11bSBsYXlv dXQgbWFyZ2lucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29h L1dLVUlEZWxlZ2F0ZVByaXZhdGUuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2Nv YS9XS1VJRGVsZWdhdGVQcml2YXRlLmgKaW5kZXggMTFiYjg3MjZjZGY0NjMyZTBhY2RkMzkzN2Mx YmU3ODgzYjNhYjZhYy4uMjgxOGIzNWMxNDMzM2Q3N2M0MmMzODYxZTE3NTY4N2Y3MDVkOGI0NiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLVUlEZWxlZ2F0 ZVByaXZhdGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tVSURl bGVnYXRlUHJpdmF0ZS5oCkBAIC0xNjUsNyArMTY1LDYgQEAgc3RydWN0IFVJRWRnZUluc2V0czsK IC0gKEJPT0wpX3dlYlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcgc2hvdWxkSW5jbHVkZUFwcExp bmtBY3Rpb25zRm9yRWxlbWVudDooX1dLQWN0aXZhdGVkRWxlbWVudEluZm8gKillbGVtZW50IFdL X0FQSV9BVkFJTEFCTEUoaW9zKDkuMCkpOwogLSAoTlNBcnJheSAqKV93ZWJWaWV3OihXS1dlYlZp ZXcgKil3ZWJWaWV3IGFjdGlvbnNGb3JFbGVtZW50OihfV0tBY3RpdmF0ZWRFbGVtZW50SW5mbyAq KWVsZW1lbnQgZGVmYXVsdEFjdGlvbnM6KE5TQXJyYXk8X1dLRWxlbWVudEFjdGlvbiAqPiAqKWRl ZmF1bHRBY3Rpb25zOwogLSAodm9pZClfd2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldyBkaWRO b3RIYW5kbGVUYXBBc0NsaWNrQXRQb2ludDooQ0dQb2ludClwb2ludDsKLS0gKHZvaWQpX3dlYlZp ZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcgZGlkTm90SGFuZGxlVGFwQXNNZWFuaW5nZnVsQ2xpY2tB dFBvaW50OihDR1BvaW50KXBvaW50IFdLX0FQSV9ERVBSRUNBVEVEX1dJVEhfUkVQTEFDRU1FTlQo Il93ZWJWaWV3OmRpZFRhcEF0UG9pbnQ6d2l0aFJlc3VsdDoiLCBpb3MoMTUuMCwgMTUuMCkpOwog LSAodm9pZClfd2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldyBkaWRUYXBBdFBvaW50OihDR1Bv aW50KXBvaW50IHdpdGhSZXN1bHQ6KF9XS1RhcEhhbmRsaW5nUmVzdWx0KXJlc3VsdCBXS19BUElf QVZBSUxBQkxFKGlvcygxNS4wKSk7CiAtICh2b2lkKV93ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJW aWV3IHJlcXVlc3RHZW9sb2NhdGlvbkF1dGhvcml6YXRpb25Gb3JVUkw6KE5TVVJMICopdXJsIGZy YW1lOihXS0ZyYW1lSW5mbyAqKWZyYW1lIGRlY2lzaW9uSGFuZGxlcjoodm9pZCAoXikoQk9PTCBh dXRob3JpemVkKSlkZWNpc2lvbkhhbmRsZXIgV0tfQVBJX0FWQUlMQUJMRShpb3MoMTEuMCkpOwog LSAoQk9PTClfd2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldyBmaWxlVXBsb2FkUGFuZWxDb250 ZW50SXNNYW5hZ2VkV2l0aEluaXRpYXRpbmdGcmFtZTooV0tGcmFtZUluZm8gKilmcmFtZTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1VJRGVsZWdhdGUuaCBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1VJRGVsZWdhdGUuaAppbmRleCA4NDk5MDA2NDlh MmM2ZWUxMTU5NWQ3NDNkZTVhMWU2ZjE4OGY0OGU3Li41NzhhYzk0OTRiZTUyMTlmNGMzNGZjNDll NGE0ZDUzN2NjZThkNTYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2Nv YS9VSURlbGVnYXRlLmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvVUlEZWxl Z2F0ZS5oCkBAIC0yNDAsNyArMjQwLDYgQEAgcHJpdmF0ZToKICNlbmRpZgogICAgICAgICBib29s IHdlYlZpZXdBY3Rpb25zRm9yRWxlbWVudERlZmF1bHRBY3Rpb25zIDogMTsKICAgICAgICAgYm9v bCB3ZWJWaWV3RGlkTm90SGFuZGxlVGFwQXNDbGlja0F0UG9pbnQgOiAxOwotICAgICAgICBib29s IHdlYlZpZXdEaWROb3RIYW5kbGVUYXBBc01lYW5pbmdmdWxDbGlja0F0UG9pbnQgOiAxOwogICAg ICAgICBib29sIHdlYlZpZXdEaWRUYXBBdFBvaW50V2l0aFJlc3VsdCA6IDE7CiAgICAgICAgIGJv b2wgcHJlc2VudGluZ1ZpZXdDb250cm9sbGVyRm9yV2ViVmlldyA6IDE7CiAjZW5kaWYKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1VJRGVsZWdhdGUubW0gYi9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9VSURlbGVnYXRlLm1tCmluZGV4IDM4ODQyOTA4N2Ex YTM2OGE1MmQ1OTgzZWQ4NjViNjEzNzNiMzM5OTYuLjhkNTM0MmU2YzBhNTFlZGUxN2RkOWI4OWUx ZTg1YjIxNDE3MjExOGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29h L1VJRGVsZWdhdGUubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvVUlEZWxl Z2F0ZS5tbQpAQCAtMTU5LDcgKzE1OSw2IEBAIHZvaWQgVUlEZWxlZ2F0ZTo6c2V0RGVsZWdhdGUo aWQgPFdLVUlEZWxlZ2F0ZT4gZGVsZWdhdGUpCiAjZW5kaWYKICAgICBtX2RlbGVnYXRlTWV0aG9k cy53ZWJWaWV3QWN0aW9uc0ZvckVsZW1lbnREZWZhdWx0QWN0aW9ucyA9IFtkZWxlZ2F0ZSByZXNw b25kc1RvU2VsZWN0b3I6QHNlbGVjdG9yKF93ZWJWaWV3OmFjdGlvbnNGb3JFbGVtZW50OmRlZmF1 bHRBY3Rpb25zOildOwogICAgIG1fZGVsZWdhdGVNZXRob2RzLndlYlZpZXdEaWROb3RIYW5kbGVU YXBBc0NsaWNrQXRQb2ludCA9IFtkZWxlZ2F0ZSByZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVjdG9y KF93ZWJWaWV3OmRpZE5vdEhhbmRsZVRhcEFzQ2xpY2tBdFBvaW50OildOwotICAgIG1fZGVsZWdh dGVNZXRob2RzLndlYlZpZXdEaWROb3RIYW5kbGVUYXBBc01lYW5pbmdmdWxDbGlja0F0UG9pbnQg PSBbZGVsZWdhdGUgcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3Rvcihfd2ViVmlldzpkaWROb3RI YW5kbGVUYXBBc01lYW5pbmdmdWxDbGlja0F0UG9pbnQ6KV07CiAgICAgbV9kZWxlZ2F0ZU1ldGhv ZHMud2ViVmlld0RpZFRhcEF0UG9pbnRXaXRoUmVzdWx0ID0gW2RlbGVnYXRlIHJlc3BvbmRzVG9T ZWxlY3RvcjpAc2VsZWN0b3IoX3dlYlZpZXc6ZGlkVGFwQXRQb2ludDp3aXRoUmVzdWx0OildOwog ICAgIG1fZGVsZWdhdGVNZXRob2RzLnByZXNlbnRpbmdWaWV3Q29udHJvbGxlckZvcldlYlZpZXcg PSBbZGVsZWdhdGUgcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3RvcihfcHJlc2VudGluZ1ZpZXdD b250cm9sbGVyRm9yV2ViVmlldzopXTsKICNlbmRpZgpAQCAtMTQyNiwxMiArMTQyNSw2IEBAIHZv aWQgVUlEZWxlZ2F0ZTo6VUlDbGllbnQ6OmRpZFRhcEF0UG9pbnQoY29uc3QgV2ViQ29yZTo6SW50 UG9pbnQmIHBvaW50LCBXZWJLaXQ6CiAKICAgICBpZiAobV91aURlbGVnYXRlLT5tX2RlbGVnYXRl TWV0aG9kcy53ZWJWaWV3RGlkVGFwQXRQb2ludFdpdGhSZXN1bHQpCiAgICAgICAgIFtzdGF0aWNf Y2FzdDxpZCA8V0tVSURlbGVnYXRlUHJpdmF0ZT4+KGRlbGVnYXRlKSBfd2ViVmlldzptX3VpRGVs ZWdhdGUtPm1fd2ViVmlldy5nZXQoKS5nZXQoKSBkaWRUYXBBdFBvaW50OnBvaW50IHdpdGhSZXN1 bHQ6d2tUYXBIYW5kbGluZ1Jlc3VsdChyZXN1bHQpXTsKLQotICAgIEFMTE9XX0RFUFJFQ0FURURf REVDTEFSQVRJT05TX0JFR0lOCi0gICAgLy8gRklYTUU6IFJlbW92ZSB0aGlzIG9uY2UgYWxsIGlu dGVybmFsIGNsaWVudHMgYWRvcHQgLV93ZWJWaWV3OmRpZFRhcEF0UG9pbnQ6d2l0aFJlc3VsdDou Ci0gICAgaWYgKG1fdWlEZWxlZ2F0ZS0+bV9kZWxlZ2F0ZU1ldGhvZHMud2ViVmlld0RpZE5vdEhh bmRsZVRhcEFzTWVhbmluZ2Z1bENsaWNrQXRQb2ludCAmJiByZXN1bHQgIT0gV2ViS2l0OjpUYXBI YW5kbGluZ1Jlc3VsdDo6TWVhbmluZ2Z1bENsaWNrKQotICAgICAgICBbc3RhdGljX2Nhc3Q8aWQg PFdLVUlEZWxlZ2F0ZVByaXZhdGU+PihkZWxlZ2F0ZSkgX3dlYlZpZXc6bV91aURlbGVnYXRlLT5t X3dlYlZpZXcuZ2V0KCkuZ2V0KCkgZGlkTm90SGFuZGxlVGFwQXNNZWFuaW5nZnVsQ2xpY2tBdFBv aW50OnBvaW50XTsKLSAgICBBTExPV19ERVBSRUNBVEVEX0RFQ0xBUkFUSU9OU19FTkQKIH0KIAog VUlWaWV3Q29udHJvbGxlciAqVUlEZWxlZ2F0ZTo6VUlDbGllbnQ6OnByZXNlbnRpbmdWaWV3Q29u dHJvbGxlcigpCg==