227860 2021-07-11 10:47:34 -0700 [Cocoa] Incorrect deprecation declaration for -[WKWebView closeAllMediaPresentations:] 2021-07-12 10:10:35 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble beidson eric.carlson james.savage jean-yves.avenard katherine_cheney peng.liu6 sam thorton webkit-bug-importer youennf oldest_to_newest 1776220 0 jer.noble 2021-07-11 10:47:34 -0700 [Cocoa] Incorrect deprecation declaration for -[WKWebView closeAllMediaPresentations:] 1776221 1 jer.noble 2021-07-11 10:48:02 -0700 <rdar://80376777> 1776222 2 433290 jer.noble 2021-07-11 10:53:26 -0700 Created attachment 433290 Patch 1776225 3 433290 beidson 2021-07-11 14:53:22 -0700 Comment on attachment 433290 Patch What does this due to the swift case in betas that have shipped? 1776226 4 jer.noble 2021-07-11 15:03:45 -0700 (In reply to Brady Eidson from comment #3) > Comment on attachment 433290 [details] > Patch > > What does this due to the swift case in betas that have shipped? It should restore the .closeAllMediaPresentations() method to the swift mapping header. The deprecated API declaration was never exposed to swift, so to swift code, it appeared as if we just removed the API entirely. See: http://codeworkshop.net/objc-diff/sdkdiffs/ios/15.0/WebKit.html 1776242 5 beidson 2021-07-11 17:29:35 -0700 Great, then the r+ comes with my r+ too :P 1776357 6 ews-feeder 2021-07-12 10:10:32 -0700 Committed r279833 (239594@main): <https://commits.webkit.org/239594@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433290. 433290 2021-07-11 10:53:26 -0700 2021-07-12 10:10:33 -0700 Patch bug-227860-20210711105325.patch text/plain 5401 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5Nzg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDA1ZjFiYjQzYThiYjYzOTEz Zjg4ZTNlMjU5NDgzODA5Njg2YmQyN2YuLjZkY2I5NDY0NGY5MzdkMzNiMDY0M2Y5YWZiYTQ3YjZk Y2U3YmYwMzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjEtMDctMTEgIEplciBOb2Js ZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBJbmNvcnJlY3QgZGVw cmVjYXRpb24gZGVjbGFyYXRpb24gZm9yIC1bV0tXZWJWaWV3IGNsb3NlQWxsTWVkaWFQcmVzZW50 YXRpb25zOl0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIyNzg2MAorICAgICAgICA8cmRhcjovLzgwMzc2Nzc3PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIHIyNzc2NDUsIHdlIGFkZGVkIGEgZGVwcmVj YXRpb24gZGVjbGFyYXRpb24gZm9yIC1jbG9zZUFsbE1lZGlhUHJlc2VudGF0aW9uczpjb21wbGV0 aW9uLCBidXQKKyAgICAgICAgdGhhdCBBUEkgd2FzIG5ldmVyIHNoaXBwZWQgaW4gYSByZWxlYXNl LiBUaGUgYWN0dWFsIHNoaXBwZWQgQVBJLCAtY2xvc2VBbGxNZWRpYVByZXNlbnRhdGlvbnMsCisg ICAgICAgIHdhcyByZW1vdmVkIGVudGlyZWx5LCBsZWFkaW5nIHRvIGJpbmNvbXBhdCBjcmFzaGVz IHdoZW4gYmluYXJpZXMgYnVpbHQgYWdhaW5zdCBvbGRlciBTREtzIGFyZQorICAgICAgICBydW4g YWdhaW5zdCBuZXdlciBPU3MuCisKKyAgICAgICAgQ29ycmVjdCB0aGUgZGVwcmVjYXRlZCBBUEkg ZGVjbGFyYXRpb24sIGFuZCByZS1hZGQgc3VwcG9ydCBmb3IgLWNsb3NlQWxsTWVkaWFQcmVzZW50 YXRpb25zLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcuaDoKKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbToKKyAgICAgICAgKC1bV0tX ZWJWaWV3IGNsb3NlQWxsTWVkaWFQcmVzZW50YXRpb25zXSk6CisKIDIwMjEtMDctMDggIEplciBO b2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgW0NvY29hXSBBbGxvdyB0aGUg VUlQcm9jZXNzIHRvIHNldCBsb2dnaW5nIHBhcmFtZXRlcnMgaW4gdGhlIEdQVVByb2Nlc3MKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcuaCBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcuaAppbmRleCA4Y2Qz MWMzOGM2MDA5NmM3N2MwYmE3YmEyOTZhNjA4NDlmYzFkMTBiLi5kZTY3NGEzYWM2NzFjMzE0MWQ4 ZmM3YmM3ZDgzYmM4N2RlODYyNTBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9BUEkvQ29jb2EvV0tXZWJWaWV3LmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJ L0NvY29hL1dLV2ViVmlldy5oCkBAIC0zNDMsOSArMzQzLDcgQEAgdHlwZWRlZiBOU19FTlVNKE5T SW50ZWdlciwgV0tNZWRpYUNhcHR1cmVTdGF0ZSkgewogIEBkaXNjdXNzaW9uIEluY2x1ZGVzIHBp Y3R1cmUtaW4tcGljdHVyZSBhbmQgZnVsbHNjcmVlbi4KICAqLwogLSAodm9pZCljbG9zZUFsbE1l ZGlhUHJlc2VudGF0aW9uc1dpdGhDb21wbGV0aW9uSGFuZGxlcjoodm9pZCAoXl9OdWxsYWJsZSko dm9pZCkpY29tcGxldGlvbkhhbmRsZXIgV0tfQVBJX0FWQUlMQUJMRShtYWNvcygxMi4wKSwgaW9z KDE1LjApKTsKLSNpZm5kZWYgX19zd2lmdF9fCi0tICh2b2lkKWNsb3NlQWxsTWVkaWFQcmVzZW50 YXRpb25zOih2b2lkICheX051bGxhYmxlKSh2b2lkKSljb21wbGV0aW9uSGFuZGxlciBXS19BUElf REVQUkVDQVRFRF9XSVRIX1JFUExBQ0VNRU5UKCJjbG9zZUFsbE1lZGlhUHJlc2VudGF0aW9uc1dp dGhDb21wbGV0aW9uSGFuZGxlcjoiLCBtYWNvcygxMS4zLCAxMi4wKSwgaW9zKDE0LjUsIDE1LjAp KTsKLSNlbmRpZgorLSAodm9pZCljbG9zZUFsbE1lZGlhUHJlc2VudGF0aW9ucyBXS19BUElfREVQ UkVDQVRFRF9XSVRIX1JFUExBQ0VNRU5UKCJjbG9zZUFsbE1lZGlhUHJlc2VudGF0aW9uc1dpdGhD b21wbGV0aW9uSGFuZGxlcjoiLCBtYWNvcygxMS4zLCAxMi4wKSwgaW9zKDE0LjUsIDE1LjApKTsK IAogLyohIEBhYnN0cmFjdCBQYXVzZXMgbWVkaWEgcGxheWJhY2sgaW4gV0tXZWJWaWV3LgogIEBk aXNjdXNzaW9uIFBhdXNlcyBtZWRpYSBwbGF5YmFjay4gTWVkaWEgaW4gdGhlIHBhZ2UgY2FuIGJl IHJlc3RhcnRlZCBieSBjYWxsaW5nIHBsYXkoKSBvbiBhIG1lZGlhIGVsZW1lbnQgb3IgcmVzdW1l KCkgb24gYW4gQXVkaW9Db250ZXh0IGluIEphdmFTY3JpcHQuIEEgdXNlciBjYW4gYWxzbyB1c2Ug bWVkaWEgY29udHJvbHMgdG8gcGxheSBtZWRpYSBjb250ZW50IGFmdGVyIGl0IGhhcyBiZWVuIHBh dXNlZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dl YlZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1t CmluZGV4IDYyYmEwMmIyNmJjNjVmZjA2MzY0M2MwN2U2NzU2OWViZjgzYmI5ODQuLjJkZTIzNjE4 ODBiMDFhYTgxNTM4NTIzNDBhNTdhMmU5NjdiNjcxOGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KKysrIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQpAQCAtOTM0LDYgKzkzNCwxMSBAQCBzdGF0 aWMgYm9vbCB2YWxpZGF0ZUFyZ3VtZW50KGlkIGFyZ3VtZW50KQogICAgIHJldHVybiBmYWxzZTsK IH0KIAorLSAodm9pZCljbG9zZUFsbE1lZGlhUHJlc2VudGF0aW9ucworeworICAgIFtzZWxmIGNs b3NlQWxsTWVkaWFQcmVzZW50YXRpb25zV2l0aENvbXBsZXRpb25IYW5kbGVyOl57IH1dOworfQor CiAtICh2b2lkKWNsb3NlQWxsTWVkaWFQcmVzZW50YXRpb25zOih2b2lkICheKSh2b2lkKSljb21w bGV0aW9uSGFuZGxlcgogewogICAgIFtzZWxmIGNsb3NlQWxsTWVkaWFQcmVzZW50YXRpb25zV2l0 aENvbXBsZXRpb25IYW5kbGVyOmNvbXBsZXRpb25IYW5kbGVyXTsKZGlmZiAtLWdpdCBhL1Rvb2xz L0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlZTI0OTQwNDNkOGJmZjcxMWZiMmIy NzNmMjAxMTYwNDY3ZGNkZjdiLi5mYWI0ODk3ZDM2YThmY2E4MTc4ZDAwOTNhOTg4Y2NkODA2YTU5 N2Y3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMjEtMDctMTEgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5j b20+CisKKyAgICAgICAgW0NvY29hXSBJbmNvcnJlY3QgZGVwcmVjYXRpb24gZGVjbGFyYXRpb24g Zm9yIC1bV0tXZWJWaWV3IGNsb3NlQWxsTWVkaWFQcmVzZW50YXRpb25zOl0KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNzg2MAorICAgICAgICA8cmRh cjovLzgwMzc2Nzc3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9XS1dlYlZpZXdDbG9zZUFs bE1lZGlhUHJlc2VudGF0aW9ucy5tbToKKyAgICAgICAgKFRFU1QpOgorCiAyMDIxLTA3LTA5ICBD YXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgogCiAgICAgICAg IFt3ZWJraXRjb3JlcHldIHJ1bi13ZWJraXQtdGVzdHMgbWF5IGhhbmcgd2l0aCBweXRob24yIGFm dGVyIHIyNzE2ODMKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0 Q29jb2EvV0tXZWJWaWV3Q2xvc2VBbGxNZWRpYVByZXNlbnRhdGlvbnMubW0gYi9Ub29scy9UZXN0 V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1dLV2ViVmlld0Nsb3NlQWxsTWVkaWFQcmVzZW50 YXRpb25zLm1tCmluZGV4IDUzYzNjNmNhYmIxYWQ5MjcxZjRkODNlYWM5YmE4NmMwZGYyZjYxMTAu LmQ1NjJiOGYwNjdjMTI0Yjk5MTg5YjkxOTI1YTllM2MwYzY3YjRiZWIgMTAwNjQ0Ci0tLSBhL1Rv b2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvV0tXZWJWaWV3Q2xvc2VBbGxNZWRp YVByZXNlbnRhdGlvbnMubW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRD b2NvYS9XS1dlYlZpZXdDbG9zZUFsbE1lZGlhUHJlc2VudGF0aW9ucy5tbQpAQCAtMjA5LDQgKzIw OSwyMyBAQCBURVNUKFdLV2ViVmlld0Nsb3NlQWxsTWVkaWFQcmVzZW50YXRpb25zLCBNdWx0aXBs ZVNlcXVlbnRpYWxDbG9zZUFsbE1lZGlhUHJlc2VudAogICAgIEVYUEVDVF9UUlVFKFt3ZWJWaWV3 IF9hbGxNZWRpYVByZXNlbnRhdGlvbnNDbG9zZWRdKTsKIH0KIAorVEVTVChXS1dlYlZpZXdDbG9z ZUFsbE1lZGlhUHJlc2VudGF0aW9ucywgUmVtb3ZlZENsb3NlQWxsTWVkaWFQcmVzZW50YXRpb25B UElzKQoreworICAgIC8vIEluIHIyNzE5NzAsIHdlIHJlbmFtZWQgLWNsb3NlQWxsTWVkaWFQcmVz ZW50YXRpb25zIHRvIC1jbG9zZUFsbE1lZGlhUHJlc2VudGF0aW9uczpjb21wbGV0aW9uSGFuZGxl ciwgd2hpY2ggYnJva2UKKyAgICAvLyBiaW5hcnkgY29tcGF0YWJpbGl0eSBvZiBhcHBzIGxpbmtl ZCBhZ2FpbnN0IG9sZGVyIFNES3MuIEVuc3VyZSBjYWxsaW5nIHRoZSByZW1vdmVkIEFQSSBkb2Vz IG5vdCBjcmFzaC4KKworICAgIGF1dG8gKmNvbmZpZ3VyYXRpb24gPSBbV0tXZWJWaWV3Q29uZmln dXJhdGlvbiBfdGVzdF9jb25maWd1cmF0aW9uV2l0aFRlc3RQbHVnSW5DbGFzc05hbWU6QCJXZWJQ cm9jZXNzUGx1Z0luV2l0aEludGVybmFscyIgY29uZmlndXJlSlNDRm9yVGVzdGluZzpZRVNdOwor ICAgIGF1dG8gd2ViVmlldyA9IGFkb3B0TlMoW1tUZXN0V0tXZWJWaWV3IGFsbG9jXSBpbml0V2l0 aEZyYW1lOk5TTWFrZVJlY3QoMCwgMCwgODAwLCA2MDApIGNvbmZpZ3VyYXRpb246Y29uZmlndXJh dGlvbiBhZGRUb1dpbmRvdzpZRVNdKTsKKworICAgIEVYUEVDVF9UUlVFKFt3ZWJWaWV3IHJlc3Bv bmRzVG9TZWxlY3RvcjpAc2VsZWN0b3IoY2xvc2VBbGxNZWRpYVByZXNlbnRhdGlvbnMpXSk7CisK KyAgICBSZXRhaW5QdHI8TlNFeGNlcHRpb24+IGV4Y2VwdGlvbjsKKyAgICBAdHJ5IHsKKyAgICAg ICAgW3dlYlZpZXcgY2xvc2VBbGxNZWRpYVByZXNlbnRhdGlvbnNdOworICAgIH0gQGNhdGNoKE5T RXhjZXB0aW9uICpjYXVnaHQpIHsKKyAgICAgICAgZXhjZXB0aW9uID0gY2F1Z2h0OworICAgIH0K KyAgICBFWFBFQ1RfRkFMU0UoZXhjZXB0aW9uKTsKK30KKwogI2VuZGlmCg==