227848 2021-07-09 22:50:06 -0700 AX: Make WebKit observe spatial audio accessibility settings 2021-07-26 17:11:06 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach benjamin cdumez cmarcelo ews-watchlist mmaxfield pvollan sam tsavell webkit-bug-importer oldest_to_newest 1776131 0 cfleizach 2021-07-09 22:50:06 -0700 Make WebKit observe spatial audio settings on Mac <rdar://problem/73590412> 1776132 1 433257 cfleizach 2021-07-09 23:11:54 -0700 Created attachment 433257 patch 1776478 2 ews-feeder 2021-07-12 16:07:23 -0700 Committed r279855 (239609@main): <https://commits.webkit.org/239609@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433257. 1776559 3 mmaxfield 2021-07-12 23:55:14 -0700 This might have broken the internal build: Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:1173:27: error: unused function 'increaseContrastPreferenceKey' [-Werror,-Wunused-function] static const WTF::String& increaseContrastPreferenceKey() 1776565 4 cfleizach 2021-07-13 00:08:47 -0700 (In reply to Myles C. Maxfield from comment #3) > This might have broken the internal build: > > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:1173:27: error: unused > function 'increaseContrastPreferenceKey' [-Werror,-Wunused-function] > static const WTF::String& increaseContrastPreferenceKey() https://bugs.webkit.org/show_bug.cgi?id=227898 1779636 5 tsavell 2021-07-26 17:06:06 -0700 It looks like the changes in https://trac.webkit.org/changeset/279855/webkit broke TestWebKitAPI.AppleLanguagesTest.UpdateAppleLanguages on Big Sur history: https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.AppleLanguagesTest.UpdateAppleLanguages Diff: TestWebKitAPI.AppleLanguagesTest.UpdateAppleLanguages /Volumes/Data/worker/bigsur-release/build/Tools/TestWebKitAPI/Tests/WebKit/OverrideAppleLanguagesPreference.mm:179 Value of: didChangeLanguage Actual: false Expected: true /Volumes/Data/worker/bigsur-release/build/Tools/TestWebKitAPI/Tests/WebKit/OverrideAppleLanguagesPreference.mm:180 Value of: preferenceObserverPreferenceDidChangeCalled Actual: false Expected: true /Volumes/Data/worker/bigsur-release/build/Tools/TestWebKitAPI/Tests/WebKit/OverrideAppleLanguagesPreference.mm:181 Expected equality of these values: @"en-US" Which is: "en-US" preferredLanguage() Which is: "en-GB" I am able to reproduce this with command: run-api-tests TestWebKitAPI.AppleLanguagesTest.UpdateAppleLanguages I bisected this and was able to reproduce it on r279855 but no r279854 1779643 6 cfleizach 2021-07-26 17:11:06 -0700 (In reply to Truitt Savell from comment #5) > It looks like the changes in https://trac.webkit.org/changeset/279855/webkit > > broke TestWebKitAPI.AppleLanguagesTest.UpdateAppleLanguages on Big Sur > > history: > https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI. > AppleLanguagesTest.UpdateAppleLanguages > > Diff: > TestWebKitAPI.AppleLanguagesTest.UpdateAppleLanguages > > > /Volumes/Data/worker/bigsur-release/build/Tools/TestWebKitAPI/Tests/WebKit/ > OverrideAppleLanguagesPreference.mm:179 > Value of: didChangeLanguage > Actual: false > Expected: true > > > > /Volumes/Data/worker/bigsur-release/build/Tools/TestWebKitAPI/Tests/WebKit/ > OverrideAppleLanguagesPreference.mm:180 > Value of: preferenceObserverPreferenceDidChangeCalled > Actual: false > Expected: true > > > > /Volumes/Data/worker/bigsur-release/build/Tools/TestWebKitAPI/Tests/WebKit/ > OverrideAppleLanguagesPreference.mm:181 > Expected equality of these values: > @"en-US" > Which is: "en-US" > preferredLanguage() > Which is: "en-GB" > > I am able to reproduce this with command: > run-api-tests TestWebKitAPI.AppleLanguagesTest.UpdateAppleLanguages > > I bisected this and was able to reproduce it on r279855 but no r279854 this seems strange. maybe the test is not robust enough. otherwise I don't see anything here that would affect AppleLanguages 433257 2021-07-09 23:11:54 -0700 2021-07-12 16:07:24 -0700 patch file_227848.txt text/plain 3592 cfleizach ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cN CmluZGV4IDVlMTFmYWIxN2NhOC4uMzI3MjFlYTAxNDNmIDEwMDY0NA0KLS0tIGEvU291cmNlL1dU Ri9DaGFuZ2VMb2cNCisrKyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nDQpAQCAtMSwzICsxLDE0IEBA DQorMjAyMS0wNy0wOSAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPg0KKw0K KyAgICAgICAgQVg6IE1ha2UgV2ViS2l0IG9ic2VydmUgc3BhdGlhbCBhdWRpbyBhY2Nlc3NpYmls aXR5IHNldHRpbmdzDQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjI3ODQ4DQorDQorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4NCisN CisgICAgICAgIFRoaXMgZmxhZyB3YXMgdXNpbmcgdGhlIHdyb25nIGZvcm1hdCBmb3IgYSBIQVZF IHNldHRpbmcsIHNvIHRoZSBjb2RlIHdhc24ndCBiZWluZyBjb21waWxlZCBpbi4NCisNCisgICAg ICAgICogd3RmL1BsYXRmb3JtSGF2ZS5oOg0KKw0KIDIwMjEtMDctMDcgIEFsZXggQ2hyaXN0ZW5z ZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4NCiANCiAgICAgICAgIFVSTCBob3N0IHNldHRl ciBzaG91bGQgcGFzcyBob3N0IHRvIFVSTFBhcnNlciBpbnN0ZWFkIG9mIHRyeWluZyB0byBlbmNv ZGUgaXQgaXRzZWxmDQpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvUGxhdGZvcm1IYXZlLmgg Yi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUhhdmUuaA0KaW5kZXggMTQ1NmI3NzE3ZThmLi40YmEy YzZlMDU2MmEgMTAwNjQ0DQotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUhhdmUuaA0KKysr IGIvU291cmNlL1dURi93dGYvUGxhdGZvcm1IYXZlLmgNCkBAIC0xMDQwLDcgKzEwNDAsNyBAQA0K IA0KICNpZiAoKChQTEFURk9STShJT1MpIHx8IFBMQVRGT1JNKE1BQ0NBVEFMWVNUKSkgJiYgX19J UEhPTkVfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTUwMDAwKSBcDQogICAgIHx8IChQTEFU Rk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTIwMDAwKSkN Ci0jZGVmaW5lIFVQREFURV9XRUJfQUNDRVNTSUJJTElUWV9TRVRUSU5HUyAxDQorI2RlZmluZSBI QVZFX1VQREFURV9XRUJfQUNDRVNTSUJJTElUWV9TRVRUSU5HUyAxDQogI2VuZGlmDQogDQogI2lm IFBMQVRGT1JNKElPUykgfHwgUExBVEZPUk0oTUFDQ0FUQUxZU1QpDQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZw0KaW5kZXggMGIw MmE2ZjMwMTA2Li5kMTUxMTEyNTIwNmEgMTAwNjQ0DQotLS0gYS9Tb3VyY2UvV2ViS2l0L0NoYW5n ZUxvZw0KKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cNCkBAIC0xLDMgKzEsMTcgQEANCisy MDIxLTA3LTA5ICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+DQorDQorICAg ICAgICBBWDogTWFrZSBXZWJLaXQgb2JzZXJ2ZSBzcGF0aWFsIGF1ZGlvIGFjY2Vzc2liaWxpdHkg c2V0dGluZ3MNCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMjc4NDgNCisNCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLg0KKw0KKyAg ICAgICAgQWxsb3cgbWFjIGFuZCBpT1MgdG8gcmVhZCBmcm9tIGFjY2Vzc2liaWxpdHkgZG9tYWlu cy4NCisgICAgICAgIEFsbG93IG1hYyBzYW5kYm94IHRvIHJlYWQgZnJvbSBjb20uYXBwbGUuQWNj ZXNzaWJpbGl0eS4NCisNCisgICAgICAgICogUGx1Z2luUHJvY2Vzcy9tYWMvY29tLmFwcGxlLldl YktpdC5wbHVnaW4tY29tbW9uLnNiLmluOg0KKyAgICAgICAgKiBVSVByb2Nlc3MvQ29jb2EvUHJl ZmVyZW5jZU9ic2VydmVyLm1tOg0KKyAgICAgICAgKC1bV0tQcmVmZXJlbmNlT2JzZXJ2ZXIgaW5p dF0pOg0KKw0KIDIwMjEtMDctMDggIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5j b20+DQogDQogICAgICAgICBbTGl2ZSBUZXh0XSBTZWxlY3Rpb24gaXMgbWlzYWxpZ25lZCBvbiBz b21lIGltYWdlcyBvbiB0d2l0dGVyLmNvbQ0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGx1 Z2luUHJvY2Vzcy9tYWMvY29tLmFwcGxlLldlYktpdC5wbHVnaW4tY29tbW9uLnNiLmluIGIvU291 cmNlL1dlYktpdC9QbHVnaW5Qcm9jZXNzL21hYy9jb20uYXBwbGUuV2ViS2l0LnBsdWdpbi1jb21t b24uc2IuaW4NCmluZGV4IDY3YWE1OGZhMjIyYy4uNDM2YTUyMDlmNmMxIDEwMDY0NA0KLS0tIGEv U291cmNlL1dlYktpdC9QbHVnaW5Qcm9jZXNzL21hYy9jb20uYXBwbGUuV2ViS2l0LnBsdWdpbi1j b21tb24uc2IuaW4NCisrKyBiL1NvdXJjZS9XZWJLaXQvUGx1Z2luUHJvY2Vzcy9tYWMvY29tLmFw cGxlLldlYktpdC5wbHVnaW4tY29tbW9uLnNiLmluDQpAQCAtMjYxLDYgKzI2MSw3IEBADQogKHNo YXJlZC1wcmVmZXJlbmNlcy1yZWFkDQogICAgICIuR2xvYmFsUHJlZmVyZW5jZXMiDQogICAgICJj b20uYXBwbGUuQVRTIg0KKyAgICAiY29tLmFwcGxlLkFjY2Vzc2liaWxpdHkiDQogICAgICJjb20u YXBwbGUuQmx1ZXRvb3RoIg0KICAgICAiY29tLmFwcGxlLkNvcmVHcmFwaGljcyINCiAgICAgImNv bS5hcHBsZS5ISVRvb2xib3giDQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv Q29jb2EvUHJlZmVyZW5jZU9ic2VydmVyLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29j b2EvUHJlZmVyZW5jZU9ic2VydmVyLm1tDQppbmRleCA3MjFhMTU0MDZjZTMuLmUwOWQ3YjQ0Y2Zi OSAxMDA2NDQNCi0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1ByZWZlcmVuY2VP YnNlcnZlci5tbQ0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvUHJlZmVyZW5j ZU9ic2VydmVyLm1tDQpAQCAtMTI5LDggKzEyOSw5IEBADQogICAgICAgICByZXR1cm4gbmlsOw0K IA0KICAgICBzdGQ6OmluaXRpYWxpemVyX2xpc3Q8TlNTdHJpbmcqPiBkb21haW5zID0gew0KLSNp ZiBQTEFURk9STShJT1NfRkFNSUxZKQ0KICAgICAgICAgQCJjb20uYXBwbGUuQWNjZXNzaWJpbGl0 eSIsDQorICAgICAgICBAImNvbS5hcHBsZS5tZWRpYWFjY2Vzc2liaWxpdHkiLA0KKyNpZiBQTEFU Rk9STShJT1NfRkFNSUxZKQ0KICAgICAgICAgQCJjb20uYXBwbGUuQWRMaWIiLA0KICAgICAgICAg QCJjb20uYXBwbGUuU3BlYWtTZWxlY3Rpb24iLA0KICAgICAgICAgQCJjb20uYXBwbGUuVUlLaXQi LA0KQEAgLTE0OSw3ICsxNTAsNiBAQA0KICAgICAgICAgQCJjb20uYXBwbGUuYXZmb3VuZGF0aW9u LnZpZGVvcGVyZm9ybWFuY2VodWQiLA0KICAgICAgICAgQCJjb20uYXBwbGUuZHJpdmVyLkFwcGxl Qmx1ZXRvb3RoTXVsdGl0b3VjaC5tb3VzZSIsDQogICAgICAgICBAImNvbS5hcHBsZS5kcml2ZXIu QXBwbGVCbHVldG9vdGhNdWx0aXRvdWNoLnRyYWNrcGFkIiwNCi0gICAgICAgIEAiY29tLmFwcGxl Lm1lZGlhYWNjZXNzaWJpbGl0eSIsDQogICAgICAgICBAImNvbS5hcHBsZS5zcGVlY2gudm9pY2Uu cHJlZnMiLA0KICAgICAgICAgQCJjb20uYXBwbGUudW5pdmVyc2FsYWNjZXNzIiwNCiAjZW5kaWYN Cg==