227834 2021-07-09 04:18:23 -0700 [GTK] Support dark scrollbars 2021-07-09 06:29:18 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 alicem webkit-unassigned bugs-noreply cgarcia mcatanzaro oldest_to_newest 1775955 0 alicem 2021-07-09 04:18:23 -0700 Scrollbars in macOS and iOS ports can change color depending on the page, using dark scrollbars on dark pages and light scrollbars on light pages. We should support that too. See the patch. 1775957 1 433207 alicem 2021-07-09 04:22:28 -0700 Created attachment 433207 Patch 1775958 2 alicem 2021-07-09 04:23:53 -0700 Test case: https://blog.ergaster.org/ https://webkit.org also triggers a dark scrollbar. 1775971 3 433207 mcatanzaro 2021-07-09 05:04:51 -0700 Comment on attachment 433207 Patch LGTM. Maybe Carlos Garcia might want to review this before landing, though? 1775978 4 ews-feeder 2021-07-09 06:29:15 -0700 Committed r279782 (239549@main): <https://commits.webkit.org/239549@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433207. 433207 2021-07-09 04:22:28 -0700 2021-07-09 06:29:16 -0700 Patch 0001-Patch.patch text/plain 5642 alicem RnJvbSAyNDU5ZWEyNTc4OTkwYjhiM2Q5MzRmNWNhZTBmN2VmNjYzNGE2YzdkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4YW5kZXIgTWlraGF5bGVua28gPGFsZXhtQGdub21lLm9y Zz4KRGF0ZTogRnJpLCA5IEp1bCAyMDIxIDE2OjIwOjU4ICswNTAwClN1YmplY3Q6IFtQQVRDSF0g UGF0Y2gKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAg IHwgMTggKysrKysrKwogLi4uL2Fkd2FpdGEvU2Nyb2xsYmFyVGhlbWVBZHdhaXRhLmNwcCAgICAg ICAgIHwgNDkgKysrKysrKysrKysrKysrKy0tLQogLi4uL3BsYXRmb3JtL2Fkd2FpdGEvU2Nyb2xs YmFyVGhlbWVBZHdhaXRhLmggIHwgIDIgKwogMyBmaWxlcyBjaGFuZ2VkLCA2MiBpbnNlcnRpb25z KCspLCA3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1MWQ0MzFlMDk3MmMuLmUwMmM1NWI0 NTMyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIxLTA3LTA5ICBBbGV4YW5kZXIg TWlraGF5bGVua28gIDxhbGV4bUBnbm9tZS5vcmc+CisKKyAgICAgICAgW0dUS10gU3VwcG9ydCBk YXJrIHNjcm9sbGJhcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIyNzgzNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFsc28gYWRqdXN0IHRoZSBjb2xvcnMgaW4gbGlnaHQgdmFyaWFudCB0byBiZSBjbG9z ZXIgdG8gdGhlIEdUSyBzY3JvbGxiYXJzLCBhbmQKKyAgICAgICAgcmVtb3ZlIGFuIHVudXNlZCB2 YXJpYWJsZS4KKworICAgICAgICBVbmZvcnR1bmF0ZWx5IHRoaXMgbGVhdmVzIHRoZSBzY3JvbGxi YXIgY29ybmVyIHdoZW4gbm9uLW92ZXJsYXkgc2Nyb2xsYmFycyBhcmUgdXNlZCwKKyAgICAgICAg YnV0IGl0IHdhcyBhbHJlYWR5IGJyb2tlbiBmb3IgbGlnaHQgc2Nyb2xsYmFycyBhcyB3ZWxsLgor CisgICAgICAgICogcGxhdGZvcm0vYWR3YWl0YS9TY3JvbGxiYXJUaGVtZUFkd2FpdGEuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsYmFyVGhlbWVBZHdhaXRhOjp1cGRhdGVTY3JvbGxiYXJP dmVybGF5U3R5bGUpOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsYmFyVGhlbWVBZHdhaXRhOjpw YWludCk6CisgICAgICAgICogcGxhdGZvcm0vYWR3YWl0YS9TY3JvbGxiYXJUaGVtZUFkd2FpdGEu aDoKKwogMjAyMS0wNy0wOCAgS2F0ZSBDaGVuZXkgIDxrYXRoZXJpbmVfY2hlbmV5QGFwcGxlLmNv bT4KIAogICAgICAgICBVbnJldmlld2VkIGlPUyBidWlsZCBmaXggYWZ0ZXIKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Fkd2FpdGEvU2Nyb2xsYmFyVGhlbWVBZHdhaXRhLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Fkd2FpdGEvU2Nyb2xsYmFyVGhlbWVBZHdhaXRh LmNwcAppbmRleCA4N2JhNGFkOTU1ZTguLmIyMDA4ZDNlMzNkYiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vYWR3YWl0YS9TY3JvbGxiYXJUaGVtZUFkd2FpdGEuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Fkd2FpdGEvU2Nyb2xsYmFyVGhlbWVBZHdhaXRhLmNw cApAQCAtNDMsMTMgKzQzLDI1IEBAIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBvdmVybGF5VGh1bWJT aXplID0gNTsKIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBtaW5pbXVtVGh1bWJTaXplID0gNDA7CiBz dGF0aWMgY29uc3QgdW5zaWduZWQgdGh1bWJTaXplID0gNjsKIHN0YXRpYyBjb25zdCBkb3VibGUg c2Nyb2xsYmFyT3BhY2l0eSA9IDAuODsKLXN0YXRpYyBjb25zdGV4cHIgYXV0byBzY3JvbGxiYXJC YWNrZ3JvdW5kQ29sb3IgPSBTUkdCQTx1aW50OF90PiB7IDI1MiwgMjUyLCAyNTIgfTsKLXN0YXRp YyBjb25zdGV4cHIgYXV0byBzY3JvbGxiYXJCb3JkZXJDb2xvciA9IFNSR0JBPHVpbnQ4X3Q+IHsg MjIwLCAyMjMsIDIyNyB9Owotc3RhdGljIGNvbnN0ZXhwciBhdXRvIG92ZXJsYXlUaHVtYkJvcmRl ckNvbG9yID0gQ29sb3I6OndoaXRlLmNvbG9yV2l0aEFscGhhQnl0ZSgxMDApOwotc3RhdGljIGNv bnN0ZXhwciBhdXRvIG92ZXJsYXlUaHVtYkNvbG9yID0gU1JHQkE8dWludDhfdD4geyA0NiwgNTIs IDU0LCAxMDAgfTsKLXN0YXRpYyBjb25zdGV4cHIgYXV0byB0aHVtYkhvdmVyZWRDb2xvciA9IFNS R0JBPHVpbnQ4X3Q+IHsgODYsIDkxLCA5MiB9Owotc3RhdGljIGNvbnN0ZXhwciBhdXRvIHRodW1i UHJlc3NlZENvbG9yID0gU1JHQkE8dWludDhfdD4geyAyNywgMTA2LCAyMDMgfTsKLXN0YXRpYyBj b25zdGV4cHIgYXV0byB0aHVtYkNvbG9yID0gU1JHQkE8dWludDhfdD4geyAxMjYsIDEyOSwgMTMw IH07CisKK3N0YXRpYyBjb25zdGV4cHIgYXV0byBzY3JvbGxiYXJCYWNrZ3JvdW5kQ29sb3JMaWdo dCA9IFNSR0JBPHVpbnQ4X3Q+IHsgMjA2LCAyMDYsIDIwNiB9Oworc3RhdGljIGNvbnN0ZXhwciBh dXRvIHNjcm9sbGJhckJvcmRlckNvbG9yTGlnaHQgPSBTUkdCQTx1aW50OF90PiB7IDIwNSwgMTk5 LCAxOTQgfTsKK3N0YXRpYyBjb25zdGV4cHIgYXV0byBvdmVybGF5VGh1bWJCb3JkZXJDb2xvckxp Z2h0ID0gQ29sb3I6OndoaXRlLmNvbG9yV2l0aEFscGhhQnl0ZSgxMDApOworc3RhdGljIGNvbnN0 ZXhwciBhdXRvIG92ZXJsYXlUaHVtYkNvbG9yTGlnaHQgPSBTUkdCQTx1aW50OF90PiB7IDQ2LCA1 MiwgNTQsIDEwMCB9Oworc3RhdGljIGNvbnN0ZXhwciBhdXRvIHRodW1iSG92ZXJlZENvbG9yTGln aHQgPSBTUkdCQTx1aW50OF90PiB7IDg2LCA5MSwgOTIgfTsKK3N0YXRpYyBjb25zdGV4cHIgYXV0 byB0aHVtYkNvbG9yTGlnaHQgPSBTUkdCQTx1aW50OF90PiB7IDEyNiwgMTI5LCAxMzAgfTsKKwor c3RhdGljIGNvbnN0ZXhwciBhdXRvIHNjcm9sbGJhckJhY2tncm91bmRDb2xvckRhcmsgPSBTUkdC QTx1aW50OF90PiB7IDQ5LCA0OSwgNDkgfTsKK3N0YXRpYyBjb25zdGV4cHIgYXV0byBzY3JvbGxi YXJCb3JkZXJDb2xvckRhcmsgPSBTUkdCQTx1aW50OF90PiB7IDI3LCAyNywgMjcgfTsKK3N0YXRp YyBjb25zdGV4cHIgYXV0byBvdmVybGF5VGh1bWJCb3JkZXJDb2xvckRhcmsgPSBDb2xvcjo6Ymxh Y2suY29sb3JXaXRoQWxwaGFCeXRlKDEwMCk7CitzdGF0aWMgY29uc3RleHByIGF1dG8gb3Zlcmxh eVRodW1iQ29sb3JEYXJrID0gU1JHQkE8dWludDhfdD4geyAyMzgsIDIzOCwgMjM2LCAxMDAgfTsK K3N0YXRpYyBjb25zdGV4cHIgYXV0byB0aHVtYkhvdmVyZWRDb2xvckRhcmsgPSBTUkdCQTx1aW50 OF90PiB7IDIwMSwgMjAxLCAxOTkgfTsKK3N0YXRpYyBjb25zdGV4cHIgYXV0byB0aHVtYkNvbG9y RGFyayA9IFNSR0JBPHVpbnQ4X3Q+IHsgMTY0LCAxNjQsIDE2MyB9OworCit2b2lkIFNjcm9sbGJh clRoZW1lQWR3YWl0YTo6dXBkYXRlU2Nyb2xsYmFyT3ZlcmxheVN0eWxlKFNjcm9sbGJhciYgc2Ny b2xsYmFyKQoreworICAgIHNjcm9sbGJhci5pbnZhbGlkYXRlKCk7Cit9CiAKIGJvb2wgU2Nyb2xs YmFyVGhlbWVBZHdhaXRhOjp1c2VzT3ZlcmxheVNjcm9sbGJhcnMoKSBjb25zdAogewpAQCAtMTE2 LDYgKzEyOCwyOSBAQCBib29sIFNjcm9sbGJhclRoZW1lQWR3YWl0YTo6cGFpbnQoU2Nyb2xsYmFy JiBzY3JvbGxiYXIsIEdyYXBoaWNzQ29udGV4dCYgZ3JhcGhpYwogICAgIGlmICghb3BhY2l0eSkK ICAgICAgICAgcmV0dXJuIHRydWU7CiAKKyAgICBTUkdCQTx1aW50OF90PiBzY3JvbGxiYXJCYWNr Z3JvdW5kQ29sb3I7CisgICAgU1JHQkE8dWludDhfdD4gc2Nyb2xsYmFyQm9yZGVyQ29sb3I7Cisg ICAgU1JHQkE8dWludDhfdD4gb3ZlcmxheVRodW1iQm9yZGVyQ29sb3I7CisgICAgU1JHQkE8dWlu dDhfdD4gb3ZlcmxheVRodW1iQ29sb3I7CisgICAgU1JHQkE8dWludDhfdD4gdGh1bWJIb3ZlcmVk Q29sb3I7CisgICAgU1JHQkE8dWludDhfdD4gdGh1bWJDb2xvcjsKKworICAgIGlmIChzY3JvbGxi YXIuc2Nyb2xsYWJsZUFyZWEoKS51c2VEYXJrQXBwZWFyYW5jZUZvclNjcm9sbGJhcnMoKSkgewor ICAgICAgICBzY3JvbGxiYXJCYWNrZ3JvdW5kQ29sb3IgPSBzY3JvbGxiYXJCYWNrZ3JvdW5kQ29s b3JEYXJrOworICAgICAgICBzY3JvbGxiYXJCb3JkZXJDb2xvciA9IHNjcm9sbGJhckJvcmRlckNv bG9yRGFyazsKKyAgICAgICAgb3ZlcmxheVRodW1iQm9yZGVyQ29sb3IgPSBvdmVybGF5VGh1bWJC b3JkZXJDb2xvckRhcms7CisgICAgICAgIG92ZXJsYXlUaHVtYkNvbG9yID0gb3ZlcmxheVRodW1i Q29sb3JEYXJrOworICAgICAgICB0aHVtYkhvdmVyZWRDb2xvciA9IHRodW1iSG92ZXJlZENvbG9y RGFyazsKKyAgICAgICAgdGh1bWJDb2xvciA9IHRodW1iQ29sb3JEYXJrOworICAgIH0gZWxzZSB7 CisgICAgICAgIHNjcm9sbGJhckJhY2tncm91bmRDb2xvciA9IHNjcm9sbGJhckJhY2tncm91bmRD b2xvckxpZ2h0OworICAgICAgICBzY3JvbGxiYXJCb3JkZXJDb2xvciA9IHNjcm9sbGJhckJvcmRl ckNvbG9yTGlnaHQ7CisgICAgICAgIG92ZXJsYXlUaHVtYkJvcmRlckNvbG9yID0gb3ZlcmxheVRo dW1iQm9yZGVyQ29sb3JMaWdodDsKKyAgICAgICAgb3ZlcmxheVRodW1iQ29sb3IgPSBvdmVybGF5 VGh1bWJDb2xvckxpZ2h0OworICAgICAgICB0aHVtYkhvdmVyZWRDb2xvciA9IHRodW1iSG92ZXJl ZENvbG9yTGlnaHQ7CisgICAgICAgIHRodW1iQ29sb3IgPSB0aHVtYkNvbG9yTGlnaHQ7CisgICAg fQorCiAgICAgR3JhcGhpY3NDb250ZXh0U3RhdGVTYXZlciBzdGF0ZVNhdmVyKGdyYXBoaWNzQ29u dGV4dCk7CiAgICAgaWYgKG9wYWNpdHkgIT0gMSkgewogICAgICAgICBncmFwaGljc0NvbnRleHQu Y2xpcChkYW1hZ2VSZWN0KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Fk d2FpdGEvU2Nyb2xsYmFyVGhlbWVBZHdhaXRhLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9h ZHdhaXRhL1Njcm9sbGJhclRoZW1lQWR3YWl0YS5oCmluZGV4IDVkMThjYjAxNjNlOS4uZGZjNWNj M2IzNzE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hZHdhaXRhL1Njcm9s bGJhclRoZW1lQWR3YWl0YS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Fkd2FpdGEv U2Nyb2xsYmFyVGhlbWVBZHdhaXRhLmgKQEAgLTM4LDYgKzM4LDggQEAgcHJvdGVjdGVkOgogICAg IGJvb2wgdXNlc092ZXJsYXlTY3JvbGxiYXJzKCkgY29uc3Qgb3ZlcnJpZGU7CiAgICAgYm9vbCBp bnZhbGlkYXRlT25Nb3VzZUVudGVyRXhpdCgpIG92ZXJyaWRlIHsgcmV0dXJuIHVzZXNPdmVybGF5 U2Nyb2xsYmFycygpOyB9CiAKKyAgICB2b2lkIHVwZGF0ZVNjcm9sbGJhck92ZXJsYXlTdHlsZShT Y3JvbGxiYXImKSBvdmVycmlkZTsKKwogICAgIGJvb2wgcGFpbnQoU2Nyb2xsYmFyJiwgR3JhcGhp Y3NDb250ZXh0JiwgY29uc3QgSW50UmVjdCYpIG92ZXJyaWRlOwogICAgIFNjcm9sbGJhckJ1dHRv blByZXNzQWN0aW9uIGhhbmRsZU1vdXNlUHJlc3NFdmVudChTY3JvbGxiYXImLCBjb25zdCBQbGF0 Zm9ybU1vdXNlRXZlbnQmLCBTY3JvbGxiYXJQYXJ0KSBvdmVycmlkZTsKIAotLSAKMi4zMS4xCgo=