227795 2021-07-08 08:46:48 -0700 >4K Referer should have tailing / 2021-07-27 09:06:22 -0700 1 1 1 Unclassified WebKit Page Loading WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=215080 InRadar P2 Normal --- 1 gsnedders achristensen achristensen beidson cdumez webkit-bug-importer oldest_to_newest 1775673 0 gsnedders 2021-07-08 08:46:48 -0700 Per referrer policy we reduce long referrers to just the origin; however, this should be serialised as per URL which means that it should have a trailing / This is a relatively big gain on WPT given the large number of referrer policy tests. 1775674 1 cdumez 2021-07-08 08:48:37 -0700 Example of failing WPT test(s)? 1775685 2 achristensen 2021-07-08 09:25:50 -0700 https://wpt.fyi/results/referrer-policy?label=experimental&label=master&aligned 1775772 3 gsnedders 2021-07-08 13:27:48 -0700 Specifically something like https://wpt.fyi/results/referrer-policy/4K+1/gen/top.http-rp/no-referrer-when-downgrade/a-tag.http.html?label=experimental&label=master&aligned is the trailing-/ case 1776694 4 433431 achristensen 2021-07-13 11:29:50 -0700 Created attachment 433431 Patch 1776705 5 433431 cdumez 2021-07-13 12:02:45 -0700 Comment on attachment 433431 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433431&action=review > Source/WebCore/ChangeLog:9 > + Covered by existing tests and web platform tests we haven't imported yet. It's too bad that we haven't imported those tests yet. > Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:79 > + checkReferer([NSURL URLWithString:longPath], "http://webkit.org/"); It is a bit confusing because this referrer is not > 4K. Also, it seems like this should be easily writable as a layout test? 1776706 6 433431 achristensen 2021-07-13 12:03:45 -0700 Comment on attachment 433431 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433431&action=review >> Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:79 >> + checkReferer([NSURL URLWithString:longPath], "http://webkit.org/"); > > It is a bit confusing because this referrer is not > 4K. > > Also, it seems like this should be easily writable as a layout test? This is the trimmed referrer. 1776709 7 433431 cdumez 2021-07-13 12:06:37 -0700 Comment on attachment 433431 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433431&action=review r=me assuming the bots are happy. >>> Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:79 >>> + checkReferer([NSURL URLWithString:longPath], "http://webkit.org/"); >> >> It is a bit confusing because this referrer is not > 4K. >> >> Also, it seems like this should be easily writable as a layout test? > > This is the trimmed referrer. Oh, I get it now. I would have liked if we had a layout test for this (as we can run in other browsers and other ports of WebKit). But technically, you have test coverage so r+. 1776718 8 433431 achristensen 2021-07-13 12:25:42 -0700 Comment on attachment 433431 Patch The web platform tests have done that for me! 1776725 9 ews-feeder 2021-07-13 12:43:50 -0700 Committed r279886 (239638@main): <https://commits.webkit.org/239638@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433431. 1776726 10 webkit-bug-importer 2021-07-13 12:44:16 -0700 <rdar://problem/80532911> 433431 2021-07-13 11:29:50 -0700 2021-07-13 12:43:51 -0700 Patch bug-227795-20210713112949.patch text/plain 3369 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5NjgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDIxMDBjYWUxOTRkZDRj ODU4YTJhODljNGI0MDlhOGMxNzMwODhlOC4uZWY3YzBkNTkyNTYwYjdiNTI5MjIxMzBlZTNkMTRm MjFjMWQxYzczOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA3LTEzICBBbGV4 IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgPjRLIFJl ZmVyZXIgc2hvdWxkIGhhdmUgdGFpbGluZyAvCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMjc3OTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGlzIG1hdGNoZXMgdGhlIGJlaGF2aW9yIG9mIG90aGVyIGJy b3dzZXJzLgorICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzIGFuZCB3ZWIgcGxhdGZv cm0gdGVzdHMgd2UgaGF2ZW4ndCBpbXBvcnRlZCB5ZXQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9u ZXR3b3JrL1Jlc291cmNlUmVxdWVzdEJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3Vy Y2VSZXF1ZXN0QmFzZTo6c2V0SFRUUFJlZmVycmVyKToKKwogMjAyMS0wNy0wNyAgQ2hyaXMgRHVt ZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIElEQk9iamVjdFN0b3JlLmtleVBhdGgg c2hvdWxkIGtlZXAgcmV0dXJuaW5nIHRoZSBzYW1lIG9iamVjdApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJlcXVlc3RCYXNlLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VSZXF1ZXN0QmFzZS5jcHAKaW5kZXgg NDZlNzg1MjI5ZTYwZjYyYmM3YjNhY2U0ZGM4MzFhN2YyNzVhODFiMi4uOTFiNGQyZDJhYTNlOWFl MzhhZTg5YWZiZjhmYmRmOTIwNWMzNTJjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9SZXNvdXJjZVJlcXVlc3RCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVxdWVzdEJhc2UuY3BwCkBAIC0zOTQsNyArMzk0 LDcgQEAgdm9pZCBSZXNvdXJjZVJlcXVlc3RCYXNlOjpzZXRIVFRQUmVmZXJyZXIoY29uc3QgU3Ry aW5nJiBodHRwUmVmZXJyZXIpCiAgICAgY29uc3RleHByIHNpemVfdCBtYXhMZW5ndGggPSA0MDk2 OwogICAgIGlmIChodHRwUmVmZXJyZXIubGVuZ3RoKCkgPiBtYXhMZW5ndGgpIHsKICAgICAgICAg UkVMRUFTRV9MT0coTG9hZGluZywgIlRydW5jYXRpbmcgSFRUUCByZWZlcmVyIik7Ci0gICAgICAg IFN0cmluZyBvcmlnaW4gPSBTZWN1cml0eU9yaWdpbjo6Y3JlYXRlKFVSTChVUkwoKSwgaHR0cFJl ZmVycmVyKSktPnRvU3RyaW5nKCk7CisgICAgICAgIFN0cmluZyBvcmlnaW4gPSBVUkwoVVJMKCks IFNlY3VyaXR5T3JpZ2luOjpjcmVhdGUoVVJMKFVSTCgpLCBodHRwUmVmZXJyZXIpKS0+dG9TdHJp bmcoKSkuc3RyaW5nKCk7CiAgICAgICAgIGlmIChvcmlnaW4ubGVuZ3RoKCkgPD0gbWF4TGVuZ3Ro KQogICAgICAgICAgICAgc2V0SFRUUEhlYWRlckZpZWxkKEhUVFBIZWFkZXJOYW1lOjpSZWZlcmVy LCBvcmlnaW4pOwogICAgIH0gZWxzZQpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9v bHMvQ2hhbmdlTG9nCmluZGV4IGE5M2M3ZTg0ZWNkNDk0ZGY2MDRhZGJmNzE1YTdkMWIyZTg1NTBm YWYuLjJhMzY3ZmFjYzk5ZmU0NmRhNGEwMGFhMzc4MGY0NjlmZmYzZWFiODkgMTAwNjQ0Ci0tLSBh L1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAor MjAyMS0wNy0xMyAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgor CisgICAgICAgID40SyBSZWZlcmVyIHNob3VsZCBoYXZlIHRhaWxpbmcgLworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI3Nzk1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3Rz L1dlYktpdENvY29hL05ldHdvcmtQcm9jZXNzLm1tOgorICAgICAgICAoVEVTVCk6CisKIDIwMjEt MDctMDcgIExpbmcgSG8gIDxsaW5naG9AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBwcm94 eSBzZXJ2ZXIgc2V0dGluZyBmcm9tIEJ1aWxkYm90IGNvbmZpZ3VyYXRpb24KZGlmZiAtLWdpdCBh L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvTmV0d29ya1Byb2Nlc3MubW0g Yi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL05ldHdvcmtQcm9jZXNzLm1t CmluZGV4IGE3NzIwYzVhYzU0YzlkZGZmMjNlNGUxMTU4NGY5Y2QxYzVjOTQwNDkuLjlhNzNmNDY4 OWI5ZTlkMTkzNmU2NDY1NWIzNDUxNGJiNjEwOTE1ZmEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RX ZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvTmV0d29ya1Byb2Nlc3MubW0KKysrIGIvVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9OZXR3b3JrUHJvY2Vzcy5tbQpAQCAtNzYs NyArNzYsNyBAQCBURVNUKFdlYktpdCwgSFRUUFJlZmVyZXIpCiAgICAgTlNTdHJpbmcgKnNob3J0 ZXJQYXRoID0gW05TU3RyaW5nIHN0cmluZ1dpdGhGb3JtYXQ6QCJodHRwOi8vd2Via2l0Lm9yZy8l cz9hc2RmIiwgYTNrLmRhdGEoKV07CiAgICAgTlNTdHJpbmcgKmxvbmdIb3N0ID0gW05TU3RyaW5n IHN0cmluZ1dpdGhGb3JtYXQ6QCJodHRwOi8vd2Via2l0Lm9yZyVzL3BhdGgiLCBhNWsuZGF0YSgp XTsKICAgICBOU1N0cmluZyAqc2hvcnRlckhvc3QgPSBbTlNTdHJpbmcgc3RyaW5nV2l0aEZvcm1h dDpAImh0dHA6Ly93ZWJraXQub3JnJXMvcGF0aCIsIGEzay5kYXRhKCldOwotICAgIGNoZWNrUmVm ZXJlcihbTlNVUkwgVVJMV2l0aFN0cmluZzpsb25nUGF0aF0sICJodHRwOi8vd2Via2l0Lm9yZyIp OworICAgIGNoZWNrUmVmZXJlcihbTlNVUkwgVVJMV2l0aFN0cmluZzpsb25nUGF0aF0sICJodHRw Oi8vd2Via2l0Lm9yZy8iKTsKICAgICBjaGVja1JlZmVyZXIoW05TVVJMIFVSTFdpdGhTdHJpbmc6 c2hvcnRlclBhdGhdLCBzaG9ydGVyUGF0aC5VVEY4U3RyaW5nKTsKICAgICBjaGVja1JlZmVyZXIo W05TVVJMIFVSTFdpdGhTdHJpbmc6bG9uZ0hvc3RdLCBudWxscHRyKTsKICAgICBjaGVja1JlZmVy ZXIoW05TVVJMIFVSTFdpdGhTdHJpbmc6c2hvcnRlckhvc3RdLCBzaG9ydGVySG9zdC5VVEY4U3Ry aW5nKTsK