227783 2021-07-07 17:53:42 -0700 add logging for GraphicsLayerCA::m_uncommittedChanges 2021-07-07 23:54:17 -0700 1 1 1 Unclassified WebKit Compositing WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 heycam heycam simon.fraser webkit-bug-importer oldest_to_newest 1775551 0 heycam 2021-07-07 17:53:42 -0700 . 1775558 1 433102 heycam 2021-07-07 17:56:05 -0700 Created attachment 433102 Patch 1775585 2 433102 simon.fraser 2021-07-07 20:04:57 -0700 Comment on attachment 433102 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433102&action=review > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:4136 > +const char* GraphicsLayerCA::layerChangeAsString(LayerChange layerChange) This is better implemented as TextStream& operator<<(TextStream&, LayerChange) 1775587 3 heycam 2021-07-07 20:09:00 -0700 I wanted to but struggled with the enum being private. 1775588 4 433102 simon.fraser 2021-07-07 20:17:24 -0700 Comment on attachment 433102 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433102&action=review > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:4207 > + bool first = true; > + while (layerChangeFlags) { > + if (layerChangeFlags & bit) { > + textStream << (first ? " " : ", ") << layerChangeAsString(static_cast<LayerChange>(bit)); > + first = false; > + } > + layerChangeFlags &= ~bit; > + bit <<= 1; > + } > + textStream << " }"; Shame that LayerChangeFlags isn' an OptionSet<> because they you wouldn't need this either. 1775590 5 heycam 2021-07-07 20:29:52 -0700 Will do that later. https://bugs.webkit.org/show_bug.cgi?id=227787 1775621 6 ews-feeder 2021-07-07 23:53:08 -0700 Committed r279712 (239504@main): <https://commits.webkit.org/239504@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433102. 1775622 7 webkit-bug-importer 2021-07-07 23:54:17 -0700 <rdar://problem/80308784> 433102 2021-07-07 17:56:05 -0700 2021-07-07 23:53:08 -0700 Patch bug-227783-20210708105603.patch text/plain 7200 heycam U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5NTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTAwYjQxZGRkNDg5OWEx Y2E5MmI5ZGY3OTIwNjNjYWJjMDgzMDcyNC4uNmFjMDRjNmJiYjFiYTIxMzVjMjcxMjU0YWI1OThj YTRjMGQzYTVjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA3LTA3ICBDYW1l cm9uIE1jQ29ybWFjayAgPGhleWNhbUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGxvZ2dpbmcg Zm9yIEdyYXBoaWNzTGF5ZXJDQTo6bV91bmNvbW1pdHRlZENoYW5nZXMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNzc4MworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Ev R3JhcGhpY3NMYXllckNBLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXJDQTo6 bGF5ZXJDaGFuZ2VBc1N0cmluZyk6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0xheWVyQ0E6 OmR1bXBMYXllckNoYW5nZUZsYWdzKToKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXJD QTo6ZHVtcEFkZGl0aW9uYWxQcm9wZXJ0aWVzIGNvbnN0KToKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9jYS9HcmFwaGljc0xheWVyQ0EuaDoKKwogMjAyMS0wNy0wNyAgQ2FtZXJvbiBNY0Nv cm1hY2sgIDxoZXljYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFN0b3AgR3JhcGhpY3NMYXllckNB OjpyZWN1cnNpdmVDb21taXRDaGFuZ2VzIHJlY3Vyc2lvbiBvbmNlIGNNYXhMYXllclRyZWVEZXB0 aCBpcyByZWFjaGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jYS9HcmFwaGljc0xheWVyQ0EuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvY2EvR3JhcGhpY3NMYXllckNBLmNwcAppbmRleCA0ODQ5YzY4MjkzNzEyMTIwYTFjNWNlMjJl ZjYxYzI2Mjk5ZGNhNzg1Li5jZGNkYmJhMjgzNDBiMWYyMjM3ZWY0N2UxNzBmMjgwZjQzYTdlMjc5 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9HcmFwaGlj c0xheWVyQ0EuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL0dy YXBoaWNzTGF5ZXJDQS5jcHAKQEAgLTQxMzMsNiArNDEzMyw4MCBAQCB2b2lkIEdyYXBoaWNzTGF5 ZXJDQTo6ZHVtcEFuaW1hdGlvbnMoV1RGOjpUZXh0U3RyZWFtJiB0ZXh0U3RyZWFtLCBjb25zdCBj aGFyKiBjYQogICAgIH0KIH0KIAorY29uc3QgY2hhciogR3JhcGhpY3NMYXllckNBOjpsYXllckNo YW5nZUFzU3RyaW5nKExheWVyQ2hhbmdlIGxheWVyQ2hhbmdlKQoreworICAgIHN3aXRjaCAobGF5 ZXJDaGFuZ2UpIHsKKyAgICBjYXNlIExheWVyQ2hhbmdlOjpOb0NoYW5nZTogcmV0dXJuICIiOyBi cmVhazsKKyAgICBjYXNlIExheWVyQ2hhbmdlOjpOYW1lQ2hhbmdlZDogcmV0dXJuICJOYW1lQ2hh bmdlZCI7CisgICAgY2FzZSBMYXllckNoYW5nZTo6Q2hpbGRyZW5DaGFuZ2VkOiByZXR1cm4gIkNo aWxkcmVuQ2hhbmdlZCI7CisgICAgY2FzZSBMYXllckNoYW5nZTo6R2VvbWV0cnlDaGFuZ2VkOiBy ZXR1cm4gIkdlb21ldHJ5Q2hhbmdlZCI7CisgICAgY2FzZSBMYXllckNoYW5nZTo6VHJhbnNmb3Jt Q2hhbmdlZDogcmV0dXJuICJUcmFuc2Zvcm1DaGFuZ2VkIjsKKyAgICBjYXNlIExheWVyQ2hhbmdl OjpDaGlsZHJlblRyYW5zZm9ybUNoYW5nZWQ6IHJldHVybiAiQ2hpbGRyZW5UcmFuc2Zvcm1DaGFu Z2VkIjsKKyAgICBjYXNlIExheWVyQ2hhbmdlOjpQcmVzZXJ2ZXMzRENoYW5nZWQ6IHJldHVybiAi UHJlc2VydmVzM0RDaGFuZ2VkIjsKKyAgICBjYXNlIExheWVyQ2hhbmdlOjpNYXNrc1RvQm91bmRz Q2hhbmdlZDogcmV0dXJuICJNYXNrc1RvQm91bmRzQ2hhbmdlZCI7CisgICAgY2FzZSBMYXllckNo YW5nZTo6RHJhd3NDb250ZW50Q2hhbmdlZDogcmV0dXJuICJEcmF3c0NvbnRlbnRDaGFuZ2VkIjsK KyAgICBjYXNlIExheWVyQ2hhbmdlOjpCYWNrZ3JvdW5kQ29sb3JDaGFuZ2VkOiByZXR1cm4gIkJh Y2tncm91bmRDb2xvckNoYW5nZWQiOworICAgIGNhc2UgTGF5ZXJDaGFuZ2U6OkNvbnRlbnRzT3Bh cXVlQ2hhbmdlZDogcmV0dXJuICJDb250ZW50c09wYXF1ZUNoYW5nZWQiOworICAgIGNhc2UgTGF5 ZXJDaGFuZ2U6OkJhY2tmYWNlVmlzaWJpbGl0eUNoYW5nZWQ6IHJldHVybiAiQmFja2ZhY2VWaXNp YmlsaXR5Q2hhbmdlZCI7CisgICAgY2FzZSBMYXllckNoYW5nZTo6T3BhY2l0eUNoYW5nZWQ6IHJl dHVybiAiT3BhY2l0eUNoYW5nZWQiOworICAgIGNhc2UgTGF5ZXJDaGFuZ2U6OkFuaW1hdGlvbkNo YW5nZWQ6IHJldHVybiAiQW5pbWF0aW9uQ2hhbmdlZCI7CisgICAgY2FzZSBMYXllckNoYW5nZTo6 RGlydHlSZWN0c0NoYW5nZWQ6IHJldHVybiAiRGlydHlSZWN0c0NoYW5nZWQiOworICAgIGNhc2Ug TGF5ZXJDaGFuZ2U6OkNvbnRlbnRzSW1hZ2VDaGFuZ2VkOiByZXR1cm4gIkNvbnRlbnRzSW1hZ2VD aGFuZ2VkIjsKKyAgICBjYXNlIExheWVyQ2hhbmdlOjpDb250ZW50c1BsYXRmb3JtTGF5ZXJDaGFu Z2VkOiByZXR1cm4gIkNvbnRlbnRzUGxhdGZvcm1MYXllckNoYW5nZWQiOworICAgIGNhc2UgTGF5 ZXJDaGFuZ2U6OkNvbnRlbnRzQ29sb3JMYXllckNoYW5nZWQ6IHJldHVybiAiQ29udGVudHNDb2xv ckxheWVyQ2hhbmdlZCI7CisgICAgY2FzZSBMYXllckNoYW5nZTo6Q29udGVudHNSZWN0c0NoYW5n ZWQ6IHJldHVybiAiQ29udGVudHNSZWN0c0NoYW5nZWQiOworICAgIGNhc2UgTGF5ZXJDaGFuZ2U6 Ok1hc2tzVG9Cb3VuZHNSZWN0Q2hhbmdlZDogcmV0dXJuICJNYXNrc1RvQm91bmRzUmVjdENoYW5n ZWQiOworICAgIGNhc2UgTGF5ZXJDaGFuZ2U6Ok1hc2tMYXllckNoYW5nZWQ6IHJldHVybiAiTWFz a0xheWVyQ2hhbmdlZCI7CisgICAgY2FzZSBMYXllckNoYW5nZTo6UmVwbGljYXRlZExheWVyQ2hh bmdlZDogcmV0dXJuICJSZXBsaWNhdGVkTGF5ZXJDaGFuZ2VkIjsKKyAgICBjYXNlIExheWVyQ2hh bmdlOjpDb250ZW50c05lZWRzRGlzcGxheTogcmV0dXJuICJDb250ZW50c05lZWRzRGlzcGxheSI7 CisgICAgY2FzZSBMYXllckNoYW5nZTo6QWNjZWxlcmF0ZXNEcmF3aW5nQ2hhbmdlZDogcmV0dXJu ICJBY2NlbGVyYXRlc0RyYXdpbmdDaGFuZ2VkIjsKKyAgICBjYXNlIExheWVyQ2hhbmdlOjpTdXBw b3J0c1N1YnBpeGVsQW50aWFsaWFzZWRUZXh0Q2hhbmdlZDogcmV0dXJuICJTdXBwb3J0c1N1YnBp eGVsQW50aWFsaWFzZWRUZXh0Q2hhbmdlZCI7CisgICAgY2FzZSBMYXllckNoYW5nZTo6Q29udGVu dHNTY2FsZUNoYW5nZWQ6IHJldHVybiAiQ29udGVudHNTY2FsZUNoYW5nZWQiOworICAgIGNhc2Ug TGF5ZXJDaGFuZ2U6OkNvbnRlbnRzVmlzaWJpbGl0eUNoYW5nZWQ6IHJldHVybiAiQ29udGVudHNW aXNpYmlsaXR5Q2hhbmdlZCI7CisgICAgY2FzZSBMYXllckNoYW5nZTo6Q292ZXJhZ2VSZWN0Q2hh bmdlZDogcmV0dXJuICJDb3ZlcmFnZVJlY3RDaGFuZ2VkIjsKKyAgICBjYXNlIExheWVyQ2hhbmdl OjpGaWx0ZXJzQ2hhbmdlZDogcmV0dXJuICJGaWx0ZXJzQ2hhbmdlZCI7CisgICAgY2FzZSBMYXll ckNoYW5nZTo6QmFja2Ryb3BGaWx0ZXJzQ2hhbmdlZDogcmV0dXJuICJCYWNrZHJvcEZpbHRlcnND aGFuZ2VkIjsKKyAgICBjYXNlIExheWVyQ2hhbmdlOjpCYWNrZHJvcEZpbHRlcnNSZWN0Q2hhbmdl ZDogcmV0dXJuICJCYWNrZHJvcEZpbHRlcnNSZWN0Q2hhbmdlZCI7CisgICAgY2FzZSBMYXllckNo YW5nZTo6VGlsaW5nQXJlYUNoYW5nZWQ6IHJldHVybiAiVGlsaW5nQXJlYUNoYW5nZWQiOworICAg IGNhc2UgTGF5ZXJDaGFuZ2U6OkRlYnVnSW5kaWNhdG9yc0NoYW5nZWQ6IHJldHVybiAiRGVidWdJ bmRpY2F0b3JzQ2hhbmdlZCI7CisgICAgY2FzZSBMYXllckNoYW5nZTo6Q3VzdG9tQXBwZWFyYW5j ZUNoYW5nZWQ6IHJldHVybiAiQ3VzdG9tQXBwZWFyYW5jZUNoYW5nZWQiOworICAgIGNhc2UgTGF5 ZXJDaGFuZ2U6OkJsZW5kTW9kZUNoYW5nZWQ6IHJldHVybiAiQmxlbmRNb2RlQ2hhbmdlZCI7Cisg ICAgY2FzZSBMYXllckNoYW5nZTo6U2hhcGVDaGFuZ2VkOiByZXR1cm4gIlNoYXBlQ2hhbmdlZCI7 CisgICAgY2FzZSBMYXllckNoYW5nZTo6V2luZFJ1bGVDaGFuZ2VkOiByZXR1cm4gIldpbmRSdWxl Q2hhbmdlZCI7CisgICAgY2FzZSBMYXllckNoYW5nZTo6VXNlckludGVyYWN0aW9uRW5hYmxlZENo YW5nZWQ6IHJldHVybiAiVXNlckludGVyYWN0aW9uRW5hYmxlZENoYW5nZWQiOworICAgIGNhc2Ug TGF5ZXJDaGFuZ2U6Ok5lZWRzQ29tcHV0ZVZpc2libGVBbmRDb3ZlcmFnZVJlY3Q6IHJldHVybiAi TmVlZHNDb21wdXRlVmlzaWJsZUFuZENvdmVyYWdlUmVjdCI7CisgICAgY2FzZSBMYXllckNoYW5n ZTo6RXZlbnRSZWdpb25DaGFuZ2VkOiByZXR1cm4gIkV2ZW50UmVnaW9uQ2hhbmdlZCI7CisjaWYg RU5BQkxFKFNDUk9MTElOR19USFJFQUQpCisgICAgY2FzZSBMYXllckNoYW5nZTo6U2Nyb2xsaW5n Tm9kZUNoYW5nZWQ6IHJldHVybiAiU2Nyb2xsaW5nTm9kZUNoYW5nZWQiOworI2VuZGlmCisjaWYg SEFWRShDT1JFX0FOSU1BVElPTl9TRVBBUkFURURfTEFZRVJTKQorICAgIGNhc2UgTGF5ZXJDaGFu Z2U6OlNlcGFyYXRlZENoYW5nZWQ6IHJldHVybiAiU2VwYXJhdGVkQ2hhbmdlZCI7CisjaWYgSEFW RShDT1JFX0FOSU1BVElPTl9TRVBBUkFURURfUE9SVEFMUykKKyAgICBjYXNlIExheWVyQ2hhbmdl OjpTZXBhcmF0ZWRQb3J0YWxDaGFuZ2VkOiByZXR1cm4gIlNlcGFyYXRlZFBvcnRhbENoYW5nZWQi OworICAgIGNhc2UgTGF5ZXJDaGFuZ2U6OkRlc2NlbmRlbnRPZlNlcGFyYXRlZFBvcnRhbENoYW5n ZWQ6IHJldHVybiAiRGVzY2VuZGVudE9mU2VwYXJhdGVkUG9ydGFsQ2hhbmdlZCI7CisjZW5kaWYK KyNlbmRpZgorICAgIH0KKyAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICByZXR1cm4gIiI7 Cit9CisKK3ZvaWQgR3JhcGhpY3NMYXllckNBOjpkdW1wTGF5ZXJDaGFuZ2VGbGFncyhUZXh0U3Ry ZWFtJiB0ZXh0U3RyZWFtLCBMYXllckNoYW5nZUZsYWdzIGxheWVyQ2hhbmdlRmxhZ3MpCit7Cisg ICAgdGV4dFN0cmVhbSA8PCAneyc7CisgICAgdWludDY0X3QgYml0ID0gMTsKKyAgICBib29sIGZp cnN0ID0gdHJ1ZTsKKyAgICB3aGlsZSAobGF5ZXJDaGFuZ2VGbGFncykgeworICAgICAgICBpZiAo bGF5ZXJDaGFuZ2VGbGFncyAmIGJpdCkgeworICAgICAgICAgICAgdGV4dFN0cmVhbSA8PCAoZmly c3QgPyAiICIgOiAiLCAiKSA8PCBsYXllckNoYW5nZUFzU3RyaW5nKHN0YXRpY19jYXN0PExheWVy Q2hhbmdlPihiaXQpKTsKKyAgICAgICAgICAgIGZpcnN0ID0gZmFsc2U7CisgICAgICAgIH0KKyAg ICAgICAgbGF5ZXJDaGFuZ2VGbGFncyAmPSB+Yml0OworICAgICAgICBiaXQgPDw9IDE7CisgICAg fQorICAgIHRleHRTdHJlYW0gPDwgIiB9IjsKK30KKwogdm9pZCBHcmFwaGljc0xheWVyQ0E6OmR1 bXBBZGRpdGlvbmFsUHJvcGVydGllcyhUZXh0U3RyZWFtJiB0ZXh0U3RyZWFtLCBMYXllclRyZWVB c1RleHRCZWhhdmlvciBiZWhhdmlvcikgY29uc3QKIHsKICAgICBpZiAoYmVoYXZpb3IgJiBMYXll clRyZWVBc1RleHRJbmNsdWRlVmlzaWJsZVJlY3RzKSB7CkBAIC00MTc4LDYgKzQyNTIsMTIgQEAg dm9pZCBHcmFwaGljc0xheWVyQ0E6OmR1bXBBZGRpdGlvbmFsUHJvcGVydGllcyhUZXh0U3RyZWFt JiB0ZXh0U3RyZWFtLCBMYXllclRyZWUKICAgICAgICAgaWYgKG1fdXNlc0Rpc3BsYXlMaXN0RHJh d2luZykKICAgICAgICAgICAgIHRleHRTdHJlYW0gPDwgaW5kZW50IDw8ICIodXNlcyBkaXNwbGF5 LWxpc3QgZHJhd2luZyAiIDw8IG1fdXNlc0Rpc3BsYXlMaXN0RHJhd2luZyA8PCAiKVxuIjsKIAor ICAgICAgICBpZiAobV91bmNvbW1pdHRlZENoYW5nZXMpIHsKKyAgICAgICAgICAgIHRleHRTdHJl YW0gPDwgaW5kZW50IDw8ICIodW5jb21taXR0ZWQgY2hhbmdlcyAiOworICAgICAgICAgICAgZHVt cExheWVyQ2hhbmdlRmxhZ3ModGV4dFN0cmVhbSwgbV91bmNvbW1pdHRlZENoYW5nZXMpOworICAg ICAgICAgICAgdGV4dFN0cmVhbSA8PCAiKVxuIjsKKyAgICAgICAgfQorCiAgICAgICAgIGR1bXBB bmltYXRpb25zKHRleHRTdHJlYW0sICJhbmltYXRpb25zIiwgbV9hbmltYXRpb25zKTsKICAgICAg ICAgZHVtcEFuaW1hdGlvbnModGV4dFN0cmVhbSwgImJhc2UgdmFsdWUgYW5pbWF0aW9ucyIsIG1f YmFzZVZhbHVlVHJhbnNmb3JtQW5pbWF0aW9ucyk7CiAgICAgICAgIGR1bXBBbmltYXRpb25zKHRl eHRTdHJlYW0sICJhbmltYXRpb24gZ3JvdXBzIiwgbV9hbmltYXRpb25Hcm91cHMpOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvR3JhcGhpY3NMYXllckNB LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9HcmFwaGljc0xheWVyQ0Eu aAppbmRleCA4NzE0MjM0ZGI1NTJiOTY0YTgyYzc4NjY5NGQzMTllZjE1YTNlMWFjLi4wMmRjMzkw YjRhNWI2MmU1ODU4MWU5MzA4MGMwNWUzOThkYzE1MjgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9HcmFwaGljc0xheWVyQ0EuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9HcmFwaGljc0xheWVyQ0EuaApAQCAtNTgwLDYg KzU4MCw4IEBAIHByaXZhdGU6CiAjZW5kaWYKICAgICB9OwogICAgIHR5cGVkZWYgdWludDY0X3Qg TGF5ZXJDaGFuZ2VGbGFnczsKKyAgICBzdGF0aWMgY29uc3QgY2hhciogbGF5ZXJDaGFuZ2VBc1N0 cmluZyhMYXllckNoYW5nZSk7CisgICAgc3RhdGljIHZvaWQgZHVtcExheWVyQ2hhbmdlRmxhZ3Mo VGV4dFN0cmVhbSYsIExheWVyQ2hhbmdlRmxhZ3MpOwogICAgIHZvaWQgYWRkVW5jb21taXR0ZWRD aGFuZ2VzKExheWVyQ2hhbmdlRmxhZ3MpOwogICAgIGJvb2wgaGFzRGVzY2VuZGFudHNXaXRoVW5j b21taXR0ZWRDaGFuZ2VzKCkgY29uc3QgeyByZXR1cm4gbV9oYXNEZXNjZW5kYW50c1dpdGhVbmNv bW1pdHRlZENoYW5nZXM7IH0KICAgICB2b2lkIHNldEhhc0Rlc2NlbmRhbnRzV2l0aFVuY29tbWl0 dGVkQ2hhbmdlcyhib29sKTsK