227782 2021-07-07 17:36:39 -0700 Heap::waitForCollector() needs to set m_mutatorDidRun. 2021-07-07 17:55:16 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1775546 0 mark.lam 2021-07-07 17:36:39 -0700 Heap::waitForCollector() is one of 2 clients of Heap::stopIfNecessarySlow(unsigned oldState). The other client, Heap::stopIfNecessarySlow() sets m_mutatorDidRun to true after calling Heap::stopIfNecessarySlow(unsigned oldState). Heap::waitForCollector() needs to do the same. Constraint solvers rely on this. rdar://78326474 1775547 1 433099 mark.lam 2021-07-07 17:41:45 -0700 Created attachment 433099 proposed patch. 1775553 2 mark.lam 2021-07-07 17:55:16 -0700 Thanks for the review. Landed in r279689: <http://trac.webkit.org/r279689>. 433099 2021-07-07 17:41:45 -0700 2021-07-07 17:43:16 -0700 proposed patch. bug-227782.patch text/plain 1898 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjc5Njg4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDIxLTA3LTA3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBI ZWFwOjp3YWl0Rm9yQ29sbGVjdG9yKCkgbmVlZHMgdG8gc2V0IG1fbXV0YXRvckRpZFJ1bi4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNzc4MgorICAg ICAgICByZGFyOi8vNzgzMjY0NzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBIZWFwOjp3YWl0Rm9yQ29sbGVjdG9yKCkgaXMgb25lIG9mIDIgY2xpZW50 cyBvZiBIZWFwOjpzdG9wSWZOZWNlc3NhcnlTbG93KHVuc2lnbmVkIG9sZFN0YXRlKS4KKyAgICAg ICAgVGhlIG90aGVyIGNsaWVudCwgSGVhcDo6c3RvcElmTmVjZXNzYXJ5U2xvdygpIHNldHMgbV9t dXRhdG9yRGlkUnVuIHRvIHRydWUgYWZ0ZXIKKyAgICAgICAgY2FsbGluZyBIZWFwOjpzdG9wSWZO ZWNlc3NhcnlTbG93KHVuc2lnbmVkIG9sZFN0YXRlKS4gIEhlYXA6OndhaXRGb3JDb2xsZWN0b3Io KQorICAgICAgICBuZWVkcyB0byBkbyB0aGUgc2FtZS4gIENvbnN0cmFpbnQgc29sdmVycyByZWx5 IG9uIHRoaXMuCisKKyAgICAgICAgV2l0aG91dCB0aGlzLCBvbmUgZmFsbCBvdXQgd2UndmUgc2Vl biBpcyB0aGF0IERPTUdDT3V0cHV0Q29uc3RyYWludCBmYWlscyB0bworICAgICAgICB2aXNpdE91 dHB1dENvbnN0cmFpbnRzLCBhbmQgYXMgYSByZXN1bHQsIG9wYXF1ZVJvb3RzIG1heSBub3QgZ2V0 IHVwZGF0ZWQuICBUaGlzCisgICAgICAgIGlzc3VlIHdhcyBjYXVnaHQgYnkgdGhlIEdDIHZlcmlm aWVyLgorCisgICAgICAgICogaGVhcC9IZWFwLmNwcDoKKyAgICAgICAgKEpTQzo6SGVhcDo6d2Fp dEZvckNvbGxlY3Rvcik6CisKIDIwMjEtMDctMDcgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBh cHBsZS5jb20+CiAKICAgICAgICAgZml0Y29yZWQgY3Jhc2hlcyBhdCBKYXZhU2NyaXB0Q29yZTog SlNDOjpIZWFwOjpyZWxlYXNlQWNjZXNzU2xvdwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L2hlYXAvSGVhcC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAv SGVhcC5jcHAJKHJldmlzaW9uIDI3OTY4NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFw L0hlYXAuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xODgyLDEwICsxODgyLDExIEBAIHZvaWQgSGVh cDo6d2FpdEZvckNvbGxlY3Rvcihjb25zdCBGdW5jJiAKICAgICAgICAgaWYgKHN0b3BJZk5lY2Vz c2FyeVNsb3cob2xkU3RhdGUpKQogICAgICAgICAgICAgY29udGludWU7CiAgICAgICAgIAorICAg ICAgICBtX211dGF0b3JEaWRSdW4gPSB0cnVlOwogICAgICAgICAvLyBGSVhNRTogV2Ugd291bGRu J3QgbmVlZCB0aGlzIGlmIHN0b3BJZk5lY2Vzc2FyeVNsb3coKSBoYWQgYSBtb2RlIHdoZXJlIGl0 IGtuZXcgdG8ganVzdAogICAgICAgICAvLyBkbyB0aGUgY29sbGVjdGlvbi4KICAgICAgICAgcmVs aW5xdWlzaENvbm4oKTsKLSAgICAgICAgCisKICAgICAgICAgaWYgKGRvbmUpIHsKICAgICAgICAg ICAgIGNsZWFyTXV0YXRvcldhaXRpbmcoKTsgLy8gQ2xlYW4gdXAganVzdCBpbiBjYXNlLgogICAg ICAgICAgICAgcmV0dXJuOwo=