227766 2021-07-07 13:17:13 -0700 Code Style Guidelines: Don't precede functions returning values with "get" 2021-07-14 13:18:24 -0700 1 1 1 Unclassified WebKit WebKit Website WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 1 fujii fujii darin jond rniwa webkit-bug-importer oldest_to_newest 1775413 0 fujii 2021-07-07 13:17:13 -0700 Code Style Guidelines: Don't precede functions returning values with "get" (In reply to Darin Adler from comment bug#227502 #21) > (In reply to Fujii Hironori from comment bug#227502 #18) > > I think the guildline rules getters, but not free functions. > > Good point about how the guideline is written. > > The intention was to apply the rule to all functions, but the guidelines are > not written that way. I agree that we should revise the guidelines at some > point. 1775414 1 fujii 2021-07-07 13:18:07 -0700 See bug#227502 comment#21 1775428 2 433067 fujii 2021-07-07 13:39:38 -0700 Created attachment 433067 Patch 1777013 3 webkit-bug-importer 2021-07-14 13:18:24 -0700 <rdar://problem/80593452> 433067 2021-07-07 13:39:38 -0700 2021-07-07 13:39:38 -0700 Patch bug-227766-20210708053937.patch text/plain 2116 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5NjYyCmRpZmYgLS1naXQgYS9XZWJzaXRlcy93ZWJraXQu b3JnL0NoYW5nZUxvZyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCmluZGV4IGM3YTc1 YjA1ZDgxMjIxN2UwZDhiYTZhMGNlYmRlODhjMmU4NTcxYTIuLjY0NDJlNzJkZjJkZmY1OGM1N2U4 NzExYzdkMWNjODM5Y2E3NGU2YTggMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hh bmdlTG9nCisrKyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMjEtMDctMDcgIEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+ CisKKyAgICAgICAgQ29kZSBTdHlsZSBHdWlkZWxpbmVzOiBEb24ndCBwcmVjZWRlIGZ1bmN0aW9u cyByZXR1cm5pbmcgdmFsdWVzIHdpdGggImdldCIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNzc2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFsdGhvdWdoICNuYW1lcy1zZXR0ZXItZ2V0dGVyIGFuZCAj bmFtZXMtb3V0LWFyZ3VtZW50IHJ1bGVzCisgICAgICAgIG1lbnRpb24gYWJvdXQgImdldCIgcHJl Zml4IGZvciBnZXR0ZXJzLCBidXQgaXQgd2FzIG5vdCBjbGVhciB0aGF0CisgICAgICAgIHRoZSBy dWxlcyBzaG91bGQgYmUgYXBwbGllZCB0byBhbGwgZnVuY3Rpb25zLgorCisgICAgICAgICNuYW1l cy12ZXJiIHJ1bGUgbWVudGlvbnMgYWJvdXQgdGhlIHZlcmIgb2YgZnVuY3Rpb25zLgorCisgICAg ICAgICogY29kZS1zdHlsZS5tZDogQ2xhcmlmaWVkICNuYW1lcy12ZXJiIHJ1bGUgZm9yICJnZXQi LgorCiAyMDIxLTAyLTE3ICBMaW5nIEhvICA8bGluZ2hvQGFwcGxlLmNvbT4KIAogICAgICAgICBX ZWJLaXQgbmlnaGx5IGFyY2hpdmVzIHBhZ2Ugbm90IHdvcmtpbmcgZm9yIEJpZyBTdXIKZGlmZiAt LWdpdCBhL1dlYnNpdGVzL3dlYmtpdC5vcmcvY29kZS1zdHlsZS5tZCBiL1dlYnNpdGVzL3dlYmtp dC5vcmcvY29kZS1zdHlsZS5tZAppbmRleCA0ZTE0MDQyNjdlYTJlODVkYWZlMmQwY2U1NWJlZjBl M2M5MTNmN2ViLi43NTIwZjRkOTUyNGJmMzUxMmMwZDk3MGRhZWI4YjgxMjdhNmQ0ZTAzIDEwMDY0 NAotLS0gYS9XZWJzaXRlcy93ZWJraXQub3JnL2NvZGUtc3R5bGUubWQKKysrIGIvV2Vic2l0ZXMv d2Via2l0Lm9yZy9jb2RlLXN0eWxlLm1kCkBAIC02NzgsMTggKzY3OCwyMCBAQCB2b2lkIGdldElu bGluZUJveEFuZE9mZnNldChJbmxpbmVCb3gqJiwgaW50JiBjYXJldE9mZnNldCkgY29uc3Q7CiB2 b2lkIGlubGluZUJveEFuZE9mZnNldChJbmxpbmVCb3gqJiwgaW50JiBjYXJldE9mZnNldCkgY29u c3Q7CiBgYGAKIAotW10oI25hbWVzLXZlcmIpIFVzZSBkZXNjcmlwdGl2ZSB2ZXJicyBpbiBmdW5j dGlvbiBuYW1lcy4KK1tdKCNuYW1lcy12ZXJiKSBVc2UgZGVzY3JpcHRpdmUgdmVyYnMgaW4gZnVu Y3Rpb24gbmFtZXMuIEJ1dCwgZG8gbm90IHVzZSAiZ2V0IiBmb3IgZnVuY3Rpb25zIHJldHVybmlu ZyBhIHZhbHVlLgogCiAjIyMjIyMgUmlnaHQ6CiAKIGBgYGNwcAogYm9vbCBjb252ZXJ0VG9BU0NJ SShzaG9ydCosIHNpemVfdCk7CitzdGQ6Om9wdGlvbmFsPHVpbnQzMl90PiB2b2x1bWVGaWxlQmxv Y2tTaXplKGNvbnN0IFN0cmluZyYpOwogYGBgCiAKICMjIyMjIyBXcm9uZzoKIAogYGBgY3BwCiBi b29sIHRvQVNDSUkoc2hvcnQqLCBzaXplX3QpOworc3RkOjpvcHRpb25hbDx1aW50MzJfdD4gZ2V0 Vm9sdW1lRmlsZUJsb2NrU2l6ZShjb25zdCBTdHJpbmcmKTsKIGBgYAogCiBbXSgjbmFtZXMtaWYt ZXhpc3RzKSBUaGUgZ2V0dGVyIGZ1bmN0aW9uIGZvciBhIG1lbWJlciB2YXJpYWJsZSBzaG91bGQg bm90IGhhdmUgYW55IHN1ZmZpeCBvciBwcmVmaXggaW5kaWNhdGluZyB0aGUgZnVuY3Rpb24gY2Fu IG9wdGlvbmFsbHkgY3JlYXRlIG9yIGluaXRpYWxpemUgdGhlIG1lbWJlciB2YXJpYWJsZS4gU3Vm Zml4IHRoZSBnZXR0ZXIgZnVuY3Rpb24gd2hpY2ggZG9lcyBub3QgYXV0b21hdGljYWxseSBjcmVh dGUgdGhlIG9iamVjdCB3aXRoIGBJZkV4aXN0c2AgaWYgdGhlcmUgaXMgYSB2YXJpYW50IHdoaWNo IGRvZXMuCg==