22776 2008-12-09 21:35:01 -0800 Add ScriptController::updateSecurityOrigin 2008-12-10 09:56:51 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abarth abarth abarth eric oldest_to_newest 102064 0 abarth 2008-12-09 21:35:01 -0800 We should call a method on ScriptController when we update a document's securityOrigin. V8 uses this method to update the security context it uses in its fast-path security check. Currently, the JavaScriptCore bindings don't have use for this method, but it might in the future. Patch forthcoming. 102065 1 25912 abarth 2008-12-09 21:35:28 -0800 Created attachment 25912 patch 102067 2 abarth 2008-12-09 21:41:36 -0800 For those keeping score at home, this method corresponds to / replaces SecriptController::setDomain in http://src.chromium.org/viewvc/chrome/trunk/src/webkit/port/bindings/v8/ScriptController.h?view=markup 102068 3 25912 sam 2008-12-09 21:44:16 -0800 Comment on attachment 25912 patch > securityOrigin()->setDomainFromDOM(newDomain); > + if (m_frame) > + m_frame->script()->updateSecurityOrigin(); The indentation looks odd here. > securityOrigin()->setDomainFromDOM(newDomain); > + if (m_frame) > + m_frame->script()->updateSecurityOrigin(); And here. r=me 102074 4 abarth 2008-12-09 22:49:57 -0800 Fixed in r39163. Thanks for the quick review! 102098 5 25912 fishd 2008-12-10 08:43:33 -0800 Comment on attachment 25912 patch >diff --git a/WebCore/dom/Document.cpp b/WebCore/dom/Document.cpp ... >+ if (m_frame) >+ m_frame->script()->updateSecurityOrigin(); > return; ... >+ if (m_frame) >+ m_frame->script()->updateSecurityOrigin(); > } FYI: indentation looks to be off by one space. 102109 6 abarth 2008-12-10 09:56:51 -0800 > FYI: indentation looks to be off by one space. Thanks. I think I fixed this before landing. 25912 2008-12-09 21:35:28 -0800 2008-12-09 21:44:16 -0800 patch update-security-origin.patch text/plain 4012 abarth RnJvbSAzNmFhMmRmNzU4ZmU2MjU1MDM1OTllMTEwYjcwMGExZTIxYzMyZGZjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGFtIEJhcnRoIDxhYmFydGhAYXJjdGljYS5sb2NhbD4KRGF0 ZTogVHVlLCA5IERlYyAyMDA4IDIxOjI4OjA4IC0wODAwClN1YmplY3Q6IFtQQVRDSF0gMjAwOC0x Mi0wOSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgoKICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgQWRkIFNjcmlwdENvbnRyb2xsZXI6OnVwZGF0ZVNl Y3VyaXR5T3JpZ2luIHRvIG5vdGlmeSB0aGUgYmluZGluZ3MKICAgICAgICB0aGF0IGEgZG9jdW1l bnQncyBzZWN1cml0eU9yaWdpbiBoYXMgYmVlbiB1cGRhdGVkLiAgVGhpcyBpcyB1c2VkIGJ5CiAg ICAgICAgVjggdG8gdXBkYXRlIGl0cyBzZWN1cml0eSBjb250ZXh0LgoKICAgICAgICAqIGJpbmRp bmdzL2pzL1NjcmlwdENvbnRyb2xsZXIuY3BwOgogICAgICAgIChXZWJDb3JlOjpTY3JpcHRDb250 cm9sbGVyOjp1cGRhdGVTZWN1cml0eU9yaWdpbik6CiAgICAgICAgKiBiaW5kaW5ncy9qcy9TY3Jp cHRDb250cm9sbGVyLmg6CiAgICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgogICAgICAgIChXZWJD b3JlOjpEb2N1bWVudDo6c2V0RG9tYWluKToKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAg ICAgICAgICAgICAgICAgIHwgICAxNCArKysrKysrKysrKysrKwogV2ViQ29yZS9iaW5kaW5ncy9q cy9TY3JpcHRDb250cm9sbGVyLmNwcCB8ICAgIDQgKysrKwogV2ViQ29yZS9iaW5kaW5ncy9qcy9T Y3JpcHRDb250cm9sbGVyLmggICB8ICAgIDYgKysrKysrCiBXZWJDb3JlL2RvbS9Eb2N1bWVudC5j cHAgICAgICAgICAgICAgICAgIHwgICAgNSArKysrKwogNCBmaWxlcyBjaGFuZ2VkLCAyOSBpbnNl cnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9n IGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWZmY2ZhYi4uZGM2ZmU4MiAxMDA2NDQKLS0tIGEv V2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBA QAorMjAwOC0xMi0wOSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBTY3JpcHRDb250cm9s bGVyOjp1cGRhdGVTZWN1cml0eU9yaWdpbiB0byBub3RpZnkgdGhlIGJpbmRpbmdzCisgICAgICAg IHRoYXQgYSBkb2N1bWVudCdzIHNlY3VyaXR5T3JpZ2luIGhhcyBiZWVuIHVwZGF0ZWQuICBUaGlz IGlzIHVzZWQgYnkKKyAgICAgICAgVjggdG8gdXBkYXRlIGl0cyBzZWN1cml0eSBjb250ZXh0Lgor CisgICAgICAgICogYmluZGluZ3MvanMvU2NyaXB0Q29udHJvbGxlci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpTY3JpcHRDb250cm9sbGVyOjp1cGRhdGVTZWN1cml0eU9yaWdpbik6CisgICAgICAg ICogYmluZGluZ3MvanMvU2NyaXB0Q29udHJvbGxlci5oOgorICAgICAgICAqIGRvbS9Eb2N1bWVu dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6c2V0RG9tYWluKToKKwogMjAwOC0x Mi0wOSAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGNvZGUg dGhhdCB3aWxsIGNyZWF0ZSBjdXN0b20gQ1NTIHNjcm9sbGJhcnMgZnJvbSB0aGUgPGJvZHk+LCB0 aGUgZG9jdW1lbnQgZWxlbWVudCAoPGh0bWw+KSBhbmQgdGhlIG93bmluZwpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRDb250cm9sbGVyLmNwcCBiL1dlYkNvcmUvYmluZGlu Z3MvanMvU2NyaXB0Q29udHJvbGxlci5jcHAKaW5kZXggNGJjOWEyOS4uMzRlMGY0MCAxMDA2NDQK LS0tIGEvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRDb250cm9sbGVyLmNwcAorKysgYi9XZWJD b3JlL2JpbmRpbmdzL2pzL1NjcmlwdENvbnRyb2xsZXIuY3BwCkBAIC0yMzYsNiArMjM2LDEwIEBA IHZvaWQgU2NyaXB0Q29udHJvbGxlcjo6dXBkYXRlRG9jdW1lbnQoKQogICAgICAgICAoKml0KS0+ dXBkYXRlRG9jdW1lbnQoKTsKIH0KIAordm9pZCBTY3JpcHRDb250cm9sbGVyOjp1cGRhdGVTZWN1 cml0eU9yaWdpbigpCit7CisgICAgLy8gT3VyIGJpbmRpbmdzIGRvIG5vdCBkbyBhbnl0aGluZyBp biB0aGlzIGNhc2UuCit9CiAKIEJpbmRpbmdzOjpSb290T2JqZWN0KiBTY3JpcHRDb250cm9sbGVy OjpiaW5kaW5nUm9vdE9iamVjdCgpCiB7CmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL2pz L1NjcmlwdENvbnRyb2xsZXIuaCBiL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0Q29udHJvbGxl ci5oCmluZGV4IDQ5MjljZWQuLmUwZDJlYjkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3Mv anMvU2NyaXB0Q29udHJvbGxlci5oCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0Q29u dHJvbGxlci5oCkBAIC0xMDMsNiArMTAzLDEyIEBAIHB1YmxpYzoKICAgICB2b2lkIGNsZWFyRm9y bWVyV2luZG93KEpTRE9NV2luZG93KiB3aW5kb3cpIHsgbV9saXZlRm9ybWVyV2luZG93cy5yZW1v dmUod2luZG93KTsgfQogICAgIHZvaWQgdXBkYXRlRG9jdW1lbnQoKTsKIAorICAgIC8vIE5vdGlm aWVzIHRoZSBTY3JpcHRDb250cm9sbGVyIHRoYXQgdGhlIHNlY3VyaXR5T3JpZ2luIG9mIHRoZSBj dXJyZW50CisgICAgLy8gZG9jdW1lbnQgd2FzIG1vZGlmaWVkLiAgRm9yIGV4YW1wbGUsIHRoaXMg bWV0aG9kIGlzIGNhbGxlZCB3aGVuCisgICAgLy8gZG9jdW1lbnQuZG9tYWluIGlzIHNldC4gIFRo aXMgbWV0aG9kIGlzICpub3QqIGNhbGxlZCB3aGVuIGEgbmV3IGRvY3VtZW50CisgICAgLy8gaXMg YXR0YWNoZWQgdG8gYSBmcmFtZSBiZWNhdXNlIHVwZGF0ZURvY3VtZW50KCkgaXMgY2FsbGVkIGlu c3RlYWQuCisgICAgdm9pZCB1cGRhdGVTZWN1cml0eU9yaWdpbigpOworCiAgICAgdm9pZCBjbGVh clNjcmlwdE9iamVjdHMoKTsKICAgICB2b2lkIGNsZWFudXBTY3JpcHRPYmplY3RzRm9yUGx1Z2lu KHZvaWQqKTsKIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwIGIvV2ViQ29y ZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IDcyNGRiMWEuLjdmMWIxNTYgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvZG9tL0RvY3VtZW50LmNwcAorKysgYi9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKQEAg LTk3LDYgKzk3LDcgQEAKICNpbmNsdWRlICJSZW5kZXJBcmVuYS5oIgogI2luY2x1ZGUgIlJlbmRl clZpZXcuaCIKICNpbmNsdWRlICJSZW5kZXJXaWRnZXQuaCIKKyNpbmNsdWRlICJTY3JpcHRDb250 cm9sbGVyLmgiCiAjaW5jbHVkZSAiU2VjdXJpdHlPcmlnaW4uaCIKICNpbmNsdWRlICJTZWdtZW50 ZWRTdHJpbmcuaCIKICNpbmNsdWRlICJTZWxlY3Rpb25Db250cm9sbGVyLmgiCkBAIC0yOTE4LDYg KzI5MTksOCBAQCB2b2lkIERvY3VtZW50OjpzZXREb21haW4oY29uc3QgU3RyaW5nJiBuZXdEb21h aW4pCiAgICAgLy8gaGF2ZSBhbHNvIGFzc2lnbmVkIHRvIGFjY2VzcyB0aGlzIHBhZ2UuCiAgICAg aWYgKGVxdWFsSWdub3JpbmdDYXNlKGRvbWFpbigpLCBuZXdEb21haW4pKSB7CiAgICAgICAgIHNl Y3VyaXR5T3JpZ2luKCktPnNldERvbWFpbkZyb21ET00obmV3RG9tYWluKTsKKyAgICAgICAgaWYg KG1fZnJhbWUpCisgICAgICAgICAgICAgbV9mcmFtZS0+c2NyaXB0KCktPnVwZGF0ZVNlY3VyaXR5 T3JpZ2luKCk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKQEAgLTI5MzksNiArMjk0Miw4IEBA IHZvaWQgRG9jdW1lbnQ6OnNldERvbWFpbihjb25zdCBTdHJpbmcmIG5ld0RvbWFpbikKICAgICAg ICAgcmV0dXJuOwogCiAgICAgc2VjdXJpdHlPcmlnaW4oKS0+c2V0RG9tYWluRnJvbURPTShuZXdE b21haW4pOworICAgIGlmIChtX2ZyYW1lKQorICAgICAgICAgbV9mcmFtZS0+c2NyaXB0KCktPnVw ZGF0ZVNlY3VyaXR5T3JpZ2luKCk7CiB9CiAKIFN0cmluZyBEb2N1bWVudDo6bGFzdE1vZGlmaWVk KCkgY29uc3QKLS0gCjEuNi4wLjEKCg==