<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>227747</bug_id>
          
          <creation_ts>2021-07-07 09:17:31 -0700</creation_ts>
          <short_desc>XPC services should release their os transaction when given a SIGTERM signal</short_desc>
          <delta_ts>2021-07-13 13:56:55 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alex Christensen">achristensen</reporter>
          <assigned_to name="Alex Christensen">achristensen</assigned_to>
          <cc>ggaren</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1775290</commentid>
    <comment_count>0</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2021-07-07 09:17:31 -0700</bug_when>
    <thetext>XPC services should release their os transaction when given a SIGTERM signal</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1775291</commentid>
    <comment_count>1</comment_count>
      <attachid>433035</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2021-07-07 09:21:38 -0700</bug_when>
    <thetext>Created attachment 433035
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1775292</commentid>
    <comment_count>2</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2021-07-07 09:21:41 -0700</bug_when>
    <thetext>&lt;rdar://problem/72430454&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1775297</commentid>
    <comment_count>3</comment_count>
      <attachid>433035</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2021-07-07 09:41:54 -0700</bug_when>
    <thetext>Comment on attachment 433035
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433035&amp;action=review

r=me

&gt; Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h:105
&gt; +    signal(SIGTERM, releaseOSTransaction);

FWIW, I like using no-capture lambdas in cases like this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1775300</commentid>
    <comment_count>4</comment_count>
      <attachid>433038</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2021-07-07 09:51:27 -0700</bug_when>
    <thetext>Created attachment 433038
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1775316</commentid>
    <comment_count>5</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-07-07 10:32:26 -0700</bug_when>
    <thetext>Committed r279647 (239460@main): &lt;https://commits.webkit.org/239460@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433038.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1776747</commentid>
    <comment_count>6</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2021-07-13 13:56:55 -0700</bug_when>
    <thetext>Reverted in r279890</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>433035</attachid>
            <date>2021-07-07 09:21:38 -0700</date>
            <delta_ts>2021-07-07 09:51:25 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-227747-20210707092137.patch</filename>
            <type>text/plain</type>
            <size>3064</size>
            <attacher name="Alex Christensen">achristensen</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5NjEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDM0OTk4ZWZjMDZjOWU1NmUz
MjlmM2U1YWI3MjhhOWY2Y2VkN2RhZWYuLjM0MTNkYWViMjFhYTNiM2E1OGE3YmU0ZWU4NmEyZWRm
NzkwNzZjOTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjEtMDctMDcgIEFsZXggQ2hy
aXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBYUEMgc2Vydmlj
ZXMgc2hvdWxkIHJlbGVhc2UgdGhlaXIgb3MgdHJhbnNhY3Rpb24gd2hlbiBnaXZlbiBhIFNJR1RF
Uk0gc2lnbmFsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD0yMjc3NDcKKyAgICAgICAgPHJkYXI6Ly83MjQzMDQ1ND4KKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBcHBhcmVudGx5IHdoZW4geW91IHNodXQgZG93
biB5b3VyIGNvbXB1dGVyLCBwcm9jZXNzZXMgYXJlIGdpdmVuIGEgU0lHVEVSTSBzaWduYWwgYW5k
IGV4cGVjdGVkIHRvIHJlbGVhc2UgdGhlaXIgb3NfdHJhbnNhY3Rpb25fdAorICAgICAgICB0byBp
bmRpY2F0ZSB0aGF0IHRoZXkgY2FuIG5vdyBiZSB0ZXJtaW5hdGVkICJjbGVhbmx5Ii4KKworICAg
ICAgICAqIFNoYXJlZC9FbnRyeVBvaW50VXRpbGl0aWVzL0NvY29hL1hQQ1NlcnZpY2UvWFBDU2Vy
dmljZUVudHJ5UG9pbnQuaDoKKyAgICAgICAgKFdlYktpdDo6WFBDU2VydmljZUluaXRpYWxpemVy
KToKKyAgICAgICAgKiBTaGFyZWQvRW50cnlQb2ludFV0aWxpdGllcy9Db2NvYS9YUENTZXJ2aWNl
L1hQQ1NlcnZpY2VFbnRyeVBvaW50Lm1tOgorICAgICAgICAoV2ViS2l0OjpyZWxlYXNlT1NUcmFu
c2FjdGlvbik6CisKIDIwMjEtMDctMDYgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBs
ZS5jb20+CiAKICAgICAgICAgW0xpdmUgVGV4dF0gRXh0cmFuZW91cyBzcGFjZXMgd2hlbiBjb3B5
aW5nIG9yIHRyYW5zbGF0aW5nIENoaW5lc2UgYW5kIEphcGFuZXNlIHRleHQgaW4gV2ViS2l0CmRp
ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9FbnRyeVBvaW50VXRpbGl0aWVzL0NvY29h
L1hQQ1NlcnZpY2UvWFBDU2VydmljZUVudHJ5UG9pbnQuaCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVk
L0VudHJ5UG9pbnRVdGlsaXRpZXMvQ29jb2EvWFBDU2VydmljZS9YUENTZXJ2aWNlRW50cnlQb2lu
dC5oCmluZGV4IDkyZTE0ZTRlZGY3MTliMWVjMDJkZmQ4NTQxODI5NDQyMjNjYzI2YTUuLjU2OTdl
ZjE5ZDZlNTM1ZGZkZGNhODY1YTlhN2YxY2UxNjYxNzMxZGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X
ZWJLaXQvU2hhcmVkL0VudHJ5UG9pbnRVdGlsaXRpZXMvQ29jb2EvWFBDU2VydmljZS9YUENTZXJ2
aWNlRW50cnlQb2ludC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0VudHJ5UG9pbnRVdGls
aXRpZXMvQ29jb2EvWFBDU2VydmljZS9YUENTZXJ2aWNlRW50cnlQb2ludC5oCkBAIC04Miw2ICs4
Miw3IEBAIHZvaWQgaW5pdGlhbGl6ZUF1eGlsaWFyeVByb2Nlc3MoQXV4aWxpYXJ5UHJvY2Vzc0lu
aXRpYWxpemF0aW9uUGFyYW1ldGVycyYmIHBhcmFtCiAKICNpZiBQTEFURk9STShNQUMpCiBPU09i
amVjdFB0cjxvc190cmFuc2FjdGlvbl90PiYgb3NUcmFuc2FjdGlvbigpOwordm9pZCByZWxlYXNl
T1NUcmFuc2FjdGlvbihpbnQpOwogI2VuZGlmCiAKIHRlbXBsYXRlPHR5cGVuYW1lIFhQQ1NlcnZp
Y2VUeXBlLCB0eXBlbmFtZSBYUENTZXJ2aWNlSW5pdGlhbGl6ZXJEZWxlZ2F0ZVR5cGU+CkBAIC0x
MDEsNiArMTAyLDcgQEAgdm9pZCBYUENTZXJ2aWNlSW5pdGlhbGl6ZXIoT1NPYmplY3RQdHI8eHBj
X2Nvbm5lY3Rpb25fdD4gY29ubmVjdGlvbiwgeHBjX29iamVjdF8KICAgICAvLyB0aGUgVUlQcm9j
ZXNzIHRha2VzIHByb2Nlc3MgYXNzZXJ0aW9ucyBvbiBiZWhhbGYgb2YgaXRzIGNoaWxkIHByb2Nl
c3Nlcy4KICNpZiBQTEFURk9STShNQUMpCiAgICAgb3NUcmFuc2FjdGlvbigpID0gYWRvcHRPU09i
amVjdChvc190cmFuc2FjdGlvbl9jcmVhdGUoIldlYktpdCBYUEMgU2VydmljZSIpKTsKKyAgICBz
aWduYWwoU0lHVEVSTSwgcmVsZWFzZU9TVHJhbnNhY3Rpb24pOwogI2VuZGlmCiAKICAgICBJbml0
aWFsaXplV2ViS2l0MigpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvRW50cnlQ
b2ludFV0aWxpdGllcy9Db2NvYS9YUENTZXJ2aWNlL1hQQ1NlcnZpY2VFbnRyeVBvaW50Lm1tIGIv
U291cmNlL1dlYktpdC9TaGFyZWQvRW50cnlQb2ludFV0aWxpdGllcy9Db2NvYS9YUENTZXJ2aWNl
L1hQQ1NlcnZpY2VFbnRyeVBvaW50Lm1tCmluZGV4IDIzMTQwYjFiZWQxNjAwMTZkOTgxZDU4ZDRh
YWVhMmE0YmI4NDUyYjAuLmQ3ZjM4MGYwYzEzYjIzYzEzZjFhZGIwMjI3MjRiMDU1ZWFkYzE4Y2Ug
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0VudHJ5UG9pbnRVdGlsaXRpZXMvQ29j
b2EvWFBDU2VydmljZS9YUENTZXJ2aWNlRW50cnlQb2ludC5tbQorKysgYi9Tb3VyY2UvV2ViS2l0
L1NoYXJlZC9FbnRyeVBvaW50VXRpbGl0aWVzL0NvY29hL1hQQ1NlcnZpY2UvWFBDU2VydmljZUVu
dHJ5UG9pbnQubW0KQEAgLTE1NCw2ICsxNTQsMTIgQEAgT1NPYmplY3RQdHI8b3NfdHJhbnNhY3Rp
b25fdD4mIG9zVHJhbnNhY3Rpb24oKQogICAgIHN0YXRpYyBOZXZlckRlc3Ryb3llZDxPU09iamVj
dFB0cjxvc190cmFuc2FjdGlvbl90Pj4gdHJhbnNhY3Rpb247CiAgICAgcmV0dXJuIHRyYW5zYWN0
aW9uLmdldCgpOwogfQorCit2b2lkIHJlbGVhc2VPU1RyYW5zYWN0aW9uKGludCBzaWduYWwpCit7
CisgICAgUkVMRUFTRV9BU1NFUlQoc2lnbmFsID09IFNJR1RFUk0pOworICAgIG9zVHJhbnNhY3Rp
b24oKSA9IG51bGxwdHI7Cit9CiAjZW5kaWYKIAogdm9pZCBYUENTZXJ2aWNlRXhpdChPU09iamVj
dFB0cjx4cGNfb2JqZWN0X3Q+JiYgcHJpb3JpdHlCb29zdE1lc3NhZ2UpCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>433038</attachid>
            <date>2021-07-07 09:51:27 -0700</date>
            <delta_ts>2021-07-07 10:32:27 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-227747-20210707095126.patch</filename>
            <type>text/plain</type>
            <size>1910</size>
            <attacher name="Alex Christensen">achristensen</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5NjEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDM0OTk4ZWZjMDZjOWU1NmUz
MjlmM2U1YWI3MjhhOWY2Y2VkN2RhZWYuLmNlYjRhZGE5ZmVmZTBlNDIxMTEwOTcyOWE1YzRjM2Rj
MDBlZjU3MGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMDctMDcgIEFsZXggQ2hy
aXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBYUEMgc2Vydmlj
ZXMgc2hvdWxkIHJlbGVhc2UgdGhlaXIgb3MgdHJhbnNhY3Rpb24gd2hlbiBnaXZlbiBhIFNJR1RF
Uk0gc2lnbmFsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD0yMjc3NDcKKyAgICAgICAgPHJkYXI6Ly83MjQzMDQ1ND4KKworICAgICAgICBSZXZpZXdlZCBi
eSBHZW9mZiBHYXJlbi4KKworICAgICAgICBBcHBhcmVudGx5IHdoZW4geW91IHNodXQgZG93biB5
b3VyIGNvbXB1dGVyLCBwcm9jZXNzZXMgYXJlIGdpdmVuIGEgU0lHVEVSTSBzaWduYWwgYW5kIGV4
cGVjdGVkIHRvIHJlbGVhc2UgdGhlaXIgb3NfdHJhbnNhY3Rpb25fdAorICAgICAgICB0byBpbmRp
Y2F0ZSB0aGF0IHRoZXkgY2FuIG5vdyBiZSB0ZXJtaW5hdGVkICJjbGVhbmx5Ii4KKworICAgICAg
ICAqIFNoYXJlZC9FbnRyeVBvaW50VXRpbGl0aWVzL0NvY29hL1hQQ1NlcnZpY2UvWFBDU2Vydmlj
ZUVudHJ5UG9pbnQuaDoKKyAgICAgICAgKFdlYktpdDo6WFBDU2VydmljZUluaXRpYWxpemVyKToK
KwogMjAyMS0wNy0wNiAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAog
ICAgICAgICBbTGl2ZSBUZXh0XSBFeHRyYW5lb3VzIHNwYWNlcyB3aGVuIGNvcHlpbmcgb3IgdHJh
bnNsYXRpbmcgQ2hpbmVzZSBhbmQgSmFwYW5lc2UgdGV4dCBpbiBXZWJLaXQKZGlmZiAtLWdpdCBh
L1NvdXJjZS9XZWJLaXQvU2hhcmVkL0VudHJ5UG9pbnRVdGlsaXRpZXMvQ29jb2EvWFBDU2Vydmlj
ZS9YUENTZXJ2aWNlRW50cnlQb2ludC5oIGIvU291cmNlL1dlYktpdC9TaGFyZWQvRW50cnlQb2lu
dFV0aWxpdGllcy9Db2NvYS9YUENTZXJ2aWNlL1hQQ1NlcnZpY2VFbnRyeVBvaW50LmgKaW5kZXgg
OTJlMTRlNGVkZjcxOWIxZWMwMmRmZDg1NDE4Mjk0NDIyM2NjMjZhNS4uZjEwNzY4MTZhZjgwMWVi
NWE5MmU3OWM0OGU1OWM5NDExOTRiNmFhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9TaGFy
ZWQvRW50cnlQb2ludFV0aWxpdGllcy9Db2NvYS9YUENTZXJ2aWNlL1hQQ1NlcnZpY2VFbnRyeVBv
aW50LmgKKysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQvRW50cnlQb2ludFV0aWxpdGllcy9Db2Nv
YS9YUENTZXJ2aWNlL1hQQ1NlcnZpY2VFbnRyeVBvaW50LmgKQEAgLTEwMSw2ICsxMDEsMTAgQEAg
dm9pZCBYUENTZXJ2aWNlSW5pdGlhbGl6ZXIoT1NPYmplY3RQdHI8eHBjX2Nvbm5lY3Rpb25fdD4g
Y29ubmVjdGlvbiwgeHBjX29iamVjdF8KICAgICAvLyB0aGUgVUlQcm9jZXNzIHRha2VzIHByb2Nl
c3MgYXNzZXJ0aW9ucyBvbiBiZWhhbGYgb2YgaXRzIGNoaWxkIHByb2Nlc3Nlcy4KICNpZiBQTEFU
Rk9STShNQUMpCiAgICAgb3NUcmFuc2FjdGlvbigpID0gYWRvcHRPU09iamVjdChvc190cmFuc2Fj
dGlvbl9jcmVhdGUoIldlYktpdCBYUEMgU2VydmljZSIpKTsKKyAgICBzaWduYWwoU0lHVEVSTSwg
W10gKGludCBzaWduYWwpIHsKKyAgICAgICAgUkVMRUFTRV9BU1NFUlQoc2lnbmFsID09IFNJR1RF
Uk0pOworICAgICAgICBvc1RyYW5zYWN0aW9uKCkgPSBudWxscHRyOworICAgIH0pOwogI2VuZGlm
CiAKICAgICBJbml0aWFsaXplV2ViS2l0MigpOwo=
</data>

          </attachment>
      

    </bug>

</bugzilla>