227745 2021-07-07 07:54:16 -0700 Use setBooleanAttribute instead of setAttributeWithoutSynchronization(X, Y ? emptyAtom() : nullAtom()); 2021-07-07 12:42:44 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ntim ntim cdumez changseok darin esprehn+autocc ews-watchlist gyuyoung.kim koivisto mifenton webkit-bug-importer oldest_to_newest 1775262 0 ntim 2021-07-07 07:54:16 -0700 https://webkit-search.igalia.com/webkit/search?q=emptyAtom%28%29+%3A+nullAtom%28%29%29&path=&case=false&regexp=false In these 2 cases, attribute sync doesn't really add value here. SetBooleanAttribute() is easier to read. 1775263 1 webkit-bug-importer 2021-07-07 07:54:28 -0700 <rdar://problem/80269282> 1775264 2 webkit-bug-importer 2021-07-07 07:56:30 -0700 <rdar://problem/80269369> 1775265 3 webkit-bug-importer 2021-07-07 07:56:49 -0700 <rdar://problem/80269378> 1775270 4 433030 ntim 2021-07-07 08:19:33 -0700 Created attachment 433030 Patch 1775288 5 ews-feeder 2021-07-07 09:14:24 -0700 Committed r279643 (239456@main): <https://commits.webkit.org/239456@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433030. 1775398 6 433030 darin 2021-07-07 12:42:44 -0700 Comment on attachment 433030 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433030&action=review > Source/WebCore/ChangeLog:8 > + It's easier to read and attribute sync doesn't make a difference here (it only does for style & SVG attributes). This comment shows a slight misunderstanding of "without synchronization". The function does not exist so that we can bypass synchronization. It’s an optimized case that saves work when we know the attribute we are setting is not something that can have SVG animation applied to it, nor is the attribute "style". By calling the plain old setAttribute, we are just forgoing a micro-optimization. So a more accurate comment would be more like, "we can do without the slight optimization that we get by calling setAttributeWithoutSynchronization". 433030 2021-07-07 08:19:33 -0700 2021-07-07 09:14:25 -0700 Patch bug-227745-20210707171932.patch text/plain 4213 ntim U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5NTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTQ2MTg4ZTM1ODQ2ZTlm ODFmZWRhMzA1MjZlMGM0YjZhZTRlODUxYy4uZDkxZTY5Yjg0ZjAwMjc5ZDc1NmQwZDY0NmY3NzA5 N2ZlZWUzOTAzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIxLTA3LTA3ICBUaW0g Tmd1eWVuICA8bnRpbUBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIHNldEJvb2xlYW5BdHRyaWJ1 dGUgaW5zdGVhZCBvZiBzZXRBdHRyaWJ1dGVXaXRob3V0U3luY2hyb25pemF0aW9uKFgsIFkgPyBl bXB0eUF0b20oKSA6IG51bGxBdG9tKCkpOworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjI3NzQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgSXQncyBlYXNpZXIgdG8gcmVhZCBhbmQgYXR0cmlidXRlIHN5bmMg ZG9lc24ndCBtYWtlIGEgZGlmZmVyZW5jZSBoZXJlIChpdCBvbmx5IGRvZXMgZm9yIHN0eWxlICYg U1ZHIGF0dHJpYnV0ZXMpLgorICAgICAgICBBbHNvIGNsZWFuIHVwIEhUTUxEaWFsb2dFbGVtZW50 IHRvIHJlbW92ZSBpbnRlcm1lZGlhcnkgYHNldE9wZW5gIG1ldGhvZC4KKworICAgICAgICAqIGh0 bWwvSFRNTERpYWxvZ0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTERpYWxvZ0Vs ZW1lbnQ6OnNob3cpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTERpYWxvZ0VsZW1lbnQ6OnNob3dN b2RhbCk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MRGlhbG9nRWxlbWVudDo6Y2xvc2UpOgorICAg ICAgICAoV2ViQ29yZTo6SFRNTERpYWxvZ0VsZW1lbnQ6OnBhcnNlQXR0cmlidXRlKToKKyAgICAg ICAgKFdlYkNvcmU6OkhUTUxEaWFsb2dFbGVtZW50OjpzZXRPcGVuKTogRGVsZXRlZC4KKyAgICAg ICAgKiBodG1sL0hUTUxEaWFsb2dFbGVtZW50Lmg6CisgICAgICAgICogaHRtbC9IVE1MU2VsZWN0 RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MU2VsZWN0RWxlbWVudDo6c2V0TXVs dGlwbGUpOgorCiAyMDIxLTA3LTA1ICBBbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAog ICAgICAgICBbTEZDXVtJRkNdIEFkZCBzdXBwb3J0IGZvciBjb25kaXRpb25hbGx5IGhhbmdpbmcg Z2x5cGgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTERpYWxvZ0VsZW1lbnQu Y3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRGlhbG9nRWxlbWVudC5jcHAKaW5kZXggNDQ3 MmJlNDZkNDExMjQ1YTdhMGYyZmUwNTJiYzAwZWU2ZTIzMjdiOS4uNWVmMTJhYzEyMDhlODc4MDA0 MzdlMGQ1NmJiMmUyYzM3NzNmZDdkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MRGlhbG9nRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRGlhbG9n RWxlbWVudC5jcHAKQEAgLTc0LDcgKzc0LDcgQEAgdm9pZCBIVE1MRGlhbG9nRWxlbWVudDo6c2hv dygpCiAgICAgaWYgKGlzT3BlbigpKQogICAgICAgICByZXR1cm47CiAgICAgCi0gICAgc2V0T3Bl bih0cnVlKTsKKyAgICBzZXRCb29sZWFuQXR0cmlidXRlKG9wZW5BdHRyLCB0cnVlKTsKIH0KIAog RXhjZXB0aW9uT3I8dm9pZD4gSFRNTERpYWxvZ0VsZW1lbnQ6OnNob3dNb2RhbCgpCkBAIC04Nyw3 ICs4Nyw3IEBAIEV4Y2VwdGlvbk9yPHZvaWQ+IEhUTUxEaWFsb2dFbGVtZW50OjpzaG93TW9kYWwo KQogICAgIGlmICghaXNDb25uZWN0ZWQoKSkKICAgICAgICAgcmV0dXJuIEV4Y2VwdGlvbiB7IElu dmFsaWRTdGF0ZUVycm9yIH07CiAKLSAgICBzZXRPcGVuKHRydWUpOworICAgIHNldEJvb2xlYW5B dHRyaWJ1dGUob3BlbkF0dHIsIHRydWUpOwogICAgIG1faXNNb2RhbCA9IHRydWU7CiAKICAgICBy ZXR1cm4geyB9OwpAQCAtOTgsNyArOTgsNyBAQCB2b2lkIEhUTUxEaWFsb2dFbGVtZW50OjpjbG9z ZShjb25zdCBTdHJpbmcmIHJldHVyblZhbHVlKQogICAgIGlmICghaXNPcGVuKCkpCiAgICAgICAg IHJldHVybjsKICAgICAKLSAgICBzZXRPcGVuKGZhbHNlKTsKKyAgICBzZXRCb29sZWFuQXR0cmli dXRlKG9wZW5BdHRyLCBmYWxzZSk7CiAgICAgaWYgKCFyZXR1cm5WYWx1ZS5pc051bGwoKSkKICAg ICAgICAgbV9yZXR1cm5WYWx1ZSA9IHJldHVyblZhbHVlOwogfQpAQCAtMTExLDcgKzExMSw3IEBA IHZvaWQgSFRNTERpYWxvZ0VsZW1lbnQ6OmRpc3BhdGNoUGVuZGluZ0V2ZW50KERpYWxvZ0V2ZW50 U2VuZGVyKiBldmVudFNlbmRlcikKIAogdm9pZCBIVE1MRGlhbG9nRWxlbWVudDo6cGFyc2VBdHRy aWJ1dGUoY29uc3QgUXVhbGlmaWVkTmFtZSYgbmFtZSwgY29uc3QgQXRvbVN0cmluZyYgdmFsdWUp CiB7Ci0gICAgaWYgKG5hbWUgPT0gSFRNTE5hbWVzOjpvcGVuQXR0cikgeworICAgIGlmIChuYW1l ID09IG9wZW5BdHRyKSB7CiAgICAgICAgIGJvb2wgb2xkVmFsdWUgPSBtX2lzT3BlbjsKICAgICAg ICAgbV9pc09wZW4gPSAhdmFsdWUuaXNOdWxsKCk7CiAKQEAgLTEyNywxMSArMTI3LDYgQEAgdm9p ZCBIVE1MRGlhbG9nRWxlbWVudDo6cGFyc2VBdHRyaWJ1dGUoY29uc3QgUXVhbGlmaWVkTmFtZSYg bmFtZSwgY29uc3QgQXRvbVN0cmkKICAgICBIVE1MRWxlbWVudDo6cGFyc2VBdHRyaWJ1dGUobmFt ZSwgdmFsdWUpOwogfQogCi12b2lkIEhUTUxEaWFsb2dFbGVtZW50OjpzZXRPcGVuKGJvb2wgdmFs dWUpCi17Ci0gICAgc2V0QXR0cmlidXRlV2l0aG91dFN5bmNocm9uaXphdGlvbihIVE1MTmFtZXM6 Om9wZW5BdHRyLCB2YWx1ZSA/IGVtcHR5QXRvbSgpIDogbnVsbEF0b20oKSk7Ci19Ci0KIGJvb2wg SFRNTERpYWxvZ0VsZW1lbnQ6OmlzTW9kYWwoKSBjb25zdAogewogICAgIHJldHVybiBtX2lzTW9k YWw7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxEaWFsb2dFbGVtZW50Lmgg Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxEaWFsb2dFbGVtZW50LmgKaW5kZXggYWQzYTRkMTA3 ZWEzYjM1MDE5MjI5MzZhNGNjY2E3MjU5NDM1ZmE5Zi4uNjJiMzUyZDA1NjliODJhZWJiN2ZlYjQ1 NDMwZWJiNTdhYzgwY2M1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRGlh bG9nRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTERpYWxvZ0VsZW1lbnQu aApAQCAtNTYsOCArNTYsNiBAQCBwcml2YXRlOgogCiAgICAgdm9pZCBwYXJzZUF0dHJpYnV0ZShj b25zdCBRdWFsaWZpZWROYW1lJiwgY29uc3QgQXRvbVN0cmluZyYpIGZpbmFsOwogCi0gICAgdm9p ZCBzZXRPcGVuKGJvb2wpOwotCiAgICAgU3RyaW5nIG1fcmV0dXJuVmFsdWU7CiAgICAgYm9vbCBt X2lzTW9kYWwgeyBmYWxzZSB9OwogICAgIGJvb2wgbV9pc09wZW4geyBmYWxzZSB9OwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmNwcAppbmRleCBiYzE2ZmQ1YTMzMGMxNTk1 ODRlZGZjOGY1ZGY2MzVjYjZhMjJhMTExLi5lMmY4YTRiZjVkOGI4NTFiYjljMTQyMzFiODEyOGVj MjQ4ODZiN2MwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVt ZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmNwcApA QCAtNDAwLDcgKzQwMCw3IEBAIHZvaWQgSFRNTFNlbGVjdEVsZW1lbnQ6OnNldE11bHRpcGxlKGJv b2wgbXVsdGlwbGUpCiB7CiAgICAgYm9vbCBvbGRNdWx0aXBsZSA9IHRoaXMtPm11bHRpcGxlKCk7 CiAgICAgaW50IG9sZFNlbGVjdGVkSW5kZXggPSBzZWxlY3RlZEluZGV4KCk7Ci0gICAgc2V0QXR0 cmlidXRlV2l0aG91dFN5bmNocm9uaXphdGlvbihtdWx0aXBsZUF0dHIsIG11bHRpcGxlID8gZW1w dHlBdG9tKCkgOiBudWxsQXRvbSgpKTsKKyAgICBzZXRCb29sZWFuQXR0cmlidXRlKG11bHRpcGxl QXR0ciwgbXVsdGlwbGUpOwogCiAgICAgLy8gUmVzdG9yZSBzZWxlY3RlZEluZGV4IGFmdGVyIGNo YW5naW5nIHRoZSBtdWx0aXBsZSBmbGFnIHRvIHByZXNlcnZlCiAgICAgLy8gc2VsZWN0aW9uIGFz IHNpbmdsZS1saW5lIGFuZCBtdWx0aS1saW5lIGhhcyBkaWZmZXJlbnQgZGVmYXVsdHMuCg==