<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>227725</bug_id>
          
          <creation_ts>2021-07-06 15:09:33 -0700</creation_ts>
          <short_desc>SubtleCrypto should only be exposed to secure contexts</short_desc>
          <delta_ts>2021-08-17 10:54:26 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>227737</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">cdumez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>achristensen</cc>
    
    <cc>bfulgham</cc>
    
    <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>ggaren</cc>
    
    <cc>jiewen_tan</cc>
    
    <cc>katherine_cheney</cc>
    
    <cc>kondapallykalyan</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1775111</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2021-07-06 15:09:33 -0700</bug_when>
    <thetext>SubtleCrypto should only be exposed to secure contexts:
- https://www.w3.org/TR/WebCryptoAPI/#dfn-Crypto

Gecko and Blink match the specification.

This is causing WebKit to fail the WebCryptoAPI/historical.any.html WPT test.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1775129</commentid>
    <comment_count>1</comment_count>
      <attachid>432984</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2021-07-06 15:39:26 -0700</bug_when>
    <thetext>Created attachment 432984
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1775143</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-07-06 16:55:01 -0700</bug_when>
    <thetext>Committed r279628 (239446@main): &lt;https://commits.webkit.org/239446@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432984.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1775145</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-07-06 16:56:18 -0700</bug_when>
    <thetext>&lt;rdar://problem/80238331&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1775170</commentid>
    <comment_count>4</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2021-07-06 19:39:59 -0700</bug_when>
    <thetext>This is a case of making things strictly worse because of someone else’s agenda.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1775216</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2021-07-06 23:03:59 -0700</bug_when>
    <thetext>Re-opened since this is blocked by bug 227737</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1775279</commentid>
    <comment_count>6</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2021-07-07 08:37:36 -0700</bug_when>
    <thetext>Committed r279642 (239455@main): &lt;https://commits.webkit.org/239455@main&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1784873</commentid>
    <comment_count>7</comment_count>
    <who name="Sam Sneddon [:gsnedders]">gsnedders</who>
    <bug_when>2021-08-17 10:54:26 -0700</bug_when>
    <thetext>*** Bug 166959 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>432984</attachid>
            <date>2021-07-06 15:39:26 -0700</date>
            <delta_ts>2021-07-06 16:55:02 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-227725-20210706153925.patch</filename>
            <type>text/plain</type>
            <size>5155</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5NjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDFhYmFlY2I5ZWRlZDI3
NGE5Y2E0MTY4NDhmZDk3YTM0MTJiYzI0MC4uMDUxOTcyOGRlZjhmM2Q2OGRhOWViYTY0NTMzMGUz
MGIzYTQ2M2U4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIxLTA3LTA2ICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU3VidGxlQ3J5cHRvIHNob3Vs
ZCBvbmx5IGJlIGV4cG9zZWQgdG8gc2VjdXJlIGNvbnRleHRzCisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjc3MjUKKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTdWJ0bGVDcnlwdG8gc2hvdWxkIG9ubHkgYmUg
ZXhwb3NlZCB0byBzZWN1cmUgY29udGV4dHM6CisgICAgICAgIC0gaHR0cHM6Ly93d3cudzMub3Jn
L1RSL1dlYkNyeXB0b0FQSS8jZGZuLUNyeXB0bworCisgICAgICAgIEdlY2tvIGFuZCBCbGluayBt
YXRjaCB0aGUgc3BlY2lmaWNhdGlvbi4KKworICAgICAgICBUaGlzIHdhcyBjYXVzaW5nIFdlYktp
dCB0byBmYWlsIHRoZSBXZWJDcnlwdG9BUEkvaGlzdG9yaWNhbC5hbnkuaHRtbCBXUFQgdGVzdC4K
KworICAgICAgICBUZXN0OiBodHRwL3dwdC9jcnlwdG8vaGlzdG9yaWNhbC5odG1sCisKKyAgICAg
ICAgKiBjcnlwdG8vQ3J5cHRvS2V5LmlkbDoKKyAgICAgICAgKiBjcnlwdG8vU3VidGxlQ3J5cHRv
LmlkbDoKKyAgICAgICAgKiBwYWdlL0NyeXB0by5pZGw6CisKIDIwMjEtMDctMDYgIFRydWl0dCBT
YXZlbGwgIDx0c2F2ZWxsQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByZXZlcnRp
bmcgcjI3OTU0Mi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2NyeXB0by9DcnlwdG9LZXku
aWRsIGIvU291cmNlL1dlYkNvcmUvY3J5cHRvL0NyeXB0b0tleS5pZGwKaW5kZXggZTQ0Njc1Mjhk
MGU4ZGY1NjIxN2E4NWU3YmQ3MjAzOTczNDlkNDk3NS4uMzFhZDExZjcyMTMyNjdkMmNiZTdjNWM0
ZTE3MzIxYWIxODU3Yjc3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3J5cHRvL0NyeXB0
b0tleS5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvY3J5cHRvL0NyeXB0b0tleS5pZGwKQEAgLTM1
LDYgKzM1LDcgQEAgdHlwZWRlZiAoQ3J5cHRvS2V5QWxnb3JpdGhtIG9yIENyeXB0b0Flc0tleUFs
Z29yaXRobSBvciBDcnlwdG9FY0tleUFsZ29yaXRobSBvcgogICAgIENvbmRpdGlvbmFsPVdFQl9D
UllQVE8sCiAgICAgRXhwb3NlZD0oV2luZG93LFdvcmtlciksCiAgICAgR2VuZXJhdGVJc1JlYWNo
YWJsZT1JbXBsLAorICAgIFNlY3VyZUNvbnRleHQsCiAgICAgU2tpcFZUYWJsZVZhbGlkYXRpb24K
IF0gaW50ZXJmYWNlIENyeXB0b0tleSB7CiAgICAgcmVhZG9ubHkgYXR0cmlidXRlIEtleVR5cGUg
dHlwZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2NyeXB0by9TdWJ0bGVDcnlwdG8uaWRs
IGIvU291cmNlL1dlYkNvcmUvY3J5cHRvL1N1YnRsZUNyeXB0by5pZGwKaW5kZXggOWE1Y2Q1YThm
MjhmMGY2ZGVjZTU5MTc0ZGU3NTZkYTAxMzI3ZGE0OC4uNDIxZTA3ODc2MGI4NTU5MTMyYWZjZmU5
OGI3NTc0OTUzYzNkNzBkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3J5cHRvL1N1YnRs
ZUNyeXB0by5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvY3J5cHRvL1N1YnRsZUNyeXB0by5pZGwK
QEAgLTMxLDYgKzMxLDcgQEAgdHlwZWRlZiAob2JqZWN0IG9yIERPTVN0cmluZykgQWxnb3JpdGht
SWRlbnRpZmllcjsKICAgICBDb25kaXRpb25hbD1XRUJfQ1JZUFRPLAogICAgIEV4cG9zZWQ9KFdp
bmRvdyxXb3JrZXIpLAogICAgIEdlbmVyYXRlSXNSZWFjaGFibGU9SW1wbFNjcmlwdEV4ZWN1dGlv
bkNvbnRleHQsCisgICAgU2VjdXJlQ29udGV4dCwKIF0gaW50ZXJmYWNlIFN1YnRsZUNyeXB0byB7
CiAgICAgW0NhbGxXaXRoPUdsb2JhbE9iamVjdF0gUHJvbWlzZTxhbnk+IGVuY3J5cHQoQWxnb3Jp
dGhtSWRlbnRpZmllciBhbGdvcml0aG0sIENyeXB0b0tleSBrZXksIEJ1ZmZlclNvdXJjZSBkYXRh
KTsKICAgICBbQ2FsbFdpdGg9R2xvYmFsT2JqZWN0XSBQcm9taXNlPGFueT4gZGVjcnlwdChBbGdv
cml0aG1JZGVudGlmaWVyIGFsZ29yaXRobSwgQ3J5cHRvS2V5IGtleSwgQnVmZmVyU291cmNlIGRh
dGEpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9DcnlwdG8uaWRsIGIvU291cmNl
L1dlYkNvcmUvcGFnZS9DcnlwdG8uaWRsCmluZGV4IDg3OTI4MWYyYzlkOTJiMmE4YzA4ZTFkNjU2
ZmVjMDZiZDhhMmI3ZTAuLmFkZWM2MWYwMDM0YzNjYjFhMGFlOWVhZmZkYmNjMGRiY2NmMWRlOTMg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvQ3J5cHRvLmlkbAorKysgYi9Tb3VyY2Uv
V2ViQ29yZS9wYWdlL0NyeXB0by5pZGwKQEAgLTMxLDYgKzMxLDYgQEAKICAgICBFeHBvc2VkPShX
aW5kb3csV29ya2VyKSwKICAgICBHZW5lcmF0ZUlzUmVhY2hhYmxlPUltcGxTY3JpcHRFeGVjdXRp
b25Db250ZXh0CiBdIGludGVyZmFjZSBDcnlwdG8gewotICAgIFtDb25kaXRpb25hbD1XRUJfQ1JZ
UFRPXSByZWFkb25seSBhdHRyaWJ1dGUgU3VidGxlQ3J5cHRvIHN1YnRsZTsKKyAgICBbQ29uZGl0
aW9uYWw9V0VCX0NSWVBUTywgU2VjdXJlQ29udGV4dF0gcmVhZG9ubHkgYXR0cmlidXRlIFN1YnRs
ZUNyeXB0byBzdWJ0bGU7CiAgICAgQXJyYXlCdWZmZXJWaWV3IGdldFJhbmRvbVZhbHVlcyhbUmV0
dXJuVmFsdWVdIEFycmF5QnVmZmVyVmlldyBhcnJheSk7CiB9OwpkaWZmIC0tZ2l0IGEvTGF5b3V0
VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDgyMzYwZjZkODQz
Mzg1N2QyMTQwYmU3ZTM0N2VkOWU5NDNjOWU2ZWEuLjk3ZTNjOTJlNDcyODEyNWJmN2E4MjhlZGQ4
MmNkODUwYmFiNjdmNzUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9M
YXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAyMS0wNy0wNiAgQ2hyaXMg
RHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCisgICAgICAgIFN1YnRsZUNyeXB0byBzaG91bGQg
b25seSBiZSBleHBvc2VkIHRvIHNlY3VyZSBjb250ZXh0cworICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI3NzI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGxheW91dCB0ZXN0IGNvdmVyYWdlLgorCisg
ICAgICAgICogaHR0cC93cHQvY3J5cHRvL2hpc3RvcmljYWwtZXhwZWN0ZWQudHh0OiBBZGRlZC4K
KyAgICAgICAgKiBodHRwL3dwdC9jcnlwdG8vaGlzdG9yaWNhbC5odG1sOiBBZGRlZC4KKwogMjAy
MS0wNy0wNiAgVHJ1aXR0IFNhdmVsbCAgPHRzYXZlbGxAYXBwbGUuY29tPgogCiAgICAgICAgIFVu
cmV2aWV3ZWQsIHJldmVydGluZyByMjc5NTQyLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0
cC93cHQvY3J5cHRvL2hpc3RvcmljYWwtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaHR0cC93
cHQvY3J5cHRvL2hpc3RvcmljYWwtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu
ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmEwZWMxNjMyYzBh
MjE3NGI0Mzg5NDdmOTNhNjUzYWYyNTFiZjdkYmUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU
ZXN0cy9odHRwL3dwdC9jcnlwdG8vaGlzdG9yaWNhbC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw1
IEBACisKK1BBU1MgTm9uLXNlY3VyZSBjb250ZXh0IHdpbmRvdyBkb2VzIG5vdCBoYXZlIGFjY2Vz
cyB0byBjcnlwdG8uc3VidGxlCitQQVNTIE5vbi1zZWN1cmUgY29udGV4dCB3aW5kb3cgZG9lcyBu
b3QgaGF2ZSBhY2Nlc3MgdG8gU3VidGxlQ3J5cHRvCitQQVNTIE5vbi1zZWN1cmUgY29udGV4dCB3
aW5kb3cgZG9lcyBub3QgaGF2ZSBhY2Nlc3MgdG8gQ3J5cHRvS2V5CisKZGlmZiAtLWdpdCBhL0xh
eW91dFRlc3RzL2h0dHAvd3B0L2NyeXB0by9oaXN0b3JpY2FsLmh0bWwgYi9MYXlvdXRUZXN0cy9o
dHRwL3dwdC9jcnlwdG8vaGlzdG9yaWNhbC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4
IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjdiMDE1ZWQ1NjQ1MjMw
YzA0MDM0MDM5MjVjZmY3ZDY2NDYzOWI0NjQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0
cy9odHRwL3dwdC9jcnlwdG8vaGlzdG9yaWNhbC5odG1sCkBAIC0wLDAgKzEsMjYgQEAKKzwhRE9D
VFlQRSBodG1sPgorPGh0bWw+Cis8Ym9keT4KKzxzY3JpcHQgc3JjPSIvcmVzb3VyY2VzL3Rlc3Ro
YXJuZXNzLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIvcmVzb3VyY2VzL3Rlc3RoYXJuZXNz
cmVwb3J0LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+CisvLyBsb2NhbGhvc3QgaXMgc2VjdXJlIGJ5
IGRlZmF1bHQuCitpbnRlcm5hbHMubWFya0NvbnRleHRBc0luc2VjdXJlKCk7CisKK3Rlc3QoKCkg
PT4geworICBhc3NlcnRfZXF1YWxzKHNlbGYuY3J5cHRvLnN1YnRsZSwgdW5kZWZpbmVkKTsKKyAg
YXNzZXJ0X2ZhbHNlKCJzdWJ0bGUiIGluIHNlbGYuY3J5cHRvKTsKK30sICJOb24tc2VjdXJlIGNv
bnRleHQgd2luZG93IGRvZXMgbm90IGhhdmUgYWNjZXNzIHRvIGNyeXB0by5zdWJ0bGUiKTsKKwor
dGVzdCgoKSA9PiB7CisgIGFzc2VydF9lcXVhbHMoc2VsZi5TdWJ0bGVDcnlwdG8sIHVuZGVmaW5l
ZCk7CisgIGFzc2VydF9mYWxzZSgiU3VidGxlQ3J5cHRvIiBpbiBzZWxmKTsKK30sICJOb24tc2Vj
dXJlIGNvbnRleHQgd2luZG93IGRvZXMgbm90IGhhdmUgYWNjZXNzIHRvIFN1YnRsZUNyeXB0byIp
CisKK3Rlc3QoKCkgPT4geworICBhc3NlcnRfZXF1YWxzKHNlbGYuQ3J5cHRvS2V5LCB1bmRlZmlu
ZWQpOworICBhc3NlcnRfZmFsc2UoIkNyeXB0b0tleSIgaW4gc2VsZik7Cit9LCAiTm9uLXNlY3Vy
ZSBjb250ZXh0IHdpbmRvdyBkb2VzIG5vdCBoYXZlIGFjY2VzcyB0byBDcnlwdG9LZXkiKQorPC9z
Y3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>