227722 2021-07-06 14:30:47 -0700 Fix type error in testb3 2021-07-06 15:50:21 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 yijia_huang yijia_huang ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer yijia_huang oldest_to_newest 1775088 0 yijia_huang 2021-07-06 14:30:47 -0700 ... 1775101 1 432976 yijia_huang 2021-07-06 14:50:29 -0700 Created attachment 432976 Patch 1775102 2 432976 mark.lam 2021-07-06 14:54:48 -0700 Comment on attachment 432976 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432976&action=review > Source/JavaScriptCore/b3/testb3_3.cpp:93 > Value* lsbValue = root->appendNew<Const32Value>(proc, Origin(), lsb); > - Value* amountValue = root->appendNew<Const64Value>(proc, Origin(), amount); > + Value* amountValue = root->appendNew<Const32Value>(proc, Origin(), amount); Why pass lab and amount in as int64_t then? Ditto for lsbs and widths vectors, why Vector<int64_t>? 1775103 3 mark.lam 2021-07-06 14:55:50 -0700 (In reply to Mark Lam from comment #2) > Comment on attachment 432976 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=432976&action=review > > > Source/JavaScriptCore/b3/testb3_3.cpp:93 > > Value* lsbValue = root->appendNew<Const32Value>(proc, Origin(), lsb); > > - Value* amountValue = root->appendNew<Const64Value>(proc, Origin(), amount); > > + Value* amountValue = root->appendNew<Const32Value>(proc, Origin(), amount); > > Why pass lab and amount in as int64_t then? Ditto for lsbs and widths > vectors, why Vector<int64_t>? Can you fix these as well? 1775110 4 432980 yijia_huang 2021-07-06 15:06:28 -0700 Created attachment 432980 Patch 1775130 5 ews-feeder 2021-07-06 15:49:40 -0700 Committed r279627 (239445@main): <https://commits.webkit.org/239445@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432980. 1775131 6 webkit-bug-importer 2021-07-06 15:50:21 -0700 <rdar://problem/80235431> 432976 2021-07-06 14:50:29 -0700 2021-07-06 15:06:25 -0700 Patch bug-227722-20210706165028.patch text/plain 2235 yijia_huang U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5NjAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz ZDU4OTE1NmU0YTMxYTg1MzgxYjUxYTE1OGFjNGU4ZWRmODdhNWRlLi45ZmQ3ODBiMzIxMTBjNTVk NjYwYTQxNzYzNzUxM2UzNzhhNjI3MGFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMS0wNy0wNiAgWWlqaWEgSHVhbmcgIDx5aWppYV9odWFuZ0BhcHBsZS5j b20+CisKKyAgICAgICAgRml4IHR5cGUgZXJyb3IgaW4gdGVzdGIzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjc3MjIKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggdHlwZSBlcnJvciBpbiB0ZXN0YjMu IFNoaWZ0IGFtb3VudCBzaG91bGQgYmUgMzItYml0IGNvbnN0YW50LgorCisgICAgICAgICogYjMv dGVzdGIzXzMuY3BwOgorICAgICAgICAodGVzdEluc2VydFNpZ25lZEJpdGZpZWxkSW5aZXJvNjQp OgorICAgICAgICAodGVzdEV4dHJhY3RTaWduZWRCaXRmaWVsZDY0KToKKwogMjAyMS0wNy0wNiAg WWlqaWEgSHVhbmcgIDx5aWppYV9odWFuZ0BhcHBsZS5jb20+CiAKICAgICAgICAgRml4IGluc3Ry dWN0aW9uIGNoZWNrIGZhaWx1cmUgb2YgVUJGWCBhbmQgU0JGSVogaW4gdGVzdGIzIGR1ZSB0byB0 aGUgc3BlY3VsYXRpdmUgZml4IGluIGJ1ZyAyMjc1NTQKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9iMy90ZXN0YjNfMy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvdGVz dGIzXzMuY3BwCmluZGV4IDA2NDFiODRjZmU2NTI3MDIwYmMwNmJlNTVjYzlkZWNkZWRkZDMxNjEu LjZlZjgxM2EwMjEyMTZkOWI4ZGFmNWJjN2NhOGQxYzZhMzI4MjhiZjggMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9iMy90ZXN0YjNfMy5jcHAKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2IzL3Rlc3RiM18zLmNwcApAQCAtOTAsNyArOTAsNyBAQCB2b2lkIHRlc3RJbnNlcnRT aWduZWRCaXRmaWVsZEluWmVybzY0KCkKIAogICAgICAgICBWYWx1ZSogc3JjVmFsdWUgPSByb290 LT5hcHBlbmROZXc8QXJndW1lbnRSZWdWYWx1ZT4ocHJvYywgT3JpZ2luKCksIEdQUkluZm86OmFy Z3VtZW50R1BSMCk7CiAgICAgICAgIFZhbHVlKiBsc2JWYWx1ZSA9IHJvb3QtPmFwcGVuZE5ldzxD b25zdDMyVmFsdWU+KHByb2MsIE9yaWdpbigpLCBsc2IpOwotICAgICAgICBWYWx1ZSogYW1vdW50 VmFsdWUgPSByb290LT5hcHBlbmROZXc8Q29uc3Q2NFZhbHVlPihwcm9jLCBPcmlnaW4oKSwgYW1v dW50KTsKKyAgICAgICAgVmFsdWUqIGFtb3VudFZhbHVlID0gcm9vdC0+YXBwZW5kTmV3PENvbnN0 MzJWYWx1ZT4ocHJvYywgT3JpZ2luKCksIGFtb3VudCk7CiAKICAgICAgICAgVmFsdWUqIHNpZ25l ZFJpZ2h0U2hpZnRWYWx1ZSA9IHJvb3QtPmFwcGVuZE5ldzxWYWx1ZT4oCiAgICAgICAgICAgICBw cm9jLCBTU2hyLCBPcmlnaW4oKSwgCkBAIC0xNzgsNyArMTc4LDcgQEAgdm9pZCB0ZXN0RXh0cmFj dFNpZ25lZEJpdGZpZWxkNjQoKQogCiAgICAgICAgIFZhbHVlKiBzcmNWYWx1ZSA9IHJvb3QtPmFw cGVuZE5ldzxBcmd1bWVudFJlZ1ZhbHVlPihwcm9jLCBPcmlnaW4oKSwgR1BSSW5mbzo6YXJndW1l bnRHUFIwKTsKICAgICAgICAgVmFsdWUqIGxzYlZhbHVlID0gcm9vdC0+YXBwZW5kTmV3PENvbnN0 MzJWYWx1ZT4ocHJvYywgT3JpZ2luKCksIGxzYik7Ci0gICAgICAgIFZhbHVlKiBhbW91bnRWYWx1 ZSA9IHJvb3QtPmFwcGVuZE5ldzxDb25zdDY0VmFsdWU+KHByb2MsIE9yaWdpbigpLCBhbW91bnQp OworICAgICAgICBWYWx1ZSogYW1vdW50VmFsdWUgPSByb290LT5hcHBlbmROZXc8Q29uc3QzMlZh bHVlPihwcm9jLCBPcmlnaW4oKSwgYW1vdW50KTsKIAogICAgICAgICBWYWx1ZSogcmlnaHRTaGlm dFZhbHVlID0gcm9vdC0+YXBwZW5kTmV3PFZhbHVlPihwcm9jLCBaU2hyLCBPcmlnaW4oKSwgc3Jj VmFsdWUsIGxzYlZhbHVlKTsKICAgICAgICAgVmFsdWUqIGxlZnRTaGlmdFZhbHVlID0gcm9vdC0+ YXBwZW5kTmV3PFZhbHVlPihwcm9jLCBTaGwsIE9yaWdpbigpLCByaWdodFNoaWZ0VmFsdWUsIGFt b3VudFZhbHVlKTsK 432980 2021-07-06 15:06:28 -0700 2021-07-06 15:49:44 -0700 Patch bug-227722-20210706170627.patch text/plain 4248 yijia_huang U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5NjAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz ZDU4OTE1NmU0YTMxYTg1MzgxYjUxYTE1OGFjNGU4ZWRmODdhNWRlLi45ZmQ3ODBiMzIxMTBjNTVk NjYwYTQxNzYzNzUxM2UzNzhhNjI3MGFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMS0wNy0wNiAgWWlqaWEgSHVhbmcgIDx5aWppYV9odWFuZ0BhcHBsZS5j b20+CisKKyAgICAgICAgRml4IHR5cGUgZXJyb3IgaW4gdGVzdGIzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjc3MjIKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggdHlwZSBlcnJvciBpbiB0ZXN0YjMu IFNoaWZ0IGFtb3VudCBzaG91bGQgYmUgMzItYml0IGNvbnN0YW50LgorCisgICAgICAgICogYjMv dGVzdGIzXzMuY3BwOgorICAgICAgICAodGVzdEluc2VydFNpZ25lZEJpdGZpZWxkSW5aZXJvNjQp OgorICAgICAgICAodGVzdEV4dHJhY3RTaWduZWRCaXRmaWVsZDY0KToKKwogMjAyMS0wNy0wNiAg WWlqaWEgSHVhbmcgIDx5aWppYV9odWFuZ0BhcHBsZS5jb20+CiAKICAgICAgICAgRml4IGluc3Ry dWN0aW9uIGNoZWNrIGZhaWx1cmUgb2YgVUJGWCBhbmQgU0JGSVogaW4gdGVzdGIzIGR1ZSB0byB0 aGUgc3BlY3VsYXRpdmUgZml4IGluIGJ1ZyAyMjc1NTQKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9iMy90ZXN0YjNfMy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvdGVz dGIzXzMuY3BwCmluZGV4IDA2NDFiODRjZmU2NTI3MDIwYmMwNmJlNTVjYzlkZWNkZWRkZDMxNjEu LjcyYjA4ZDE2YWE3MjljZGI4MzQ2ZmQyZmFhZmNhZDllMDAzOWQ2ZWIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9iMy90ZXN0YjNfMy5jcHAKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2IzL3Rlc3RiM18zLmNwcApAQCAtNzksMTggKzc5LDE4IEBAIHZvaWQgdGVzdEluc2Vy dFNpZ25lZEJpdGZpZWxkSW5aZXJvNjQoKQogICAgIGlmIChKU0M6Ok9wdGlvbnM6OmRlZmF1bHRC M09wdExldmVsKCkgPCAyKQogICAgICAgICByZXR1cm47CiAgICAgaW50NjRfdCBzcmMgPSAweGZm ZmZmZmZmZmZmZmZmZmY7Ci0gICAgVmVjdG9yPGludDY0X3Q+IGxzYnMgPSB7IDEsIDMwLCA2MiB9 OwotICAgIFZlY3RvcjxpbnQ2NF90PiB3aWR0aHMgPSB7IDYyLCAzMywgMSB9OworICAgIFZlY3Rv cjxpbnQzMl90PiBsc2JzID0geyAxLCAzMCwgNjIgfTsKKyAgICBWZWN0b3I8aW50MzJfdD4gd2lk dGhzID0geyA2MiwgMzMsIDEgfTsKIAogICAgIC8vIFRlc3QgUGF0dGVybjogKChzcmMgPDwgYW1v dW50KSA+PiBhbW91bnQpIDw8IGxzYgogICAgIC8vIHdoZXJlOiBhbW91bnQgPSBkYXRhc2l6ZSAt IHdpZHRoCi0gICAgYXV0byB0ZXN0ID0gWyZdIChpbnQ2NF90IGxzYiwgaW50NjRfdCBhbW91bnQp IC0+IGludDY0X3QgeworICAgIGF1dG8gdGVzdCA9IFsmXSAoaW50MzJfdCBsc2IsIGludDMyX3Qg YW1vdW50KSAtPiBpbnQ2NF90IHsKICAgICAgICAgUHJvY2VkdXJlIHByb2M7CiAgICAgICAgIEJh c2ljQmxvY2sqIHJvb3QgPSBwcm9jLmFkZEJsb2NrKCk7CiAKICAgICAgICAgVmFsdWUqIHNyY1Zh bHVlID0gcm9vdC0+YXBwZW5kTmV3PEFyZ3VtZW50UmVnVmFsdWU+KHByb2MsIE9yaWdpbigpLCBH UFJJbmZvOjphcmd1bWVudEdQUjApOwogICAgICAgICBWYWx1ZSogbHNiVmFsdWUgPSByb290LT5h cHBlbmROZXc8Q29uc3QzMlZhbHVlPihwcm9jLCBPcmlnaW4oKSwgbHNiKTsKLSAgICAgICAgVmFs dWUqIGFtb3VudFZhbHVlID0gcm9vdC0+YXBwZW5kTmV3PENvbnN0NjRWYWx1ZT4ocHJvYywgT3Jp Z2luKCksIGFtb3VudCk7CisgICAgICAgIFZhbHVlKiBhbW91bnRWYWx1ZSA9IHJvb3QtPmFwcGVu ZE5ldzxDb25zdDMyVmFsdWU+KHByb2MsIE9yaWdpbigpLCBhbW91bnQpOwogCiAgICAgICAgIFZh bHVlKiBzaWduZWRSaWdodFNoaWZ0VmFsdWUgPSByb290LT5hcHBlbmROZXc8VmFsdWU+KAogICAg ICAgICAgICAgcHJvYywgU1NociwgT3JpZ2luKCksIApAQCAtMTA4LDggKzEwOCw4IEBAIHZvaWQg dGVzdEluc2VydFNpZ25lZEJpdGZpZWxkSW5aZXJvNjQoKQogICAgIH07CiAKICAgICBmb3IgKHNp emVfdCBpID0gMDsgaSA8IGxzYnMuc2l6ZSgpOyArK2kpIHsKLSAgICAgICAgaW50NjRfdCBsc2Ig PSBsc2JzLmF0KGkpOwotICAgICAgICBpbnQ2NF90IHdpZHRoID0gd2lkdGhzLmF0KGkpOworICAg ICAgICBpbnQzMl90IGxzYiA9IGxzYnMuYXQoaSk7CisgICAgICAgIGludDMyX3Qgd2lkdGggPSB3 aWR0aHMuYXQoaSk7CiAgICAgICAgIGludDY0X3QgYW1vdW50ID0gQ0hBUl9CSVQgKiBzaXplb2Yo c3JjKSAtIHdpZHRoOwogICAgICAgICBpbnQ2NF90IGJmc3ggPSAoc3JjIDw8IGFtb3VudCkgPj4g YW1vdW50OwogICAgICAgICBDSEVDSyh0ZXN0KGxzYiwgYW1vdW50KSA9PSAoYmZzeCA8PCBsc2Ip KTsKQEAgLTE2NywxOCArMTY3LDE4IEBAIHZvaWQgdGVzdEV4dHJhY3RTaWduZWRCaXRmaWVsZDY0 KCkKICAgICBpZiAoSlNDOjpPcHRpb25zOjpkZWZhdWx0QjNPcHRMZXZlbCgpIDwgMikKICAgICAg ICAgcmV0dXJuOwogICAgIGludDY0X3Qgc3JjID0gMHhmZmZmZmZmZmZmZmZmZmZmOwotICAgIFZl Y3RvcjxpbnQ2NF90PiBsc2JzID0geyAxLCAzMCwgNjIgfTsKLSAgICBWZWN0b3I8aW50NjRfdD4g d2lkdGhzID0geyA2MiwgMzMsIDEgfTsKKyAgICBWZWN0b3I8aW50MzJfdD4gbHNicyA9IHsgMSwg MzAsIDYyIH07CisgICAgVmVjdG9yPGludDMyX3Q+IHdpZHRocyA9IHsgNjIsIDMzLCAxIH07CiAK ICAgICAvLyBUZXN0IFBhdHRlcm46ICgoc3JjID4+IGxzYikgPDwgYW1vdW50KSA+PiBhbW91bnQK ICAgICAvLyB3aGVyZTogYW1vdW50ID0gZGF0YXNpemUgLSB3aWR0aAotICAgIGF1dG8gdGVzdCA9 IFsmXSAoaW50NjRfdCBsc2IsIGludDY0X3QgYW1vdW50KSAtPiBpbnQ2NF90IHsKKyAgICBhdXRv IHRlc3QgPSBbJl0gKGludDMyX3QgbHNiLCBpbnQzMl90IGFtb3VudCkgLT4gaW50NjRfdCB7CiAg ICAgICAgIFByb2NlZHVyZSBwcm9jOwogICAgICAgICBCYXNpY0Jsb2NrKiByb290ID0gcHJvYy5h ZGRCbG9jaygpOwogCiAgICAgICAgIFZhbHVlKiBzcmNWYWx1ZSA9IHJvb3QtPmFwcGVuZE5ldzxB cmd1bWVudFJlZ1ZhbHVlPihwcm9jLCBPcmlnaW4oKSwgR1BSSW5mbzo6YXJndW1lbnRHUFIwKTsK ICAgICAgICAgVmFsdWUqIGxzYlZhbHVlID0gcm9vdC0+YXBwZW5kTmV3PENvbnN0MzJWYWx1ZT4o cHJvYywgT3JpZ2luKCksIGxzYik7Ci0gICAgICAgIFZhbHVlKiBhbW91bnRWYWx1ZSA9IHJvb3Qt PmFwcGVuZE5ldzxDb25zdDY0VmFsdWU+KHByb2MsIE9yaWdpbigpLCBhbW91bnQpOworICAgICAg ICBWYWx1ZSogYW1vdW50VmFsdWUgPSByb290LT5hcHBlbmROZXc8Q29uc3QzMlZhbHVlPihwcm9j LCBPcmlnaW4oKSwgYW1vdW50KTsKIAogICAgICAgICBWYWx1ZSogcmlnaHRTaGlmdFZhbHVlID0g cm9vdC0+YXBwZW5kTmV3PFZhbHVlPihwcm9jLCBaU2hyLCBPcmlnaW4oKSwgc3JjVmFsdWUsIGxz YlZhbHVlKTsKICAgICAgICAgVmFsdWUqIGxlZnRTaGlmdFZhbHVlID0gcm9vdC0+YXBwZW5kTmV3 PFZhbHVlPihwcm9jLCBTaGwsIE9yaWdpbigpLCByaWdodFNoaWZ0VmFsdWUsIGFtb3VudFZhbHVl KTsKQEAgLTE5Miw4ICsxOTIsOCBAQCB2b2lkIHRlc3RFeHRyYWN0U2lnbmVkQml0ZmllbGQ2NCgp CiAgICAgfTsKIAogICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgbHNicy5zaXplKCk7ICsraSkg ewotICAgICAgICBpbnQ2NF90IGxzYiA9IGxzYnMuYXQoaSk7Ci0gICAgICAgIGludDY0X3Qgd2lk dGggPSB3aWR0aHMuYXQoaSk7CisgICAgICAgIGludDMyX3QgbHNiID0gbHNicy5hdChpKTsKKyAg ICAgICAgaW50MzJfdCB3aWR0aCA9IHdpZHRocy5hdChpKTsKICAgICAgICAgaW50NjRfdCBhbW91 bnQgPSBDSEFSX0JJVCAqIHNpemVvZihzcmMpIC0gd2lkdGg7CiAgICAgICAgIGludDY0X3QgcmVz dWx0ID0gKChzcmMgPj4gbHNiKSA8PCBhbW91bnQpID4+IGFtb3VudDsKICAgICAgICAgQ0hFQ0so dGVzdChsc2IsIGFtb3VudCkgPT0gcmVzdWx0KTsK