227704 2021-07-06 07:20:11 -0700 [LegacySVG] clip-path inset is incorrectly applied to the svg element. 2024-08-22 16:29:59 -0700 1 1 1 Unclassified WebKit SVG Safari 14 Unspecified Unspecified RESOLVED FIXED https://github.com/web-platform-tests/wpt/pull/47754 InRadar P2 Normal --- 1 justas543 simon.fraser ahmad.saleem792 rbuis sabouhallawa simon.fraser webkit-bug-importer zalan zimmermann oldest_to_newest 1774936 0 432924 justas543 2021-07-06 07:20:11 -0700 Created attachment 432924 safari incorrect clipping clip-path inset is incorrectly applied to the svg element. Go to https://jsfiddle.net/byo2kenj/5/ Observe that when clip-path is applied to div it is working correctly. Observe that when the same clip-path is applied to exact same size svg it is clipping it incorrectly. Both Firefox and Chrome are working as intended only Safari is breaking. 1776621 1 webkit-bug-importer 2021-07-13 07:21:17 -0700 <rdar://problem/80516912> 1995788 2 ahmad.saleem792 2023-11-29 18:15:51 -0800 It is fixed in Layer based SVG Engine (LBSE). 2050571 3 simon.fraser 2024-08-04 12:03:24 -0700 This is causing a number of WPT tests to fail: imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-reference-box-004.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-borderBox-1c.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-contentBox-1c.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-fillBox-1a.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-paddingBox-1c.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-strokeBox-1a.html [ ImageOnlyFailure ] imported/w3c/web-platform-tests/css/css-masking/clip-path/clip-path-viewBox-1c.html [ ImageOnlyFailure ] The issue is that we get the wrong referenceBox in SVGRenderSupport::clipContextToCSSClippingArea; we get the size of the SVG before scaling, not the size of the renderer. 2050575 4 simon.fraser 2024-08-04 12:27:53 -0700 Actually when CSS applies clip-path on the SVG root element, RenderLayer::setupClipPath() does need to apply the clip-path, because it needs to clip CSS borders etc. So the early return in RenderLayer::setupClipPath() is wrong (and we'll need to avoid clipping twice). 2050688 5 simon.fraser 2024-08-05 10:38:01 -0700 Pull request: https://github.com/WebKit/WebKit/pull/31726 2050918 6 ews-feeder 2024-08-06 09:04:15 -0700 Committed 281893@main (891e5f194137): <https://commits.webkit.org/281893@main> Reviewed commits have been landed. Closing PR #31726 and removing active labels. 2054837 7 simon.fraser 2024-08-22 16:29:59 -0700 Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/47754 432924 2021-07-06 07:20:11 -0700 2021-07-06 07:20:11 -0700 safari incorrect clipping safari-clip-bug.png image/png 921 justas543 iVBORw0KGgoAAAANSUhEUgAAADQAAAA+CAYAAABk4ziNAAAAAXNSR0IArs4c6QAAAARnQU1BAACx jwv8YQUAAAAJcEhZcwAAEnQAABJ0Ad5mH3gAAAMuSURBVGhD7ZtLaBNRFIbPpLVdKIpUXFS76cKA KIpPRNxYEMQHLoSiLlQUQUXEYhEEURQXgsViq6VVKuJOsBVcuVCkbtwo2oWKuvIJKoqC+GiT+J1k SrVo72RIMidhfvh7H72T3m/OvZfMSeplkFSQEn5ZMao4oOySy1zrl0xbO80Crr6mlZI4fpS/4Pkd JZLypDu7MsNebWZYagrmVPMWXjidvV+llL/kinAuRHTWxIeCdcVA1uUEesiBcVnS8o0yyDY/JSlp kiE5QRnFseAEes60epicTvQx9Z9+///0lDED+EkkOAGAvuIHTO4SUToL1E3K97Rd040GJ+AeGsbv cC8wnUBdp3zGlH9kf2tLeR0Ketdv8/MkQD14kLpG0JLyAhrRG0DOE6lWYqdLMEVfVEtsrEIBqXQZ 3gfjCDgttF5R176oFRpII6J76CO1Dz6MhSiFBqrCjeLJJl5iK606vy9qhQKajJcBs53Ld4KxinIK 7dB3p4DKew4zcBOX7QZkF54HSIkf4cZVICCdcA2up6ZL7BjeiHWZWVMgIIVJ4m4icliqZTaXWdgv /5ITqAHvYNgVQFZQTqJtaYmNlRNoAUP2EI+kD+O6YD9j+4E/SBkFuBNoGk4ytQm5plPzGbuWl10Y URwD7aFyUgxkXTGQdeVy2+e6JL3vAG+XC/h+uWGmeEuX+I2/5S1eJF5rS1Hy3sUDGkfehvWS6Lta FKBollwRb1x8KFhXDGRdTiBN6fZJWr6bSIG45QTSXHW3pOQCUC+o//L7rcoJ9AnfBaQdqF58D7DP tK3GK9AeGsIv8WlgzgB1i/ItSNpvTXkdCml8A5BD1C7i1wbjlBfQiBSkg0jpxyvWkEIBaXL+i29r CgWk0sjoErSm0EB6ocXcXCigiXiOeDI3oszOeMobaCrm8Uz2culmbA0pMJAOrMWa025jsW3D08s1 QprbnoVzue2q8s5t1+NmhnVItaym1E8gFNCqnED6+Y/mtpcztI661ciMKECEvOwhYDkqfyrQHion xUDWFQNZVy4V/GhQ5M4AzRI93TQ2irdujd8orEb/96GUX0su4pfTR4EqQiK/AS8Ze9QscWeSAAAA AElFTkSuQmCC