227633 2021-07-02 11:51:17 -0700 [macOS] Only use WebGL on Metal by default on safe versions of macOS 2021-07-04 18:28:25 -0700 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham benjamin cdumez cmarcelo dino ews-watchlist kbr kkinnunen kpiddington thorton webkit-bug-importer oldest_to_newest 1774516 0 bfulgham 2021-07-02 11:51:17 -0700 Some older supported macOS releases have a version of Metal that does not work properly for implementing WebGL features. We should stick to the OpenGL backend on those releases (by default) and only activate Metal WebGL on systems we know pass all tests. Users can still activate WebGL on Metal if they wish, but it will not be the default behavior. <rdar://problem/78527887> 1774519 1 432809 bfulgham 2021-07-02 11:59:00 -0700 Created attachment 432809 Patch 1774533 2 432809 dino 2021-07-02 13:09:20 -0700 Comment on attachment 432809 Patch Won't this disable it on watchOS, tvOS and Catalyst? 1774566 3 bfulgham 2021-07-02 14:13:40 -0700 (In reply to Dean Jackson from comment #2) > Comment on attachment 432809 [details] > Patch > > Won't this disable it on watchOS, tvOS and Catalyst? #if PLATFORM(IOS_FAMILY) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 120000) #define HAVE_WEBGL_COMPATIBLE_METAL 1 #endif This should ENABLE it for watchOS, tvOS, Catalyst, and iPhone, and on any macOS at or above 120000. I THINK!?! 1774569 4 bfulgham 2021-07-02 14:21:47 -0700 I asked Tim to double-check and he said it looked right. 1774615 5 ews-feeder 2021-07-02 16:21:09 -0700 Committed r279524 (239374@main): <https://commits.webkit.org/239374@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432809. 1774744 6 432809 kbr 2021-07-04 18:22:43 -0700 Comment on attachment 432809 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432809&action=review > Source/WTF/wtf/PlatformHave.h:1097 > +#if PLATFORM(IOS_FAMILY) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 120000) Could you explain a bit more how these compile time guards work? I would assume that runtime checks would be needed in order to choose the Metal backend only when running on certain macOS versions. 1774745 7 thorton 2021-07-04 18:28:25 -0700 (In reply to Kenneth Russell from comment #6) > Comment on attachment 432809 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=432809&action=review > > > Source/WTF/wtf/PlatformHave.h:1097 > > +#if PLATFORM(IOS_FAMILY) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 120000) > > Could you explain a bit more how these compile time guards work? I would > assume that runtime checks would be needed in order to choose the Metal > backend only when running on certain macOS versions. No need for a runtime check; we build separate binaries with the appropriate SDK for each OS, so a check like this is fine (and very common). 1774746 8 thorton 2021-07-04 18:28:25 -0700 (In reply to Kenneth Russell from comment #6) > Comment on attachment 432809 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=432809&action=review > > > Source/WTF/wtf/PlatformHave.h:1097 > > +#if PLATFORM(IOS_FAMILY) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 120000) > > Could you explain a bit more how these compile time guards work? I would > assume that runtime checks would be needed in order to choose the Metal > backend only when running on certain macOS versions. No need for a runtime check; we build separate binaries with the appropriate SDK for each OS, so a check like this is fine (and very common). 432809 2021-07-02 11:59:00 -0700 2021-07-02 16:21:10 -0700 Patch bug-227633-20210702115859.patch text/plain 2116 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5NDg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDczZTkxMjVmM2Q4NDM0NmVmMzA5MmVl ZDY1Zjk2N2VhYTIzZTI2NDUuLjExMTg1N2M0Mjg3MTZmMDQzYWM3YmUzYjc5OWQwZjE4MjUwNTZm ODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMDctMDIgIEJyZW50IEZ1bGdoYW0gIDxiZnVs Z2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW21hY09TXSBPbmx5IHVzZSBXZWJHTCBvbiBNZXRh bCBieSBkZWZhdWx0IG9uIHNhZmUgdmVyc2lvbnMgb2YgbWFjT1MKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNzYzMworICAgICAgICA8cmRhcjovL3By b2JsZW0vNzg1Mjc4ODc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGVzdGVkIGJ5IFdlYkdMIHRlc3Qgc3VpdGUuCisKKyAgICAgICAgKiBTY3JpcHRz L1ByZWZlcmVuY2VzL1dlYlByZWZlcmVuY2VzRXhwZXJpbWVudGFsLnlhbWw6CisgICAgICAgICog d3RmL1BsYXRmb3JtSGF2ZS5oOgorCiAyMDIxLTA3LTAxICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5u QGFwcGxlLmNvbT4KIAogICAgICAgICBEaXNhYmxlIHJlbGF5IGZvciBVRFAgc29ja2V0cyB3aGVu IG5vdCBuZWVkZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvU2NyaXB0cy9QcmVmZXJlbmNlcy9X ZWJQcmVmZXJlbmNlc0V4cGVyaW1lbnRhbC55YW1sIGIvU291cmNlL1dURi9TY3JpcHRzL1ByZWZl cmVuY2VzL1dlYlByZWZlcmVuY2VzRXhwZXJpbWVudGFsLnlhbWwKaW5kZXggNTRhNmVlNjAzOWVi ZmM3YTQ2OGQ5MmNiMWZhMDcwNDlhMzQ3N2Q4YS4uOWVjYjdhM2Q2YjM5Y2EyM2RkZDMyNTgzMjZh MWZkYzJmMDE2Y2UzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9TY3JpcHRzL1ByZWZlcmVuY2Vz L1dlYlByZWZlcmVuY2VzRXhwZXJpbWVudGFsLnlhbWwKKysrIGIvU291cmNlL1dURi9TY3JpcHRz L1ByZWZlcmVuY2VzL1dlYlByZWZlcmVuY2VzRXhwZXJpbWVudGFsLnlhbWwKQEAgLTEyMDIsMTEg KzEyMDIsMTQgQEAgV2ViR0xVc2luZ01ldGFsOgogICBjb25kaXRpb246IEVOQUJMRShXRUJHTCkg JiYgUExBVEZPUk0oQ09DT0EpCiAgIGRlZmF1bHRWYWx1ZToKICAgICBXZWJLaXRMZWdhY3k6Ci0g ICAgICBkZWZhdWx0OiB0cnVlCisgICAgICAiSEFWRShXRUJHTF9DT01QQVRJQkxFX01FVEFMKSI6 IHRydWUKKyAgICAgIGRlZmF1bHQ6IGZhbHNlCiAgICAgV2ViS2l0OgotICAgICAgZGVmYXVsdDog dHJ1ZQorICAgICAgIkhBVkUoV0VCR0xfQ09NUEFUSUJMRV9NRVRBTCkiOiB0cnVlCisgICAgICBk ZWZhdWx0OiBmYWxzZQogICAgIFdlYkNvcmU6Ci0gICAgICBkZWZhdWx0OiB0cnVlCisgICAgICAi SEFWRShXRUJHTF9DT01QQVRJQkxFX01FVEFMKSI6IHRydWUKKyAgICAgIGRlZmF1bHQ6IGZhbHNl CiAKIFdlYkdQVUVuYWJsZWQ6CiAgIHR5cGU6IGJvb2wKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYv d3RmL1BsYXRmb3JtSGF2ZS5oIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm1IYXZlLmgKaW5kZXgg NTg3YWFjZTEyMTljMTA5MjBkZWIxMTYyMmVlOTFhYjA5ZjQwZWNmMS4uMTQ1NmI3NzE3ZThmNzVj MjhmODQxZGE2ZDcyOGY5YTdlMjUxOGIyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvUGxh dGZvcm1IYXZlLmgKKysrIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm1IYXZlLmgKQEAgLTEwOTMs MyArMTA5Myw3IEBACiAjaWYgIWRlZmluZWQoSEFWRV9HUk9VUF9BQ1RJVklUSUVTKSAmJiBQTEFU Rk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTIwMDAwCiAj ZGVmaW5lIEhBVkVfR1JPVVBfQUNUSVZJVElFUyAxCiAjZW5kaWYKKworI2lmIFBMQVRGT1JNKElP U19GQU1JTFkpIHx8IChQTEFURk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVR VUlSRUQgPj0gMTIwMDAwKQorI2RlZmluZSBIQVZFX1dFQkdMX0NPTVBBVElCTEVfTUVUQUwgMQor I2VuZGlmCg==