227632 2021-07-02 11:36:26 -0700 Regression(r278786) LocalStorageDatabase's transaction may be remain active when process gets suspended 2021-07-02 13:24:16 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=227552 InRadar P2 Normal --- 226938 1 cdumez cdumez ggaren kkinnunen sihui_liu webkit-bug-importer oldest_to_newest 1774513 0 cdumez 2021-07-02 11:36:26 -0700 LocalStorageDatabase's transaction may be remain active when process gets suspended. LocalStorageDatabase commits its transaction after 500ms. However, when PrepareToSuspend gets called, we suspend/hang the storage thread and the task to commit the transaction cannot get committed. 1774515 1 432808 cdumez 2021-07-02 11:44:37 -0700 Created attachment 432808 Patch 1774534 2 432808 ggaren 2021-07-02 13:10:17 -0700 Comment on attachment 432808 Patch r=me 1774541 3 ews-feeder 2021-07-02 13:23:06 -0700 Committed r279512 (239364@main): <https://commits.webkit.org/239364@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432808. 1774543 4 webkit-bug-importer 2021-07-02 13:24:16 -0700 <rdar://problem/80099966> 432808 2021-07-02 11:44:37 -0700 2021-07-02 13:23:07 -0700 Patch bug-227632-20210702114437.patch text/plain 3943 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5NTA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGVkNmMyNjQ5ZThkZmViY2Mx OTc4MGViNWNiYzg2NDZjYTE5MDUxYTcuLmJhNWRmZDBlYTI1YThlMDYxNDkxYTIyOWNjNDE4MjZm MmYyODljOTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjEtMDctMDIgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIyNzg3ODYpIExv Y2FsU3RvcmFnZURhdGFiYXNlJ3MgdHJhbnNhY3Rpb24gbWF5IGJlIHJlbWFpbiBhY3RpdmUgd2hl biBwcm9jZXNzIGdldHMgc3VzcGVuZGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMjc2MzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBZnRlciByMjc4Nzg2LCBMb2NhbFN0b3JhZ2VEYXRhYmFzZSBoYXMg YSBTUUwgdHJhbnNhY3Rpb24gdGhhdCBnZXRzIGNvbW1pdHRlZCB3aXRoIGEgNTAwbXMgZGVsYXkg b24gdGhlCisgICAgICAgIHN0b3JhZ2UgdGhyZWFkLiBXaGVuIHRoZSBuZXR3b3JrIHByb2Nlc3Mg d291bGQgcmVjZWl2ZSB0aGUgUHJlcGFyZVRvU3VzcGVuZCBJUEMsIGl0IHdvdWxkIHN1c3BlbmQg LyBoYW5nCisgICAgICAgIHRoZSBzdG9yYWdlIHRocmVhZCwgd2hpY2ggd291bGQgcHJldmVudCB0 aGUgU1FMIHRyYW5zYWN0aW9uIGZyb20gZ2V0dGluZyBjb21taXR0ZWQgYW5kIHdlIHdvdWxkIHN1 c3BlbmQKKyAgICAgICAgd2l0aCBhIGxvY2tlZCBmaWxlIGFuZCBnZXQga2lsbGVkLiBXZSBub3cg bWFrZSBzdXJlIHRvIGZsdXNoIGxvY2FsIHN0b3JhZ2UgdG8gZGlzayAoaS5lLiBjb21taXQgdGhh dAorICAgICAgICB0cmFuc2FjdGlvbikgYmVmb3JlIHdlIHN1c3BlbmQgLyBoYW5nIHRoZSBzdG9y YWdlIHRocmVhZC4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL1dlYlN0b3JhZ2UvU3RvcmFn ZU1hbmFnZXJTZXQuY3BwOgorICAgICAgICAoV2ViS2l0OjpTdG9yYWdlTWFuYWdlclNldDo6d2Fp dFVudGlsU3luY2luZ0xvY2FsU3RvcmFnZUZpbmlzaGVkKToKKyAgICAgICAgKFdlYktpdDo6U3Rv cmFnZU1hbmFnZXJTZXQ6OmZsdXNoTG9jYWxTdG9yYWdlKToKKyAgICAgICAgKFdlYktpdDo6U3Rv cmFnZU1hbmFnZXJTZXQ6OnN1c3BlbmQpOgorICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL1dlYlN0 b3JhZ2UvU3RvcmFnZU1hbmFnZXJTZXQuaDoKKwogMjAyMS0wNy0wMiAgQnJhZHkgRWlkc29uICA8 YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViUGFnZVByb3h5OjpzZXRBcHBIaWdobGln aHRzVmlzaWJpbGl0eSBtaWdodCBzZW5kIG1lc3NhZ2UgZnJvbSBhIGJhY2tncm91bmQgdGhyZWFk LCBBU1NFUlRpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvV2Vi U3RvcmFnZS9TdG9yYWdlTWFuYWdlclNldC5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9j ZXNzL1dlYlN0b3JhZ2UvU3RvcmFnZU1hbmFnZXJTZXQuY3BwCmluZGV4IDYxZDBiM2M3N2NlNWM4 ZGNkNzQxYzdkMDRhZDQxNDVmNmI0N2Y2NmUuLjk4MjYyMWFmYmZlZDJkZGE5ZGNjNjJhMzc0MzA2 NThjMzczOTQ0ZjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvV2Vi U3RvcmFnZS9TdG9yYWdlTWFuYWdlclNldC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3Jr UHJvY2Vzcy9XZWJTdG9yYWdlL1N0b3JhZ2VNYW5hZ2VyU2V0LmNwcApAQCAtMTU3LDE2ICsxNTcs MjIgQEAgdm9pZCBTdG9yYWdlTWFuYWdlclNldDo6d2FpdFVudGlsU3luY2luZ0xvY2FsU3RvcmFn ZUZpbmlzaGVkKCkKIAogICAgIEJpbmFyeVNlbWFwaG9yZSBzZW1hcGhvcmU7CiAgICAgbV9xdWV1 ZS0+ZGlzcGF0Y2goW3RoaXMsICZzZW1hcGhvcmVdIHsKLSAgICAgICAgZm9yIChjb25zdCBhdXRv JiBzdG9yYWdlQXJlYSA6IG1fc3RvcmFnZUFyZWFzLnZhbHVlcygpKSB7Ci0gICAgICAgICAgICBB U1NFUlQoc3RvcmFnZUFyZWEpOwotICAgICAgICAgICAgaWYgKHN0b3JhZ2VBcmVhKQotICAgICAg ICAgICAgICAgIHN0b3JhZ2VBcmVhLT5zeW5jVG9EYXRhYmFzZSgpOwotICAgICAgICB9CisgICAg ICAgIGZsdXNoTG9jYWxTdG9yYWdlKCk7CiAgICAgICAgIHNlbWFwaG9yZS5zaWduYWwoKTsKICAg ICB9KTsKICAgICBzZW1hcGhvcmUud2FpdCgpOwogfQogCit2b2lkIFN0b3JhZ2VNYW5hZ2VyU2V0 OjpmbHVzaExvY2FsU3RvcmFnZSgpCit7CisgICAgQVNTRVJUKCFSdW5Mb29wOjppc01haW4oKSk7 CisgICAgZm9yIChjb25zdCBhdXRvJiBzdG9yYWdlQXJlYSA6IG1fc3RvcmFnZUFyZWFzLnZhbHVl cygpKSB7CisgICAgICAgIEFTU0VSVChzdG9yYWdlQXJlYSk7CisgICAgICAgIGlmIChzdG9yYWdl QXJlYSkKKyAgICAgICAgICAgIHN0b3JhZ2VBcmVhLT5zeW5jVG9EYXRhYmFzZSgpOworICAgIH0K K30KKwogdm9pZCBTdG9yYWdlTWFuYWdlclNldDo6c3VzcGVuZChDb21wbGV0aW9uSGFuZGxlcjx2 b2lkKCk+JiYgY29tcGxldGlvbkhhbmRsZXIpCiB7CiAgICAgQVNTRVJUKFJ1bkxvb3A6OmlzTWFp bigpKTsKQEAgLTE4Niw2ICsxOTIsMTAgQEAgdm9pZCBTdG9yYWdlTWFuYWdlclNldDo6c3VzcGVu ZChDb21wbGV0aW9uSGFuZGxlcjx2b2lkKCk+JiYgY29tcGxldGlvbkhhbmRsZXIpCiAgICAgICAg ICAgICByZXR1cm47CiAgICAgICAgIH0KIAorICAgICAgICAvLyBNYWtlIHN1cmUgd2UgZmx1c2gg bG9jYWwgc3RvcmFnZSB0byBkaXNrIGJlZm9yZSB3ZSBzdXNwZW5kIHRoZSB0aHJlYWQgYXMgd2Ug d2FudCB0byBtYWtlIHN1cmUgYW55IHBlbmRpbmcKKyAgICAgICAgLy8gU1FMIHRyYW5zYWN0aW9u IGhhcyBiZWVuIGNvbW1pdHRlZC4KKyAgICAgICAgZmx1c2hMb2NhbFN0b3JhZ2UoKTsKKwogICAg ICAgICBtX3N0YXRlID0gU3RhdGU6OlN1c3BlbmRlZDsKICAgICAgICAgUnVuTG9vcDo6bWFpbigp LmRpc3BhdGNoKFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpKTsKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9XZWJTdG9yYWdlL1N0b3JhZ2VNYW5hZ2VyU2V0Lmgg Yi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL1dlYlN0b3JhZ2UvU3RvcmFnZU1hbmFnZXJT ZXQuaAppbmRleCA0MjQzZjMyNTczYmRhZDE0NTIxMDdmNTVjODIzMjg5NjFjZDViMGQ0Li42OTQ1 ZjJiMTk5MjAyYTc3NDEzYmVmNzExYTU5NTEwYTcwMGQxOGIzIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L05ldHdvcmtQcm9jZXNzL1dlYlN0b3JhZ2UvU3RvcmFnZU1hbmFnZXJTZXQuaAorKysg Yi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL1dlYlN0b3JhZ2UvU3RvcmFnZU1hbmFnZXJT ZXQuaApAQCAtODAsNiArODAsOCBAQCBwdWJsaWM6CiBwcml2YXRlOgogICAgIFN0b3JhZ2VNYW5h Z2VyU2V0KCk7CiAKKyAgICB2b2lkIGZsdXNoTG9jYWxTdG9yYWdlKCk7CisKICAgICAvLyBNZXNz YWdlIEhhbmRsZXJzCiAgICAgdm9pZCBjb25uZWN0VG9Mb2NhbFN0b3JhZ2VBcmVhKElQQzo6Q29u bmVjdGlvbiYsIFBBTDo6U2Vzc2lvbklEICwgU3RvcmFnZU5hbWVzcGFjZUlkZW50aWZpZXIsIFNl Y3VyaXR5T3JpZ2luRGF0YSYmLCBDb25uZWN0VG9TdG9yYWdlQXJlYUNhbGxiYWNrJiYpOwogICAg IHZvaWQgY29ubmVjdFRvVHJhbnNpZW50TG9jYWxTdG9yYWdlQXJlYShJUEM6OkNvbm5lY3Rpb24m LCBQQUw6OlNlc3Npb25JRCAsIFN0b3JhZ2VOYW1lc3BhY2VJZGVudGlmaWVyLCBTZWN1cml0eU9y aWdpbkRhdGEmJiwgU2VjdXJpdHlPcmlnaW5EYXRhJiYsIENvbm5lY3RUb1N0b3JhZ2VBcmVhQ2Fs bGJhY2smJik7Cg==