227603 2021-07-01 17:11:32 -0700 Provide SPI for clients to override just the contextmenu preview instead of the entire `UIContextMenuConfiguration` 2021-07-06 15:34:52 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 hi hi hi thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1774304 0 hi 2021-07-01 17:11:32 -0700 . 1774305 1 hi 2021-07-01 17:11:51 -0700 <rdar://problem/78832586> 1774307 2 432753 hi 2021-07-01 17:16:19 -0700 Created attachment 432753 Patch 1774316 3 432753 wenson_hsieh 2021-07-01 17:39:13 -0700 Comment on attachment 432753 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432753&action=review > Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:185 > +- (UIViewController *)_webView:(WKWebView *)webView contextMenuPreviewForElement:(WKContextMenuElementInfo *)elementInfo WK_API_AVAILABLE(ios(WK_IOS_TBA)); I'd maybe call this `-_webView:contextMenuContentPreviewForElement:` to match the wording in `UIContextMenuContentPreviewProvider`. Since this is going into iOS 15 and we've already replaced all the TBA macros for iOS 15/macOS 12, I think we should also make this `ios(15.0)` from the start. 1775028 4 432959 hi 2021-07-06 12:13:27 -0700 Created attachment 432959 Patch 1775124 5 ews-feeder 2021-07-06 15:34:51 -0700 Committed r279625 (239443@main): <https://commits.webkit.org/239443@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432959. 432753 2021-07-01 17:16:19 -0700 2021-07-06 12:13:26 -0700 Patch bug-227603-20210701171618.patch text/plain 3239 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggOTg2M2FiMTM4NzI5N2QwOWY2YWJkMTc3YmNkMjg5ZDAzMDA3N2IyYy4uMGEy ZWJkOTMzNjM3MGI0YTgzOTRjZDc1Mjg0YTY2ZDFhZWQ0YzQ5NyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNiBAQAorMjAyMS0wNy0wMSAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CisK KyAgICAgICAgUHJvdmlkZSBTUEkgZm9yIGNsaWVudHMgdG8gb3ZlcnJpZGUganVzdCB0aGUgY29u dGV4dG1lbnUgcHJldmlldyBpbnN0ZWFkIG9mIHRoZSBlbnRpcmUgYFVJQ29udGV4dE1lbnVDb25m aWd1cmF0aW9uYAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjI3NjAzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83ODgzMjU4Nj4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29j b2EvV0tVSURlbGVnYXRlUHJpdmF0ZS5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250 ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IGNvbnRpbnVl Q29udGV4dE1lbnVJbnRlcmFjdGlvbjpdKToKKyAgICAgICAgVGhpcyBhbGxvd3MgU2FmYXJpIHRv IHJlbW92ZSBzb21lIGN1c3RvbSBjb250ZXh0bWVudSBjb2RlIGFuZCB1c2UgV2ViS2l0J3MgZGVm YXVsdCBhY3Rpb25zLgorCiAyMDIxLTA2LTI4ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhA YXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIyNzkzMTApOiBPY2Nhc2lvbmFsIGNy YXNoIHdoZW4gZm9jdXNpbmcgbG9naW4gZmllbGRzIG9uIGlQYWQgd2l0aCBhIHNvZnR3YXJlIGtl eWJvYXJkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tV SURlbGVnYXRlUHJpdmF0ZS5oIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dL VUlEZWxlZ2F0ZVByaXZhdGUuaAppbmRleCBmNzNjMzgxOTIwMjY2ZTc1MzFhMGY0NDFlYTU0Y2Yx ZGUyZDliYTY5Li5iNTc3NTc0NGUyNmQ2YzYyOWE3OTE0NWJmMzU0ZWU1MzlhN2U0ZGI3IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tVSURlbGVnYXRlUHJp dmF0ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1VJRGVsZWdh dGVQcml2YXRlLmgKQEAgLTE4Miw2ICsxODIsNyBAQCBzdHJ1Y3QgVUlFZGdlSW5zZXRzOwogLy8g VGhlc2UgY2FuIGJlIHJlbW92ZWQgb25jZSB0aGVyZSBpcyBhbiBBUEkgdmVyc2lvbi4KIC0gKHZv aWQpX3dlYlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcgY29udGV4dE1lbnVGb3JFbGVtZW50OihX S0NvbnRleHRNZW51RWxlbWVudEluZm8gKillbGVtZW50SW5mbyB3aWxsQ29tbWl0V2l0aEFuaW1h dG9yOihpZDxVSUNvbnRleHRNZW51SW50ZXJhY3Rpb25Db21taXRBbmltYXRpbmc+KWFuaW1hdG9y IFdLX0FQSV9BVkFJTEFCTEUoaW9zKDEzLjApKTsKIC0gKHZvaWQpX3dlYlZpZXc6KFdLV2ViVmll dyAqKXdlYlZpZXcgY29udGV4dE1lbnVXaWxsUHJlc2VudEZvckVsZW1lbnQ6KFdLQ29udGV4dE1l bnVFbGVtZW50SW5mbyAqKWVsZW1lbnRJbmZvIFdLX0FQSV9BVkFJTEFCTEUoaW9zKDEzLjApKTsK Ky0gKFVJVmlld0NvbnRyb2xsZXIgKilfd2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldyBjb250 ZXh0TWVudVByZXZpZXdGb3JFbGVtZW50OihXS0NvbnRleHRNZW51RWxlbWVudEluZm8gKillbGVt ZW50SW5mbyBXS19BUElfQVZBSUxBQkxFKGlvcyhXS19JT1NfVEJBKSk7CiAtICh2b2lkKV93ZWJW aWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3IGNvbnRleHRNZW51RGlkRW5kRm9yRWxlbWVudDooV0tD b250ZXh0TWVudUVsZW1lbnRJbmZvICopZWxlbWVudEluZm8gV0tfQVBJX0FWQUlMQUJMRShpb3Mo MTMuMCkpOwogI2VuZGlmCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lv cy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9p b3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IDIwYzMzNTY4ZDk2NGM0OTcwYTI3 MzljZTliYmZmOWJhYjU5OWNmZDQuLmNlODUyNWQxMmZkMTgxNjc0OTM3YmZkOWVkOWYyZjllOTE5 MTg4ZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRW aWV3SW50ZXJhY3Rpb24ubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29u dGVudFZpZXdJbnRlcmFjdGlvbi5tbQpAQCAtMTEwMDYsNiArMTEwMDYsMTIgQEAgLSAodm9pZClj b250aW51ZUNvbnRleHRNZW51SW50ZXJhY3Rpb246KHZvaWQoXikoVUlDb250ZXh0TWVudUNvbmZp Z3VyYXRpb24gKikpY28KICAgICAgICAgICAgICAgICBpZiAoIXN0cm9uZ1NlbGYpCiAgICAgICAg ICAgICAgICAgICAgIHJldHVybiBuaWw7CiAKKyAgICAgICAgICAgICAgICBhdXRvIHVpRGVsZWdh dGUgPSBzdGF0aWNfY2FzdDxpZDxXS1VJRGVsZWdhdGVQcml2YXRlPj4oW3N0cm9uZ1NlbGYgd2Vi Vmlld1VJRGVsZWdhdGVdKTsKKyAgICAgICAgICAgICAgICBpZiAoW3VpRGVsZWdhdGUgcmVzcG9u ZHNUb1NlbGVjdG9yOkBzZWxlY3Rvcihfd2ViVmlldzpjb250ZXh0TWVudVByZXZpZXdGb3JFbGVt ZW50OildKSB7CisgICAgICAgICAgICAgICAgICAgIGlmIChVSVZpZXdDb250cm9sbGVyICpwcmV2 aWV3Vmlld0NvbnRyb2xsZXIgPSBbdWlEZWxlZ2F0ZSBfd2ViVmlldzpbc3Ryb25nU2VsZiB3ZWJW aWV3XSBjb250ZXh0TWVudVByZXZpZXdGb3JFbGVtZW50OnN0cm9uZ1NlbGYtPl9jb250ZXh0TWVu dUVsZW1lbnRJbmZvLmdldCgpXSkKKyAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiBwcmV2 aWV3Vmlld0NvbnRyb2xsZXI7CisgICAgICAgICAgICAgICAgfQorCiAgICAgICAgICAgICAgICAg cmV0dXJuIGFkb3B0TlMoW1tXS0ltYWdlUHJldmlld1ZpZXdDb250cm9sbGVyIGFsbG9jXSBpbml0 V2l0aENHSW1hZ2U6Y2dJbWFnZSBkZWZhdWx0QWN0aW9uczpuaWwgZWxlbWVudEluZm86ZWxlbWVu dEluZm8uZ2V0KCldKS5hdXRvcmVsZWFzZSgpOwogICAgICAgICAgICAgfTsKIAo= 432959 2021-07-06 12:13:27 -0700 2021-07-06 15:34:51 -0700 Patch bug-227603-20210706121327.patch text/plain 3252 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggOTg2M2FiMTM4NzI5N2QwOWY2YWJkMTc3YmNkMjg5ZDAzMDA3N2IyYy4uMzFl ZjRjNWNmMTRlYWU4NTMxMGY0NzBmZmM0NGYyZjMzNmNiMDY3YSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNiBAQAorMjAyMS0wNy0wNiAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CisK KyAgICAgICAgUHJvdmlkZSBTUEkgZm9yIGNsaWVudHMgdG8gb3ZlcnJpZGUganVzdCB0aGUgY29u dGV4dG1lbnUgcHJldmlldyBpbnN0ZWFkIG9mIHRoZSBlbnRpcmUgYFVJQ29udGV4dE1lbnVDb25m aWd1cmF0aW9uYAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjI3NjAzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83ODgzMjU4Nj4KKworICAgICAgICBS ZXZpZXdlZCBieSBXZW5zb24gSHNpZWguCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29h L1dLVUlEZWxlZ2F0ZVByaXZhdGUuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVu dFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBjb250aW51ZUNv bnRleHRNZW51SW50ZXJhY3Rpb246XSk6CisgICAgICAgIFRoaXMgYWxsb3dzIFNhZmFyaSB0byBy ZW1vdmUgc29tZSBjdXN0b20gY29udGV4dG1lbnUgY29kZSBhbmQgdXNlIFdlYktpdCdzIGRlZmF1 bHQgYWN0aW9ucy4KKwogMjAyMS0wNi0yOCAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFw cGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMjc5MzEwKTogT2NjYXNpb25hbCBjcmFz aCB3aGVuIGZvY3VzaW5nIGxvZ2luIGZpZWxkcyBvbiBpUGFkIHdpdGggYSBzb2Z0d2FyZSBrZXli b2FyZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLVUlE ZWxlZ2F0ZVByaXZhdGUuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1VJ RGVsZWdhdGVQcml2YXRlLmgKaW5kZXggZjczYzM4MTkyMDI2NmU3NTMxYTBmNDQxZWE1NGNmMWRl MmQ5YmE2OS4uMmE0NDE4ZDVkZGM1YjE4NmQ4OGRhYTE1MmZkODJiODMwN2YzOTY3MyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLVUlEZWxlZ2F0ZVByaXZh dGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tVSURlbGVnYXRl UHJpdmF0ZS5oCkBAIC0xODIsNiArMTgyLDcgQEAgc3RydWN0IFVJRWRnZUluc2V0czsKIC8vIFRo ZXNlIGNhbiBiZSByZW1vdmVkIG9uY2UgdGhlcmUgaXMgYW4gQVBJIHZlcnNpb24uCiAtICh2b2lk KV93ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3IGNvbnRleHRNZW51Rm9yRWxlbWVudDooV0tD b250ZXh0TWVudUVsZW1lbnRJbmZvICopZWxlbWVudEluZm8gd2lsbENvbW1pdFdpdGhBbmltYXRv cjooaWQ8VUlDb250ZXh0TWVudUludGVyYWN0aW9uQ29tbWl0QW5pbWF0aW5nPilhbmltYXRvciBX S19BUElfQVZBSUxBQkxFKGlvcygxMy4wKSk7CiAtICh2b2lkKV93ZWJWaWV3OihXS1dlYlZpZXcg Kil3ZWJWaWV3IGNvbnRleHRNZW51V2lsbFByZXNlbnRGb3JFbGVtZW50OihXS0NvbnRleHRNZW51 RWxlbWVudEluZm8gKillbGVtZW50SW5mbyBXS19BUElfQVZBSUxBQkxFKGlvcygxMy4wKSk7Cist IChVSVZpZXdDb250cm9sbGVyICopX3dlYlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcgY29udGV4 dE1lbnVDb250ZW50UHJldmlld0ZvckVsZW1lbnQ6KFdLQ29udGV4dE1lbnVFbGVtZW50SW5mbyAq KWVsZW1lbnRJbmZvIFdLX0FQSV9BVkFJTEFCTEUoaW9zKDE1LjApKTsKIC0gKHZvaWQpX3dlYlZp ZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcgY29udGV4dE1lbnVEaWRFbmRGb3JFbGVtZW50OihXS0Nv bnRleHRNZW51RWxlbWVudEluZm8gKillbGVtZW50SW5mbyBXS19BUElfQVZBSUxBQkxFKGlvcygx My4wKSk7CiAjZW5kaWYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9z L1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lv cy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KaW5kZXggMjBjMzM1NjhkOTY0YzQ5NzBhMjcz OWNlOWJiZmY5YmFiNTk5Y2ZkNC4uYjA5ZDZiM2QyMzhhYjk0NjdhN2MyNDUxZTA1M2MyNGNkYzYy YzE1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZp ZXdJbnRlcmFjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250 ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBAIC0xMTAwNiw2ICsxMTAwNiwxMiBAQCAtICh2b2lkKWNv bnRpbnVlQ29udGV4dE1lbnVJbnRlcmFjdGlvbjoodm9pZCheKShVSUNvbnRleHRNZW51Q29uZmln dXJhdGlvbiAqKSljbwogICAgICAgICAgICAgICAgIGlmICghc3Ryb25nU2VsZikKICAgICAgICAg ICAgICAgICAgICAgcmV0dXJuIG5pbDsKIAorICAgICAgICAgICAgICAgIGF1dG8gdWlEZWxlZ2F0 ZSA9IHN0YXRpY19jYXN0PGlkPFdLVUlEZWxlZ2F0ZVByaXZhdGU+Pihbc3Ryb25nU2VsZiB3ZWJW aWV3VUlEZWxlZ2F0ZV0pOworICAgICAgICAgICAgICAgIGlmIChbdWlEZWxlZ2F0ZSByZXNwb25k c1RvU2VsZWN0b3I6QHNlbGVjdG9yKF93ZWJWaWV3OmNvbnRleHRNZW51Q29udGVudFByZXZpZXdG b3JFbGVtZW50OildKSB7CisgICAgICAgICAgICAgICAgICAgIGlmIChVSVZpZXdDb250cm9sbGVy ICpwcmV2aWV3Vmlld0NvbnRyb2xsZXIgPSBbdWlEZWxlZ2F0ZSBfd2ViVmlldzpbc3Ryb25nU2Vs ZiB3ZWJWaWV3XSBjb250ZXh0TWVudUNvbnRlbnRQcmV2aWV3Rm9yRWxlbWVudDpzdHJvbmdTZWxm LT5fY29udGV4dE1lbnVFbGVtZW50SW5mby5nZXQoKV0pCisgICAgICAgICAgICAgICAgICAgICAg ICByZXR1cm4gcHJldmlld1ZpZXdDb250cm9sbGVyOworICAgICAgICAgICAgICAgIH0KKwogICAg ICAgICAgICAgICAgIHJldHVybiBhZG9wdE5TKFtbV0tJbWFnZVByZXZpZXdWaWV3Q29udHJvbGxl ciBhbGxvY10gaW5pdFdpdGhDR0ltYWdlOmNnSW1hZ2UgZGVmYXVsdEFjdGlvbnM6bmlsIGVsZW1l bnRJbmZvOmVsZW1lbnRJbmZvLmdldCgpXSkuYXV0b3JlbGVhc2UoKTsKICAgICAgICAgICAgIH07 CiAK