227591 2021-07-01 12:50:38 -0700 Add logging for legacy AppHighlight decoding to aid in future debugging. 2021-07-08 10:18:16 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1774218 0 megan_gardner 2021-07-01 12:50:38 -0700 Add logging for legacy AppHighlight decoding to aid in future debugging. 1774221 1 432717 megan_gardner 2021-07-01 12:54:20 -0700 Created attachment 432717 Patch 1774223 2 432717 thorton 2021-07-01 12:57:30 -0700 Comment on attachment 432717 Patch You should probably also think about other logs that might be useful (AppHighlightRangeData failed to decode?) to diagnose issues from the field. 1775682 3 433136 megan_gardner 2021-07-08 09:16:53 -0700 Created attachment 433136 Patch 1775689 4 433136 wenson_hsieh 2021-07-08 09:32:20 -0700 Comment on attachment 433136 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433136&action=review > Source/WebCore/Modules/highlight/AppHighlightStorage.cpp:136 > + RELEASE_LOG(AppHighlights, "Attempting fallback text search for AppHighlightRangeData."); Do you need to `#include Logging.h` in this file as well? (I suspect it's currently grabbing it from the AppHighlightRangeData.cpp here, since it's right before this file in unified sources). 1775708 5 ews-feeder 2021-07-08 10:17:18 -0700 Committed r279728 (239515@main): <https://commits.webkit.org/239515@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432717. 1775709 6 webkit-bug-importer 2021-07-08 10:18:16 -0700 <rdar://problem/80330605> 432717 2021-07-01 12:54:20 -0700 2021-07-08 10:17:18 -0700 Patch bug-227591-20210701125419.patch text/plain 2116 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5NDcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjkzODk5OGQ2NDFhMGFi N2VmMmQ5OGY5YjI3ZTg0YWE5OWUzMDQ2ZC4uZDEzMTlkMTk5Y2EwMmI4YTIzMWNlNDg1OTQyMjM3 YTljNGFjYzljNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTA3LTAxICBNZWdh biBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGxvZ2dp bmcgZm9yIGxlZ2FjeSBBcHBIaWdobGlnaHQgZGVjb2RpbmcgdG8gYWlkIGluIGZ1dHVyZSBkZWJ1 Z2dpbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y Mjc1OTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IE1vZHVsZXMvaGlnaGxpZ2h0L0FwcEhpZ2hsaWdodFJhbmdlRGF0YS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpBcHBIaWdobGlnaHRSYW5nZURhdGE6OmRlY29kZSk6CisgICAgICAgICogcGxhdGZv cm0vTG9nZ2luZy5oOgorCiAyMDIxLTA3LTAxICBBbWlyIE1hcmsgSnIgIDxhbWlyX21hcmtAYXBw bGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJldmVydGluZyByMjc5NDUyLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9oaWdobGlnaHQvQXBwSGlnaGxpZ2h0UmFuZ2VE YXRhLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaGlnaGxpZ2h0L0FwcEhpZ2hsaWdodFJh bmdlRGF0YS5jcHAKaW5kZXggNzI0YzM0YjMwNzBlYWJiNTUwYzMyMTBiYTI3NmRmNDk2MTg5NTlh Mi4uZTJkOWE2MWU0Mjc2NzZlYjdiN2RhZWFiZmZhMzJkMDRhNDU3NmMwNiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9oaWdobGlnaHQvQXBwSGlnaGxpZ2h0UmFuZ2VEYXRhLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2hpZ2hsaWdodC9BcHBIaWdobGlnaHRSYW5n ZURhdGEuY3BwCkBAIC0zMSw2ICszMSw3IEBACiAjaW5jbHVkZSAiRG9jdW1lbnQuaCIKICNpbmNs dWRlICJEb2N1bWVudE1hcmtlckNvbnRyb2xsZXIuaCIKICNpbmNsdWRlICJIVE1MQm9keUVsZW1l bnQuaCIKKyNpbmNsdWRlICJMb2dnaW5nLmgiCiAjaW5jbHVkZSAiTm9kZS5oIgogI2luY2x1ZGUg IlJlbmRlcmVkRG9jdW1lbnRNYXJrZXIuaCIKICNpbmNsdWRlICJTaGFyZWRCdWZmZXIuaCIKQEAg LTEyMCw2ICsxMjEsNyBAQCB0ZW1wbGF0ZTxjbGFzcyBEZWNvZGVyPiBzdGQ6Om9wdGlvbmFsPEFw cEhpZ2hsaWdodFJhbmdlRGF0YT4gQXBwSGlnaGxpZ2h0UmFuZ2VEYQogICAgICAgICBpZiAoIWRl Y29kZXIucmV3aW5kKHNpemVvZihoaWdobGlnaHRGaWxlU2lnbmF0dXJlKSkpCiAgICAgICAgICAg ICByZXR1cm4gc3RkOjpudWxsb3B0OwogICAgICAgICB2ZXJzaW9uID0gMDsKKyAgICAgICAgUkVM RUFTRV9MT0coQXBwSGlnaGxpZ2h0cywgIkRlY29kZWQgbGVnYWN5ICh2MCkgaGlnaGxpZ2h0LiIp OwogICAgIH0KICAgICAKICAgICBzdGQ6Om9wdGlvbmFsPFN0cmluZz4gaWRlbnRpZmllcjsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xvZ2dpbmcuaCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL0xvZ2dpbmcuaAppbmRleCBkNDkxY2YyNjg1MTMwZTEzMmM5MzNmZDdjMzUw MmIyZDYxMTc0NDQ1Li45OWE0ODViNTY5M2FmY2M4YTA2M2UxMzU4OTI3NjZlMjYxZWRjNDY2IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2dnaW5nLmgKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vTG9nZ2luZy5oCkBAIC0zOSw2ICszOSw3IEBAIG5hbWVzcGFjZSBX ZWJDb3JlIHsKICNkZWZpbmUgV0VCQ09SRV9MT0dfQ0hBTk5FTFMoTSkgXAogICAgIE0oQWNjZXNz aWJpbGl0eSkgXAogICAgIE0oQW5pbWF0aW9ucykgXAorICAgIE0oQXBwSGlnaGxpZ2h0cykgXAog ICAgIE0oQXBwbGVQYXkpIFwKICAgICBNKEFyY2hpdmVzKSBcCiAgICAgTShCYWNrRm9yd2FyZENh Y2hlKSBcCg== 433136 2021-07-08 09:16:53 -0700 2021-07-08 09:32:20 -0700 Patch bug-227591-20210708091652.patch text/plain 3947 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5NDcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjkzODk5OGQ2NDFhMGFi N2VmMmQ5OGY5YjI3ZTg0YWE5OWUzMDQ2ZC4uZDEzMTlkMTk5Y2EwMmI4YTIzMWNlNDg1OTQyMjM3 YTljNGFjYzljNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTA3LTAxICBNZWdh biBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGxvZ2dp bmcgZm9yIGxlZ2FjeSBBcHBIaWdobGlnaHQgZGVjb2RpbmcgdG8gYWlkIGluIGZ1dHVyZSBkZWJ1 Z2dpbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y Mjc1OTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IE1vZHVsZXMvaGlnaGxpZ2h0L0FwcEhpZ2hsaWdodFJhbmdlRGF0YS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpBcHBIaWdobGlnaHRSYW5nZURhdGE6OmRlY29kZSk6CisgICAgICAgICogcGxhdGZv cm0vTG9nZ2luZy5oOgorCiAyMDIxLTA3LTAxICBBbWlyIE1hcmsgSnIgIDxhbWlyX21hcmtAYXBw bGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJldmVydGluZyByMjc5NDUyLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9oaWdobGlnaHQvQXBwSGlnaGxpZ2h0UmFuZ2VE YXRhLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaGlnaGxpZ2h0L0FwcEhpZ2hsaWdodFJh bmdlRGF0YS5jcHAKaW5kZXggNzI0YzM0YjMwNzBlYWJiNTUwYzMyMTBiYTI3NmRmNDk2MTg5NTlh Mi4uZTJkOWE2MWU0Mjc2NzZlYjdiN2RhZWFiZmZhMzJkMDRhNDU3NmMwNiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9oaWdobGlnaHQvQXBwSGlnaGxpZ2h0UmFuZ2VEYXRhLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2hpZ2hsaWdodC9BcHBIaWdobGlnaHRSYW5n ZURhdGEuY3BwCkBAIC0zMSw2ICszMSw3IEBACiAjaW5jbHVkZSAiRG9jdW1lbnQuaCIKICNpbmNs dWRlICJEb2N1bWVudE1hcmtlckNvbnRyb2xsZXIuaCIKICNpbmNsdWRlICJIVE1MQm9keUVsZW1l bnQuaCIKKyNpbmNsdWRlICJMb2dnaW5nLmgiCiAjaW5jbHVkZSAiTm9kZS5oIgogI2luY2x1ZGUg IlJlbmRlcmVkRG9jdW1lbnRNYXJrZXIuaCIKICNpbmNsdWRlICJTaGFyZWRCdWZmZXIuaCIKQEAg LTEyMCw2ICsxMjEsNyBAQCB0ZW1wbGF0ZTxjbGFzcyBEZWNvZGVyPiBzdGQ6Om9wdGlvbmFsPEFw cEhpZ2hsaWdodFJhbmdlRGF0YT4gQXBwSGlnaGxpZ2h0UmFuZ2VEYQogICAgICAgICBpZiAoIWRl Y29kZXIucmV3aW5kKHNpemVvZihoaWdobGlnaHRGaWxlU2lnbmF0dXJlKSkpCiAgICAgICAgICAg ICByZXR1cm4gc3RkOjpudWxsb3B0OwogICAgICAgICB2ZXJzaW9uID0gMDsKKyAgICAgICAgUkVM RUFTRV9MT0coQXBwSGlnaGxpZ2h0cywgIkRlY29kZWQgbGVnYWN5ICh2MCkgaGlnaGxpZ2h0LiIp OwogICAgIH0KICAgICAKICAgICBzdGQ6Om9wdGlvbmFsPFN0cmluZz4gaWRlbnRpZmllcjsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaGlnaGxpZ2h0L0FwcEhpZ2hsaWdodFN0 b3JhZ2UuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9oaWdobGlnaHQvQXBwSGlnaGxpZ2h0 U3RvcmFnZS5jcHAKaW5kZXggNzgwZmM1MTZkZmU1NjkwNTA2MDY2ZDJhYTkyZjNkODNlMDU1YWU3 MS4uMWU1ODU4YjA1YTYzMGQ0ZmRlM2VjZTZhOTllNTFhOWIyYmEzNDk5YSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9oaWdobGlnaHQvQXBwSGlnaGxpZ2h0U3RvcmFnZS5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9oaWdobGlnaHQvQXBwSGlnaGxpZ2h0U3RvcmFn ZS5jcHAKQEAgLTEzMyw2ICsxMzMsNyBAQCBzdGF0aWMgc3RkOjpvcHRpb25hbDxTaW1wbGVSYW5n ZT4gZmluZFJhbmdlQnlJZGVudGlmeWluZ1N0YXJ0QW5kRW5kUG9zaXRpb25zKGNvbgogCiBzdGF0 aWMgc3RkOjpvcHRpb25hbDxTaW1wbGVSYW5nZT4gZmluZFJhbmdlQnlTZWFyY2hpbmdUZXh0KGNv bnN0IEFwcEhpZ2hsaWdodFJhbmdlRGF0YSYgcmFuZ2UsIERvY3VtZW50JiBkb2N1bWVudCkKIHsK KyAgICBSRUxFQVNFX0xPRyhBcHBIaWdobGlnaHRzLCAiQXR0ZW1wdGluZyBmYWxsYmFjayB0ZXh0 IHNlYXJjaCBmb3IgQXBwSGlnaGxpZ2h0UmFuZ2VEYXRhLiIpOwogICAgIEhhc2hTZXQ8U3RyaW5n PiBpZGVudGlmaWVyc0luU3RhcnRQYXRoOwogICAgIGZvciAoYXV0byYgY29tcG9uZW50IDogcmFu Z2Uuc3RhcnRDb250YWluZXIoKSkgewogICAgICAgICBpZiAoIWNvbXBvbmVudC5pZGVudGlmaWVy LmlzRW1wdHkoKSkKQEAgLTIzOSw4ICsyNDAsMTAgQEAgdm9pZCBBcHBIaWdobGlnaHRTdG9yYWdl OjpzdG9yZUFwcEhpZ2hsaWdodChSZWY8U3RhdGljUmFuZ2U+JiYgcmFuZ2UpCiB2b2lkIEFwcEhp Z2hsaWdodFN0b3JhZ2U6OnJlc3RvcmVBbmRTY3JvbGxUb0FwcEhpZ2hsaWdodChSZWY8U2hhcmVk QnVmZmVyPiYmIGJ1ZmZlciwgU2Nyb2xsVG9IaWdobGlnaHQgc2Nyb2xsKQogewogICAgIGF1dG8g YXBwSGlnaGxpZ2h0UmFuZ2VEYXRhID0gQXBwSGlnaGxpZ2h0UmFuZ2VEYXRhOjpjcmVhdGUoYnVm ZmVyKTsKLSAgICBpZiAoIWFwcEhpZ2hsaWdodFJhbmdlRGF0YSkKKyAgICBpZiAoIWFwcEhpZ2hs aWdodFJhbmdlRGF0YSkgeworICAgICAgICBSRUxFQVNFX0xPRyhBcHBIaWdobGlnaHRzLCAiQXBw SGlnaGxpZ2h0UmFuZ2VEYXRhIGZhaWxlZCB0byBkZWNvZGUuIik7CiAgICAgICAgIHJldHVybjsK KyAgICB9CiAgICAgCiAgICAgaWYgKCFhdHRlbXB0VG9SZXN0b3JlSGlnaGxpZ2h0QW5kU2Nyb2xs KGFwcEhpZ2hsaWdodFJhbmdlRGF0YS52YWx1ZSgpLCBzY3JvbGwpKSB7CiAgICAgICAgIGlmIChz Y3JvbGwgPT0gU2Nyb2xsVG9IaWdobGlnaHQ6OlllcykKQEAgLTI2MSw4ICsyNjQsMTAgQEAgYm9v bCBBcHBIaWdobGlnaHRTdG9yYWdlOjphdHRlbXB0VG9SZXN0b3JlSGlnaGxpZ2h0QW5kU2Nyb2xs KEFwcEhpZ2hsaWdodFJhbmdlRGEKICAgICAKICAgICBhdXRvIHJhbmdlID0gZmluZFJhbmdlKGhp Z2hsaWdodCwgKnN0cm9uZ0RvY3VtZW50KTsKICAgICAKLSAgICBpZiAoIXJhbmdlKQorICAgIGlm ICghcmFuZ2UpIHsKKyAgICAgICAgUkVMRUFTRV9MT0coQXBwSGlnaGxpZ2h0cywgIkZhaWxlZCB0 byBmaW5kIHJhbmdlIGZvciBBcHBIaWdobGlnaHRSYW5nZURhdGEuIik7CiAgICAgICAgIHJldHVy biBmYWxzZTsKKyAgICB9CiAgICAgCiAgICAgc3Ryb25nRG9jdW1lbnQtPmFwcEhpZ2hsaWdodFJl Z2lzdGVyKCkuYWRkQXBwSGlnaGxpZ2h0KFN0YXRpY1JhbmdlOjpjcmVhdGUoKnJhbmdlKSk7CiAg ICAgCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2dnaW5nLmggYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2dnaW5nLmgKaW5kZXggZDQ5MWNmMjY4NTEzMGUxMzJjOTMz ZmQ3YzM1MDJiMmQ2MTE3NDQ0NS4uOTlhNDg1YjU2OTNhZmNjOGEwNjNlMTM1ODkyNzY2ZTI2MWVk YzQ2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTG9nZ2luZy5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xvZ2dpbmcuaApAQCAtMzksNiArMzksNyBAQCBuYW1l c3BhY2UgV2ViQ29yZSB7CiAjZGVmaW5lIFdFQkNPUkVfTE9HX0NIQU5ORUxTKE0pIFwKICAgICBN KEFjY2Vzc2liaWxpdHkpIFwKICAgICBNKEFuaW1hdGlvbnMpIFwKKyAgICBNKEFwcEhpZ2hsaWdo dHMpIFwKICAgICBNKEFwcGxlUGF5KSBcCiAgICAgTShBcmNoaXZlcykgXAogICAgIE0oQmFja0Zv cndhcmRDYWNoZSkgXAo=