227572 2021-07-01 00:26:39 -0700 [macOS] Fix sandbox violations related to IOKit filtering 2021-07-01 11:52:11 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham webkit-bug-importer oldest_to_newest 1774020 0 pvollan 2021-07-01 00:26:39 -0700 The IOKit filter on macOS is missing some methods which are being used. 1774021 1 pvollan 2021-07-01 00:27:06 -0700 <rdar://78354215> 1774023 2 432662 pvollan 2021-07-01 00:29:45 -0700 Created attachment 432662 Patch 1774080 3 432681 pvollan 2021-07-01 05:40:32 -0700 Created attachment 432681 Patch 1774144 4 432681 bfulgham 2021-07-01 09:39:19 -0700 Comment on attachment 432681 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432681&action=review > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:122 > +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 120000 && __MAC_OS_X_VERSION_MIN_REQUIRED < 120500 Should this be 130000? I don't think we typically build with MIN_REQUIRED not being a full round number. 1774158 5 432681 bfulgham 2021-07-01 10:34:18 -0700 Comment on attachment 432681 Patch Per Arne and I spoke, and he will land the patch with the 130000 round number. r=me 1774163 6 432708 pvollan 2021-07-01 10:56:01 -0700 Created attachment 432708 Patch 1774164 7 432708 pvollan 2021-07-01 10:56:49 -0700 Comment on attachment 432708 Patch Thanks for reviewing! 1774191 8 ews-feeder 2021-07-01 11:52:11 -0700 Committed r279476 (239329@main): <https://commits.webkit.org/239329@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432708. 432662 2021-07-01 00:29:45 -0700 2021-07-01 05:40:28 -0700 Patch bug-227572-20210701092944.patch text/plain 1502 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNzk0NTMpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDIxLTA3LTAxICBQZXIgQXJuZSAg PHB2b2xsYW5AYXBwbGUuY29tPgorCisgICAgICAgIFttYWNPU10gQWRkIG1ldGhvZHMgdG8gSU9L aXQgZmlsdGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMjc1NzIKKyAgICAgICAgPHJkYXI6Ly83ODM1NDIxNT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgSU9LaXQgZmlsdGVyIG9uIG1hY09TIGlz IG1pc3Npbmcgc29tZSBtZXRob2RzIHdoaWNoIGFyZSBiZWluZyB1c2VkLgorCisgICAgICAgICog V2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbjoKKwogMjAyMS0wNy0wMSAgSmVy IE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBbTWFjXSAoUmUtKWVuYWJs ZSBHcm91cEFjdGl2aXRpZXMgYWZ0ZXIgdXBzdHJlYW1pbmcKSW5kZXg6IFNvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbgo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW4JKHJldmlzaW9u IDI3OTQ1MykKKysrIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vz cy5zYi5pbgkod29ya2luZyBjb3B5KQpAQCAtMTc0LDEyICsxNzQsMTkgQEAKICNlbmRpZgogICAg ICAgICApCiAjaWYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMjAwMDAKLSAg ICAgICAgKGlmIChlcXVhbD8gKHBhcmFtICJDUFUiKSAiYXJtNjQiKQorICAgICAgICAod2hlbiAo ZXF1YWw/IChwYXJhbSAiQ1BVIikgImFybTY0IikKICAgICAgICAgICAgIChhbGxvdyBpb2tpdC1l eHRlcm5hbC1tZXRob2QKICAgICAgICAgICAgICAgICAoaW9raXQtbWV0aG9kLW51bWJlcgorICAg ICAgICAgICAgICAgICAgICA0MQogICAgICAgICAgICAgICAgICAgICA0MwogICAgICAgICAgICAg ICAgICAgICA0NAogICAgICAgICAgICAgICAgICAgICA0NgorICAgICAgICAgICAgICAgICAgICA0 OQorICAgICAgICAgICAgICAgICkKKyAgICAgICAgICAgICkKKyAgICAgICAgICAgIChhbGxvdyBp b2tpdC1hc3luYy1leHRlcm5hbC1tZXRob2QKKyAgICAgICAgICAgICAgICAoaW9raXQtbWV0aG9k LW51bWJlcgorICAgICAgICAgICAgICAgICAgICA0OAogICAgICAgICAgICAgICAgICkKICAgICAg ICAgICAgICkKICAgICAgICAgKQo= 432681 2021-07-01 05:40:32 -0700 2021-07-01 10:34:18 -0700 Patch bug-227572-20210701144030.patch text/plain 1798 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNzk0NTMpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDIxLTA3LTAxICBQZXIgQXJuZSAg PHB2b2xsYW5AYXBwbGUuY29tPgorCisgICAgICAgIFttYWNPU10gRml4IHNhbmRib3ggdmlvbGF0 aW9ucyByZWxhdGVkIHRvIElPS2l0IGZpbHRlcmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI3NTcyCisgICAgICAgIDxyZGFyOi8vNzgzNTQyMTU+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQ cm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluOgorCiAyMDIxLTA3LTAxICBKZXIgTm9i bGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFtNYWNdIChSZS0pZW5hYmxlIEdy b3VwQWN0aXZpdGllcyBhZnRlciB1cHN0cmVhbWluZwpJbmRleDogU291cmNlL1dlYktpdC9XZWJQ cm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQvV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbgkocmV2aXNpb24gMjc5 NDUzKQorKysgU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNi LmluCSh3b3JraW5nIGNvcHkpCkBAIC0xMTksNyArMTE5LDcgQEAKICAgICAgICAgICAgIGlva2l0 LWV4dGVybmFsLW1ldGhvZAogICAgICAgICApCiAgICAgICAgIChhbGxvdyBpb2tpdC1hc3luYy1l eHRlcm5hbC1tZXRob2QKLSNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEy MDAwMAorI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTIwMDAwICYmIF9f TUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPCAxMjA1MDAKICAgICAgICAgICAgIChpb2tp dC1tZXRob2QtbnVtYmVyCiAgICAgICAgICAgICAgICAgMAogICAgICAgICAgICAgICAgIDQ3CkBA IC0xMjcsNyArMTI3LDcgQEAKICNlbmRpZgogICAgICAgICApCiAgICAgICAgIChhbGxvdyBpb2tp dC1leHRlcm5hbC1tZXRob2QKLSNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49 IDEyMDAwMAorI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTIwMDAwICYm IF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPCAxMjA1MDAKICAgICAgICAgICAgIChp b2tpdC1tZXRob2QtbnVtYmVyCiAgICAgICAgICAgICAgICAgMAogICAgICAgICAgICAgICAgIDEK QEAgLTE3Myw3ICsxNzMsNyBAQAogICAgICAgICAgICAgKQogI2VuZGlmCiAgICAgICAgICkKLSNp ZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEyMDAwMAorI2lmIF9fTUFDX09T X1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTIwMDAwICYmIF9fTUFDX09TX1hfVkVSU0lPTl9N SU5fUkVRVUlSRUQgPCAxMjA1MDAKICAgICAgICAgKGlmIChlcXVhbD8gKHBhcmFtICJDUFUiKSAi YXJtNjQiKQogICAgICAgICAgICAgKGFsbG93IGlva2l0LWV4dGVybmFsLW1ldGhvZAogICAgICAg ICAgICAgICAgIChpb2tpdC1tZXRob2QtbnVtYmVyCg== 432708 2021-07-01 10:56:01 -0700 2021-07-01 11:52:11 -0700 Patch bug-227572-20210701195559.patch text/plain 1797 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNzk0NTMpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDIxLTA3LTAxICBQZXIgQXJuZSAg PHB2b2xsYW5AYXBwbGUuY29tPgorCisgICAgICAgIFttYWNPU10gRml4IHNhbmRib3ggdmlvbGF0 aW9ucyByZWxhdGVkIHRvIElPS2l0IGZpbHRlcmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI3NTcyCisgICAgICAgIDxyZGFyOi8vNzgzNTQyMTU+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQnJlbnQgRnVsZ2hhbS4KKworICAgICAgICAqIFdlYlBy b2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW46CisKIDIwMjEtMDctMDEgIEplciBOb2Js ZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgW01hY10gKFJlLSllbmFibGUgR3Jv dXBBY3Rpdml0aWVzIGFmdGVyIHVwc3RyZWFtaW5nCkluZGV4OiBTb3VyY2UvV2ViS2l0L1dlYlBy b2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW4KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdC9XZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluCShyZXZpc2lvbiAyNzk0 NTMpCisrKyBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2Iu aW4JKHdvcmtpbmcgY29weSkKQEAgLTExOSw3ICsxMTksNyBAQAogICAgICAgICAgICAgaW9raXQt ZXh0ZXJuYWwtbWV0aG9kCiAgICAgICAgICkKICAgICAgICAgKGFsbG93IGlva2l0LWFzeW5jLWV4 dGVybmFsLW1ldGhvZAotI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTIw MDAwCisjaWYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMjAwMDAgJiYgX19N QUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA8IDEzMDAwMAogICAgICAgICAgICAgKGlva2l0 LW1ldGhvZC1udW1iZXIKICAgICAgICAgICAgICAgICAwCiAgICAgICAgICAgICAgICAgNDcKQEAg LTEyNyw3ICsxMjcsNyBAQAogI2VuZGlmCiAgICAgICAgICkKICAgICAgICAgKGFsbG93IGlva2l0 LWV4dGVybmFsLW1ldGhvZAotI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0g MTIwMDAwCisjaWYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMjAwMDAgJiYg X19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA8IDEzMDAwMAogICAgICAgICAgICAgKGlv a2l0LW1ldGhvZC1udW1iZXIKICAgICAgICAgICAgICAgICAwCiAgICAgICAgICAgICAgICAgMQpA QCAtMTczLDcgKzE3Myw3IEBACiAgICAgICAgICAgICApCiAjZW5kaWYKICAgICAgICAgKQotI2lm IF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTIwMDAwCisjaWYgX19NQUNfT1Nf WF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMjAwMDAgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01J Tl9SRVFVSVJFRCA8IDEzMDAwMAogICAgICAgICAoaWYgKGVxdWFsPyAocGFyYW0gIkNQVSIpICJh cm02NCIpCiAgICAgICAgICAgICAoYWxsb3cgaW9raXQtZXh0ZXJuYWwtbWV0aG9kCiAgICAgICAg ICAgICAgICAgKGlva2l0LW1ldGhvZC1udW1iZXIK