227558 2021-06-30 18:07:55 -0700 BytecodeGenerator should emit is_null in more places 2021-07-14 11:46:03 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID InRadar P2 Normal --- 1 keith_miller keith_miller ews-watchlist mark.lam msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1773962 0 keith_miller 2021-06-30 18:07:55 -0700 BytecodeGenerator should emit is_null and is_undefined in more places 1773965 1 432648 keith_miller 2021-06-30 18:20:57 -0700 Created attachment 432648 Patch 1773966 2 432648 ysuzuki 2021-06-30 18:23:50 -0700 Comment on attachment 432648 Patch I think this is intentional: OpEqNull also checks masquerade-as-undefined while strict-eq-jsnull doesn't. 1773967 3 keith_miller 2021-06-30 18:28:05 -0700 (In reply to Yusuke Suzuki from comment #2) > Comment on attachment 432648 [details] > Patch > > I think this is intentional: OpEqNull also checks masquerade-as-undefined > while strict-eq-jsnull doesn't. Ah, I'm surprised we don't have a test for this... 1773991 4 mark.lam 2021-06-30 21:19:31 -0700 (In reply to Keith Miller from comment #3) > (In reply to Yusuke Suzuki from comment #2) > > Comment on attachment 432648 [details] > > Patch > > > > I think this is intentional: OpEqNull also checks masquerade-as-undefined > > while strict-eq-jsnull doesn't. > > Ah, I'm surprised we don't have a test for this... Do we have one in testapi? 1775562 5 webkit-bug-importer 2021-07-07 18:08:20 -0700 <rdar://problem/80298794> 432648 2021-06-30 18:20:57 -0700 2021-07-10 14:23:03 -0700 Patch bug-227558-20210630212056.patch text/plain 1995 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MzUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh MTA1ZjVkOWI1Nzg3ZmViNzE5Mzc1ZWZhMWNkMmExODA4NTc1OTk0Li5jM2EyNTI0MDYyOTc5NGFm YmI2MDUwZjEzMzc0NWNkM2JiMGNhMjUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMS0wNi0zMCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBCeXRlY29kZUdlbmVyYXRvciBzaG91bGQgZW1pdCBpc19udWxsIGlu IG1vcmUgcGxhY2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjc1NTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBVbmZvcnR1bmF0ZWx5LCB3ZSBkb24ndCBoYXZlIGFuIG9wX2lzX3VuZGVmaW5lZCBzbyB3 ZSBjYW5ub3QKKyAgICAgICAgdXNlIHRoZSBzYW1lIGlkZWEgZm9yIGVtaXRJc1VuZGVmaW5lZC4K KworICAgICAgICAqIGJ5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5oOgorICAgICAgICAo SlNDOjpCeXRlY29kZUdlbmVyYXRvcjo6ZW1pdElzTnVsbCk6CisKIDIwMjEtMDYtMjggIE1pa2hh aWwgUi4gR2FkZWxoYSAgPG1pa2hhaWxAaWdhbGlhLmNvbT4KIAogICAgICAgICBBZGQgTExJbnQg ZmFzdCBwYXRoIGZvciBsZXNzLCBsZXNzZXEsIGdyZWF0ZXIgYW5kIGdyZWF0ZXJlcQpkaWZmIC0t Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRv ci5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRv ci5oCmluZGV4IDUyZmRjNGViNjM5YjFhNGQzNGZlOWQyZTg0N2UzNDI1ZmIxMjlmZTMuLjY1OGYz NzQ2M2ZlZjhjOGEzZTE0ZjlhNmNjZDdmMzkyMjI0MmI0YmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuaAorKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmgKQEAgLTk1 Nyw3ICs5NTcsNyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgUmVnaXN0ZXJJRCogZW1pdElz Q2FsbGFibGUoUmVnaXN0ZXJJRCogZHN0LCBSZWdpc3RlcklEKiBzcmMpOwogICAgICAgICBSZWdp c3RlcklEKiBlbWl0SXNDb25zdHJ1Y3RvcihSZWdpc3RlcklEKiBkc3QsIFJlZ2lzdGVySUQqIHNy Yyk7CiAgICAgICAgIFJlZ2lzdGVySUQqIGVtaXRJc051bWJlcihSZWdpc3RlcklEKiBkc3QsIFJl Z2lzdGVySUQqIHNyYyk7Ci0gICAgICAgIFJlZ2lzdGVySUQqIGVtaXRJc051bGwoUmVnaXN0ZXJJ RCogZHN0LCBSZWdpc3RlcklEKiBzcmMpIHsgcmV0dXJuIGVtaXRFcXVhbGl0eU9wPE9wU3RyaWN0 ZXE+KGRzdCwgc3JjLCBlbWl0TG9hZChudWxscHRyLCBqc051bGwoKSkpOyB9CisgICAgICAgIFJl Z2lzdGVySUQqIGVtaXRJc051bGwoUmVnaXN0ZXJJRCogZHN0LCBSZWdpc3RlcklEKiBzcmMpIHsg cmV0dXJuIGVtaXRVbmFyeU9wPE9wRXFOdWxsPihkc3QsIHNyYyk7IH0KICAgICAgICAgUmVnaXN0 ZXJJRCogZW1pdElzVW5kZWZpbmVkKFJlZ2lzdGVySUQqIGRzdCwgUmVnaXN0ZXJJRCogc3JjKSB7 IHJldHVybiBlbWl0RXF1YWxpdHlPcDxPcFN0cmljdGVxPihkc3QsIHNyYywgZW1pdExvYWQobnVs bHB0ciwganNVbmRlZmluZWQoKSkpOyB9CiAgICAgICAgIFJlZ2lzdGVySUQqIGVtaXRJc1VuZGVm aW5lZE9yTnVsbChSZWdpc3RlcklEKiBkc3QsIFJlZ2lzdGVySUQqIHNyYyk7CiAgICAgICAgIFJl Z2lzdGVySUQqIGVtaXRJc0VtcHR5KFJlZ2lzdGVySUQqIGRzdCwgUmVnaXN0ZXJJRCogc3JjKTsK