227554 2021-06-30 16:24:26 -0700 ARM64: Disable selection of BFI instruction variants by default. 2021-06-30 16:37:33 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1773931 0 mark.lam 2021-06-30 16:24:26 -0700 We suspect that this may have cause some hangs. Disabling while we investigate. rdar://79978150 1773933 1 432643 mark.lam 2021-06-30 16:29:42 -0700 Created attachment 432643 proposed patch. 1773935 2 mark.lam 2021-06-30 16:37:07 -0700 Thanks for the review. Landed in r279441: <http://trac.webkit.org/r279441>. 432643 2021-06-30 16:29:42 -0700 2021-06-30 16:31:07 -0700 proposed patch. bug-227554.patch text/plain 3960 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjc5NDQwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDIxLTA2LTMwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB Uk02NDogRGlzYWJsZSBzZWxlY3Rpb24gb2YgQkZJIGluc3RydWN0aW9uIHZhcmlhbnRzIGJ5IGRl ZmF1bHQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y Mjc1NTQKKyAgICAgICAgcmRhcjovLzc5OTc4MTUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ugc3VzcGVjdCB0aGF0IHRoaXMgbWF5IGhhdmUgY2F1 c2VkIHNvbWUgaGFuZ3MuICBEaXNhYmxpbmcgd2hpbGUgd2UgaW52ZXN0aWdhdGUuCisKKyAgICAg ICAgKiBiMy9CM0xvd2VyVG9BaXIuY3BwOgorICAgICAgICAqIGIzL3Rlc3RiM18yLmNwcDoKKyAg ICAgICAgKHRlc3RJbnNlcnRCaXRGaWVsZDMyKToKKyAgICAgICAgKHRlc3RJbnNlcnRCaXRGaWVs ZDY0KToKKyAgICAgICAgKiBydW50aW1lL09wdGlvbnNMaXN0Lmg6CisKIDIwMjEtMDYtMjkgIEpv b25naHVuIFBhcmsgIDxqaDcxOC5wYXJrQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFJlbW92ZSAi ZnVuY3Rpb24gZGVjbGFyZWQg4oCYc3RhdGlj4oCZIGJ1dCBuZXZlciBkZWZpbmVkIiBidWlsZCB3 YXJuaW5ncyBzaW5jZSByMjc4OTcxLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL0Iz TG93ZXJUb0Fpci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL0Iz TG93ZXJUb0Fpci5jcHAJKHJldmlzaW9uIDI3OTQ0MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9iMy9CM0xvd2VyVG9BaXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNzY0LDYgKzI3NjQsOCBA QCBwcml2YXRlOgogICAgICAgICAgICAgLy8gVUJGWCBQYXR0ZXJuOiBkZXN0ID0gKHNyYyA+PiBs c2IpICYgbWFzayAKICAgICAgICAgICAgIC8vIFdoZXJlOiBtYXNrID0gKDEgPDwgd2lkdGgpIC0g MQogICAgICAgICAgICAgYXV0byB0cnlBcHBlbmRVQkZYID0gWyZdICgpIC0+IGJvb2wgeworICAg ICAgICAgICAgICAgIGlmICghT3B0aW9uczo6dXNlQkZJKCkpCisgICAgICAgICAgICAgICAgICAg IHJldHVybiBmYWxzZTsKICAgICAgICAgICAgICAgICBBaXI6Ok9wY29kZSBvcGNvZGUgPSBvcGNv ZGVGb3JUeXBlKEV4dHJhY3RVbnNpZ25lZEJpdGZpZWxkMzIsIEV4dHJhY3RVbnNpZ25lZEJpdGZp ZWxkNjQsIG1fdmFsdWUtPnR5cGUoKSk7CiAgICAgICAgICAgICAgICAgaWYgKCFpc1ZhbGlkRm9y bShvcGNvZGUsIEFyZzo6VG1wLCBBcmc6OkltbSwgQXJnOjpJbW0sIEFyZzo6VG1wKSkgCiAgICAg ICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKQEAgLTI4MjYsNiArMjgyOCw4IEBAIHByaXZh dGU6CiAgICAgICAgICAgICAvLyBXaGVyZTogbWFzazEgPSAoKDEgPDwgd2lkdGgpIC0gMSkKICAg ICAgICAgICAgIC8vICAgICAgICBtYXNrMiA9IH4obWFzazEgPDwgbHNiKQogICAgICAgICAgICAg YXV0byB0cnlBcHBlbmRCRkkgPSBbJl0gKFZhbHVlKiBsZWZ0LCBWYWx1ZSogcmlnaHQpIC0+IGJv b2wgeworICAgICAgICAgICAgICAgIGlmICghT3B0aW9uczo6dXNlQkZJKCkpCisgICAgICAgICAg ICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAgICAgICAgICBBaXI6Ok9wY29kZSBvcGNv ZGUgPSBvcGNvZGVGb3JUeXBlKEluc2VydEJpdEZpZWxkMzIsIEluc2VydEJpdEZpZWxkNjQsIG1f dmFsdWUtPnR5cGUoKSk7CiAgICAgICAgICAgICAgICAgaWYgKCFpc1ZhbGlkRm9ybShvcGNvZGUs IEFyZzo6VG1wLCBBcmc6OkltbSwgQXJnOjpJbW0sIEFyZzo6VG1wKSkgCiAgICAgICAgICAgICAg ICAgICAgIHJldHVybiBmYWxzZTsKQEAgLTMwMzAsNiArMzAzNCw4IEBAIHByaXZhdGU6CiAgICAg ICAgICAgICAvLyBTQkZJWiBQYXR0ZXJuOiBkID0gKChzcmMgPDwgYW1vdW50KSA+PiBhbW91bnQp IDw8IGxzYgogICAgICAgICAgICAgLy8gd2hlcmU6IGFtb3VudCA9IGRhdGFzaXplIC0gd2lkdGgK ICAgICAgICAgICAgIGF1dG8gdHJ5QXBwZW5kU0JGSVogPSBbJl0gKCkgLT4gYm9vbCB7CisgICAg ICAgICAgICAgICAgaWYgKCFPcHRpb25zOjp1c2VCRkkoKSkKKyAgICAgICAgICAgICAgICAgICAg cmV0dXJuIGZhbHNlOwogICAgICAgICAgICAgICAgIEFpcjo6T3Bjb2RlIG9wY29kZSA9IG9wY29k ZUZvclR5cGUoSW5zZXJ0U2lnbmVkQml0ZmllbGRJblplcm8zMiwgSW5zZXJ0U2lnbmVkQml0Zmll bGRJblplcm82NCwgbV92YWx1ZS0+dHlwZSgpKTsKICAgICAgICAgICAgICAgICBpZiAoIWlzVmFs aWRGb3JtKG9wY29kZSwgQXJnOjpUbXAsIEFyZzo6SW1tLCBBcmc6OkltbSwgQXJnOjpUbXApKQog ICAgICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvYjMvdGVzdGIzXzIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9iMy90ZXN0YjNfMi5jcHAJKHJldmlzaW9uIDI3OTQ0MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9iMy90ZXN0YjNfMi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMxNjAsNiArMzE2MCw4IEBA IHZvaWQgdGVzdFViZml6NjRBbmRTaGlmdCgpCiAKIHZvaWQgdGVzdEluc2VydEJpdEZpZWxkMzIo KQogeworICAgIGlmICghSlNDOjpPcHRpb25zOjp1c2VCRkkoKSkKKyAgICAgICAgcmV0dXJuOwog ICAgIGlmIChKU0M6Ok9wdGlvbnM6OmRlZmF1bHRCM09wdExldmVsKCkgPCAyKQogICAgICAgICBy ZXR1cm47CiAgICAgdWludDMyX3QgZCA9IDB4ZjBmMGYwZjA7CkBAIC0zMjM4LDYgKzMyNDAsOCBA QCB2b2lkIHRlc3RJbnNlcnRCaXRGaWVsZDMyKCkKIAogdm9pZCB0ZXN0SW5zZXJ0Qml0RmllbGQ2 NCgpCiB7CisgICAgaWYgKCFKU0M6Ok9wdGlvbnM6OnVzZUJGSSgpKQorICAgICAgICByZXR1cm47 CiAgICAgaWYgKEpTQzo6T3B0aW9uczo6ZGVmYXVsdEIzT3B0TGV2ZWwoKSA8IDIpCiAgICAgICAg IHJldHVybjsKICAgICB1aW50NjRfdCBkID0gMHhmMGYwZjBmMGYwZjBmMGYwOwpJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9uc0xpc3QuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9PcHRpb25zTGlzdC5oCShyZXZpc2lvbiAyNzk0 NDApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9PcHRpb25zTGlzdC5oCSh3b3Jr aW5nIGNvcHkpCkBAIC01NDgsNiArNTQ4LDcgQEAgYm9vbCBjYW5Vc2VXZWJBc3NlbWJseUZhc3RN ZW1vcnkoKTsKICAgICB2KEJvb2wsIHZlcmJvc2VFeGVjdXRhYmxlUG9vbEFsbG9jYXRpb24sIGZh bHNlLCBOb3JtYWwsIG51bGxwdHIpIFwKICAgICB2KEJvb2wsIHVzZURhdGFJQywgaXNBUk02NCgp LCBOb3JtYWwsIG51bGxwdHIpIFwKICAgICB2KEJvb2wsIHVzZURhdGFJQ0luT3B0aW1pemluZ0pJ VCwgZmFsc2UsIE5vcm1hbCwgbnVsbHB0cikgXAorICAgIHYoQm9vbCwgdXNlQkZJLCBmYWxzZSwg Tm9ybWFsLCAiQWxsb3cgQVJNNjQgaW5zdHJ1Y3Rpb24gc2VsZWN0aW9uIG9mIEJGSSIpIFwKIAog CiBlbnVtIE9wdGlvbkVxdWl2YWxlbmNlIHsK