227549 2021-06-30 15:28:53 -0700 [results.webkit.org] linkify urls in commit messages 2021-07-13 10:05:48 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 kevin_neal kevin_neal jbedard kevin_neal webkit-bug-importer zhifei_fang oldest_to_newest 1773906 0 kevin_neal 2021-06-30 15:28:53 -0700 Commit messages usually contain URLs pointing to the bug; however, the URLs do not have hyperlinks to the bug. 1773909 1 webkit-bug-importer 2021-06-30 15:30:36 -0700 <rdar://problem/79988762> 1773922 2 432638 kevin_neal 2021-06-30 16:02:46 -0700 Created attachment 432638 Patch 1776018 3 433222 kevin_neal 2021-07-09 10:07:20 -0700 Created attachment 433222 Patch 1776045 4 433222 zhifei_fang 2021-07-09 11:32:48 -0700 Comment on attachment 433222 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433222&action=review > Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/commit.js:122 > + let linkify = (function(commitMessage) { better to make this a top level function, not a IIFE. If you put the code here, actually there is no need for have a IIFE. Originally line 117 we used the IIFE for making javascript string template can support normal js statements not just expressions. > Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/commit.js:123 > + let reg = /\b(https?|rdar):\/{2}[^\s<>&]+/gmi; May also need to consider http, and I am not sure if we have some links without leading protocol, may worth to find if they are existed. > Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/commit.js:125 > + let newMessageText = messageText.replace(reg, `<a href="$&">$&</a>`); It will be better to open a new tab, add target="_blank" 1776335 5 433222 jbedard 2021-07-12 08:42:30 -0700 Comment on attachment 433222 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433222&action=review >> Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/commit.js:123 >> + let reg = /\b(https?|rdar):\/{2}[^\s<>&]+/gmi; > > May also need to consider http, and I am not sure if we have some links without leading protocol, may worth to find if they are existed. Existing code does consider http, I think, the regex is `https?` which should match http and https 1776475 6 433366 kevin_neal 2021-07-12 15:53:06 -0700 Created attachment 433366 Patch 1776477 7 433366 jbedard 2021-07-12 16:02:45 -0700 Comment on attachment 433366 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433366&action=review > Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/commit.js:121 > return `<br><div>${escapeHTML(cell.commit.message.split('\n')[0])}</div>`; We should lankily this text as well, in case someone has a link in the first line > Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/commit.js:122 > + return linkify(escapeHTML(cell.commit.message)); We still want to keep the `<br><div></div>` surrounding this text 1776644 8 433409 kevin_neal 2021-07-13 09:24:30 -0700 Created attachment 433409 Patch 1776645 9 433410 kevin_neal 2021-07-13 09:32:23 -0700 Created attachment 433410 fast-cq Patch 1776659 10 ews-feeder 2021-07-13 10:05:48 -0700 Committed r279876 (239629@main): <https://commits.webkit.org/239629@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433410. 432638 2021-06-30 16:02:46 -0700 2021-07-09 10:07:16 -0700 Patch bug-227549-20210630190245.patch text/plain 2090 kevin_neal U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MzgxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTJlNzRlMzQ3MzhiYmIzM2QwMWI2NjNkY2NlNjBiNWYx NGQ0NWY3NS4uNWRmM2IwM2VhNmViYjczYWFkMzBmMzA1MjA0MzllMjczYTRhOGRmNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDIxLTA2LTMwICBLZXZpbiBOZWFsICA8a2V2aW5fbmVhbEBhcHBsZS5jb20+CisKKyAg ICAgICAgW3Jlc3VsdHMud2Via2l0Lm9yZ10gbGlua2lmeSB1cmxzIGluIGNvbW1pdCBtZXNzYWdl cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI3NTQ5 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83OTk4ODc2Mj4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXb3JrIGluIHByb2dyZXNzLgorCisgICAgICAg ICogU2NyaXB0cy9saWJyYXJpZXMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvdmlldy9zdGF0aWMv anMvY29tbWl0LmpzOgorICAgICAgICAodGhlYWQudGJvZHkucm93cy5tYXAuKToKKyAgICAgICAg KHRoZWFkLnRib2R5LnJvd3MubWFwKToKKyAgICAgICAgKENvbW1pdFRhYmxlKToKKwogMjAyMS0w Ni0yOSAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAgW3dl YmtpdGNvcmVweV0gQWRkIE5lc3RlZEZ1enp5RGljdApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy9saWJyYXJpZXMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvdmlldy9zdGF0aWMvanMvY29tbWl0 LmpzIGIvVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvdmll dy9zdGF0aWMvanMvY29tbWl0LmpzCmluZGV4IDJkZTVlOGNiZmU3NDJlYTM2OTMzZmYzN2E0MmEw MTZhOTdkOWM4M2UuLmI0YzA3YTdhOGI4MDZjMGJmYzBkZDdmZjUyNWEzNTY0OTFhY2IyZTQgMTAw NjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5 L3ZpZXcvc3RhdGljL2pzL2NvbW1pdC5qcworKysgYi9Ub29scy9TY3JpcHRzL2xpYnJhcmllcy9y ZXN1bHRzZGJweS9yZXN1bHRzZGJweS92aWV3L3N0YXRpYy9qcy9jb21taXQuanMKQEAgLTExOSw3 ICsxMTksMTAgQEAgZnVuY3Rpb24gQ29tbWl0VGFibGUoY29tbWl0cywgcmVwb3NpdG9yeUlkcyA9 IFtdLCBvbmVMaW5lID0gZmFsc2UpIHsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg cmV0dXJuICcnOwogICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlmIChvbmVMaW5lKQogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gYDxicj48ZGl2PiR7ZXNjYXBlSFRN TChjZWxsLmNvbW1pdC5tZXNzYWdlLnNwbGl0KCdcbicpWzBdKX08L2Rpdj5gOwotICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHJldHVybiBgPGJyPjxkaXY+JHtlc2NhcGVIVE1MKGNlbGwuY29t bWl0Lm1lc3NhZ2UpfTwvZGl2PmA7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgLy9yZXR1 cm4gYDxicj48ZGl2PiR7ZXNjYXBlSFRNTChjZWxsLmNvbW1pdC5tZXNzYWdlKX08L2Rpdj5gOwor ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiBgPGJyPjxkaXY+JHtlc2NhcGVIVE1M KGNlbGwuY29tbWl0Lm1lc3NhZ2Uuc3BsaXQoJ1xuJylbMF0pfTwvZGl2Pjxicj4KKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgPGRpdj48YSBocmVmPSIke2VzY2FwZUhUTUwoY2VsbC5j b21taXQubWVzc2FnZS5zcGxpdCgnXG4nKVsxXSl9Ij4ke2VzY2FwZUhUTUwoY2VsbC5jb21taXQu bWVzc2FnZS5zcGxpdCgnXG4nKVsxXSl9PC9hPjwvZGl2PgorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICA8YnI+PGRpdj4ke2VzY2FwZUhUTUwoY2VsbC5jb21taXQubWVzc2FnZSl9PC9k aXY+YDsKICAgICAgICAgICAgICAgICAgICAgICAgIH0oKX0KICAgICAgICAgICAgICAgICAgICAg PC90ZD5gOwogICAgICAgICAgICAgICAgIH0pLmpvaW4oJycpfQo= 433222 2021-07-09 10:07:20 -0700 2021-07-12 15:53:04 -0700 Patch bug-227549-20210709130718.patch text/plain 2198 kevin_neal U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5Nzg3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWUyNDk0MDQzZDhiZmY3MTFmYjJiMjczZjIwMTE2MDQ2 N2RjZGY3Yi4uMzZiYmJjYzlmYjhlNWViYTc3YTAyN2M2NWYzNzYyMWU2NmU5YWRkOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDIxLTA3LTA5ICBLZXZpbiBOZWFsICA8a2V2aW5fbmVhbEBhcHBsZS5jb20+CisKKyAg ICAgICAgW3Jlc3VsdHMud2Via2l0Lm9yZ10gbGlua2lmeSB1cmxzIGluIGNvbW1pdCBtZXNzYWdl cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI3NTQ5 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83OTk4ODc2Mj4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvbGlicmFyaWVzL3Jlc3VsdHNk YnB5L3Jlc3VsdHNkYnB5L3ZpZXcvc3RhdGljL2pzL2NvbW1pdC5qczoKKyAgICAgICAgKHRoZWFk LnRib2R5LnJvd3MubWFwLik6CisgICAgICAgICh0aGVhZC50Ym9keS5yb3dzLm1hcCk6CisgICAg ICAgIChDb21taXRUYWJsZSk6CisKIDIwMjEtMDctMDkgIENhcmxvcyBBbGJlcnRvIExvcGV6IFBl cmV6ICA8Y2xvcGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgW3dlYmtpdGNvcmVweV0gcnVuLXdl YmtpdC10ZXN0cyBtYXkgaGFuZyB3aXRoIHB5dGhvbjIgYWZ0ZXIgcjI3MTY4MwpkaWZmIC0tZ2l0 IGEvVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvdmlldy9z dGF0aWMvanMvY29tbWl0LmpzIGIvVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvcmVzdWx0c2RicHkv cmVzdWx0c2RicHkvdmlldy9zdGF0aWMvanMvY29tbWl0LmpzCmluZGV4IDJkZTVlOGNiZmU3NDJl YTM2OTMzZmYzN2E0MmEwMTZhOTdkOWM4M2UuLmZkODllOWE4YjRmNGJjMmM0YzM4ZDM0N2UxMGFh NzE5NTFkOTFjMmYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3Jlc3VsdHNk YnB5L3Jlc3VsdHNkYnB5L3ZpZXcvc3RhdGljL2pzL2NvbW1pdC5qcworKysgYi9Ub29scy9TY3Jp cHRzL2xpYnJhcmllcy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS92aWV3L3N0YXRpYy9qcy9jb21t aXQuanMKQEAgLTExOSw3ICsxMTksMTMgQEAgZnVuY3Rpb24gQ29tbWl0VGFibGUoY29tbWl0cywg cmVwb3NpdG9yeUlkcyA9IFtdLCBvbmVMaW5lID0gZmFsc2UpIHsKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgcmV0dXJuICcnOwogICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlm IChvbmVMaW5lKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gYDxicj48 ZGl2PiR7ZXNjYXBlSFRNTChjZWxsLmNvbW1pdC5tZXNzYWdlLnNwbGl0KCdcbicpWzBdKX08L2Rp dj5gOwotICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiBgPGJyPjxkaXY+JHtlc2Nh cGVIVE1MKGNlbGwuY29tbWl0Lm1lc3NhZ2UpfTwvZGl2PmA7CisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgbGV0IGxpbmtpZnkgPSAoZnVuY3Rpb24oY29tbWl0TWVzc2FnZSkgeworICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBsZXQgcmVnID0gL1xiKGh0dHBzP3xyZGFyKTpcL3sy fVteXHM8PiZdKy9nbWk7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxldCBtZXNz YWdlVGV4dCA9IGAke2VzY2FwZUhUTUwoY2VsbC5jb21taXQubWVzc2FnZSl9YDsKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgbGV0IG5ld01lc3NhZ2VUZXh0ID0gbWVzc2FnZVRleHQu cmVwbGFjZShyZWcsIGA8YSBocmVmPSIkJiI+JCY8L2E+YCk7CisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICByZXR1cm4gYDxicj48ZGl2PiR7bmV3TWVzc2FnZVRleHR9PC9kaXY+ YDsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICB9KGVzY2FwZUhUTUwoY2VsbC5jb21taXQu bWVzc2FnZSkpKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gbGlua2lmeTsK ICAgICAgICAgICAgICAgICAgICAgICAgIH0oKX0KICAgICAgICAgICAgICAgICAgICAgPC90ZD5g OwogICAgICAgICAgICAgICAgIH0pLmpvaW4oJycpfQo= 433366 2021-07-12 15:53:06 -0700 2021-07-13 09:24:27 -0700 Patch bug-227549-20210712185305.patch text/plain 3108 kevin_neal U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5ODUzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTFkNjVmOWIzZDRkM2E5NTg1NTcwMGNhZDA3ZGJhNzk5 MmY5YzM1MC4uOWZkYWMwYmY1ODBhYjMwYzk1NjhjZTQ3ZjE3OTk5ZWU4MzJmOWZkYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDIxLTA3LTA5ICBLZXZpbiBOZWFsICA8a2V2aW5fbmVhbEBhcHBsZS5jb20+CisKKyAg ICAgICAgW3Jlc3VsdHMud2Via2l0Lm9yZ10gbGlua2lmeSB1cmxzIGluIGNvbW1pdCBtZXNzYWdl cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI3NTQ5 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83OTk4ODc2Mj4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvbGlicmFyaWVzL3Jlc3VsdHNk YnB5L3Jlc3VsdHNkYnB5L3ZpZXcvc3RhdGljL2pzL2NvbW1pdC5qczoKKyAgICAgICAgKHRoZWFk LnRib2R5LnJvd3MubWFwLik6CisgICAgICAgICh0aGVhZC50Ym9keS5yb3dzLm1hcCk6CisgICAg ICAgIChDb21taXRUYWJsZSk6CisKIDIwMjEtMDctMTIgIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRh cmRAYXBwbGUuY29tPgogCiAgICAgICAgIFtydW4tYXBpLXRlc3RzXSBVc2UgUHl0aG9uIDMgKFBh cnQgMSkKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3Jlc3VsdHNkYnB5L3Jl c3VsdHNkYnB5L3ZpZXcvc3RhdGljL2pzL2NvbW1pdC5qcyBiL1Rvb2xzL1NjcmlwdHMvbGlicmFy aWVzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L3ZpZXcvc3RhdGljL2pzL2NvbW1pdC5qcwppbmRl eCAyZGU1ZThjYmZlNzQyZWEzNjkzM2ZmMzdhNDJhMDE2YTk3ZDljODNlLi4zOTAyNWJiZmYyMjQ2 OWVlOTkxMmQzMzQ5NWZhYTAwZDgxNjI2NDliIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL2xp YnJhcmllcy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS92aWV3L3N0YXRpYy9qcy9jb21taXQuanMK KysrIGIvVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvdmll dy9zdGF0aWMvanMvY29tbWl0LmpzCkBAIC0yMSw3ICsyMSw3IEBACiAvLyBBUklTSU5HIElOIEFO WSBXQVkgT1VUIE9GIFRIRSBVU0UgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9G CiAvLyBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAKLWltcG9ydCB7RXJyb3JEaXNw bGF5LCBlc2NhcGVIVE1MLCBwYXJhbXNUb1F1ZXJ5LCBxdWVyeVRvUGFyYW1zfSBmcm9tICcvYXNz ZXRzL2pzL2NvbW1vbi5qcyc7CitpbXBvcnQge0Vycm9yRGlzcGxheSwgZXNjYXBlSFRNTCwgbGlu a2lmeSwgcGFyYW1zVG9RdWVyeSwgcXVlcnlUb1BhcmFtc30gZnJvbSAnL2Fzc2V0cy9qcy9jb21t b24uanMnOwogCiBjb25zdCBUSU1FU1RBTVBfVE9fVVVJRF9NVUxUSVBMSUVSID0gMTAwOwogCkBA IC0xMTksNyArMTE5LDcgQEAgZnVuY3Rpb24gQ29tbWl0VGFibGUoY29tbWl0cywgcmVwb3NpdG9y eUlkcyA9IFtdLCBvbmVMaW5lID0gZmFsc2UpIHsKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgcmV0dXJuICcnOwogICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlmIChvbmVMaW5l KQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gYDxicj48ZGl2PiR7ZXNj YXBlSFRNTChjZWxsLmNvbW1pdC5tZXNzYWdlLnNwbGl0KCdcbicpWzBdKX08L2Rpdj5gOwotICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiBgPGJyPjxkaXY+JHtlc2NhcGVIVE1MKGNl bGwuY29tbWl0Lm1lc3NhZ2UpfTwvZGl2PmA7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAg cmV0dXJuIGxpbmtpZnkoZXNjYXBlSFRNTChjZWxsLmNvbW1pdC5tZXNzYWdlKSk7CiAgICAgICAg ICAgICAgICAgICAgICAgICB9KCl9CiAgICAgICAgICAgICAgICAgICAgIDwvdGQ+YDsKICAgICAg ICAgICAgICAgICB9KS5qb2luKCcnKX0KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvbGlicmFy aWVzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L3ZpZXcvc3RhdGljL2pzL2NvbW1vbi5qcyBiL1Rv b2xzL1NjcmlwdHMvbGlicmFyaWVzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L3ZpZXcvc3RhdGlj L2pzL2NvbW1vbi5qcwppbmRleCA5ZWNjZjFjYTMzNGMyMDA2ZWZhZWI1ZjBjMzY2NDlmMWRkOGU4 YTc1Li40NWNkNjY0MGM5ODIxYjQyOGZiM2Y3ODkyMTUxZjJjYmI2NGE2YjFjIDEwMDY0NAotLS0g YS9Ub29scy9TY3JpcHRzL2xpYnJhcmllcy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS92aWV3L3N0 YXRpYy9qcy9jb21tb24uanMKKysrIGIvVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvcmVzdWx0c2Ri cHkvcmVzdWx0c2RicHkvdmlldy9zdGF0aWMvanMvY29tbW9uLmpzCkBAIC0xMzksNiArMTM5LDEw IEBAIGZ1bmN0aW9uIGVzY2FwZUhUTUwodGV4dCkgewogICB9KTsKIH0KIAorZnVuY3Rpb24gbGlu a2lmeSh0ZXh0KSB7CisgICAgcmV0dXJuIHRleHQucmVwbGFjZSgvXGIoaHR0cHM/fHJkYXIpOlwv ezJ9W15cczw+Jl0rW15cLlxzPD4mXS9nbWksIGA8YSBocmVmPSIkJiIgdGFyZ2V0PSJfYmxhbmsi PiQmPC9hPmApOworfQorCiBmdW5jdGlvbiBkZWVwQ29tcGFyZShhLCBiKSB7CiAgICAgaWYgKGEg PT09IGIpCiAgICAgICAgIHJldHVybiB0cnVlOwpAQCAtMTkzLDQgKzE5Nyw0IEBAIGZ1bmN0aW9u IGVsYXBzZWRUaW1lKHN0YXJ0VGltZXN0YW1wLCBlbmRUaW1lc3RhbXApCiAgICAgcmV0dXJuIHJl c3VsdDsKIH0KIAotZXhwb3J0IHtkZWVwQ29tcGFyZSwgRXJyb3JEaXNwbGF5LCBxdWVyeVRvUGFy YW1zLCBwYXJhbXNUb1F1ZXJ5LCBRdWVyeU1vZGlmaWVyLCBlc2NhcGVIVE1MLCBwZXJjZW50YWdl LCBlbGFwc2VkVGltZX07CitleHBvcnQge2RlZXBDb21wYXJlLCBFcnJvckRpc3BsYXksIHF1ZXJ5 VG9QYXJhbXMsIHBhcmFtc1RvUXVlcnksIFF1ZXJ5TW9kaWZpZXIsIGVzY2FwZUhUTUwsIGxpbmtp ZnksIHBlcmNlbnRhZ2UsIGVsYXBzZWRUaW1lfTsK 433409 2021-07-13 09:24:30 -0700 2021-07-13 09:32:21 -0700 Patch bug-227549-20210713122429.patch text/plain 3817 kevin_neal U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5ODcyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzQxMWJkYTdkNGQzZDRkNjBkYmU1N2MxZjJmYTk5Yzg0 YTU0OWYzMi4uOTM2Yjk3MGJjNTY5Y2IzZTFmYmE2YTFjM2ZjN2Q0NDA3MjRhZWM1YyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMw IEBACisyMDIxLTA3LTEzICBLZXZpbiBOZWFsICA8a2V2aW5fbmVhbEBhcHBsZS5jb20+CisKKyAg ICAgICAgW3Jlc3VsdHMud2Via2l0Lm9yZ10gbGlua2lmeSB1cmxzIGluIGNvbW1pdCBtZXNzYWdl cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI3NTQ5 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83OTk4ODc2Mj4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvbGlicmFyaWVzL3Jlc3VsdHNk YnB5L3Jlc3VsdHNkYnB5L3ZpZXcvc3RhdGljL2pzL2NvbW1pdC5qczoKKyAgICAgICAgKHRoZWFk LnRib2R5LnJvd3MubWFwLik6CisgICAgICAgICh0aGVhZC50Ym9keS5yb3dzLm1hcCk6CisgICAg ICAgIChDb21taXRUYWJsZSk6CisgICAgICAgICogU2NyaXB0cy9saWJyYXJpZXMvcmVzdWx0c2Ri cHkvcmVzdWx0c2RicHkvdmlldy9zdGF0aWMvanMvY29tbW9uLmpzOgorCisyMDIxLTA3LTA5ICBL ZXZpbiBOZWFsICA8a2V2aW5fbmVhbEBhcHBsZS5jb20+CisKKyAgICAgICAgW3Jlc3VsdHMud2Vi a2l0Lm9yZ10gbGlua2lmeSB1cmxzIGluIGNvbW1pdCBtZXNzYWdlcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI3NTQ5CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS83OTk4ODc2Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFNjcmlwdHMvbGlicmFyaWVzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L3Zp ZXcvc3RhdGljL2pzL2NvbW1pdC5qczoKKyAgICAgICAgKHRoZWFkLnRib2R5LnJvd3MubWFwLik6 CisgICAgICAgICh0aGVhZC50Ym9keS5yb3dzLm1hcCk6CisgICAgICAgIChDb21taXRUYWJsZSk6 CisKIDIwMjEtMDctMTMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCiAgICAgICAgIFtHVEtdW1dQRV0gRXhwb3NlIHN1cHBvcnQgZm9yIGNsaWVudCBjZXJ0aWZp Y2F0ZSBhdXRoCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2xpYnJhcmllcy9yZXN1bHRzZGJw eS9yZXN1bHRzZGJweS92aWV3L3N0YXRpYy9qcy9jb21taXQuanMgYi9Ub29scy9TY3JpcHRzL2xp YnJhcmllcy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS92aWV3L3N0YXRpYy9qcy9jb21taXQuanMK aW5kZXggMmRlNWU4Y2JmZTc0MmVhMzY5MzNmZjM3YTQyYTAxNmE5N2Q5YzgzZS4uYjRkMDVjMjI3 NjY1YmM4ODM3NmU3Y2UxNmMyMDY3ZWU0MjFmZjc2YSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0 cy9saWJyYXJpZXMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvdmlldy9zdGF0aWMvanMvY29tbWl0 LmpzCisrKyBiL1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5 L3ZpZXcvc3RhdGljL2pzL2NvbW1pdC5qcwpAQCAtMjEsNyArMjEsNyBAQAogLy8gQVJJU0lORyBJ TiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNF RCBPRgogLy8gVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogCi1pbXBvcnQge0Vycm9y RGlzcGxheSwgZXNjYXBlSFRNTCwgcGFyYW1zVG9RdWVyeSwgcXVlcnlUb1BhcmFtc30gZnJvbSAn L2Fzc2V0cy9qcy9jb21tb24uanMnOworaW1wb3J0IHtFcnJvckRpc3BsYXksIGVzY2FwZUhUTUws IGxpbmtpZnksIHBhcmFtc1RvUXVlcnksIHF1ZXJ5VG9QYXJhbXN9IGZyb20gJy9hc3NldHMvanMv Y29tbW9uLmpzJzsKIAogY29uc3QgVElNRVNUQU1QX1RPX1VVSURfTVVMVElQTElFUiA9IDEwMDsK IApAQCAtMTE4LDggKzExOCw4IEBAIGZ1bmN0aW9uIENvbW1pdFRhYmxlKGNvbW1pdHMsIHJlcG9z aXRvcnlJZHMgPSBbXSwgb25lTGluZSA9IGZhbHNlKSB7CiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgaWYgKCFjZWxsLmNvbW1pdC5tZXNzYWdlKQogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICByZXR1cm4gJyc7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaWYgKG9uZUxp bmUpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiBgPGJyPjxkaXY+JHtl c2NhcGVIVE1MKGNlbGwuY29tbWl0Lm1lc3NhZ2Uuc3BsaXQoJ1xuJylbMF0pfTwvZGl2PmA7Ci0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIGA8YnI+PGRpdj4ke2VzY2FwZUhUTUwo Y2VsbC5jb21taXQubWVzc2FnZSl9PC9kaXY+YDsKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgcmV0dXJuIGA8YnI+PGRpdj4ke2xpbmtpZnkoZXNjYXBlSFRNTChjZWxsLmNvbW1pdC5t ZXNzYWdlLnNwbGl0KCdcbicpWzBdKSl9PC9kdj5gOworICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHJldHVybiBgPGJyPjxkaXY+JHtsaW5raWZ5KGVzY2FwZUhUTUwoY2VsbC5jb21taXQubWVz c2FnZSkpfTwvZGl2PmA7CiAgICAgICAgICAgICAgICAgICAgICAgICB9KCl9CiAgICAgICAgICAg ICAgICAgICAgIDwvdGQ+YDsKICAgICAgICAgICAgICAgICB9KS5qb2luKCcnKX0KZGlmZiAtLWdp dCBhL1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L3ZpZXcv c3RhdGljL2pzL2NvbW1vbi5qcyBiL1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3Jlc3VsdHNkYnB5 L3Jlc3VsdHNkYnB5L3ZpZXcvc3RhdGljL2pzL2NvbW1vbi5qcwppbmRleCA5ZWNjZjFjYTMzNGMy MDA2ZWZhZWI1ZjBjMzY2NDlmMWRkOGU4YTc1Li4wZWMzOGE1ZmIyMTlhOTZhNjIxYTE0ZjVkNTli NWY2MzM3N2RmZDVkIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL2xpYnJhcmllcy9yZXN1bHRz ZGJweS9yZXN1bHRzZGJweS92aWV3L3N0YXRpYy9qcy9jb21tb24uanMKKysrIGIvVG9vbHMvU2Ny aXB0cy9saWJyYXJpZXMvcmVzdWx0c2RicHkvcmVzdWx0c2RicHkvdmlldy9zdGF0aWMvanMvY29t bW9uLmpzCkBAIC0xMzksNiArMTM5LDEwIEBAIGZ1bmN0aW9uIGVzY2FwZUhUTUwodGV4dCkgewog ICB9KTsKIH0KIAorZnVuY3Rpb24gbGlua2lmeSh0ZXh0KSB7CisgICAgcmV0dXJuIHRleHQucmVw bGFjZSgvXGIoaHR0cHM/fHJkYXIpOlwvezJ9W15cczw+Jl0rW15cLlxzPD4mLF0vZ21pLCBgPGEg aHJlZj0iJCYiIHRhcmdldD0iX2JsYW5rIj4kJjwvYT5gKTsKK30KKwogZnVuY3Rpb24gZGVlcENv bXBhcmUoYSwgYikgewogICAgIGlmIChhID09PSBiKQogICAgICAgICByZXR1cm4gdHJ1ZTsKQEAg LTE5Myw0ICsxOTcsNCBAQCBmdW5jdGlvbiBlbGFwc2VkVGltZShzdGFydFRpbWVzdGFtcCwgZW5k VGltZXN0YW1wKQogICAgIHJldHVybiByZXN1bHQ7CiB9CiAKLWV4cG9ydCB7ZGVlcENvbXBhcmUs IEVycm9yRGlzcGxheSwgcXVlcnlUb1BhcmFtcywgcGFyYW1zVG9RdWVyeSwgUXVlcnlNb2RpZmll ciwgZXNjYXBlSFRNTCwgcGVyY2VudGFnZSwgZWxhcHNlZFRpbWV9OworZXhwb3J0IHtkZWVwQ29t cGFyZSwgRXJyb3JEaXNwbGF5LCBxdWVyeVRvUGFyYW1zLCBwYXJhbXNUb1F1ZXJ5LCBRdWVyeU1v ZGlmaWVyLCBlc2NhcGVIVE1MLCBsaW5raWZ5LCBwZXJjZW50YWdlLCBlbGFwc2VkVGltZX07Cg== 433410 2021-07-13 09:32:23 -0700 2021-07-13 10:05:48 -0700 fast-cq Patch bug-227549-20210713123222.patch text/plain 3403 kevin_neal U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5ODcyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzQxMWJkYTdkNGQzZDRkNjBkYmU1N2MxZjJmYTk5Yzg0 YTU0OWYzMi4uODRkYjYwYmJkYzI4NmM1ZTdiYTNhYmNjODJjNDcyMzE5YmM4OWU2ZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDIxLTA3LTEzICBLZXZpbiBOZWFsICA8a2V2aW5fbmVhbEBhcHBsZS5jb20+CisKKyAg ICAgICAgW3Jlc3VsdHMud2Via2l0Lm9yZ10gbGlua2lmeSB1cmxzIGluIGNvbW1pdCBtZXNzYWdl cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI3NTQ5 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83OTk4ODc2Mj4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvbGlicmFyaWVzL3Jlc3VsdHNk YnB5L3Jlc3VsdHNkYnB5L3ZpZXcvc3RhdGljL2pzL2NvbW1pdC5qczoKKyAgICAgICAgKHRoZWFk LnRib2R5LnJvd3MubWFwLik6CisgICAgICAgICh0aGVhZC50Ym9keS5yb3dzLm1hcCk6CisgICAg ICAgIChDb21taXRUYWJsZSk6CisgICAgICAgICogU2NyaXB0cy9saWJyYXJpZXMvcmVzdWx0c2Ri cHkvcmVzdWx0c2RicHkvdmlldy9zdGF0aWMvanMvY29tbW9uLmpzOgorCisKIDIwMjEtMDctMTMg IENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtH VEtdW1dQRV0gRXhwb3NlIHN1cHBvcnQgZm9yIGNsaWVudCBjZXJ0aWZpY2F0ZSBhdXRoCmRpZmYg LS1naXQgYS9Ub29scy9TY3JpcHRzL2xpYnJhcmllcy9yZXN1bHRzZGJweS9yZXN1bHRzZGJweS92 aWV3L3N0YXRpYy9qcy9jb21taXQuanMgYi9Ub29scy9TY3JpcHRzL2xpYnJhcmllcy9yZXN1bHRz ZGJweS9yZXN1bHRzZGJweS92aWV3L3N0YXRpYy9qcy9jb21taXQuanMKaW5kZXggMmRlNWU4Y2Jm ZTc0MmVhMzY5MzNmZjM3YTQyYTAxNmE5N2Q5YzgzZS4uYjRkMDVjMjI3NjY1YmM4ODM3NmU3Y2Ux NmMyMDY3ZWU0MjFmZjc2YSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvcmVz dWx0c2RicHkvcmVzdWx0c2RicHkvdmlldy9zdGF0aWMvanMvY29tbWl0LmpzCisrKyBiL1Rvb2xz L1NjcmlwdHMvbGlicmFyaWVzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L3ZpZXcvc3RhdGljL2pz L2NvbW1pdC5qcwpAQCAtMjEsNyArMjEsNyBAQAogLy8gQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBP RiBUSEUgVVNFIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRgogLy8gVEhFIFBP U1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogCi1pbXBvcnQge0Vycm9yRGlzcGxheSwgZXNjYXBl SFRNTCwgcGFyYW1zVG9RdWVyeSwgcXVlcnlUb1BhcmFtc30gZnJvbSAnL2Fzc2V0cy9qcy9jb21t b24uanMnOworaW1wb3J0IHtFcnJvckRpc3BsYXksIGVzY2FwZUhUTUwsIGxpbmtpZnksIHBhcmFt c1RvUXVlcnksIHF1ZXJ5VG9QYXJhbXN9IGZyb20gJy9hc3NldHMvanMvY29tbW9uLmpzJzsKIAog Y29uc3QgVElNRVNUQU1QX1RPX1VVSURfTVVMVElQTElFUiA9IDEwMDsKIApAQCAtMTE4LDggKzEx OCw4IEBAIGZ1bmN0aW9uIENvbW1pdFRhYmxlKGNvbW1pdHMsIHJlcG9zaXRvcnlJZHMgPSBbXSwg b25lTGluZSA9IGZhbHNlKSB7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaWYgKCFjZWxs LmNvbW1pdC5tZXNzYWdlKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4g Jyc7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaWYgKG9uZUxpbmUpCi0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHJldHVybiBgPGJyPjxkaXY+JHtlc2NhcGVIVE1MKGNlbGwu Y29tbWl0Lm1lc3NhZ2Uuc3BsaXQoJ1xuJylbMF0pfTwvZGl2PmA7Ci0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgcmV0dXJuIGA8YnI+PGRpdj4ke2VzY2FwZUhUTUwoY2VsbC5jb21taXQubWVz c2FnZSl9PC9kaXY+YDsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIGA8 YnI+PGRpdj4ke2xpbmtpZnkoZXNjYXBlSFRNTChjZWxsLmNvbW1pdC5tZXNzYWdlLnNwbGl0KCdc bicpWzBdKSl9PC9kdj5gOworICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiBgPGJy PjxkaXY+JHtsaW5raWZ5KGVzY2FwZUhUTUwoY2VsbC5jb21taXQubWVzc2FnZSkpfTwvZGl2PmA7 CiAgICAgICAgICAgICAgICAgICAgICAgICB9KCl9CiAgICAgICAgICAgICAgICAgICAgIDwvdGQ+ YDsKICAgICAgICAgICAgICAgICB9KS5qb2luKCcnKX0KZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw dHMvbGlicmFyaWVzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L3ZpZXcvc3RhdGljL2pzL2NvbW1v bi5qcyBiL1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3Jlc3VsdHNkYnB5L3Jlc3VsdHNkYnB5L3Zp ZXcvc3RhdGljL2pzL2NvbW1vbi5qcwppbmRleCA5ZWNjZjFjYTMzNGMyMDA2ZWZhZWI1ZjBjMzY2 NDlmMWRkOGU4YTc1Li4wZWMzOGE1ZmIyMTlhOTZhNjIxYTE0ZjVkNTliNWY2MzM3N2RmZDVkIDEw MDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL2xpYnJhcmllcy9yZXN1bHRzZGJweS9yZXN1bHRzZGJw eS92aWV3L3N0YXRpYy9qcy9jb21tb24uanMKKysrIGIvVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMv cmVzdWx0c2RicHkvcmVzdWx0c2RicHkvdmlldy9zdGF0aWMvanMvY29tbW9uLmpzCkBAIC0xMzks NiArMTM5LDEwIEBAIGZ1bmN0aW9uIGVzY2FwZUhUTUwodGV4dCkgewogICB9KTsKIH0KIAorZnVu Y3Rpb24gbGlua2lmeSh0ZXh0KSB7CisgICAgcmV0dXJuIHRleHQucmVwbGFjZSgvXGIoaHR0cHM/ fHJkYXIpOlwvezJ9W15cczw+Jl0rW15cLlxzPD4mLF0vZ21pLCBgPGEgaHJlZj0iJCYiIHRhcmdl dD0iX2JsYW5rIj4kJjwvYT5gKTsKK30KKwogZnVuY3Rpb24gZGVlcENvbXBhcmUoYSwgYikgewog ICAgIGlmIChhID09PSBiKQogICAgICAgICByZXR1cm4gdHJ1ZTsKQEAgLTE5Myw0ICsxOTcsNCBA QCBmdW5jdGlvbiBlbGFwc2VkVGltZShzdGFydFRpbWVzdGFtcCwgZW5kVGltZXN0YW1wKQogICAg IHJldHVybiByZXN1bHQ7CiB9CiAKLWV4cG9ydCB7ZGVlcENvbXBhcmUsIEVycm9yRGlzcGxheSwg cXVlcnlUb1BhcmFtcywgcGFyYW1zVG9RdWVyeSwgUXVlcnlNb2RpZmllciwgZXNjYXBlSFRNTCwg cGVyY2VudGFnZSwgZWxhcHNlZFRpbWV9OworZXhwb3J0IHtkZWVwQ29tcGFyZSwgRXJyb3JEaXNw bGF5LCBxdWVyeVRvUGFyYW1zLCBwYXJhbXNUb1F1ZXJ5LCBRdWVyeU1vZGlmaWVyLCBlc2NhcGVI VE1MLCBsaW5raWZ5LCBwZXJjZW50YWdlLCBlbGFwc2VkVGltZX07Cg==