22754 2008-12-09 01:56:38 -0800 Keyboard shortcut for Element finder 2009-11-19 18:13:23 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P5 Enhancement --- 1 holster bweinstein bweinstein joepeck oldest_to_newest 101953 0 holster 2008-12-09 01:56:38 -0800 I wish the "Select an element in the page to inspect it" button (magnifier icon in the bottom toolbar) has a keyboard shortcut, similar to Firebug's cmd+shift+c. I bet for many web developers it is one of the most used function. Maybe the Develop menu could contain "Select element" item, so people were able to set a shortcut. 131780 1 joepeck 2009-07-14 18:11:55 -0700 Is this a Safari feature or a WebKit one? I have a feeling this is mostly going to be Safari that has to hook in. Maybe WebKit has to provide a hook? I'll see if I can get someone to mention what would need to be done. 165129 2 bweinstein 2009-11-19 15:41:48 -0800 This should be possible at the WebKit level, just like (Command/Control)-F takes you to the top right search of the Inspector. I'm not sure the shortcut to use here, maybe (Command/Control)-I, for inspect? 165130 3 bweinstein 2009-11-19 15:42:31 -0800 Or we could use Command-Shift-C, like Firebug users are used to. I can lay the groundwork, but some other opinions on this would be nice. 165143 4 bweinstein 2009-11-19 16:35:58 -0800 Since this is a request from Firebug switchers, probably should give them the shortcut they are used to - patch coming momentarily. 165146 5 43533 bweinstein 2009-11-19 16:38:24 -0800 Created attachment 43533 [PATCH] Fix 165167 6 bweinstein 2009-11-19 18:13:23 -0800 Landed in r51225. I'm not sure if we need to support a better shortcut that works more of the time, but I'll close the bug for now. 43533 2009-11-19 16:38:24 -0800 2009-11-19 17:56:42 -0800 [PATCH] Fix inspect_shortcut.patch text/plain 1843 bweinstein SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTIyMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMTEtMTkgIEJyaWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5A YXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEZpeGVzIDxodHRwOi8vd2Via2l0Lm9yZy9iLzIyNzU0Pi4KKwkJV2ViIEluc3BlY3Rvcjog S2V5Ym9hcmQgc2hvcnRjdXQgZm9yIEVsZW1lbnQgZmluZGVyLgorCQkKKwkJVXNlIENvbW1hbmQg KyBTaGlmdCArIEMgYXMgYSBzaG9ydGN1dCBmb3IgTm9kZSBTZWFyY2gsIHRvIAorCQltYXRjaCB0 aGUgRmlyZWJ1ZyBzaG9ydGN1dCB0byBkbyB0aGUgc2FtZSB0aGluZy4KKworICAgICAgICAqIGlu c3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5FbGVtZW50c1BhbmVsLnByb3RvdHlwZS5oYW5kbGVLZXlFdmVudCk6CisKIDIwMDktMTEtMTkg IEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgogCiAgICAgICAgQnVpbGQgZml4LiBObyBy ZXZpZXcgbmVlZGVkLgpJbmRleDogV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRz UGFuZWwuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1l bnRzUGFuZWwuanMJKHJldmlzaW9uIDUxMTk2KQorKysgV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL0VsZW1lbnRzUGFuZWwuanMJKHdvcmtpbmcgY29weSkKQEAgLTk5OCw2ICs5OTgsMjIgQEAg V2ViSW5zcGVjdG9yLkVsZW1lbnRzUGFuZWwucHJvdG90eXBlID0gewogCiAgICAgaGFuZGxlS2V5 RXZlbnQ6IGZ1bmN0aW9uKGV2ZW50KQogICAgIHsKKyAgICAgICAgLy8gQ21kL0NvbnRyb2wgKyBT aGlmdCArIEMgc2hvdWxkIGJlIGEgc2hvcnRjdXQgdG8gY2xpY2tpbmcgdGhlIE5vZGUgU2VhcmNo IEJ1dHRvbi4KKyAgICAgICAgLy8gVGhpcyBzaG9ydGN1dCBtYXRjaGVzIEZpcmVidWcuCisgICAg ICAgIGlmIChldmVudC5rZXlJZGVudGlmaWVyID09PSAiVSswMDQzIikgeyAgICAgLy8gQyBrZXkK KyAgICAgICAgICAgIHZhciBpc01hYyA9IEluc3BlY3RvckNvbnRyb2xsZXIucGxhdGZvcm0oKS5p bmRleE9mKCJtYWMtIikgPT09IDA7CisgICAgICAgICAgICBpZiAoaXNNYWMpCisgICAgICAgICAg ICAgICAgdmFyIGlzTm9kZVNlYXJjaEtleSA9IGV2ZW50Lm1ldGFLZXkgJiYgIWV2ZW50LmN0cmxL ZXkgJiYgIWV2ZW50LmFsdEtleSAmJiBldmVudC5zaGlmdEtleTsKKyAgICAgICAgICAgIGVsc2UK KyAgICAgICAgICAgICAgICB2YXIgaXNOb2RlU2VhcmNoS2V5ID0gZXZlbnQuY3RybEtleSAmJiAh ZXZlbnQubWV0YUtleSAmJiAhZXZlbnQuYWx0S2V5ICYmIGV2ZW50LnNoaWZ0S2V5OworCisgICAg ICAgICAgICBpZiAoaXNOb2RlU2VhcmNoS2V5KSB7CisgICAgICAgICAgICAgICAgdGhpcy5fbm9k ZVNlYXJjaEJ1dHRvbkNsaWNrZWQoZXZlbnQpOworICAgICAgICAgICAgICAgIGV2ZW50LnByZXZl bnREZWZhdWx0KCk7CisgICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAgICAgfQorICAg ICAgICB9CisgICAgICAgIAogICAgICAgICB0aGlzLnRyZWVPdXRsaW5lLmhhbmRsZUtleUV2ZW50 KGV2ZW50KTsKICAgICB9LAogCg==