227538 2021-06-30 11:00:32 -0700 Use vImage for WebGL toDataURL image y-flip 2021-07-07 11:01:18 -0700 1 1 1 Unclassified WebKit WebGL WebKit Local Build Unspecified Unspecified ASSIGNED https://bugs.webkit.org/show_bug.cgi?id=156129 InRadar P2 Normal --- 227539 1 kkinnunen kkinnunen dino kbr kkinnunen sabouhallawa sam webkit-bug-importer oldest_to_newest 1773816 0 kkinnunen 2021-06-30 11:00:32 -0700 Use vImage for WebGL toDataURL image y-flip Came up in bug 223920 review 1773817 1 kkinnunen 2021-06-30 11:01:35 -0700 Sam, do you have a suggestion how to expose this through the layers so that it's consistent with PixelBufferConversion.h API 1773858 2 sabouhallawa 2021-06-30 12:43:17 -0700 Came up in bug 156129 review. 1774157 3 sam 2021-07-01 10:32:02 -0700 I think my best idea is that instead of flipping at all we should see if we can just pass the flipped PixelBuffer to data() and dataURL() (with some indication it is flipped, maybe a new FlippedPixelBuffer type) and have the code that actually encodes the data and use a custom CGDataProvider to feed the data row by row backwards. 1774175 4 sabouhallawa 2021-07-01 11:14:14 -0700 Or you add the following function to PixelBuffer: PixelBuffer yFlipped() const; And the code in GraphicsContextGLOpenGL::paintRenderingResultsToPixelBuffer() can look like this: if (auto results = readRenderingResultsForPainting()) return results->yFlipped(); return std::nullopt; 1774213 5 sam 2021-07-01 12:36:51 -0700 (In reply to Said Abou-Hallawa from comment #4) > Or you add the following function to PixelBuffer: > > PixelBuffer yFlipped() const; > > And the code in > GraphicsContextGLOpenGL::paintRenderingResultsToPixelBuffer() can look like > this: > > if (auto results = readRenderingResultsForPainting()) > return results->yFlipped(); > return std::nullopt; I think rather than adding members to PixelBuffer, I would prefer a free function like in PixelBufferConversion.h that takes a PixelBufferConversionView (perhaps renamed to PixelBufferView). 1775338 6 webkit-bug-importer 2021-07-07 11:01:18 -0700 <rdar://problem/80279046>