227462 2021-06-28 14:53:52 -0700 Nullptr crash in ResourceLoadStatisticsDatabaseStore::allAttributedPrivateClickMeasurement 2021-06-28 17:21:59 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu cdumez webkit-bug-importer oldest_to_newest 1773212 0 sihui_liu 2021-06-28 14:53:52 -0700 ... 1773213 1 sihui_liu 2021-06-28 14:54:25 -0700 rdar://50772934 1773215 2 432427 sihui_liu 2021-06-28 14:59:48 -0700 Created attachment 432427 Patch 1773216 3 432427 cdumez 2021-06-28 15:01:55 -0700 Comment on attachment 432427 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432427&action=review > Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:3509 > + return attributions; Darin told me in the past to return { }; in such cases and not move the variable declaration so I am passing along the comment :) 1773226 4 432430 sihui_liu 2021-06-28 15:19:20 -0700 Created attachment 432430 Patch for landing 1773280 5 ews-feeder 2021-06-28 17:21:58 -0700 Committed r279353 (239221@main): <https://commits.webkit.org/239221@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432430. 432427 2021-06-28 14:59:48 -0700 2021-06-28 15:19:17 -0700 Patch bug-227462-20210628145947.patch text/plain 2821 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDg3YzIyNDJlMGUyYWI5YjAx YzllYjBhYThkZjE3Nzg5OTQwYWZlNDYuLjk3YTI3OGJhOWU0MWU3ODdiYWMzZDYzYjMxMzExODJl Y2IwNWEyYzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMDYtMjggIFNpaHVpIExp dSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CisKKyAgICAgICAgTnVsbHB0ciBjcmFzaCBpbiBSZXNv dXJjZUxvYWRTdGF0aXN0aWNzRGF0YWJhc2VTdG9yZTo6YWxsQXR0cmlidXRlZFByaXZhdGVDbGlj a01lYXN1cmVtZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjc0NjIKKyAgICAgICAgcmRhcjovLzUwNzcyOTM0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmV0dXJuIGVhcmx5IGlmIHN0YXRlbWVudCBj YW5ub3QgYmUgY3JlYXRlZC4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL0NsYXNzaWZpZXIv UmVzb3VyY2VMb2FkU3RhdGlzdGljc0RhdGFiYXNlU3RvcmUuY3BwOgorICAgICAgICAoV2ViS2l0 OjpSZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGF0YWJhc2VTdG9yZTo6aW5zZXJ0RG9tYWluUmVsYXRp b25zaGlwTGlzdCk6CisgICAgICAgIChXZWJLaXQ6OlJlc291cmNlTG9hZFN0YXRpc3RpY3NEYXRh YmFzZVN0b3JlOjphbGxBdHRyaWJ1dGVkUHJpdmF0ZUNsaWNrTWVhc3VyZW1lbnQpOgorCiAyMDIx LTA2LTI3ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAg ICBVbnJldmlld2VkLCByZXZlcnRpbmcgcjI3OTMyMi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvTmV0d29ya1Byb2Nlc3MvQ2xhc3NpZmllci9SZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGF0YWJh c2VTdG9yZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL0NsYXNzaWZpZXIvUmVz b3VyY2VMb2FkU3RhdGlzdGljc0RhdGFiYXNlU3RvcmUuY3BwCmluZGV4IDAzMWU0NGNhMzE5YmY5 NTQ5NzNkMWE4YmVjNGM5NTQ1YzM2OTBmYjUuLmIyY2RmYjMzMDU5YTBjMmQ4NGI1NGJhNzhkNGQw YWZjMTAzZmI0MWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvQ2xh c3NpZmllci9SZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGF0YWJhc2VTdG9yZS5jcHAKKysrIGIvU291 cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9DbGFzc2lmaWVyL1Jlc291cmNlTG9hZFN0YXRpc3Rp Y3NEYXRhYmFzZVN0b3JlLmNwcApAQCAtMTA1Nyw2ICsxMDU3LDcgQEAgdm9pZCBSZXNvdXJjZUxv YWRTdGF0aXN0aWNzRGF0YWJhc2VTdG9yZTo6aW5zZXJ0RG9tYWluUmVsYXRpb25zaGlwTGlzdChj b25zdCBTUUwKICAgICAgICAgfHwgaW5zZXJ0UmVsYXRpb25zaGlwU3RhdGVtZW50LT5iaW5kSW50 KDEsIGRvbWFpbklEKSAhPSBTUUxJVEVfT0spIHsKICAgICAgICAgICAgIElUUF9SRUxFQVNFX0xP R19FUlJPUihtX3Nlc3Npb25JRCwgIiVwIC0gUmVzb3VyY2VMb2FkU3RhdGlzdGljc0RhdGFiYXNl U3RvcmU6Omluc2VydERvbWFpblJlbGF0aW9uc2hpcExpc3QgZmFpbGVkLCBlcnJvciBtZXNzYWdl OiAlIiBQUklWQVRFX0xPR19TVFJJTkcsIHRoaXMsIG1fZGF0YWJhc2UubGFzdEVycm9yTXNnKCkp OwogICAgICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgICAgICAgICByZXR1cm47 CiAgICAgfQogICAgIAogICAgIGlmIChzdGF0ZW1lbnQuY29udGFpbnMoIlJFUExBQ0UiKSkgewpA QCAtMzUwMSwxMiArMzUwMiwxMyBAQCBWZWN0b3I8V2ViQ29yZTo6UHJpdmF0ZUNsaWNrTWVhc3Vy ZW1lbnQ+IFJlc291cmNlTG9hZFN0YXRpc3RpY3NEYXRhYmFzZVN0b3JlOjphbAogewogICAgIGF1 dG8gYXR0cmlidXRlZFNjb3BlZFN0YXRlbWVudCA9IHRoaXMtPnNjb3BlZFN0YXRlbWVudChtX2Fs bEF0dHJpYnV0ZWRQcml2YXRlQ2xpY2tNZWFzdXJlbWVudFN0YXRlbWVudCwgYWxsQXR0cmlidXRl ZFByaXZhdGVDbGlja01lYXN1cmVtZW50UXVlcnksICJwcml2YXRlQ2xpY2tNZWFzdXJlbWVudFRv U3RyaW5nIl9zKTsKIAorICAgIFZlY3RvcjxXZWJDb3JlOjpQcml2YXRlQ2xpY2tNZWFzdXJlbWVu dD4gYXR0cmlidXRpb25zOwogICAgIGlmICghYXR0cmlidXRlZFNjb3BlZFN0YXRlbWVudCkgewog ICAgICAgICBJVFBfUkVMRUFTRV9MT0dfRVJST1IobV9zZXNzaW9uSUQsICIlcCAtIFJlc291cmNl TG9hZFN0YXRpc3RpY3NEYXRhYmFzZVN0b3JlOjpwcml2YXRlQ2xpY2tNZWFzdXJlbWVudFRvU3Ry aW5nLCBlcnJvciBtZXNzYWdlOiAlIiBQUklWQVRFX0xPR19TVFJJTkcsIHRoaXMsIG1fZGF0YWJh c2UubGFzdEVycm9yTXNnKCkpOwogICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICAg ICAgcmV0dXJuIGF0dHJpYnV0aW9uczsKICAgICB9CiAKLSAgICBWZWN0b3I8V2ViQ29yZTo6UHJp dmF0ZUNsaWNrTWVhc3VyZW1lbnQ+IGF0dHJpYnV0aW9uczsKICAgICB3aGlsZSAoYXR0cmlidXRl ZFNjb3BlZFN0YXRlbWVudC0+c3RlcCgpID09IFNRTElURV9ST1cpCiAgICAgICAgIGF0dHJpYnV0 aW9ucy5hcHBlbmQoYnVpbGRQcml2YXRlQ2xpY2tNZWFzdXJlbWVudEZyb21EYXRhYmFzZShhdHRy aWJ1dGVkU2NvcGVkU3RhdGVtZW50LmdldCgpLCBQcml2YXRlQ2xpY2tNZWFzdXJlbWVudEF0dHJp YnV0aW9uVHlwZTo6QXR0cmlidXRlZCkpOwogCg== 432430 2021-06-28 15:19:20 -0700 2021-06-28 17:21:59 -0700 Patch for landing bug-227462-20210628151920.patch text/plain 2332 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5MzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDg3YzIyNDJlMGUyYWI5YjAx YzllYjBhYThkZjE3Nzg5OTQwYWZlNDYuLmIwYmQwNGU0YjAxNzI1ZjY0NzNlYWI3M2U3MjY4YjYy NjJiMGVjOTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMDYtMjggIFNpaHVpIExp dSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CisKKyAgICAgICAgTnVsbHB0ciBjcmFzaCBpbiBSZXNv dXJjZUxvYWRTdGF0aXN0aWNzRGF0YWJhc2VTdG9yZTo6YWxsQXR0cmlidXRlZFByaXZhdGVDbGlj a01lYXN1cmVtZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjc0NjIKKyAgICAgICAgcmRhcjovLzUwNzcyOTM0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgQ2hyaXMgRHVtZXouCisKKyAgICAgICAgUmV0dXJuIGVhcmx5IGlmIHN0YXRlbWVudCBjYW5u b3QgYmUgY3JlYXRlZC4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL0NsYXNzaWZpZXIvUmVz b3VyY2VMb2FkU3RhdGlzdGljc0RhdGFiYXNlU3RvcmUuY3BwOgorICAgICAgICAoV2ViS2l0OjpS ZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGF0YWJhc2VTdG9yZTo6aW5zZXJ0RG9tYWluUmVsYXRpb25z aGlwTGlzdCk6CisgICAgICAgIChXZWJLaXQ6OlJlc291cmNlTG9hZFN0YXRpc3RpY3NEYXRhYmFz ZVN0b3JlOjphbGxBdHRyaWJ1dGVkUHJpdmF0ZUNsaWNrTWVhc3VyZW1lbnQpOgorCiAyMDIxLTA2 LTI3ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBV bnJldmlld2VkLCByZXZlcnRpbmcgcjI3OTMyMi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv TmV0d29ya1Byb2Nlc3MvQ2xhc3NpZmllci9SZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGF0YWJhc2VT dG9yZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL0NsYXNzaWZpZXIvUmVzb3Vy Y2VMb2FkU3RhdGlzdGljc0RhdGFiYXNlU3RvcmUuY3BwCmluZGV4IDAzMWU0NGNhMzE5YmY5NTQ5 NzNkMWE4YmVjNGM5NTQ1YzM2OTBmYjUuLmJiZGQxNmNiY2UxZGE1ZjU3MzZiMTE2NDIxMjcyNzI1 YjA2ODI0YTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvQ2xhc3Np Zmllci9SZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGF0YWJhc2VTdG9yZS5jcHAKKysrIGIvU291cmNl L1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9DbGFzc2lmaWVyL1Jlc291cmNlTG9hZFN0YXRpc3RpY3NE YXRhYmFzZVN0b3JlLmNwcApAQCAtMTA1Nyw2ICsxMDU3LDcgQEAgdm9pZCBSZXNvdXJjZUxvYWRT dGF0aXN0aWNzRGF0YWJhc2VTdG9yZTo6aW5zZXJ0RG9tYWluUmVsYXRpb25zaGlwTGlzdChjb25z dCBTUUwKICAgICAgICAgfHwgaW5zZXJ0UmVsYXRpb25zaGlwU3RhdGVtZW50LT5iaW5kSW50KDEs IGRvbWFpbklEKSAhPSBTUUxJVEVfT0spIHsKICAgICAgICAgICAgIElUUF9SRUxFQVNFX0xPR19F UlJPUihtX3Nlc3Npb25JRCwgIiVwIC0gUmVzb3VyY2VMb2FkU3RhdGlzdGljc0RhdGFiYXNlU3Rv cmU6Omluc2VydERvbWFpblJlbGF0aW9uc2hpcExpc3QgZmFpbGVkLCBlcnJvciBtZXNzYWdlOiAl IiBQUklWQVRFX0xPR19TVFJJTkcsIHRoaXMsIG1fZGF0YWJhc2UubGFzdEVycm9yTXNnKCkpOwog ICAgICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgICAgICAgICByZXR1cm47CiAg ICAgfQogICAgIAogICAgIGlmIChzdGF0ZW1lbnQuY29udGFpbnMoIlJFUExBQ0UiKSkgewpAQCAt MzUwNCw2ICszNTA1LDcgQEAgVmVjdG9yPFdlYkNvcmU6OlByaXZhdGVDbGlja01lYXN1cmVtZW50 PiBSZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGF0YWJhc2VTdG9yZTo6YWwKICAgICBpZiAoIWF0dHJp YnV0ZWRTY29wZWRTdGF0ZW1lbnQpIHsKICAgICAgICAgSVRQX1JFTEVBU0VfTE9HX0VSUk9SKG1f c2Vzc2lvbklELCAiJXAgLSBSZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGF0YWJhc2VTdG9yZTo6cHJp dmF0ZUNsaWNrTWVhc3VyZW1lbnRUb1N0cmluZywgZXJyb3IgbWVzc2FnZTogJSIgUFJJVkFURV9M T0dfU1RSSU5HLCB0aGlzLCBtX2RhdGFiYXNlLmxhc3RFcnJvck1zZygpKTsKICAgICAgICAgQVNT RVJUX05PVF9SRUFDSEVEKCk7CisgICAgICAgIHJldHVybiB7IH07CiAgICAgfQogCiAgICAgVmVj dG9yPFdlYkNvcmU6OlByaXZhdGVDbGlja01lYXN1cmVtZW50PiBhdHRyaWJ1dGlvbnM7Cg==