227455 2021-06-28 11:16:38 -0700 [webkitcorepy] Fix race condition in TaskPool unittests 2021-07-28 20:57:37 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain darin dewei_zhu ryanhaddad slewis webkit-bug-importer oldest_to_newest 1773139 0 jbedard 2021-06-28 11:16:38 -0700 webkitcorepy.tests.task_pool_unittest.TaskPoolUnittest.test_invalid_shutdown is racey on EWS, because it relies on the parent process terminating it's children before the children have a chance to finish their computation. 1773140 1 webkit-bug-importer 2021-06-28 11:16:52 -0700 <rdar://problem/79873003> 1773141 2 432410 jbedard 2021-06-28 11:21:42 -0700 Created attachment 432410 Patch 1773142 3 jbedard 2021-06-28 11:22:05 -0700 Failures like this one https://ews-build.webkit.org/#/builders/5/builds/55039/steps/11/logs/stdio are the ones I'm trying to address. 1773144 4 jbedard 2021-06-28 11:23:55 -0700 History of this test: https://results.webkit.org/?suite=webkitpy-tests&test=webkitcorepy.tests.task_pool_unittest.TaskPoolUnittest.test_invalid_shutdown 1773147 5 432410 dewei_zhu 2021-06-28 12:02:32 -0700 Comment on attachment 432410 Patch r=me, this seems to be a mitigation, but theoretically doesn't fix the race itself. 1773149 6 jbedard 2021-06-28 12:06:14 -0700 (In reply to dewei_zhu from comment #5) > Comment on attachment 432410 [details] > Patch > > r=me, this seems to be a mitigation, but theoretically doesn't fix the race > itself. It doesn't fix the race, but it's hard to see how we could (and still retain the test). The test is basically verifying that the parent can and does terminate a child process if it's taking too long to complete. We clearly want some kind of limit on how long the child runs, in case the parent actually isn't terminating the child 1773152 7 ews-feeder 2021-06-28 12:11:39 -0700 Committed r279345 (239213@main): <https://commits.webkit.org/239213@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432410. 1780065 8 jbedard 2021-07-28 08:39:48 -0700 Reopening to attach new patch. 1780066 9 434429 jbedard 2021-07-28 08:39:49 -0700 Created attachment 434429 Patch 1780069 10 jbedard 2021-07-28 08:40:59 -0700 The original change didn't fix our flakiness. This test isn't super valuable in the first place, I think we should just delete it. 1780093 11 434429 darin 2021-07-28 10:16:53 -0700 Comment on attachment 434429 Patch How does deleting a function fix a race condition? 1780094 12 434429 darin 2021-07-28 10:17:26 -0700 Comment on attachment 434429 Patch Oh, I get it, deleting a test (not just a function). 1780284 13 434429 dewei_zhu 2021-07-28 17:57:48 -0700 Comment on attachment 434429 Patch r=me 1780289 14 ews-feeder 2021-07-28 18:48:53 -0700 Committed r280412 (240052@main): <https://commits.webkit.org/240052@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434429. 432410 2021-06-28 11:21:42 -0700 2021-07-28 08:39:46 -0700 Patch bug-227455-20210628112141.patch text/plain 1474 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3OTM0MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIxLTA2LTI4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbd2Via2l0Y29yZXB5XSBGaXggcmFjZSBjb25kaXRpb24gaW4gVGFza1Bv b2wgdW5pdHRlc3RzIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjI3NDU1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83OTg3MzAwMz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvbGlicmFy aWVzL3dlYmtpdGNvcmVweS93ZWJraXRjb3JlcHkvdGVzdHMvdGFza19wb29sX3VuaXR0ZXN0LnB5 OgorICAgICAgICAoVGFza1Bvb2xVbml0dGVzdC50ZXN0X2ludmFsaWRfc2h1dGRvd24pOiBJbmNy ZWFzZSB3b3JrZXIgbG9hZCB0byA1IHNlY29uZHMuCisKIDIwMjEtMDYtMjggIEFsZXggQ2hyaXN0 ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSRUxFQVNFX0FTU0VS VCBoaXQgaW4gTmV0d29ya1Nlc3Npb25Db2NvYTo6cmVtb3ZlV2ViU29ja2V0VGFzayB3aGVuIHVz aW5nIFdLV2ViVmlld0NvbmZpZ3VyYXRpb24uX2F0dHJpYnV0ZWRCdW5kbGVJZGVudGlmaWVyCklu ZGV4OiBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRjb3JlcHkvd2Via2l0Y29yZXB5L3Rl c3RzL3Rhc2tfcG9vbF91bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2xp YnJhcmllcy93ZWJraXRjb3JlcHkvd2Via2l0Y29yZXB5L3Rlc3RzL3Rhc2tfcG9vbF91bml0dGVz dC5weQkocmV2aXNpb24gMjc5MzQxKQorKysgVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0 Y29yZXB5L3dlYmtpdGNvcmVweS90ZXN0cy90YXNrX3Bvb2xfdW5pdHRlc3QucHkJKHdvcmtpbmcg Y29weSkKQEAgLTE3Myw0ICsxNzMsNCBAQCBjbGFzcyBUYXNrUG9vbFVuaXR0ZXN0KHVuaXR0ZXN0 LlRlc3RDYXNlCiAgICAgICAgIHdpdGggT3V0cHV0Q2FwdHVyZSgpOgogICAgICAgICAgICAgd2l0 aCBzZWxmLmFzc2VydFJhaXNlcyhUYXNrUG9vbC5FeGNlcHRpb24pOgogICAgICAgICAgICAgICAg IHdpdGggVGFza1Bvb2wod29ya2Vycz0xLCB0ZWFyZG93bj10ZWFyZG93biwgZ3JhY2VfcGVyaW9k PTEsIGZvcmNlX2Zvcms9VHJ1ZSkgYXMgcG9vbDoKLSAgICAgICAgICAgICAgICAgICAgcG9vbC5k byh3YWl0LCAyKQorICAgICAgICAgICAgICAgICAgICBwb29sLmRvKHdhaXQsIDUpCg== 434429 2021-07-28 08:39:49 -0700 2021-07-28 20:57:37 -0700 Patch bug-227455-20210728083949.patch text/plain 1558 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI4MDM4MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIxLTA3LTI3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbd2Via2l0Y29yZXB5XSBGaXggcmFjZSBjb25kaXRpb24gaW4gVGFza1Bv b2wgdW5pdHRlc3RzIChmb2xsb3ctdXAgZml4KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI3NDU1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83OTg3 MzAwMz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFNjcmlwdHMvbGlicmFyaWVzL3dlYmtpdGNvcmVweS93ZWJraXRjb3JlcHkvdGVzdHMvdGFza19w b29sX3VuaXR0ZXN0LnB5OgorICAgICAgICAoVGFza1Bvb2xVbml0dGVzdC50ZXN0X2ludmFsaWRf c2h1dGRvd24pOiBEZWxldGVkLgorCiAyMDIxLTA3LTI4ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5v cm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBbV1BFXVtHVEtdIFNWTl9SRVZJU0lPTiBkcmlm dGluZyBhd2F5IGlmIGJvdHMgZG9uJ3QgcmUtcnVuIGNtYWtlCkluZGV4OiBUb29scy9TY3JpcHRz L2xpYnJhcmllcy93ZWJraXRjb3JlcHkvd2Via2l0Y29yZXB5L3Rlc3RzL3Rhc2tfcG9vbF91bml0 dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRjb3Jl cHkvd2Via2l0Y29yZXB5L3Rlc3RzL3Rhc2tfcG9vbF91bml0dGVzdC5weQkocmV2aXNpb24gMjgw MzgyKQorKysgVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0Y29yZXB5L3dlYmtpdGNvcmVw eS90ZXN0cy90YXNrX3Bvb2xfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTE2OCw5ICsx NjgsMyBAQCBjbGFzcyBUYXNrUG9vbFVuaXR0ZXN0KHVuaXR0ZXN0LlRlc3RDYXNlCiAgICAgICAg ICAgICBzb3J0ZWQoY2FwdHVyZWQud2Via2l0Y29yZXB5LmxvZy5nZXR2YWx1ZSgpLnNwbGl0bGlu ZXMoKSksCiAgICAgICAgICAgICBbJ3dvcmtlci97fSBUZWFyZG93biBhcmd1bWVudCcuZm9ybWF0 KHgpIGZvciB4IGluIHJhbmdlKDQpXSwKICAgICAgICAgKQotCi0gICAgZGVmIHRlc3RfaW52YWxp ZF9zaHV0ZG93bihzZWxmKToKLSAgICAgICAgd2l0aCBPdXRwdXRDYXB0dXJlKCk6Ci0gICAgICAg ICAgICB3aXRoIHNlbGYuYXNzZXJ0UmFpc2VzKFRhc2tQb29sLkV4Y2VwdGlvbik6Ci0gICAgICAg ICAgICAgICAgd2l0aCBUYXNrUG9vbCh3b3JrZXJzPTEsIHRlYXJkb3duPXRlYXJkb3duLCBncmFj ZV9wZXJpb2Q9MSwgZm9yY2VfZm9yaz1UcnVlKSBhcyBwb29sOgotICAgICAgICAgICAgICAgICAg ICBwb29sLmRvKHdhaXQsIDUpCg==